Samuel Attard
9e26dfaa06
build: use async remove method to handle errors better ( #16917 )
...
On windows removeSync randomly seems to fail with DIRNOTEMPTY. By using
the async version fs-extra will do some back-off-retry logic to
hopefully get this dir deleted
2019-03-26 10:34:03 +09:00
Milan Burda
cbd884060e
fix: validate sender for replies in ipcMainInternalUtils.invokeInWebContents() ( #17416 )
2019-03-26 10:15:51 +09:00
Milan Burda
95df531b33
fix: add missing buffer size check in nativeImage ( #17465 )
2019-03-26 10:13:39 +09:00
Robo
6c20c6e668
refactor: Enable network service (Part 1) ( #17431 )
...
* Convert InspectableWebContentsImpl::LoadNetworkResource to SimpleURLLoader
https://bugs.chromium.org/p/chromium/issues/detail?id=721408
* Plumb creation of network context with the service
2019-03-26 10:10:48 +09:00
Shelley Vohr
4ec2f8b67b
chore: remove some bot config options ( #17506 )
2019-03-22 19:29:23 -05:00
Shelley Vohr
a5febe392c
chore: update issue templates with guidelines ( #17505 )
2019-03-22 16:56:52 -07:00
Cheng Zhao
49f13e38f9
fix: close context menu before popup ( #17474 )
2019-03-21 21:56:22 -07:00
Samuel Attard
d2ad8efef4
build: pass through value of unknown flag as well as the flag to make --grep work again ( #17485 )
2019-03-21 12:24:07 -07:00
Nitish Sakhawalkar
a16dc13f85
chore: Update node commit sha ( #17486 )
...
No changes made to node canary, just rebased with fixups.
This change updates to the new commit of `electron-node-canary`.
2019-03-21 14:19:49 -05:00
Samuel Attard
784f9742bc
build: auto-fix whitespace in docs in pre-commit hook ( #17490 )
2019-03-21 12:15:55 -07:00
Jeremy Apthorp
6555be2636
chore: bump chromium to 74.0.3729.27 (master) ( #17345 )
...
* chore: bump chromium to 74.0.3729.5 (master)
* Remove ScopedBlockingCall constructor without location
https://chromium-review.googlesource.com/c/chromium/src/+/1496560
* Use XCode 9.4.1 for Mac SDK 10.13
* chore: roll chromium 74.0.3729.27
2019-03-21 11:45:22 -04:00
Milan Burda
07b02653ba
docs: update sandbox-option.md ( #17468 )
...
* docs: update sandbox-option.md
* Update docs/api/sandbox-option.md
Co-Authored-By: miniak <milan.burda@gmail.com>
2019-03-21 14:41:53 +01:00
Shelley Vohr
b25279df89
docs: clarify documentation for getLastCrashReport ( #17458 )
...
* docs: clarify documentation for getLastCrashReport
* address feedback
2019-03-20 15:34:21 -07:00
Shelley Vohr
b140a82fe8
fix: take foreground visibility into account for isVisible on macOS ( #17463 )
2019-03-20 15:33:59 -07:00
Milan Burda
a82bbd010e
build: strip trailing whitespace in docs ( #17488 )
2019-03-20 13:12:47 -07:00
Klaus Sinani
1c7b3026a6
docs: Use correct image URL on docs/tutorial/windows-taskbar.md
( #17467 )
2019-03-20 10:01:28 -07:00
Samuel Attard
45d90e77b7
fix: use a more unique identifier for NSUserNotification instances ( #17469 )
...
So although apple has it documented that notifications with duplicate identifiers in the same session won't be presented. They apparently forgot to mention that macOS also non-deterministically and without any errors, logs or warnings will also not present some notifications in future sessions if they have a previously used identifier.
As such, we're going to truly randomize these identifiers so they are
unique between apps and sessions. The identifier now consists of a
randomly generated UUID and the app bundle id.
2019-03-20 09:53:20 -07:00
Milan Burda
de1bacddd9
docs: process.getProcessMemoryInfo() returns a Promise ( #16593 )
...
* docs: process.getProcessMemoryInfo() returns a Promise
* chore: bump electron-typescript-definitions to get Promise<T> fix
2019-03-20 17:26:57 +01:00
Cheng Zhao
671533f7d2
fix: check the result when calling js function ( #17443 )
...
* fix: check the result when calling js function
* test: should not crash when callback returns nothing
2019-03-20 08:27:06 -07:00
Samuel Attard
1571461bae
build: add a workaround for circleci known_hosts issue ( #17471 )
2019-03-19 19:37:52 -07:00
Shelley Vohr
1d93bc76cd
feat: expose colorSpace to display object ( #17405 )
...
* feat: expose colorSpace to display object
* update doc
* add a spec
2019-03-19 15:12:03 -07:00
Milan Burda
4c51fa93f5
feat: add systemPreferences.getAnimationSettings() ( #17382 )
2019-03-19 12:15:40 -07:00
Milan Burda
4d8e024b6d
spec: fix isEmpty() checks in nativeImage tests ( #17441 )
2019-03-19 12:13:15 -07:00
Zachary
9b359c6a75
docs: correction to ipc-main-event.md 'frane' to 'frame' ( #17424 )
2019-03-19 12:07:30 -07:00
Milan Burda
7389dfca59
fix: report module name when require fails in sandboxed renderers ( #17413 )
2019-03-19 12:00:41 -07:00
Milan Burda
06a4594435
chore: remove special handling for dialog methods in remote module ( #17412 )
...
* chore: remove special handling for dialog methods in remote module
* refactor: remove callFunction helper
2019-03-19 11:59:33 -07:00
Benny Neugebauer
f4c3151815
docs: fix typo in webview.md ( #17454 )
2019-03-19 11:43:19 -07:00
Milan Burda
ddd51525f1
refactor: make ELECTRON_INSPECTOR_CONTEXT_MENU handler async ( #17411 )
2019-03-19 10:37:43 -07:00
Shelley Vohr
879462af4b
docs: document modernization initiative more clearly ( #17376 )
...
* docs: document modernization initiative more clearly
2019-03-19 10:31:45 -07:00
Milan Burda
53f4af7722
fix: regressions introduced by adding world isolation to Chrome extension content scripts ( #17422 )
2019-03-19 14:45:48 +01:00
Shelley Vohr
2fb9085e5b
feat: add tray.getTitle() ( #17385 )
...
* feat: add tray.getTitle
* fix spec
2019-03-18 12:40:34 -07:00
Shelley Vohr
38d75010c7
chore: rename atomBinding to electronBinding ( #17419 )
2019-03-18 12:37:06 -07:00
Samuel Attard
5025c991ee
fix: pass the correct HostPort into the node inspector ( #17380 )
...
Fixes #17348
2019-03-18 09:19:33 -07:00
Shelley Vohr
db29978fe0
fix: throw error when inserting menu items out-of-range ( #17401 )
...
* fix: throw error when inserting menu items out-of-range
* also check pos < 0
2019-03-18 07:58:42 -07:00
Shelley Vohr
f09f43a4a9
chore: remove unused arg parsing code in dialog ( #17420 )
2019-03-18 07:58:03 -07:00
Samuel Attard
108545e416
spec: add new test runner for main-process based tests ( #17325 )
2019-03-17 14:49:00 -07:00
Milan Burda
3a091cdea4
refactor: implement clipboard APIs without the remote module ( #17200 )
2019-03-15 17:32:04 -07:00
Samuel Attard
b502c62111
spec: fix fixtures path for second instance test
2019-03-15 12:29:25 -07:00
Samuel Attard
984e77e470
fix: spec runner not parsing correctly
2019-03-15 10:57:12 -07:00
Heilig Benedek
43ef561d48
feat: enable NodeIntegrationInSubFrames for webview ( #17226 )
...
* feat: enable nodeIntegrationInSubFrames for webview
* test: add tests
* docs: document webview's nodeintegrationinsubframes
* lint: fix indent
* fix: resolve some merge bloopers
2019-03-15 10:39:20 -07:00
Samuel Attard
4b6b59cc82
chore: update PR as per feedback
2019-03-14 17:22:42 -07:00
Shelley Vohr
961c9a88a8
feat: promisify dialog.showCertificateTrustDialog() ( #17181 )
...
* feat: promisify dialog.showCertificateTrustDialog()
* update promisification doc
2019-03-15 09:02:50 +09:00
Samuel Attard
6b326f7924
build: spread runner args onto the runner
2019-03-14 16:15:23 -07:00
Milan Burda
f15d0b1ed7
refactor: make ELECTRON_INSPECTOR_CONFIRM handler async ( #17378 )
2019-03-14 15:29:40 -07:00
Samuel Attard
df57ac4ce7
chore: steal all unknown args for use by the spec runners
2019-03-14 15:23:21 -07:00
Shelley Vohr
cb4ede453f
chore: add deprecation helper for fnToProperty ( #17377 )
...
* chore: add deprecation helper for fnToProperty
* add a test
2019-03-14 15:19:19 -07:00
Samuel Attard
be60f93bd0
fix: we can not use ts-node apaprently
2019-03-14 13:39:53 -07:00
Shelley Vohr
12b6a0f5b2
feat: add native emoji picker ( #17359 )
2019-03-14 13:39:52 -07:00
Samuel Attard
46e5767527
update for PR feedback
2019-03-14 13:18:16 -07:00
Samuel Attard
259bc3a918
build: remove log from the spec runner
2019-03-14 12:50:06 -07:00