Erick Zhao
e03a40026a
fix: correct triggeredByAccelerator Event property behavior ( #18865 )
...
Fixes #18808
Previously, the triggeredByAccelerator flag would be entirely coupled with whether or not the modifier keys were being used or not.
This PR swaps out the ui::EventFlagsFromModifiers([event modifierFlags])) call in the macOS code to ui::EventFlagsFromNSEventWithModifiers(event, [event modifierFlags])). The latter outputs flags that take into account mouse click events on top of modifier flags (see Chromium documentation).
The business logic to detect triggeredByAccelerator is then changed to exclude any mouse click flags.
2019-06-28 14:38:17 -07:00
Samuel Attard
6eed4a98ce
fix: do not remove node globals when context isolation is enabled ( #18967 )
2019-06-28 14:37:00 -07:00
Cheng Zhao
1d8e16bc6e
docs: UploadData does not have contentType ( #19026 )
2019-06-28 11:19:01 -07:00
Electron Bot
23b8c9c917
Revert "Bump v7.0.0-nightly.20190628"
...
This reverts commit 769dcce9d7
.
2019-06-28 09:07:12 -07:00
Electron Bot
769dcce9d7
Bump v7.0.0-nightly.20190628
2019-06-28 08:31:15 -07:00
Shelley Vohr
a4f61565c3
fix: crash when tray popup called twice ( #18999 )
2019-06-28 08:24:54 -07:00
Micha Hanselmann
e44bb8474b
test: move tray api tests to main process ( #18986 )
2019-06-28 07:43:04 -07:00
Cheng Zhao
0a9438dbba
docs: documentation of NetworkService-based protocol module ( #18952 )
...
* docs: NetworkService-based protocol module
* docs: separate ProtocolRequest
* docs: separate ProtocolResponse
* docs: fix lint warning
* docs: fix electron.d.ts
* fix: print deprecation warnings for protocol module
* docs: fix links
* Apply suggestions from code review
Co-Authored-By: Felix Rieseberg <felix@felixrieseberg.com>
* Apply suggestions from code review
Co-Authored-By: Samuel Attard <samuel.r.attard@gmail.com>
* Do not publish NetworkService changes draft
* Apply suggestions from code review
Co-Authored-By: Samuel Attard <samuel.r.attard@gmail.com>
* docs: filePath must be absolute
2019-06-28 16:25:30 +09:00
Samuel Attard
127d617db5
fix: delay emitting screen events by a tick to avoid re-entrancy crash ( #19016 )
2019-06-27 19:01:28 -07:00
Shelley Vohr
1a6a16e346
docs: fix platform location for params ( #18987 )
2019-06-27 14:51:18 -07:00
Jeremy Apthorp
ec8697bcdc
test: move protocol specs to main process ( #18923 )
2019-06-27 14:20:29 -07:00
Electron Bot
fdb2502a19
Bump v7.0.0-nightly.20190627
2019-06-27 08:31:59 -07:00
Shelley Vohr
e8e360a902
fix: silent printing mode ( #18979 )
2019-06-26 20:53:17 -07:00
Micha Hanselmann
819cebff5d
change menu item docs ( #18985 )
2019-06-26 20:20:04 -07:00
Samuel Attard
c1ad0725d8
build: fix include paths so that __file__ is absolute not relative ( #18997 )
2019-06-26 11:32:42 -07:00
Shelley Vohr
6243dba068
chore: use ScopedPumpMessagesInPrivateModes in tray ( #18977 )
...
* chore: use ScopedPumpMessagesInPrivateModes in tray
* revert refcounting of AtomMenuModel
* Prefer WeakPtr for posting tasks to handle unexpected destruction
2019-06-26 10:18:53 -07:00
Electron Bot
d643921313
Bump v7.0.0-nightly.20190626
2019-06-26 08:31:57 -07:00
Shelley Vohr
5298358b72
fix: set size of GTK about panel icon ( #18957 )
2019-06-25 22:17:30 -07:00
Alexandre Lacheze
2b3a256647
docs: precise that node integration is enabled in natively opened window if nodeIntegrationInSubFrames is true ( #18156 )
2019-06-25 21:03:23 -07:00
Shelley Vohr
c87394ee25
feat: show optional authors in gtk about panel ( #18964 )
...
* feat: show optional authors in gtk about panel
* chore: use a base::Value for about dialog options on Linux
* docs: mark 'version' as supported on Linux too
2019-06-25 11:31:14 -07:00
Electron Bot
ab5ec0af33
Bump v7.0.0-nightly.20190625
2019-06-25 08:32:04 -07:00
Shelley Vohr
dc2cd8e780
fix: make tray not block main process ( #18880 )
...
* fix: make tray not block main process
* make AtomMenuModel refcounted
2019-06-24 19:30:26 -07:00
Shelley Vohr
24ffc3cfb0
docs: update badges ( #18955 )
2019-06-24 14:09:17 -07:00
Julien Isorce
99e3de56df
spec: fix flakiness of test BrowserWindow.moveTop ( #18962 )
...
Wait for the focus event because checking focus status.
BrowserWindow.show gives focus to the window but there is
a moment where the window is shown but does not have the
focus yet. And the test was failing at this moment.
2019-06-24 13:41:42 -07:00
Milan Burda
1304f259cc
spec: remove unused variables ( #18947 )
2019-06-24 13:41:20 -05:00
Micha Hanselmann
ed5c624b08
move screen api test to main process ( #18956 )
2019-06-24 11:30:47 -07:00
Samuel Attard
764be844ec
fix: override the timers module impls to activate the uv loop ( #18948 )
2019-06-24 10:18:29 -07:00
Samuel Attard
fb01c94511
build: clean up scripts folder, move release scripts, move zip manifest logic ( #18945 )
...
* build: move zip manifest logic in zip_manifests dir
* build: remove unused get-version.py script
* chore: move all release/sudowoodo related scripts into script/releases
* chore: update paths to zip manifests in CI configs
* build: fix path to ci release build script for arm tests
2019-06-24 10:18:04 -07:00
Samuel Attard
5686a0713e
fix: make isDarkMode correctly detect dark mode in the auto setting on catalina ( #18949 )
2019-06-24 10:17:38 -07:00
Electron Bot
1cd7c21f38
Bump v7.0.0-nightly.20190624
2019-06-24 08:31:27 -07:00
Electron Bot
a084093d73
Bump v7.0.0-nightly.20190623
2019-06-23 08:31:00 -07:00
Samuel Attard
79ac99c09b
build: remove scripts in the tools dir that are unused ( #18944 )
2019-06-22 22:29:22 -07:00
Electron Bot
e8c8328081
Bump v7.0.0-nightly.20190622
2019-06-22 08:31:58 -07:00
Charles Kerr
792f6b246c
docs: fix spelling and grammar errors ( #18910 )
2019-06-21 16:19:21 -05:00
Shelley Vohr
bef9610f6a
chore: account for remotes in branch parsing ( #18930 )
2019-06-21 13:58:59 -07:00
Micha Hanselmann
81497c7f2e
fix: sanitize invalid custom protocol headers ( #18854 )
2019-06-21 09:23:57 -07:00
Electron Bot
236d552d6a
Bump v7.0.0-nightly.20190621
2019-06-21 08:31:04 -07:00
Shelley Vohr
57c099d8b8
chore: fix branch trimming for blast-off releases ( #18907 )
2019-06-20 13:12:05 -07:00
Shelley Vohr
7e5ea179a1
chore: remove unneeded require ( #18863 )
...
* chore: remove unneeded require
* chore: update lockfile
2019-06-20 12:28:13 -07:00
Shelley Vohr
536327151d
refactor: make savePath a property on DownloadItem ( #18677 )
2019-06-20 10:04:57 -07:00
Jeremy Apthorp
e95d2129be
spec: de-flake ses.protocol test ( #18884 )
2019-06-20 09:54:33 -07:00
Electron Bot
c27231ce5c
Bump v7.0.0-nightly.20190620
2019-06-20 08:31:49 -07:00
David Sanders
6251a6d307
fix: typo in comment ( #18899 )
2019-06-20 10:11:38 -05:00
Milan Burda
f3f2990b9e
feat: sandbox renderer processes for cross-origin frames ( #18650 )
2019-06-20 12:10:56 +02:00
Jeremy Apthorp
23286fe557
fix: bundle swiftshader and ANGLE libraries on mac ( #18870 )
...
Fixes #18639 . Not sure what exactly caused this to start breaking now, but these libraries appeared in https://chromium-review.googlesource.com/c/chromium/src/+/955949/ and got enabled by default on mac here https://chromium-review.googlesource.com/c/chromium/src/+/1005017/ . The call during gpu process startup that was causing this crash was added here https://chromium-review.googlesource.com/c/chromium/src/+/1599993 .
2019-06-19 18:14:51 -07:00
Samuel Attard
dca583a77f
build: add an FYI job for building with RUN_AS_NODE disabled ( #18890 )
2019-06-19 18:10:04 -07:00
Samuel Attard
34c4c8d508
refactor: rename the atom namespace to electron
2019-06-19 17:33:28 -07:00
Samuel Attard
8c4496a9c9
chore: replace atom path with shell in scripts
2019-06-19 17:33:28 -07:00
Samuel Attard
56930338e8
chore: fix linting after shell rename
2019-06-19 17:33:28 -07:00
Samuel Attard
2160c1fcc9
refactor: replace includes for atom with shell
2019-06-19 17:33:28 -07:00