Commit graph

3239 commits

Author SHA1 Message Date
Max Brunsfeld
ccef805e9b Add API for custom handling of deprecations 2016-02-16 15:21:32 -08:00
Cheng Zhao
61a9316f67 Merge pull request #4496 from cesine/update/deps
fix dependencies badge  which shows out of date
2016-02-16 22:18:51 +08:00
Cheng Zhao
44260634af Merge pull request #4364 from atom/launch-url-or-file-directly-from-cli
Launch URL or HTML file directly
2016-02-16 16:13:10 +08:00
Cheng Zhao
7ca09de386 Merge remote-tracking branch 'origin/dont-write-empty-dev-tools-extensions-file' 2016-02-16 12:30:42 +08:00
cesine
2aff0c47d0 ⬆️ 👕 updated to eslint 2.1.0
Verified migration doc (nothing to be done)
http://eslint.org/docs/user-guide/migrating-to-2.0.0

And made sure the eslint tasks passed
2016-02-15 22:30:29 -05:00
Cheng Zhao
66bb6a8534 Use weak pointer instead of manual bookkeeping 2016-02-16 10:44:10 +08:00
Cheng Zhao
1232a285e6 Merge pull request #4451 from MaxWhere/framesubscriber-fix
Fixing FrameSubscriber memory issue
2016-02-16 10:20:44 +08:00
Cheng Zhao
f3f6fa958e Merge pull request #4449 from deepak1556/permission_helper_media_patch
browser: handle desktop capture devices in media permission request
2016-02-15 23:12:57 +08:00
Cheng Zhao
08e5c1f6fe Merge branch 'webcontent_invalid_loadurl_patch' of https://github.com/deepak1556/atom-shell into deepak1556-webcontent_invalid_loadurl_patch 2016-02-15 21:14:54 +08:00
Cheng Zhao
e244d0db0c Merge pull request #4421 from atom/dialog-icon-on-mac
Support configurable dialog icon on Mac
2016-02-15 16:48:43 +07:00
Cheng Zhao
18f31d7db9 Merge pull request #4398 from LartSimZ/master
Fix for issue #4369
2016-02-15 15:30:06 +07:00
Heilig Benedek
f36e2841bf Don't fire callbacks after we end the subscription 2016-02-12 13:30:11 +01:00
Heilig Benedek
91c96559fa Fixing the problem related to FrameSubscriber 2016-02-12 02:18:13 +01:00
Robo
c09ff40916 browser: handle desktop capture devices in media permission request 2016-02-12 05:07:06 +05:30
Kevin Sawicki
042825e8fb emmitted -> emitted 2016-02-11 13:32:34 -08:00
Kevin Sawicki
bad4816976 Expand error message 2016-02-11 13:28:33 -08:00
Kevin Sawicki
674af4211c Use interpolated string 2016-02-11 13:28:33 -08:00
Kevin Sawicki
42a8674cea Add missing semicolon 2016-02-11 13:28:33 -08:00
Kevin Sawicki
8cacd0b931 Throw custom error when WebView API is unavailable 2016-02-11 13:28:33 -08:00
Kevin Sawicki
704bd4d191 Improve error message 2016-02-11 13:25:58 -08:00
Kevin Sawicki
c94f1fc857 Throw error when IPC channel is missing 2016-02-11 13:25:58 -08:00
Kevin Sawicki
55d4db1387 🎨 2016-02-11 13:25:57 -08:00
Kevin Jose Martin
dbb4e21684 Fix index increment 2016-02-11 15:41:36 -05:00
Kevin Jose Martin
6d2ad5ae58 Add ability to specify command line switches in package.json 2016-02-11 15:34:19 -05:00
Robo
5a8bebc2f8 browser: emit did-fail-load for invalid url 2016-02-12 01:52:42 +05:30
Kevin Sawicki
7da4c3acf7 Use const for util require 2016-02-09 14:54:18 -08:00
Kevin Sawicki
6617592224 Remove lint errors 2016-02-09 14:54:18 -08:00
Kevin Sawicki
c842ca1f12 Don't use ES6 class for AutoUpdater windows class 2016-02-09 14:54:17 -08:00
gellert
664f95a7b4 fixes osx request call 2016-02-09 01:39:27 +01:00
Heilig Benedek
a8ae14e94f Introducing a will-enter-full-screen event that's cancellable 2016-02-09 01:17:05 +01:00
Kevin Sawicki
756aeffe03 Set icon on NSAlert when specified 2016-02-08 15:18:05 -08:00
Michael Vasseur
702455674b Using node::Buffer::Copy() instead of node::Buffer::New() to copy the handle bytes to buffer make the buffer really contains the data. 2016-02-07 10:20:38 +01:00
Vjekoslav Ratkajec
252b12be13 Add readRtf feature with appropriate spec test. Docs updated as well. 2016-02-05 09:06:21 +01:00
Kevin Sawicki
fa4ad9d95f Tweak help message for new path options 2016-02-04 10:45:52 -08:00
Vjekoslav Ratkajec
acd5d40ab0 Adding support to write RTF to clipboard. 2016-02-04 19:38:47 +01:00
Kevin Sawicki
f482ea4902 loadPackagePath -> loadApplicationPackage 2016-02-04 10:35:17 -08:00
Kevin Sawicki
b74dd43ff5 Support opening file: URLs directly 2016-02-04 10:34:36 -08:00
Kevin Sawicki
312182e0bd Add support for launching HTML files directly 2016-02-04 10:33:22 -08:00
Kevin Sawicki
69687c92e9 Add support for launching http URL directly 2016-02-04 10:26:11 -08:00
Kevin Sawicki
2e96cab6aa Extract helper function to load specified app 2016-02-04 10:07:19 -08:00
Kevin Sawicki
8df3856c8f Use const for fs/path requires 2016-02-04 09:16:40 -08:00
Kevin Sawicki
adfa4844d1 Don't return anything from will-quit handler 2016-02-03 17:15:28 -08:00
Kevin Sawicki
6252511b7f Delete extensions file when there are no loaded extensions 2016-02-03 17:12:09 -08:00
Kevin Sawicki
8bd07af5e5 Correct typo in comment 2016-02-03 16:22:16 -08:00
Cheng Zhao
47de3f3f24 Fix failing specs 2016-02-03 00:05:27 +08:00
Cheng Zhao
bc196c016b Do process.emit('exit') in WillReleaseScriptContext 2016-02-02 23:47:19 +08:00
Cheng Zhao
ffcf609de1 Ensure only main frame get notifications 2016-02-02 23:44:33 +08:00
Cheng Zhao
4b67ff9534 Override WillReleaseScriptContext 2016-02-02 23:38:49 +08:00
Cheng Zhao
50d69fd9bb Get rid of SavePathData 2016-02-02 20:11:39 +08:00
Cheng Zhao
eaa60e9c17 Destroy the item once item is downloaded 2016-02-02 19:54:41 +08:00
Cheng Zhao
12d311fd29 Gracefully destroy downloadItem 2016-02-02 19:52:09 +08:00
Cheng Zhao
65cf85808f Calling cancel() should destroy the downloadItem 2016-02-02 19:05:58 +08:00
Cheng Zhao
f1f91828ba Rely on OnDownloadDestroyed to destroy downloadItem 2016-02-02 18:49:43 +08:00
Cheng Zhao
f624800881 Merge pull request #4314 from deepak1556/download_cancel_patch
fix crash when default download is canceled
2016-02-02 18:40:44 +08:00
Robo
2819af9586 fix lifetime of downloadItem class when defaultdownload canceled 2016-02-02 15:54:51 +05:30
Cheng Zhao
b2d44a94ce Merge pull request #4312 from deepak1556/host_resolver_cache_clear_patch
session: api to clear host resolver cache
2016-02-02 13:49:35 +08:00
Robo
ce2ea963b9 session: api to clear host resolver cache 2016-02-02 02:06:49 +05:30
yan
035c1dd5a1 Fix 'user strict' typo 2016-02-01 11:46:02 -08:00
Robo
045e42a10c fix crash when default download is canceled 2016-02-02 00:26:37 +05:30
Cheng Zhao
7d68ca21c8 No need of DefaultWebContentsDelegate 2016-02-01 21:09:12 +08:00
Cheng Zhao
159fb857f4 No need to override RequestToLockMouse in CommonWebContentsDelegate 2016-02-01 21:05:29 +08:00
Cheng Zhao
69f93a7528 Merge pull request #4223 from deepak1556/notification_disable_patch
session: add setPermissionRequestHandler api
2016-02-01 20:51:22 +08:00
Robo
ff5fb512b8 use mediastreamdevicescontroller from brightray to enumerate available devices 2016-02-01 17:45:53 +05:30
Robo
b575cd0ef9 add fullscreen permission type 2016-02-01 16:22:05 +05:30
Cheng Zhao
6c282775a9 Merge pull request #4301 from ragingwind/set-icon-crash
Fix type cast of sharedApplication
2016-02-01 18:46:20 +08:00
Robo
45eada306f add pointerlock permission type 2016-02-01 15:13:49 +05:30
Cheng Zhao
e450d1586e Merge pull request #4288 from MaxWhere/master
Adding cursor-changed event to webContents
2016-02-01 17:03:16 +08:00
ragingwind
d2ec311c55 Fix type cast of sharedApplication 2016-02-01 17:17:22 +09:00
Robo
db26dcaf4c expose handler from session and remove permission-request event 2016-02-01 12:23:51 +05:30
Heilig Benedek
745253a369 Quick fix for the memory leak + docs 2016-02-01 07:17:58 +01:00
Cheng Zhao
457c7f55e6 Merge pull request #4271 from thingsinjars/master
🍎 Add 'Hide' to App API for OS X only
2016-02-01 12:54:07 +08:00
Robo
04c3e083fb remove unnecessary getter 2016-02-01 00:43:29 +05:30
Heilig Benedek
066c189249 Renamed some cursor types to their CSS names and added a way to handle custom cursors properly. 2016-01-31 17:00:14 +01:00
Heilig Benedek
61e0219e91 Added documentation, restructured the files to fit better with electron's style and fixed a typo in keyboard_util's name. 2016-01-31 02:27:14 +01:00
Simon Madine
f9efdc4435 🍎 Add Show to API for OS X 2016-01-30 22:30:38 +01:00
Robo
f7556de9fb add spec for new permissions 2016-01-30 19:10:52 +05:30
Cheng Zhao
0aa0efa439 Do not print warning for FILE_ERROR_NOT_FOUND
Close #4282.
2016-01-30 20:49:35 +08:00
Robo
2a278ceb8f delegate to permission manager for other permissions 2016-01-30 16:49:18 +05:30
Heilig Benedek
0c9174bc7c Introduced the cursor-changed event with one parameter - the name of the cursor type 2016-01-30 06:33:55 +01:00
Cheng Zhao
9d8e23c822 Bump v0.36.7 2016-01-30 13:20:46 +08:00
Cheng Zhao
11e2058136 Merge pull request #4281 from atom/fix-object-destroyed
Fix the occasional `Object has been destroyed` exception in the main process
2016-01-30 13:20:09 +08:00
Cheng Zhao
d2c757e2a5 Merge pull request #4277 from lukeadams/osx-min-version-bump
OS X min version bump (10.8=>10.9)
2016-01-30 13:02:24 +08:00
Cheng Zhao
3f68b2f227 Check whether sender is destroyed before calling sender.send
Fix #4279.
2016-01-30 12:58:21 +08:00
Cheng Zhao
5d16257c2d Fix "Object has been destroyed" error in "page-title-updated" event
Close #4249.
2016-01-30 12:20:28 +08:00
Cheng Zhao
899294a040 win: Don't close the handle since we already closed the fd
Fix #4266.
2016-01-30 11:47:22 +08:00
Simon Madine
6a643ec3c8 Only add Hide if OS_X is defined 2016-01-29 22:51:06 +01:00
Luke Adams
839612c9ae Bump minimum OSX version to 10.9 2016-01-29 13:57:48 -06:00
Simon Madine
7a370ccd0f 🍎 Add 'Hide' to App API for OS X only 2016-01-29 16:09:54 +01:00
Robo
f32bf08eb3 add spec 2016-01-29 15:23:28 +05:30
Robo
85e13333c3 webview: add permission-request event 2016-01-29 15:23:28 +05:30
Cheng Zhao
30b35644f6 Bump v0.36.6 2016-01-29 12:43:35 +08:00
Cheng Zhao
77cf30f758 Revert "renderer: dont fork the process when there is server redirect"
This reverts commit ab9d1bf97e.
2016-01-29 11:52:31 +08:00
Cheng Zhao
516b01e398 win: Call _close before close file handle
Fix #4258.
2016-01-28 22:38:53 +08:00
Paul Betts
05aeceeb52 Always fall back to OpenFolderViaShell when trying to reveal a file
We should always fallback to OpenFolderViaShell when revealing a file fails,
since this API seems to be highly subject to Random Bad Things happening to
you.
2016-01-28 19:05:16 +08:00
Cheng Zhao
30ff18ac64 Merge branch 'webrequest_upload_data_patch' of https://github.com/deepak1556/atom-shell into deepak1556-webrequest_upload_data_patch 2016-01-28 18:41:39 +08:00
Cheng Zhao
e9d00b1fc0 Merge pull request #4247 from deepak1556/common_exports_patch
common: export hideInternalModules
2016-01-27 23:20:59 +08:00
Robo
a6bcc5d110 common: export hideInternalModules 2016-01-27 18:44:47 +05:30
Robo
dc0151099c session: provide uploadData with webrequest api when available 2016-01-27 18:39:40 +05:30
Paul P
cbf11f38ca remove unused variable 2016-01-26 14:55:31 +00:00
Paul P
864449db89 prevent assignment to constant variable (url) 2016-01-26 14:44:46 +00:00
Cheng Zhao
a83aee90e5 No need to use scoped_nsobject for id 2016-01-25 15:15:58 +08:00
Cheng Zhao
059d97e1aa Merge pull request #4181 from bengotow/scroll-touch-events
Extend NativeWindow to track touch-based scroll events on OS X
2016-01-25 14:47:54 +08:00
Cheng Zhao
253a4f226f Merge pull request #4211 from ragingwind/dock-seticon
Add app.dock.setIcon to change icon of dock
2016-01-24 22:36:28 +08:00
Cheng Zhao
93cdc91f1a Merge pull request #4206 from ragingwind/paramter-consistency
Update name of paramter for consistency
2016-01-24 22:11:01 +08:00
Cheng Zhao
e1e58b642e Merge pull request #4182 from deepak1556/debugger_api_patch
browser: add webContents.debugger api
2016-01-24 21:43:18 +08:00
Cheng Zhao
7761815339 Merge branch 'bg-color-pr' of https://github.com/evgenyzinoviev/electron 2016-01-24 21:33:53 +08:00
Cheng Zhao
cc560a3900 spec: Fix failing tests on Windows 2016-01-24 14:31:37 +08:00
Cheng Zhao
c41de501cb spec: Test the -able methods 2016-01-24 14:31:37 +08:00
Cheng Zhao
010cc3276a Simplify the setStyleMask calls 2016-01-24 14:31:37 +08:00
Cheng Zhao
239bfe970c Make hasShadow work on Windows/Linux 2016-01-24 14:31:37 +08:00
Cheng Zhao
d704b3f7ba Reorgnize how attributes work 2016-01-24 14:31:37 +08:00
Cheng Zhao
ae7e96f181 Fix fullscreenable on EL Capitan 2016-01-24 14:31:36 +08:00
Cheng Zhao
5372b6cd91 Fullscreenable => FullScreenable 2016-01-24 14:31:36 +08:00
ragingwind
7229d2462a Add app.dock.setIcon to change icon of dock 2016-01-24 08:30:14 +09:00
ragingwind
09966aec38 Update name of paramter for consistency 2016-01-23 22:59:05 +09:00
Cheng Zhao
31624995bc Merge pull request #4202 from evgenyzinoviev/shadow-pr
Added hasShadow option to BrowserWindow on OS X
2016-01-22 23:56:38 -08:00
Cheng Zhao
8cabe0f008 Merge pull request #4156 from evgenyzinoviev/windows-pr
Improvements in BrowserWindow
2016-01-22 23:42:41 -08:00
Robo
d938dd68b0 wrap debugger for lazy initialization 2016-01-23 09:32:21 +05:30
evgenyzinoviev
ff41b4a267 added hasShadow option to BrowserWindow (osx) 2016-01-23 01:16:08 +01:00
evgenyzinoviev
2fcd3ce7cd Support alpha in backgroundColor 2016-01-23 00:55:08 +01:00
evgenyzinoviev
85991d312a mac: SetResizable fix 2016-01-22 23:44:17 +01:00
evgenyzinoviev
ef51e4e108 maximizable and fullscreenable 2016-01-22 23:21:46 +01:00
Cheng Zhao
984462be44 Remove Menu::Popup 2016-01-22 11:59:08 -07:00
Cheng Zhao
ca77c95c6d No more need to override Menu::Popup 2016-01-22 11:27:17 -07:00
Cheng Zhao
0e3a3d0748 views: Remove PopupAtPoint 2016-01-22 11:25:16 -07:00
Cheng Zhao
5f195a789a mac: Remove duplicate code of Popup 2016-01-22 11:17:12 -07:00
Cheng Zhao
360266ba5b positioningItem => positioning_item 2016-01-22 10:51:51 -07:00
Cheng Zhao
ea9b0cfed0 Merge pull request #4192 from evgenyzinoviev/menu-pr
Menu.popup: specify positioning item (OS X)
2016-01-22 10:49:17 -07:00
Robo
3a60ab386c add spec 2016-01-22 19:10:48 +05:30
Robo
df5bad3f89 fix api and docs 2016-01-22 10:27:25 +05:30
evgenyzinoviev
072ab0ddea specify positioning item for popup menus 2016-01-22 03:18:27 +01:00
Ben Gotow
d186dceb4b Add correct window check for wheel events. See description
Tested that with two windows, events are fired on the correct BrowserWindow instance and not both, and that scrolling a window which is in the background works properly.
2016-01-21 16:36:48 -08:00
Ben Gotow
e96e674201 Properly clean up NSEvent monitor 2016-01-21 16:31:31 -08:00
Ben Gotow
d492ff45d5 Rename up/down => begin/end 2016-01-21 16:31:09 -08:00
Cheng Zhao
a230a89de4 Bump v0.36.5 2016-01-21 17:04:38 -07:00
Cheng Zhao
b039741c6b Merge pull request #3902 from bengotow/asar-perf
Add env var to export a hint file to optimize ASAR ordering
2016-01-21 16:46:49 -07:00
Jessica Lord
980bc7bf32 Use Alt in accelerator 2016-01-21 15:48:06 -07:00
Ben Gotow
a3b6f69772 Log ASAR file access to build ordering hint file
This is a work in progress—need to make this behavior optional via a new flag.
2016-01-21 14:45:22 -08:00
Cheng Zhao
21f5e27a5e Merge pull request #4161 from gabriel/master
Support backgroundColor for window on mac
2016-01-21 15:42:21 -07:00
Cheng Zhao
bbf622187c Merge pull request #4178 from deepak1556/webview_blinkfeatures_attributes_patch
webview: add blinkfeatures attribute
2016-01-21 15:03:33 -07:00
Cheng Zhao
a98d576b48 Merge pull request #4177 from deepak1556/default_download_dir_patch
browser: change location of default download dir
2016-01-21 14:54:21 -07:00
Cheng Zhao
56e8ddbdaf Merge pull request #4186 from CharlieHess/webview-load-url
Expose loadURL for the webview tag.
2016-01-21 14:53:32 -07:00
Cheng Zhao
000625e23f Merge pull request #4163 from deepak1556/web_preferences_fonts_patch
browser: add font related settings to webpreferences
2016-01-21 14:35:30 -07:00
Charlie Hess
7192a8517b Expose loadURL for the webview tag. 2016-01-21 13:31:35 -08:00
Gabriel Handford
239baa3e9a Support backgroundColor for window on mac 2016-01-21 11:07:33 -08:00
Robo
0e2323c9c8 browser: add webContents.debugger api 2016-01-21 23:52:23 +05:30
Ben Gotow
bd2252ea55 Extend NativeWindow to track touch-based scroll events on OS X
In N1, we want to implement the famous "swipe to archive" action on threads in the user's inbox. Chrome exposes `scroll` and `wheel` events, but these aren't sufficient to implement the interaction because the element needs to "snap" when the user lifts their fingers from the trackpad, not when they / we stop receiving `wheel` / `scroll` events. These events may stop before the user lifts their fingers, or continue after the user has lifted their fingers if they had enough momentum for the gesture to continue.

This exposes BrowserWindow `scroll-touch-down` and `scroll-touch-up`, which fire immeditaely when the user touches two fingers to the trackpad, and again when the user lifts their fingers. Combined with the existing wheel event should allow for "swipe-to-archive" and other similar interactions.

Note: This is only implemented on Mac OS X and the events don't fire unless you're using a trackpad!

Related: #1486, #2683, https://github.com/nylas/N1/issues/541
2016-01-21 09:40:21 -08:00
Kevin Sawicki
16b4b58de1 e -> error 2016-01-21 09:32:21 -07:00
Kevin Sawicki
b1f679ff6d Clean up semicolon lint errors 2016-01-21 09:32:21 -07:00
Kevin Sawicki
70bcb0ac5a Clean up no-unused-vars lint errors 2016-01-21 09:32:21 -07:00
Kevin Sawicki
4f4456bde8 Clean up indent eslint errors 2016-01-21 09:32:21 -07:00
Kevin Sawicki
45ddbb6d67 Clean up no-unreachable lint errors 2016-01-21 09:32:21 -07:00
Robo
fab34b400e webview: add blinkfeatures attribute 2016-01-21 15:43:41 +05:30
Robo
c14dd71df1 browser: change location of default download dir 2016-01-21 13:51:37 +05:30
Robo
8a00406862 browser: add font related settings to webpreferences 2016-01-21 13:30:05 +05:30
Cheng Zhao
40557083f0 Merge pull request #4164 from deepak1556/menu_toggle_crash_patch
browser: fix crash when switching to sibling menu from submenus
2016-01-20 15:32:53 -07:00
Kevin Sawicki
8140adb6bc Remove trailing whitespace 2016-01-20 09:43:32 -07:00
Robo
65325dc63f browser: fix crash when switching to sibling menu from submenus 2016-01-20 10:54:12 +05:30
Kevin Sawicki
517dce443b Remove unused errorMessage reference 2016-01-19 11:02:12 -08:00
evgenyzinoviev
fd5c249cb8 fix for windows 2016-01-19 16:58:19 +01:00
evgenyzinoviev
0a79204abb IsMovable to return true on Linux 2016-01-19 16:44:04 +01:00
evgenyzinoviev
c3049e1e99 docs updated 2016-01-19 16:14:59 +01:00
evgenyzinoviev
2a554cb138 added or/and improved closable, minimizable, movable, resizable features for windows on os x and windows 2016-01-19 16:14:57 +01:00
Cheng Zhao
3b62ce7fa6 modules.exports => module.exports 2016-01-16 14:26:01 +08:00
Cheng Zhao
775e475d5c Merge pull request #4131 from etiktin/add_is_DWM_enabled
Add API for checking if DWM composition (Aero Glass) is enabled
2016-01-16 14:16:22 +08:00
Cheng Zhao
25afcf2673 Merge pull request #4121 from atom/format-coffee-helpers
Format leftover CoffeeScript helpers
2016-01-16 13:24:26 +08:00
Eran Tiktin
83b36ce40b Add API for checking if AeroGlass/DWM is enabled
Resolves #1020
2016-01-16 06:27:44 +02:00
Cheng Zhao
712f11a9a3 Merge pull request #4112 from evgenyzinoviev/resize-animate-pr
Animate window resizing on OS X
2016-01-16 12:12:00 +08:00
Cheng Zhao
b132c0dde8 Update brightray, close #4124 2016-01-16 11:43:46 +08:00
Eran Tiktin
85449e953e Fix Windows crash when trying to free asar fd 2016-01-16 03:48:07 +02:00
Kevin Sawicki
0fe539f2c3 Remove unneeded semicolon 2016-01-15 15:30:07 -08:00
Kevin Sawicki
ae20292322 Add missing { 2016-01-15 15:30:07 -08:00
Kevin Sawicki
f830af49c2 Use ES6 style class 2016-01-15 15:30:01 -08:00
Kevin Sawicki
5fc671f522 Add back v8Util binding 2016-01-15 14:29:36 -08:00
Kevin Sawicki
aab2821122 Use ES6 style class 2016-01-15 14:28:12 -08:00
Kevin Sawicki
aab1568682 Use ES6 style class 2016-01-15 14:16:38 -08:00
Kevin Sawicki
02f055b784 Use ES6 style class 2016-01-15 14:12:57 -08:00
Kevin Sawicki
caf7cf5582 Use const instead of var 2016-01-15 11:46:52 -08:00
Kevin Sawicki
79f1029d59 Remove unneeded .constructor segments 2016-01-15 10:29:00 -08:00
Kevin Sawicki
34030d7b2b Use util.inherits instead of CoffeeScript's extend function 2016-01-15 10:17:45 -08:00
Kevin Sawicki
2b95aeba3c Declare vars one per line 2016-01-15 10:17:45 -08:00
Kevin Sawicki
2833db78ad Use [].inclues where appropriate 2016-01-15 10:17:45 -08:00
Kevin Sawicki
c2d473cf65 Remove unneeded [].indexOf fallback 2016-01-15 10:17:45 -08:00
Kevin Sawicki
741d148776 Add missing semicolon 2016-01-15 10:09:19 -08:00
Kevin Sawicki
b119704ea9 Use 2 space indent instead of 3 2016-01-15 10:05:35 -08:00
evgenyzinoviev
64f310168c code style fix 2016-01-15 17:40:42 +01:00
evgenyzinoviev
b75dccb0be arguments handing rewritten, doc updated 2016-01-15 17:31:31 +01:00
Cheng Zhao
63278aeec2 Merge pull request #4118 from Ivshti/patch-1
Ensure we close FD on Windows
2016-01-15 23:58:57 +08:00
Cheng Zhao
0937144849 Merge pull request #4111 from evgenyzinoviev/movable
Added an option to prevent a window from being moved on OS X
2016-01-15 23:24:22 +08:00
Ivo Georgiev
7586078d0a Ensure we close FD on Windows 2016-01-15 16:54:29 +02:00
Cheng Zhao
9ccc7ee30d Small ajustments on lifetime of webContents 2016-01-15 16:36:35 +08:00
Cheng Zhao
c10c419f1d No need to call sender.callbacks.remove
The IDWeakMap automatically removes the key when object is garbage
collected.
2016-01-15 16:36:35 +08:00
Cheng Zhao
3875b30fcf Merge pull request #4109 from atom/const
[WIP] Use `const` for requires
2016-01-15 16:32:07 +08:00
Cheng Zhao
39225ac5ec Bump v0.36.4 2016-01-15 14:27:19 +08:00
evgenyzinoviev
2598b00b41 Animate window resizing on OS X 2016-01-15 05:59:58 +01:00
evgenyzinoviev
cda88db77c Added option to prevent a window from being moved on OS X 2016-01-15 03:58:57 +01:00
Jessica Lord
003de0debe Clean up variable declarations 2016-01-14 18:07:29 -08:00
Jessica Lord
5a4a8e1fa7 🔥 stray ref 2016-01-14 17:03:55 -08:00
Jessica Lord
ae2893ceaa Inline var 2016-01-14 15:44:33 -08:00
Jessica Lord
5412ecdcc1 Use const 2016-01-14 14:52:05 -08:00
Jessica Lord
ab8908a4af Use const 2016-01-14 14:41:46 -08:00
Jessica Lord
1779701445 Use const 2016-01-14 14:40:12 -08:00
Jessica Lord
3a0fb42737 Use const 2016-01-14 14:33:45 -08:00
Jessica Lord
9103253f62 Use const 2016-01-14 14:26:10 -08:00
Kevin Sawicki
030d2a843c Remove extra newlines around comments 2016-01-14 11:10:12 -08:00
Kevin Sawicki
990dc30e8d Use // for multi-line comments 2016-01-14 10:44:21 -08:00
Kevin Sawicki
f4af744519 Use // for single line comments 2016-01-14 10:35:29 -08:00
Cheng Zhao
26350f4ccb GetHttpCacheInIO => DoCacheActionInIO 2016-01-14 20:48:14 +08:00
Robo
10e4698baa session: api to get current cache size 2016-01-14 17:15:45 +05:30
Robo
8b38bbcf18 webview: respect properties provided during webview creation 2016-01-13 22:40:55 +05:30
Cheng Zhao
489539d62e Merge pull request #4071 from deepak1556/session_flush_data_patch
session: api to flush DOMStorage data
2016-01-13 16:18:37 +08:00
Cheng Zhao
8ae836d82d Unlisten the zoom-level-changed event when webview is detached 2016-01-13 14:58:16 +08:00
Cheng Zhao
44b8343585 Fix crash when closing page with webview 2016-01-13 14:47:39 +08:00
Cheng Zhao
af02739c4e Change webview's zoom level on JavaScript side 2016-01-13 12:50:02 +08:00
Cheng Zhao
350c572a8c Handle default parameter of executeJavaScript in C++ 2016-01-13 12:17:56 +08:00
Cheng Zhao
55dfddba77 Handle executeJavaScript in JavaScript 2016-01-13 12:11:46 +08:00
Cheng Zhao
5b7d1a9890 Add insertText to WebContents 2016-01-13 11:55:49 +08:00
Robo
8433d94cac session: api to flush DOMStorage data 2016-01-13 08:56:00 +05:30
Cheng Zhao
5567baf335 Add webFrame.insertText API 2016-01-13 11:21:16 +08:00
Kevin Sawicki
b547a38b3f Add wrapper functions to mirror old CoffeeScript 2016-01-12 16:24:06 -08:00
Kevin Sawicki
ab73f4c94a Copy JS files to tempdir before packing asar 2016-01-12 16:24:06 -08:00
Kevin Sawicki
1f9691ae13 Convert all source files to JavaScript 2016-01-12 16:24:06 -08:00
Kevin Sawicki
403870a27e Migrate to block comments 2016-01-12 16:22:34 -08:00
Cheng Zhao
eb63e6b9a7 Destroy the native class when webContents is destroyed 2016-01-12 21:10:24 +08:00
Cheng Zhao
c7a89b6e29 Merge pull request #4058 from kyku/master
Pass --touch-devices to chromium contents under X11
2016-01-11 22:57:00 +08:00
Cheng Zhao
9e82334b67 Merge pull request #4057 from princejwesley/browser-window
Return null for no focused window when calling BrowserWindow.getFocusedWindow
2016-01-11 22:53:38 +08:00
Cheng Zhao
192fa4c86b Cleanup docs and code of setProxy 2016-01-11 22:45:34 +08:00
Cheng Zhao
34c9279fc5 Merge pull request #4046 from deepak1556/session_proxy_patch
session: allow user to isolate pac script and proxy bypass rules
2016-01-11 21:49:15 +08:00
Cheng Zhao
26bd97d6cf Fix style issues of #4029 2016-01-11 21:12:07 +08:00
Cheng Zhao
edcd34d4ce Merge pull request #4029 from leethomas/show-message-box-default-button
Show message box default button
2016-01-11 20:58:03 +08:00
Krzysztof
440c588a33 Pass --touch-devices to chromium contents under X11 2016-01-11 12:23:53 +01:00
Cheng Zhao
91ca84d106 Merge pull request #4050 from etiktin/cosmetic
Remove unneeded extra semicolons (;; -> ;)
2016-01-11 15:41:06 +08:00
Prince J Wesley
018ae5189b Return null for no focused window when calling BrowserWindow.getFocusedWindow() 2016-01-11 12:58:44 +05:30
Robo
8557cd223c maintain api compatibility 2016-01-11 12:24:01 +05:30
Cheng Zhao
1944472c2f docs: Make win.getNativeWindowHandle more clear 2016-01-11 13:43:24 +08:00
Cheng Zhao
54e1d7b3bf Merge pull request #4023 from omrilitov/master
Added getNativeWindowHandle method
2016-01-11 13:32:29 +08:00
leethomas
fee301e768 follow style guidelines 2016-01-10 19:15:40 -08:00
Eran Tiktin
29939dc0b7 Remove unneeded extra semicolons (;; -> ;) 2016-01-11 02:11:40 +02:00
leethomas
803b06b7de 🏁 support defaultId for dialog boxes on Windows 2016-01-10 15:55:26 -08:00
leethomas
ae5c6add11 rename all references to default_button_index -> default_id to keep consistent with cancel_id 2016-01-10 15:33:27 -08:00
Robo
be50ca2653 session: allow user to isolate pac script and proxy bypass rules 2016-01-11 03:55:56 +05:30
leethomas
dfce803045 🏁 update windows message_box function signatures to accept default_button_index....and do nothing with it 2016-01-08 08:23:06 -08:00
leethomas
22c455175a 🐧 add default button index for linux/gtk 2016-01-08 08:22:10 -08:00
leethomas
f1edd5f26f 🍎 add default button index for osx 2016-01-08 08:21:54 -08:00
Cheng Zhao
df27cda36c Bump v0.36.3 2016-01-08 13:40:47 +08:00
Cheng Zhao
ec4c5e58ff Initialize resource bundle on browser process separately 2016-01-08 12:06:06 +08:00
Cheng Zhao
5f6a8a7c24 Merge pull request #4009 from atom/remove-getobject-handler
Remove custom WM_GETOBJECT handler
2016-01-08 09:55:24 +08:00
Omri Litov
943e46f3bd Fix linux and mac build errors 2016-01-08 00:27:53 +02:00
Omri Litov
3f0c007578 Added getNativeWindowHandle 2016-01-07 22:38:35 +02:00
Cheng Zhao
3a32dc5da7 Fix "name" of Error object not serialized
Close #3364.
2016-01-07 16:35:05 +08:00
Cheng Zhao
10f663d017 Fix hiding fullscreen button on EL Capitan 2016-01-07 15:46:40 +08:00
Cheng Zhao
3f2b26ddb7 Add blinkFeatures option 2016-01-07 14:10:18 +08:00
Cheng Zhao
bd20b3f32a Rely on content switches for implementing experimental features 2016-01-07 12:49:00 +08:00
Cheng Zhao
16d23bbda5 Remove pageVisibility option
The original purpose of this option is not working anymore, also adds
docs on the current way to disable process backgrounding.
2016-01-07 12:28:20 +08:00
Cheng Zhao
c6e03f8390 Remove overlayScrollbars and sharedWorker options
They are already enabled by default.
2016-01-07 12:17:19 +08:00
Paul Betts
705001a50e Remove custom WM_GETOBJECT
As of Chromium 47 this seems to be handled automatically, nvda still reports
elements and the typing lag issue described in #4001 is fixed
2016-01-06 10:37:12 -08:00
Cheng Zhao
3ca5b0ce23 win: Don't change transparent window's style
Close #1952.
2016-01-06 23:02:33 +08:00
Cheng Zhao
89fccb7eb2 Fix crash when request failed 2016-01-06 21:07:07 +08:00
Cheng Zhao
c4071a7f66 Throw ENOTDIR when calling mkdir inside asar archive 2016-01-06 12:04:16 +08:00
leethomas
59eda67ba4 🍎🐛 make displaying alternate tray image depend on mouse down event instead of highlight state 2016-01-05 09:49:27 -08:00
Cheng Zhao
2b6ac966c0 Do not write our own filter code
The Win32 API has done everything for us, there is no need to do this
oursevles.
2016-01-05 13:45:34 +08:00
Cheng Zhao
698700716b Show menu by clicking the menu button 2016-01-05 12:05:27 +08:00
Cheng Zhao
43bfce26a7 Do not behave like bookmarkbar menu 2016-01-05 11:57:58 +08:00
Cheng Zhao
0df03a23a3 Pass origin in capturePage 2016-01-04 20:06:36 +08:00
Cheng Zhao
7a1717156e Revert "browser: dont lose coordinates in capturepage src rect"
This reverts commit 3c5e5053e3.
2016-01-04 19:37:25 +08:00
Cheng Zhao
4844e68ba1 Rename did-navigate-to-different-page to did-navigate 2016-01-04 12:09:11 +08:00
Cheng Zhao
941232a76b Merge pull request #3975 from leethomas/add-webview-navigation-events
Add webview navigation events
2016-01-04 11:24:27 +08:00
Cheng Zhao
6ff79eddb4 Merge pull request #3958 from deepak1556/content_strings_localzation_patch
browser: provide localized string from resourcebundle
2016-01-04 10:59:09 +08:00
Cheng Zhao
14db4a1946 Add isDevToolsFocused to webview 2016-01-04 10:46:30 +08:00
leethomas
911e60b507 add did-navigate-in-page event to webview & webcontents (triggers on hash/ref changes, anchor links...), pass url into events 2016-01-01 17:13:39 -08:00
leethomas
9f6319dd71 add will-navigate, did-navigate-to-different-page events to webview 2016-01-01 13:36:35 -08:00
leethomas
54c8c3e3fc 📝 update webview docs to include devtools-* events 2016-01-01 04:49:34 -08:00
leethomas
96d68b9285 🐛 add isDevToolsFocused to WebContents to fix #3928, add devtools-[focused|open|close] events to WebView to fix #3783. 2015-12-31 22:21:54 -08:00
Cheng Zhao
8aced2c31e Add comment on why checking empty set 2015-12-31 18:58:16 +08:00
Cheng Zhao
b308cd6f96 Merge pull request #3967 from leethomas/fix-osx-crash-when-extensions-empty
🍎 fix #3864 where saving a file causes a crash if file extensio…
2015-12-31 18:51:55 +08:00
Cheng Zhao
be2f900d93 Merge pull request #3968 from leethomas/fix-window-submenu-crashes
🍎 only add sub menus to Window when they actually have menu ite…
2015-12-31 18:51:45 +08:00
Cheng Zhao
af5e76f6ae Merge pull request #3959 from deepak1556/remote_object_patch
remote: support arguments of type Date
2015-12-31 18:46:22 +08:00
leethomas
eac2f6fec3 🍎 only add sub menus to Window when they actually have menu items. fixes #3873 2015-12-30 19:38:14 -08:00
leethomas
ba26a4b4e6 🍎 fix #3864 where saving a file causes a crash if file extension array is empty 2015-12-30 13:26:38 -08:00
Robo
1585a7a0ad browser: provide localized string from resourcebundle 2015-12-30 10:58:46 +05:30
Cheng Zhao
cb5d79e0df Merge pull request #3957 from atom/widevine
Merge #3830
2015-12-30 12:46:19 +08:00
Nishanth Shanmugham
20d03b10d9 osx: Implement clear recent documents
Fixes #3932
2015-12-29 18:36:16 -06:00
Robo
72374b6e31 remote: support arguments of type Date 2015-12-30 01:41:31 +05:30
Cheng Zhao
c0f0685296 Merge pull request #3944 from nishanths/feature/tray-file-drop-osx-dock
tray: Support file-drop from OS X Dock
2015-12-29 19:59:24 +08:00
Cheng Zhao
c76db0ba1d Fix coding styles 2015-12-29 18:59:27 +08:00
Robo
2e78aba090 webFrame: support fetch api for schemes that are privileged. 2015-12-29 15:57:59 +05:30
Nishanth Shanmugham
2bbf86c524 tray: Support file-drop from OS X Dock
A long-standing Apple bug does not call `prepareForDragOperation:sender`
for file drag-and-drop operations from the Dock. So we manually
call our custom `handleDrop:sender` for all drag-and-drop cases (that
is, from the Dock and from Finder).

References to the bug in question:
- http://stackoverflow.com/q/9534543/3309046
- http://openradar.appspot.com/radar?id=1745403

However, we still need to return YES from `prepareForDragOperation:sender`,
otherwise the "drag failed" animation occurs. For the same reason, we also
return YES from `performDragOperation:sender`.
2015-12-29 03:27:59 -06:00
Cyrille Lebeaupin
9d878ad6b2 Add widevine third party
Add 2 new command options to use widevine:
- widevine-cdm-path: Path to widevine plugin
- widevine-cdm-version: Version of the widevine plugin
2015-12-29 14:50:59 +08:00
Cheng Zhao
2294a5ce69 Leak FunctionTemplateHandle
They are cached through the app's lifetime, and freeing them at the
right time is complicate, so just leak them.
2015-12-29 10:40:10 +08:00
Cheng Zhao
d8d963b780 Cache function templates created by CreateObjectWithName 2015-12-29 10:29:48 +08:00
Cheng Zhao
ffc2870ccb Fix circular reference caused by Object.defineProperty 2015-12-29 10:17:35 +08:00
Cheng Zhao
3d2163230b Optimize the case when creating plain object 2015-12-28 22:51:40 +08:00
Cheng Zhao
6785870dde Variables are not shadowed in inline class 2015-12-28 22:51:40 +08:00
Cheng Zhao
b5fd491c2d Fix circular reference caused by RemoteMemberFunction 2015-12-28 22:51:40 +08:00
Cheng Zhao
9ffe502fb1 Bump v0.36.2 2015-12-25 13:45:07 +08:00
Robo
ab9d1bf97e renderer: dont fork the process when there is server redirect 2015-12-25 02:19:56 +05:30
Cheng Zhao
e96f89133c Reset whole headers when requestHeaders is set 2015-12-24 16:59:13 +08:00
Cheng Zhao
6aa3464aad Merge pull request #3912 from tylergibson/FixingMoveItemToTrash-Windows7
Adding check for Windows version and alternate flags for Windows Vista/7
2015-12-24 15:32:09 +08:00
Tyler Gibson
2d0e1c313a Adding check for Windows version and alternate flags for Windows Vista/7 2015-12-24 06:08:43 +00:00
Cheng Zhao
7bd9f2e5d0 Fix converting string to NSURL 2015-12-24 12:43:07 +08:00
Cheng Zhao
d3d8ab7c66 linux: Fix pressing Alt not toggling window menu bar 2015-12-24 11:43:14 +08:00
Cheng Zhao
a6074f89a3 Merge pull request #3900 from bbondy/theme-color
Theme color
2015-12-23 16:09:57 +08:00
Cheng Zhao
e90435e236 Remove visual artifacts of hidden-inset window 2015-12-23 12:38:11 +08:00
Brian R. Bondy
29b00ae0d6 Add tests for did-change-theme-color event 2015-12-22 23:05:03 -05:00
Cheng Zhao
79b507bda6 Merge pull request #3890 from jaanus/hidden-inset-fullscreen-fix
Fixes #2810: correct look of hidden-inset windows in full screen.
2015-12-23 11:26:06 +08:00
Cheng Zhao
3e1edfc9d0 Cancel callback in OnComplete event 2015-12-23 10:20:59 +08:00
Brian R. Bondy
11b2015535 Add did-change-theme-color event to webview 2015-12-22 17:28:22 -05:00
jaanus
aa2f7aaf3a Fixes #2810: correct look of hidden-inset windows in full screen.
`hidden` and `hidden-inset` windows differ only by the hidden-inset window having a toolbar. Yet, the toolbar yields an incorrect look in fullscreen mode. So, we hide and recreate the toolbar for such windows when going to/from fullscreen.

There are some visible artifacts during the fullscreen animations, as the toolbar gets created and destroyed. When entering fullscreen, you see a toolbar that then disappears. When going back to normal window, you see the traffic light buttons jump around a little bit. Yet, this is definitely better than the current broken fullscreen look.
2015-12-22 20:31:55 +02:00
Cheng Zhao
c8c4381085 Cancel callback when URLRequest is destroyed 2015-12-22 23:35:23 +08:00
Cheng Zhao
c4931bb2d1 Merge pull request #3865 from deepak1556/visibility_api_patch
browser: fix document.hidden value
2015-12-22 19:04:23 +08:00
Robo
61004f0e46 fix cpplint warning 2015-12-21 19:16:02 +05:30
Robo
cc7040d75f add test 2015-12-21 18:47:52 +05:30
Robo
ff51e4033a browser: fix value of document.hidden 2015-12-21 17:43:46 +05:30
Robo
d162180196 add api to webview 2015-12-21 17:13:23 +05:30
Robo
39e615ed87 webContents: adding findInPage api 2015-12-21 17:09:56 +05:30
Cheng Zhao
144b73c267 Merge pull request #3877 from bbondy/master
Add media play events to webview
2015-12-21 18:22:30 +08:00
Cheng Zhao
fa8d251370 Merge pull request #3875 from deepak1556/history_navigation_patch
navigaton: handle history operations from renderer
2015-12-21 18:18:45 +08:00
Cheng Zhao
99a661e2d2 Code cleanup of browser_mac.mm 2015-12-21 10:52:49 +08:00
Cheng Zhao
8d094d99da Merge pull request #3853 from jrehbein/fix-issue-3739-mac-dockshow
DockShow workaround for issue #3739
2015-12-21 10:38:52 +08:00
Brian R. Bondy
fed0c43970 Add media play events to webview 2015-12-19 22:37:51 -05:00
Robo
7b03ac6d61 navigaton: handle history operations from renderer 2015-12-20 01:23:47 +05:30
Cheng Zhao
bff2861311 Bump v0.36.1 2015-12-18 13:16:30 +08:00
Cheng Zhao
62c4a471d9 Merge pull request #3854 from deepak1556/browser_client_crash_patch
browser: check for rvh existence
2015-12-18 12:10:41 +08:00
Cheng Zhao
7d000807c5 Merge pull request #3849 from herrmannplatz/improvement/escape-url-openexternal
escape url string
2015-12-18 09:45:39 +08:00
Robo
836c13b330 browser: check for rvh existence 2015-12-18 04:45:32 +05:30
Jeff Rehbein
a39834740c DockShow workaround
Implemented workaround in DockShow for TransformProcessType bugginess
based on discussion at http://stackoverflow.com/questions/7596643/
2015-12-17 14:00:04 -06:00
rehez
9eb797296c escape url string 2015-12-17 16:23:30 +01:00
Cheng Zhao
353f08e477 Remove sync call in remote module 2015-12-17 22:03:16 +08:00
Cheng Zhao
0282d424bf Pass opener ID in command line 2015-12-17 21:27:14 +08:00
Cheng Zhao
71303d4804 Fix context menu not working in devtools 2015-12-16 22:57:03 +08:00
Cheng Zhao
c6634b1ea5 Don't pump message loop when sending sync msg
In old days sending sync message to browser process requires pumping
message loop in the renderer process, but now in Chrome 47 it is not
true anymore. And even when we do it, the Send method may fail
sometimes, so this change seems to be required for the Chrome 47
upgrade.
2015-12-16 22:38:04 +08:00
Kevin Sawicki
67c0de36a3 📝 Add missing period 2015-12-15 16:47:19 -08:00
Kevin Sawicki
d44a9d1fcc 🎨 Remove parens 2015-12-15 16:46:53 -08:00
Kevin Sawicki
aedfd3bf0e Add specs for companyName/submitURL being required 2015-12-15 16:44:38 -08:00
Kevin Sawicki
80e9631220 Use better signature match in deprecation message 2015-12-15 16:27:01 -08:00
Kevin Sawicki
524649797f Make companyName and submitURL required options 2015-12-15 16:22:31 -08:00
Kevin Sawicki
dcc99dd5cb Remove duplicate start calls 2015-12-15 16:10:04 -08:00
Cheng Zhao
d0962b1a93 Fix crash when passing empty path to addRecentDocument 2015-12-15 17:17:24 +08:00
Cheng Zhao
02e0c169a2 Merge pull request #3815 from bjrmatos/master
Add A5 Page Size to printToPDF
2015-12-15 16:55:17 +08:00
Cheng Zhao
8ddf4da9ad Merge pull request #3809 from deepak1556/capture_page_api_patch
browser: dont lose coordinates in capturepage src rect
2015-12-15 15:33:02 +08:00
BJR Matos
86bf7341b7 Add A5 Page Size to printToPDF 2015-12-14 23:28:25 -05:00
Kevin Sawicki
d133553c6a Remove unused ipc event handler 2015-12-14 16:58:32 -08:00
Kevin Sawicki
c5936a024d Remove unneeded custom postMessage on window.opener 2015-12-14 16:54:26 -08:00
Kevin Sawicki
184b11be4c Use id from source window when building proxy for event source 2015-12-14 16:47:33 -08:00
Kevin Sawicki
0ef0ce7345 Add comment about window.opener tweaks 2015-12-14 14:57:38 -08:00
Kevin Sawicki
574eec3e74 Make window.opener a BrowserWindowProxy 2015-12-14 14:55:48 -08:00
Robo
3c5e5053e3 browser: dont lose coordinates in capturepage src rect 2015-12-14 00:52:05 +05:30
Cheng Zhao
10cad5d9ec Passing '' to fromPartiion should return default partition 2015-12-12 15:47:15 +08:00
Cheng Zhao
4d1e223044 Cleanup the cookies code 2015-12-12 15:33:51 +08:00
Cheng Zhao
9438d42322 Use generic function to handle events 2015-12-12 13:49:58 +08:00