Charles Kerr
e24cd329d9
Merge pull request #11268 from electron/fix_crash
...
Don't access unique pointer after it was moved from
2017-11-27 19:20:44 +01:00
Ales Pergl
f8b683ca3d
Don't access unique pointer after it was moved from
2017-11-27 17:55:21 +01:00
Charles Kerr
defa42b458
Merge pull request #11257 from electron/fix-11242
...
Remove "async" flag from the `menu.popup()` options
2017-11-27 16:41:56 +01:00
Cheng Zhao
141c4e9a0e
Merge pull request #11241 from electron/update-to-the-latest-libcc
...
Use latest libcc with Chromium 61
2017-11-27 17:49:05 +09:00
Zhuo Lu
104d307a4a
Use base::scoped_nsobject
2017-11-27 17:26:23 +09:00
Zhuo Lu
8fa3e71ce4
Format code
2017-11-27 17:26:22 +09:00
Zhuo Lu
2f73f4f77e
Fix typo
2017-11-27 17:26:22 +09:00
Zhuo Lu
4934685f53
Declare with static
2017-11-27 17:26:22 +09:00
Zhuo Lu
0c4e425872
Do not autorelease global variables
2017-11-27 17:26:22 +09:00
Zhuo Lu
2de7b338ad
Update API docs
2017-11-27 17:26:22 +09:00
Zhuo Lu
dcdc3621ac
Rename roles
2017-11-27 17:26:22 +09:00
Zhuo Lu
1ab4504e94
No need to make visible
2017-11-27 17:26:22 +09:00
Zhuo Lu
cf73fb737f
Small optimization
2017-11-27 17:26:22 +09:00
Zhuo Lu
3e6e327711
Remove redundant menu item
...
Already addressed with role: clearrecent
2017-11-27 17:26:22 +09:00
Zhuo Lu
5d44dbaf54
Redesign recent documents role API
...
- For more flexibility in designing the recent documents menu, now there can be one menu item (known issue: you may specify more but AppKit doens't display more than one) in the submenu list, rather than separating the labels with a tab.
- Also added is the role `clearrecent` that can be given to a menu item that can clear the recent documents.
2017-11-27 17:26:22 +09:00
Zhuo Lu
828d233f2a
Rollback duplicated feature
2017-11-27 17:26:22 +09:00
Zhuo Lu
0b9cea334f
Specify "Clear Menu" through label option
...
Like a bit of a hack right now, conforming to the existing menu item definition
2017-11-27 17:26:22 +09:00
Zhuo Lu
970babbfd7
Document openrecent menu item
2017-11-27 17:26:22 +09:00
Zhuo Lu
8b720c120d
Hide "Open Recent" in xib
2017-11-27 17:26:22 +09:00
Zhuo Lu
4da2eb9366
Introduce openrecent role
...
- Does not yet accept any options except label--"Clear Menu" can't be modified through exposed node API
- If `openrecent` is present across multiple menu items, the last seen will be visible in the main menu due to that it is designed to behave like a singleton
2017-11-27 17:26:22 +09:00
Zhuo Lu
0ba2fa5cba
Use else if
2017-11-27 17:26:22 +09:00
Zhuo Lu
f0bff74995
Add "Open Recent" submenu to default
2017-11-27 17:26:22 +09:00
Cheng Zhao
c0e9dbcc00
Merge pull request #11144 from dittos/mas-login-helper-again
...
Re-land MAS login helper (w/ regression fix)
2017-11-27 17:02:57 +09:00
Cheng Zhao
1c0ea0286e
Merge pull request #11235 from electron/standard-10
...
infra: Upgrade to StandardJS 10
2017-11-27 15:42:52 +09:00
Charles Kerr
295945b806
copyediting
2017-11-26 08:44:37 +01:00
Charles Kerr
81bc0efc75
fix styleguide errors
2017-11-26 08:38:58 +01:00
Charles Kerr
a75a85449d
sync with master
2017-11-26 08:28:27 +01:00
Charles Kerr
d1ac773e01
Merge pull request #11253 from electron/fix-a-codeblock-in-the-upgrading-node-md
...
Fix a codeblock markup
2017-11-26 08:00:47 +01:00
deepak1556
084292f3ab
fix: focus the webview as a temp workaround
2017-11-25 20:18:01 +05:30
Aleksei Kuzmin
9c5acf6233
Remove "async" flag from the menu.popup() options
...
All menus have become async after the Chromium 61 upgrade.
Fixes #11242 .
2017-11-25 13:31:58 +01:00
Aleksei Kuzmin
3e9f9429d1
Enable "<webview> tag found-in-page event emits when a request is made"
...
Fixes #11244 .
2017-11-25 13:21:26 +01:00
Aleksei Kuzmin
91e4193622
Enable nativeImage module addRepresentation() tests
...
Fixes #11245 .
2017-11-25 12:58:33 +01:00
Zeke Sikelianos
df0c7e2f74
Merge pull request #11250 from electron/docs-lint-fix
...
🔧 fix remark code flag error
2017-11-24 21:05:26 -08:00
Aleksei Kuzmin
ce6af85f98
Fix a codeblock markup
2017-11-25 00:56:07 +01:00
Aleksei Kuzmin
d9d2a8176e
Use latest libcc with Chromium 61
2017-11-24 23:43:32 +01:00
Shelley Vohr
d9c7b95141
fix remark code flag error
2017-11-24 21:40:19 +01:00
Charles Kerr
22c15082a3
partial doc update from my sprint notes
2017-11-24 14:21:41 +01:00
shelley vohr
6941f93627
Merge pull request #11247 from electron/use_sh_in_docs
...
prefer `sh` to `bash` in the docs
2017-11-24 11:38:10 +01:00
Charles Kerr
b59557569c
oops, the upgrading-chrome.md changes belonged in a separate PR
2017-11-24 11:19:53 +01:00
Charles Kerr
3e3cac6f1b
prefer sh to bash in the docs
2017-11-24 11:17:43 +01:00
shelley vohr
00999a07d8
Merge pull request #11240 from electron/upgrading_docs
...
Upgrading docs for node, crashpad, and chromium
2017-11-24 11:16:18 +01:00
Shelley Vohr
bd70ec5e97
finalize node upgrade doc
2017-11-24 11:15:07 +01:00
Charles Kerr
1b0c1842ca
prefer sh to bash in the docs
2017-11-24 11:13:57 +01:00
Shelley Vohr
ba6224039c
make some things more explicit and style conformity
2017-11-24 11:06:04 +01:00
Shelley Vohr
178462b800
chrome -> chromium and updates to crashpad doc
2017-11-24 10:40:37 +01:00
Charles Kerr
f91020a04d
add section for updating submodule references
2017-11-24 10:40:30 +01:00
Charles Kerr
f8858a7577
add rough draft of node, crashpad update notes
2017-11-24 10:40:21 +01:00
shelley vohr
c18afc924b
Merge pull request #10213 from electron/upgrade-to-chromium-61
...
[WIP] Upgrade to Chromium 61
2017-11-24 10:17:52 +01:00
Charles Kerr
fcc8e0924e
Merge pull request #11097 from brenca/resizable-win-fix
...
Fix resizable property not working when taskbar was resized
2017-11-24 10:04:43 +01:00
Cheng Zhao
c30faa4ee8
Use 2xlarge for ARM jobs
2017-11-24 11:03:02 +09:00
