Charles Kerr
d663b4eaee
fix: fix gn cpplint warnings ( #14583 )
...
* chore: fix cpplint 'include_what_you_use' warnings
Typically by including <memory>, <utility> etc.
* chore: fix 'static/global string constant' warning
Use C style strings instead of std::string.
Style guide forbids non-trivial static / global variables. https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables
/home/charles/electron/electron-gn/src/electron/script/cpplint.js
* refactor: remove global string variables.
Fix 'global string variables are not permitted' linter warnings
by using the base::NoDestructor<> wrapper to make it explicit that
these variables are never destroyed.
The style guide's take on globals with nontrivial destructors:
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables
* fix: initializer error introduced in last commit
* fix: remove WIP file that was included by accident
* fix: include order
* fix: include order
* fix: include order
* fix: include order, again
2018-09-12 19:25:56 -05:00
deepak1556
ed045c10ee
Replace ProxyConfigSource with ProxyConfigWithAnnotation.
...
https://chromium-review.googlesource.com/c/chromium/src/+/934126
2018-09-11 20:21:32 +02:00
Aleksei Kuzmin
7bd1b85d4e
Rename net/proxy_resolution/proxy_service* files
...
https://chromium-review.googlesource.com/941901
2018-09-11 20:21:31 +02:00
John Kleinschmidt
98b7a9ce9c
Merge pull request #14107 from electron/channel_id_patch
...
fix: create persistent channel ID store when cookie store is persistent
2018-08-28 14:10:04 -04:00
Robo
c8f506a8aa
fix: add method and referrer properties to app login event ( #14231 )
...
* refactor: remove brightray/network_delegate.{cc|h}
* refactor: respond to http requests through network delegate
2018-08-23 18:55:13 +09:00
deepak1556
73b7390707
fix: create persistent channel ID store when cookie store is persistent
2018-08-20 08:52:55 +05:30
Robo
9989195f19
fix: notify request context shutdown on IO before cleanup ( #14058 )
2018-08-14 14:07:53 -07:00
Charles Kerr
b9490177da
Revert "[WIP] refactor: (Part I) make the ownership of URLRequestContextGetter more clear ( #13956 )"
...
This reverts commit 1c0bb06d4a
.
2018-08-13 16:16:04 -07:00
Robo
1c0bb06d4a
[WIP] refactor: (Part I) make the ownership of URLRequestContextGetter more clear ( #13956 )
...
* refactor: desttroy URLRequestContextGetter on IO thread
* Accepts a factory class that can customize the creation of URLRequestContext
* Use a separate request context for media which is derived from the default
* Notify URLRequestContextGetter observers and cleanup on IO thread
* Move most of brightray net/ classes into atom net/
* refactor: remove refs to URLRequestContextGetter on shutdown
* refactor: remove brigtray switches.{cc|h}
* refactor: remove brightray network_delegate.{cc|h}
* refactor: make AtomURLRequestJobFactory the top level factory.
* Allows to use the default handler from content/ for http{s}, ws{s} schemes.
* Removes the storage of job factory in URLRequestContextGetter.
2018-08-13 15:22:45 -07:00
deepak1556
6d241e972b
Clean up net::HttpAuthPreferences.
...
https://chromium-review.googlesource.com/c/chromium/src/+/727399
2018-06-19 11:49:40 +10:00
deepak1556
83632f15a9
Fix session restore with network service.
...
https://chromium-review.googlesource.com/c/chromium/src/+/818486
2018-06-19 11:49:40 +10:00
deepak1556
bf55d856d2
Cookie Store: Extract change notifications to separate classes.
...
https://chromium-review.googlesource.com/c/chromium/src/+/919159
2018-06-19 11:49:40 +10:00
deepak1556
806acbdf12
Move content/network to services/network.
...
https://chromium-review.googlesource.com/891646
2018-06-19 11:49:40 +10:00
Aleksei Kuzmin
7c95100180
Rename ProxyService class to ProxyResolutionService
...
https://chromium-review.googlesource.com/857421
2018-06-19 11:46:59 +10:00
Aleksei Kuzmin
408b62bcc2
Move net/proxy to net/proxy_resolution
...
https://chromium-review.googlesource.com/868176
Also includes changes from:
Rename files relating to PAC (proxy auto config).
https://chromium-review.googlesource.com/836927
2018-06-19 11:46:58 +10:00
deepak1556
6d0ac6593c
[chromium-style] Complex class/struct needs an explicit out-of-line copy constructor.
2018-04-19 11:12:58 -07:00
Jeremy Apthorp
27cee90e5e
[chromium-style] move methods out of headers
2018-04-19 11:12:58 -07:00
Jeremy Apthorp
a635f078c6
[chromium-style] auto variable type must not deduce to a raw pointer type
2018-04-19 11:10:52 -07:00
Shelley Vohr
49c8c31220
format previously misses .cc files
2018-04-17 21:56:12 -04:00
Shelley Vohr
b05932310b
replace base::MakeUnique with std::make_unique
2018-04-12 08:48:32 -04:00
Robo
171230e45d
Cleanup destruction of URLRequestContextGetter ( #12305 )
...
- Add Leak detector
- Indicate shutdown of request context from Browser Context
- Change stored references to URLRequestContextGetter to use BrowserContext
- Destroy session properties explicitly
2018-03-30 08:24:55 -05:00
deepak1556
b552ad7065
add taskpriority when creating sequences task runners
2018-03-20 10:13:15 +03:00
deepak1556
007ea500d0
REVIEW: Re-use devtools network throttling from content layer
...
https://chromium-review.googlesource.com/c/chromium/src/+/664356
2018-03-20 10:13:15 +03:00
Samuel Attard
de2981a767
Move proxy constructor to ProxyService namespace
2018-03-20 10:08:58 +03:00
Samuel Attard
6f695b93d5
Fix system proxy config resolver constructor
2018-03-20 10:08:58 +03:00
Samuel Attard
f2edd5d068
v8 proxy service has been removed
2018-03-20 10:08:58 +03:00
Samuel Attard
f0ef11b856
BlockingPool has been removed
2018-03-20 10:08:58 +03:00
deepak1556
5eb0a89579
REVIEW: let browser context manage cookie change sub list
2018-02-23 10:21:24 +09:00
deepak1556
248d572077
REVIEW: Subscribe to cookie store for changes in place of CookieMonsterDelegate
2018-02-23 10:21:23 +09:00
Shelley Vohr
233679865b
fix some more compilation errors
2018-02-23 10:21:23 +09:00
deepak1556
abe1faea5c
REVIEW: setup request context for NSS OCSP only once
2018-01-02 16:37:11 +09:00
deepak1556
a1592446da
REVIEW: access GetApplicationLocale on sequence that allows IO
2018-01-02 16:37:08 +09:00
deepak1556
ebb0e46380
REVIEW: create AtomNetworkDelegate on the IO thread
2018-01-02 16:37:08 +09:00
deepak1556
e60557e2e6
simplify URLRequestContextGetter for HttpNetworkSession::Context
2017-11-24 10:58:53 +09:00
Aleksei Kuzmin
c6333728d9
Fix brightray::URLRequestContextGetter::GetURLRequestContext()
...
Split HttpNetworkSession::Params into two structs.
https://codereview.chromium.org/2907463002
Make HttpNetworkSession::host_mapping_rules no longer a pointer.
https://codereview.chromium.org/2906463002
2017-11-24 10:58:17 +09:00
Tony Ganch
0ad967c9a5
Don't specify URLRequestContext when starting logging
...
Related CL: https://codereview.chromium.org/2698143004
2017-11-24 10:58:17 +09:00
Aleksei Kuzmin
6ba372f9f2
Move some of IOThread's command line logic to network_session_configurator.
...
https://codereview.chromium.org/2914893002
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
6c7ad3ac58
Remove the dependence on BrowserThread::FILE for
...
https://codereview.chromium.org/2944313003
2017-11-24 10:58:16 +09:00
Thiago de Arruda
a9a9e58b68
Fix random crash on app quit.
...
Move AtomCTDelegate to brightray as RequireCTDelegate and transfer ownership to
brightray::URLRequestContextGetter. This fixes the wrong lifetime assumptions
that result in AtomCTDelegate being used after free in some scenarios.
Close #10051
2017-11-17 12:03:23 -03:00
Kevin Sawicki
d7321ed980
Add brightray prefix to include paths from within brightray
2017-05-19 08:46:15 -07:00
Kevin Sawicki
c4608c0f37
Fix build/include_alpha linter violations in brightray
2017-05-19 08:46:15 -07:00
Kevin Sawicki
ca274f7be0
Use kIgnoreCertificateErrors from content_switches.h
2017-05-19 08:46:15 -07:00
Kevin Sawicki
ed076a8693
Remove unneeded HasSwitch check
2017-05-15 10:35:43 -07:00
Dun Liang
5b02974aa8
fix line is > 80 characters long
2017-05-15 10:35:43 -07:00
Dun Liang
9ce08d08de
support --disk-cache-size flag #290
2017-05-15 10:35:43 -07:00
Cheng Zhao
bbd4749668
base::WrapUnique has changed its API
2017-04-17 16:16:02 +09:00
Kevin Sawicki
2ece711c2e
Format line length to 80 instead of 100
2017-03-23 15:47:30 -07:00
Kevin Sawicki
be0c0e278a
Remove cpplint errors
2017-03-23 12:48:27 -07:00
Cheng Zhao
ac4ef926e1
URLRequestContenxtGetter now accepts task runner
2017-01-23 15:43:17 +09:00
Ales Pergl
85db1bb47d
Adjustments after upgrading to Chromium 54
2017-01-17 17:18:51 +09:00