trop[bot]
95bce0bce1
refactor: use base::as_string_view() ( #45746 )
...
Use `base::as_string_view()` as a safer alternative to `reinterpret_cast`
in a couple of places.
Xref: 5472408
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2025-02-21 10:14:12 -06:00
trop[bot]
727e218c47
fix: possible timing issue in utility-process spec ( #45728 )
...
This fixture has been calling process.exit() immediately after writing
to stdout and stderr, which the Node.js docs say is risky behavior:
> Calling process.exit() will force the process to exit as quickly as
> possible even if there are still asynchronous operations pending that
> have not yet completed fully, including I/O operations to
> process.stdout and process.stderr.
This fixture's been around for years without problems (AFAIK).
The writes are very small ('hello\n' and 'world') and finish quickly.
But recently I've been testing on a very slow CI machine. There, I see
this spec flaking when it expects stderr to be 'world' but it gets ''.
This PR changes the fixture to wait for stdout & stderr to flush
before calling process.exit().
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2025-02-20 08:54:45 +01:00
trop[bot]
16cb1e46c8
refactor: track downloads by guid ( #45717 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-02-20 08:17:21 +01:00
trop[bot]
435facd8e4
fix: extension web workers net request failing ( #45710 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com>
2025-02-19 23:00:08 -05:00
trop[bot]
75ce54614e
fix: osr stutter fix backport for electron. ( #45659 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: reito <cnschwarzer@qq.com>
2025-02-19 14:43:07 -06:00
electron-roller[bot]
de958d0dab
chore: bump chromium to 132.0.6834.209 (34-x-y) ( #45695 )
...
chore: bump chromium in DEPS to 132.0.6834.209
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2025-02-19 15:19:51 -05:00
Sam Maddock
0af85fc5f0
fix: dangling speculative frames ( #45687 )
...
fix: dangling speculative frames (#45609 )
* fix: dangling speculative frames
* harden lifecycle state checks
* feedback
* add const
2025-02-19 15:19:19 -05:00
John Kleinschmidt
f927d1dd92
build: remove appveyor bake ( #45683 )
...
build: remove appveyor bake (#45073 )
2025-02-19 12:09:55 +01:00
trop[bot]
f2ec3763c2
fix: osr crash on window close ( #45629 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-02-18 16:19:48 -05:00
trop[bot]
c8c5f9c986
fix: win.closeFilePreview recreates panel when called twice ( #45662 )
...
* fix: close quick look during tests on macOS
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
* use longer delay 🤷
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
* fix: sharedPreviewPanel being recreated on close
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
* test: ensure preview panel gets closed
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
2025-02-18 10:01:53 +01:00
trop[bot]
c1c9c1d001
build: run source cache clean daily ( #45654 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-02-18 09:59:42 +01:00
Robo
3b89a5e183
fix: support for v8.setHeapSnapshotNearHeapLimit api ( #45644 )
...
* fix: support for v8.setHeapSnapshotNearHeapLimit api
* chore: fix lint
2025-02-17 15:48:02 +01:00
trop[bot]
e2042de483
fix: asan build on macOS ( #45567 )
...
* fix: asan build on macOS
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* chore: fix build
Co-authored-by: deepak1556 <hop2deep@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2025-02-17 11:14:38 +01:00
trop[bot]
dd5def7f46
build: make sure chromium cookie is set everywhere ( #45634 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2025-02-14 16:02:11 -05:00
trop[bot]
6210a9e82c
fix: pointer lock permission after focus loss and regain ( #45627 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-02-14 12:58:49 -05:00
Charles Kerr
eb7216be1c
refactor: use node::tracing::Agent() directly (34-x-y) ( #45620 )
...
* refactor: use node::tracing::Agent()
* chore: e patches all
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-02-14 10:18:24 +01:00
trop[bot]
32830de5b6
chore: change node test timeout from 20m to 30m ( #45624 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2025-02-14 10:17:54 +01:00
Charles Kerr
a9f3754d22
docs: fix powerMonitor event types (34-x-y) ( #45615 )
...
docs: fix powerMonitor event types (#45518 )
* fix: powerMonitor event types
* fix: thermal-state-change missing Returns
Co-authored-by: Sam Maddock <samuelmaddock@electronjs.org>
2025-02-13 17:25:36 -05:00
electron-roller[bot]
eb7a5c2548
chore: bump node to v20.18.3 (34-x-y) ( #45575 )
...
* chore: bump node in DEPS to v20.18.3
* src: fix outdated js2c.cc references
https://github.com/nodejs/node/pull/56133
* lib: remove startsWith/endsWith primordials for char checks
https://github.com/nodejs/node/pull/55407
* test,crypto: make crypto tests work with BoringSSL
https://github.com/nodejs/node/pull/55491
* fix: potential WIN32_LEAN_AND_MEAN redefinition
https://github.com/c-ares/c-ares/pull/869
* chore: fixup patch indices
* deps: update c-ares to v1.34.1
https://github.com/nodejs/node/pull/55369
* chore: fix bssl test
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-02-13 19:26:54 +01:00
electron-roller[bot]
cb1c7b447b
chore: bump chromium to 132.0.6834.207 (34-x-y) ( #45605 )
...
chore: bump chromium in DEPS to 132.0.6834.207
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2025-02-13 11:04:24 -05:00
Shelley Vohr
d33905c5d9
fix: cppgc crashes on Linux with 16KiB pages ( #45571 )
2025-02-13 10:12:17 +01:00
trop[bot]
ddc7afd3f0
feat: Restore webContents navigation history and page state ( #45584 )
...
* feat: Working navigationHistory.restore with just title/url
Co-authored-by: Felix Rieseberg <fr@makenotion.com>
* feat: Restore page state, too
Co-authored-by: Felix Rieseberg <fr@makenotion.com>
* chore: Docs, lint, tests
Co-authored-by: Felix Rieseberg <fr@makenotion.com>
* Implement feedback
Co-authored-by: Felix Rieseberg <fr@makenotion.com>
* More magic
Co-authored-by: Felix Rieseberg <fr@makenotion.com>
* Make _awaitNextLoad truly private
Co-authored-by: Felix Rieseberg <fr@makenotion.com>
* Implement API group feedback
Co-authored-by: Felix Rieseberg <fr@makenotion.com>
* One more round of feedback
Co-authored-by: Felix Rieseberg <fr@makenotion.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Felix Rieseberg <fr@makenotion.com>
2025-02-12 21:29:32 +01:00
trop[bot]
d04491dff0
build: set chromium cookie on depot tools requests ( #45600 )
...
* build: set chromium cookie on depot tools requests
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
* build: correct secrets syntax
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
* build: handle windows cmd
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
2025-02-12 10:37:33 -08:00
trop[bot]
88286e8f16
build: bump actions/cache past deprecated version ( #45203 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
2025-02-12 10:07:01 +01:00
trop[bot]
a6eb660a3d
build: make gen-libc++-filenames.js produce the same results on Windows ( #45577 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Will Anderson <will@itsananderson.com>
2025-02-11 11:08:35 -05:00
electron-roller[bot]
bb6d76a07a
chore: bump node to v20.18.2 (34-x-y) ( #45300 )
...
chore: bump node in DEPS to v20.18.2
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2025-02-11 11:39:09 +01:00
trop[bot]
27349fc233
fix: fix mksnapshot gen/v8 path ( #45544 )
...
* fix: fix mksnapshot gen/v8 path
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
* build: use 7z compression
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
* build: unzip mksnapshot on Windows and update zip
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* chore: escape backslashes
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
* chore: try another attempt
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
* chore: remove rmdir for now
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
2025-02-11 10:02:45 +01:00
trop[bot]
c1a9e79d08
fix: window maximizing with Mica ( #45526 )
...
* fix: window maximizing with Mica
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* Fix rounded corners after restore
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-02-10 15:36:51 -05:00
Keeley Hammond
b3bb3c5be0
chore: clean up web secure context patch ( #45528 )
...
chore: clean up patch application
2025-02-09 21:36:25 +01:00
trop[bot]
882bcb9435
build: make sure there is at least 35GB free for source cache ( #45515 )
...
build: make sure there is at least 35GB free for cache
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2025-02-09 21:35:54 +01:00
electron-roller[bot]
d2fce89969
chore: bump chromium to 132.0.6834.196 (34-x-y) ( #45516 )
...
chore: bump chromium in DEPS to 132.0.6834.196
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2025-02-07 13:59:02 -05:00
trop[bot]
78adaed2c6
refactor: only pass v8::Context
to gin_helper::MicrotasksScope
constructor ( #45505 )
...
refactor: forward v8::Context to v8::MicrotasksScope constructor
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Milan Burda <milan.burda@gmail.com>
2025-02-07 10:03:21 +01:00
trop[bot]
bba618f4d3
fix: RenderFrameHost nullptr dereference ( #45510 )
...
* fix: add nullptr tests before using render_frame_
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: extract-method HasRenderFrame()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2025-02-07 10:02:55 +01:00
Samuel Attard
b83b8ef851
chore: cherry-pick dd8e2822e507 from chromium ( #45497 )
2025-02-06 14:42:57 -08:00
trop[bot]
e4df33053c
test: dump Electron process PID to path if environment variable set ( #45492 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
2025-02-06 12:09:19 -06:00
Shelley Vohr
dc149e6d3f
build: remove outdated Node.js serdes patch ( #45431 )
2025-02-06 10:38:04 +01:00
trop[bot]
c1918f96cb
feat: view.getVisible() ( #45410 )
...
* feat: view.getVisible()
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
* test: visible apis
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
* docs: clarify getVisible
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
2025-02-05 14:35:12 -05:00
Robo
9fe5f566a4
feat: route deprecated sync clipboard read through permission checks ( #45472 )
...
feat: route deprecated sync clipboard read through permission checks (#45377 )
2025-02-05 14:10:18 -05:00
trop[bot]
3053e33739
fix: WCO not working with some window configurations ( #45478 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-02-05 14:09:46 -05:00
electron-roller[bot]
d857946d6e
chore: bump chromium to 132.0.6834.194 (34-x-y) ( #45480 )
...
chore: bump chromium in DEPS to 132.0.6834.194
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2025-02-05 14:08:35 -05:00
trop[bot]
082d43e022
build: add NSPrefersDisplaySafeAreaCompatibilityMode
= false
to Info.plist ( #45469 )
...
build: add NSPrefersDisplaySafeAreaCompatibilityMode = false to Info.plist
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Milan Burda <milan.burda@gmail.com>
2025-02-05 10:50:50 +01:00
Keeley Hammond
18ee5c25c6
build: migrate Windows release builds to GHA ( #45466 )
...
* build: migrate Windows release builds to GHA (#45137 )
* build: migrate release builds to GHA
* build: alter CI jobs release script
* build: remove generate-sas-token (#45347 )
* build: use windows builders for win-publish (#45340 )
* build: add win toolchain for release builds (#45380 )
* build: add win toolchain for release builds
* build: fix installed_software.json script
* chore: run pwsh script within src
* build: fixup uploader arch
2025-02-04 13:57:30 -08:00
trop[bot]
69333ae82f
build: always use python3 in script/lib/get-version.js
( #45441 )
...
build: always use python3 in script/lib/get-version.js
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
2025-02-04 19:35:28 +01:00
trop[bot]
614c987401
docs: document deletion of databases
directory ( #45449 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
2025-02-04 08:28:27 -06:00
trop[bot]
2ce5fdbec8
docs: mention C++20 requirement in breaking changes document ( #45446 )
...
* docs: mention C++20 requirement in breaking changes document
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
* chore: fix linter issue
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
2025-02-03 16:29:16 -05:00
trop[bot]
54e5f1d8b2
fix: default path not working on KDE Linux ( #45419 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-02-03 22:01:23 +01:00
trop[bot]
5ccd987f61
fix: incorrect WCO tooltip in RTL ( #45426 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-02-03 14:02:23 +01:00
electron-roller[bot]
754ac14e78
chore: bump chromium to 132.0.6834.161 (34-x-y) ( #45391 )
...
chore: bump chromium in DEPS to 132.0.6834.161
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2025-01-31 12:22:14 -05:00
trop[bot]
608d89e447
fix: multiple directory selection on Linux ( #45395 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-01-31 11:28:28 -05:00
trop[bot]
45f633e0f9
build: fix slack-github-action
for backports ( #45404 )
...
build: fix slack-github-action for backports
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-01-31 09:53:31 -05:00