trop[bot]
b11c6cf9bf
docs: fix win.getContentView() return type ( #44464 )
...
docs: fix win.getContentView() return type
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-10-29 17:00:13 -04:00
trop[bot]
b9b982cd7d
docs: clarify utilityProcess child.pid value ( #44363 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-10-22 19:22:02 +02:00
Niklas Wenzel
72802c374b
docs: add section on resource management to base-window.md ( #43610 )
2024-10-15 11:49:54 -04:00
Sam Maddock
8b3d70a2a3
feat: add WebFrameMain detached property ( #43473 )
...
* feat: add WebFrameMain detached property
fix: throw instead of returning null senderFrame
test: detached frames
fix: ensure IPCs of pending deletion RFHs are dispatched
fix: lookup WFM by FTN ID to dispatch IPCs
feat: add frame.isDestroyed()
return null
fix: return undefined
docs: add null to all frame properties
refactor: option c, return null and emit warning
refactor: add routingId & processId to navigation events
test: null frame property
docs: clarify warning message
better wording
clarify null frame
fix: browserwindow spec
* maybe fix 🤷
* fix: use updated util #43722
* docs: add notice for frame change of behavior
* docs: clarify why frame properties may be null
* lint
* wip
* fix: content::FrameTreeNodeId lookup and converter
* refactor: avoid holey array deoptimization
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-10-11 18:33:53 -04:00
Niklas Wenzel
5400c04e43
docs: clarify interplay between utility process events ( #44015 )
2024-10-11 10:25:25 -04:00
Keeley Hammond
08d315da14
refactor: revert url::DomainIs() for cookie domains ( #44153 )
...
build: revert DomainIs refactor
2024-10-08 18:39:37 -07:00
Robo
f68184a9f9
feat: add error event for utility process ( #43774 )
...
* feat: add error event for utility process
* chore: use public report api
* chore: fix lint
* doc: mark error event as experimental
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-27 10:17:06 +09:00
Samuel Attard
74af96da16
build: update some build dependencies ( #43882 )
...
* build: update some build dependencies
* build: fix eslint issues after updating
* build: disable ts check on busted js example
* build: update internal types for stricter event handling
* restore url.parse behavior
* fix typing issues
* sigh
* build: update easy deps
* build: skip woa engines check
2024-09-26 00:12:11 -07:00
Erick Zhao
fb5baec6d5
docs: add advanced specification for Squirrel updater ( #43234 )
...
* docs: add advanced specification for Squirrel updater
* address feedback
2024-09-23 10:20:43 -07:00
Niklas Wenzel
8f0dffea9e
docs: document View.removeChildView edge case ( #43673 )
2024-09-16 11:32:03 +02:00
Keeley Hammond
309d5dade3
feat: add support for system picker in setDisplayMediaRequestHandler ( #43581 )
...
* tmp
* feat: add support for system picker in setDisplayMediaRequestHandler
* oops
* Apply suggestions from code review
Co-authored-by: Erick Zhao <erick@hotmail.ca>
* stuff
* well...
* seems legit
* chore: update patch to handle screenCapturer
* feat: modify API to use useSystemPicker
* fix: gate ScreenCaptureKitPicker to macos 15 or higher
* fix: don't use native picker with legacy media selection
* chore: code review, boolean set & docs update
* fix: add cancelCallback
* docs: clarify session & desktopCapturer docs
---------
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
Co-authored-by: Samuel Attard <sam@electronjs.org>
Co-authored-by: Erick Zhao <erick@hotmail.ca>
2024-09-10 16:05:57 -07:00
Kilian Valkhof
32d5f9e3ef
docs: explain ipcRenderer behavior in context-bridge.md ( #43455 )
...
* docs: explain ipcRenderer behavior in context-bridge.md
* Update context-bridge.md
* Update context-bridge.md
* Update docs/api/context-bridge.md
Co-authored-by: Erik Moura <erikian@erikian.dev>
* Update context-bridge.md
* Update context-bridge.md
* Update context-bridge.md
* Update docs/api/context-bridge.md
Co-authored-by: Erick Zhao <erick@hotmail.ca>
* Update docs/api/context-bridge.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
---------
Co-authored-by: Erik Moura <erikian@erikian.dev>
Co-authored-by: Erick Zhao <erick@hotmail.ca>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
2024-09-05 16:48:22 -04:00
Shelley Vohr
3a5a1ea7bd
docs: titleBarOverlay is defined as a BaseWindow ctor option ( #43430 )
...
docs: titleBarOverlay is defined as a BaseWindow ctor option
2024-08-23 11:02:43 -04:00
reito
1aeca6fd0e
feat: GPU shared texture offscreen rendering ( #42953 )
...
* feat: GPU shared texture offscreen rendering
* docs: clarify texture infos that passed by the paint event.
* feat: make gpu osr spec test optional
* fix: osr image compare
* fix: remove duplicate test
* fix: update patch file
* fix: code review
* feat: expose more metadata
* feat: use better switch design
* feat: add warning when user forget to release the texture.
* fix: typo
* chore: update patch
* fix: update patch
* fix: update patch description
* fix: update docs
* fix: apply suggestions from code review
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* fix: apply suggested fixes
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-08-22 19:23:13 -05:00
Shelley Vohr
50ce448556
fix: menu should allow focused BaseWindow where possible ( #43404 )
...
fix: menu should allow focused BaseWindow
2024-08-22 14:13:30 -04:00
Alexander Cyon
b27dc7514e
fix: documentation spelling errors ( #43366 )
...
chore: fix typos in 'docs/' folder.
2024-08-22 15:44:55 +02:00
Shelley Vohr
755c6640fd
docs: clarify icon value in Notification ( #43377 )
...
* docs: clarify icon value in Notification
* Update docs/api/notification.md
Co-authored-by: Erick Zhao <erick@hotmail.ca>
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca>
2024-08-21 19:38:06 -05:00
Vít Černý
189675575c
feat: extend navigationHistory API ( #42014 )
...
* feat: extend navigationHistory API
* refactor: simplify index checking
* refactor: rename 'getHistory' and 'replaceHistory' methods of navigationHistory
* refactor: rename delete*() methods to remove*()
* feat: remove navigationHistory.replaceHistory()
* tests: add tests for removeEntryAtIndex and getAllEntries
2024-08-19 15:46:04 -04:00
Piotr Płaczek
4d51edc504
docs: api history ( #42982 )
...
* feat(api-history): api history schema
Reference: f36e0a8483/text/0004-api-history-schema.mdhttps://github.com/electron/electron/pull/42982/files#r1692532877
* docs(api-history): schema word choice
Co-authored-by: Erick Zhao <erick@hotmail.ca>
Reference: 0b1b6a7cc0https://github.com/electron/electron/pull/42982#discussion_r1692539906
* docs(api-history): Always use double quotes for descriptions
* docs(api-history): `styleguide.md` improvements
* docs(api-history): copy `ipc-renderer.md` change to `context-bridge.md`
* docs(api-history): `styleguide.md` placement
* docs(api-history): add migration guide
* docs(api-history): remove confusing `breaking-changes-header` in `browser-view.md`
Reference: 7b03c0703d (r1703444772)https://github.com/electron/electron/pull/42982#discussion_r1703441001
* docs(api-history): update `breaking-changer-header`
Reference: https://github.com/electron/electron/pull/43217
* docs(api-history): deprecate `browser-view.md`
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
2024-08-19 11:17:10 -07:00
Shelley Vohr
d7689bb9b5
docs: expand dialog window to BaseWindow ( #43334 )
...
docs: expand dialog window to BaseWindow
2024-08-16 10:49:10 -04:00
Robo
9b166b3ed4
feat: support app#login event for utility process net requests ( #42631 )
...
* feat: support app#login event for utility process net requests
* chore: address review feedback
* GlobalRequestID: Avoid unwanted inlining and narrowing int conversions
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5702737
2024-08-14 11:36:47 +09:00
Shelley Vohr
d294871980
chore: deprecate textured BrowserWindow type option on macOS ( #43133 )
2024-08-12 10:32:35 +02:00
Charles Kerr
c35739d60d
refactor: use url::DomainIs() to check cookie domains ( #43262 )
...
* test: add tests to exercise pre-exsiting cookie domain matching behavior
* refactor: use url::DomainIs() to match cookie domains
* docs: fix typo
2024-08-09 18:35:18 -05:00
Felix Rieseberg
3fabf7837e
docs: Document ideal iconPath size ( #43149 )
2024-08-07 11:43:05 +02:00
Shelley Vohr
5669a40d5c
feat: add transparency checking to nativeTheme ( #42862 )
...
* feat: add transparency checking to nativeTheme
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4684870
* chore: deprecate previous function
* chore: fix lint
2024-07-24 14:38:22 +02:00
Shelley Vohr
9fc760bc4c
docs: note macOS fullscreen events in fullscreen query ( #42997 )
...
docs: note macOS fullscreen events in fs query
2024-07-23 16:40:59 -04:00
Shelley Vohr
3c9d4452c6
docs: improve desktop capture example ( #42957 )
2024-07-23 11:55:23 +02:00
Shelley Vohr
8454f4e49f
feat: emit an event when accessing restricted path in File System Access API ( #42561 )
...
* fix: show a dialog when accessing restricted path in File System Access API
* fix: allow overriding initial blocked paths
* docs: fix doc
* Update docs/api/session.md
Co-authored-by: Erick Zhao <erick@hotmail.ca>
* fix: change block to deny for consistency
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca>
2024-07-22 12:18:15 +02:00
arno renevier
81bdba67ec
feat: Implement password delegate for NSS ( #41205 )
...
* feat: Implement password delegate for NSS (#41188 )
Introduce an app event client-certificate-request-password. It allows
the user to display a UI to prompt for the password.
An alternative would have been to implement a class similar to
CryptoModulePasswordDialogView, to provide the UI. This might have been
simpler for the user, comparing to letting them implement the UI. But it
seems like electron does not have an i18n framework, so it's not
possible to provide a locale aware UI.
* fix lint:markdown error
* address review comments
* use a trampoline handler in JS. The api exposed is now app.setClientCertRequestPasswordHandler
* use properties on the Event object instead of positional parameters
* remove ChromeNSSCryptoModuleDelegate::OnPassword in favor of args->GetNext(&password_)
* address review comments second round
- backslash escape parametrized TypeScript
- rename hostName param to hostname
- use base::ScopedAllowBaseSyncPrimitivesForTesting
- and then, rename ChromeNSSCryptoModuleDelegate to ElectronNSSCryptoModuleDelegate
* Update docs/api/app.md
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com>
* Update docs/api/app.md
Co-authored-by: Erick Zhao <erick@hotmail.ca>
---------
Co-authored-by: Arno Renevier <arnaud@switchboard.app>
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com>
Co-authored-by: Erick Zhao <erick@hotmail.ca>
2024-07-17 09:48:03 -04:00
Sam Maddock
778d3098a0
feat: customize border radius of Views ( #42320 )
...
* feat: add View#setBorderRadius
test: initial setBorderRadius tests
fix: robustly set border radius
chore: add PAUSE_CAPTURE_TESTS for easier screencap dev
feat: add view border radius support
test: view border radius
refactor: cleanup view code
* maybe delay capture to fix tests?
* refactor: retry screen captures in an attempt to fix flakiness
* refactor: ScreenCapture constructor no longer async
* increase screen capture timeout, feels a little short
* refactor: move rounded rect util into chromium_src
* skip some capture tests on mas
2024-07-16 20:16:25 -04:00
Theo Gravity
bab3fcc9ab
feat: add getPercentComplete / getCurrentBytesPerSecond / getEndTime to DownloadItem ( #42805 )
...
feat: getCurrentSpeed / getPercentComplete / getEndTime on DownloadItem
2024-07-15 19:32:44 -04:00
Anny Yang
14303a0a71
docs: grammar fix in isBeingCaptured docs ( #42692 )
2024-07-01 15:01:27 -04:00
Chris Stringer
2b5342cb49
docs - Update net.md ( #42691 )
...
Update net.md
Changes heading level for net.resolveHost() entry to H3
2024-07-01 14:45:49 -04:00
Shelley Vohr
32e5012017
feat: enable Windows Control Overlay on Linux ( #41769 )
2024-06-27 14:56:36 +02:00
Samuel Attard
b31acfb706
docs: clarify security semantics of safeStorage ( #42666 )
...
* docs: clarify security semantics of safeStorage
* Apply suggestions from code review
Co-authored-by: Erick Zhao <erick@hotmail.ca>
* Update safe-storage.md
* Update safe-storage.md
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca>
2024-06-26 13:24:06 -07:00
George Xu
ba8ad4716b
feat: expose system preferences to utility process ( #42203 )
...
* chore: expose system preferences to utility process
* chore: add tests, doc changes and module-list update
* relative link
* use @
* fix test
* chore: disable linux test
* kick
* noop on windows utility process
2024-06-20 11:15:57 -04:00
David Sanders
6d4c2057e4
docs: add backticks around example URL ( #42536 )
2024-06-17 16:35:26 -07:00
Tomáš Hübelbauer
15c404a3c8
docs: fix the Apple HIG link for Dock context menu ( #42450 )
...
Fix the Apple human interface guidelines link for Dock context menu
The link seems to have changed. This is the up to date link.
2024-06-13 15:24:05 -05:00
rcombs
d8e4579e3c
feat: add cumulativeCPUUsage to AppMetrics and CPUUsage ( #41819 )
...
This allows apps to measure their CPU usage over any given period
without worrying about other calls affecting the output,
as they would with `percentCPUUsage`.
2024-06-11 09:38:03 -05:00
David Sanders
c6845b0afc
chore: update @electron/lint-roller to 2.2.0 ( #42412 )
2024-06-10 10:14:03 -05:00
Shelley Vohr
91205540c4
fix: restore wasOpenedAtLogin functionality ( #42411 )
...
fix: restore opened at login functionality
2024-06-10 09:39:56 -05:00
Alice Zhao
406f644d26
feat: duplicate navigation related APIs to contents.navigationHistory ( #41752 )
...
* refactor: move navigation related api to navigationHistory
* docs: add deprecation messages to old web content methods
* fix: add deprecation warnings to webcontents
* fix: add deprecation warnings and make existing naviagation apis internal
* Update docs/api/web-contents.md
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com>
* Update docs/api/web-contents.md
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com>
* Update docs/api/web-contents.md
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com>
* Update docs/api/web-contents.md
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com>
* docs: fix links
* docs: add breaking change to 31
* docs: move breaking change to 32
* chore: re-run pipeline
---------
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com>
2024-06-05 09:34:47 -07:00
Krzysztof Halwa
85df2a86dd
feat: Allow WebContentsView to accept webContents object. ( #42086 )
...
feat: Allow WebContentsView to accept webContents object
2024-05-30 12:45:35 -07:00
Erick Zhao
09fb892c6e
docs: ensure all links are on a single line ( #42235 )
2024-05-28 11:15:18 -07:00
Evo
6423968dc5
fix: fixed the type of WebviewTag.webpreferences ( #42275 )
...
fix: fixed the type of WebviewTag.webpreferences
2024-05-25 22:06:06 -07:00
Erick Zhao
b8381b7d93
docs: fix broken anchors ( #42213 )
2024-05-17 09:46:18 +02:00
Jeremy Rose
19dc276878
feat: remove File.path ( #42053 )
2024-05-15 11:07:23 -07:00
David Sanders
88f28a302f
docs: improve protocol.handle file examples ( #42111 )
...
* docs: improve protocol.handle file examples
* chore: fix lint
2024-05-13 11:49:18 +02:00
David Sanders
c00eb5d491
chore: update @electron/lint-roller to 2.1.0 ( #42078 )
2024-05-10 11:00:15 +02:00
Shelley Vohr
3bd807b03e
fix: View reordering on re-addition to same parent ( #42085 )
2024-05-10 10:16:33 +02:00
