joshaber
736d6afe73
As you wish linter
2017-04-04 09:23:30 -04:00
joshaber
146e1ed3ce
Don't pass the result through
...
It's meaningless on macOS, at least.
2017-04-04 09:21:15 -04:00
joshaber
0cab8a3322
Put CertFromData in an anon namespace
2017-04-04 09:19:23 -04:00
Ryohei Ikegami
61fa8693d2
Merge branch 'master' into native-window-open
2017-04-04 20:54:37 +09:00
Ryohei Ikegami
e7b9b4b1a5
Always create new site instance
2017-04-04 20:54:10 +09:00
Ryohei Ikegami
051e133ce3
Add test for opeing HTML file
2017-04-04 19:05:13 +09:00
Milan Burda
568454525d
Use point / size / rectangle structures consistently in API docs
2017-04-04 08:31:09 +02:00
Philip Jackson
6169ccd1e2
📝 Document that setApplicationMenu(null) has no effect on macOS
2017-04-04 18:00:20 +12:00
Ryohei Ikegami
3eab5df4a4
Revert "Reuse site instance only on window.open"
...
This reverts commit 4d61d071b2
2017-04-04 13:48:17 +09:00
Cheng Zhao
7265a0c1b4
Merge pull request #8528 from Anatzum/patch-1
...
Use kioclient for MoveItemToTrash on KDE
2017-04-04 12:15:21 +09:00
joshaber
8d465234e4
Appease our linty overlords
2017-04-03 21:40:46 -04:00
joshaber
e2bda3ca0f
Use an options object for most of the params
2017-04-03 21:33:21 -04:00
joshaber
2badfbe04f
Remove the intermediate function
2017-04-03 21:22:37 -04:00
joshaber
b3e865a478
Fix some style things
2017-04-03 21:22:14 -04:00
joshaber
398132cfe3
Fix file sorting
2017-04-03 21:19:00 -04:00
Ryohei Ikegami
24fedb2e20
No extra linebreak
2017-04-04 09:40:38 +09:00
Ryohei Ikegami
4a7eec8f2d
Pass app path as command line argument
2017-04-04 09:36:01 +09:00
Ryohei Ikegami
9cb6bc098d
Use beforeEach/afterEach
2017-04-04 09:08:27 +09:00
Kevin Sawicki
7860ea0227
Merge pull request #9097 from electron/handle-setter-errors
...
Surface errors setting remote properties
2017-04-03 13:30:39 -07:00
joshaber
370cf815d9
Get rid of intermediates and rehydrate from issuerCert
2017-04-03 16:27:53 -04:00
joshaber
74c0cbddae
Linebreak to keep the linter happy
2017-04-03 16:07:02 -04:00
joshaber
b8ff4666c8
Remove stale includes
2017-04-03 15:48:47 -04:00
joshaber
da1b0aab3e
Flesh out some docs
2017-04-03 15:39:45 -04:00
joshaber
b0ef7ddf44
Use better iteration
2017-04-03 15:28:51 -04:00
joshaber
06643e525a
Const ref that message
2017-04-03 15:28:44 -04:00
joshaber
11f5c942ce
Conditionalize
2017-04-03 15:25:09 -04:00
joshaber
0b7ffd094a
Expose through the actual JS API too
2017-04-03 15:25:06 -04:00
Kevin Sawicki
e85e483c71
Parse setting response to surface thrown errors
2017-04-03 12:16:51 -07:00
Kevin Sawicki
f49e748020
Merge pull request #9096 from electron/upgrade-brightray-for-cpp-cleanup
...
Upgrade brightray to latest
2017-04-03 12:16:10 -07:00
joshaber
bcecba20e6
Fix indentation
2017-04-03 15:09:24 -04:00
joshaber
4ffaf2cd99
Remove old unnecssary change on app
2017-04-03 15:09:04 -04:00
joshaber
6e89cb9d7c
Move it into dialog
2017-04-03 15:05:24 -04:00
joshaber
4bbbcd093b
Handle the callback and cleanup properly
2017-04-03 14:01:48 -04:00
joshaber
1ed443ea29
Do the callback & release dance
2017-04-03 13:21:44 -04:00
Kevin Sawicki
257f6b142f
Add spec for remote setter not surfacing error
2017-04-03 09:10:46 -07:00
Kevin Sawicki
0989fd7a1c
Upgrade brightray to latest
2017-04-03 08:32:16 -07:00
Kevin Sawicki
f5a75c4e87
Merge pull request #9076 from electron/cleanup-cpp
...
Cleanup cpp codebase
2017-04-03 08:30:08 -07:00
Kevin Sawicki
0981807261
Merge pull request #287 from electron/no-anonymous-ns-in-header
...
Don't use anonymous namespace in header file.
2017-04-03 08:27:51 -07:00
Kevin Sawicki
7dce066854
Merge pull request #286 from electron/cleanup-cpp
...
Cleanup codebase
2017-04-03 08:26:32 -07:00
Kevin Sawicki
2f692c1002
Merge pull request #9084 from runinspring/patch-1
...
Update web-contents.md
2017-04-03 08:20:06 -07:00
Ryohei Ikegami
001d03c859
Do not add search paths in devtools
2017-04-03 22:40:36 +09:00
Ryohei Ikegami
d1212d4a43
Fix JS style
2017-04-03 20:23:36 +09:00
Ryohei Ikegami
50c99e4507
Search for module under the app directory
2017-04-03 20:19:10 +09:00
Ryohei Ikegami
673f4f4d0c
Add test for require to search under app dir
2017-04-03 20:11:19 +09:00
Haojian Wu
34a91434aa
Remove extra spaces.
2017-04-01 22:01:29 +02:00
ZhangYu
671bcf2161
Update web-contents.md
2017-04-02 00:41:36 +08:00
Haojian Wu
e80a9bbb93
Move title_ to InspectableWebContentsViewVies to get rid of cast.
2017-04-01 15:10:52 +02:00
Haojian Wu
f09e3f3835
Remove extra blank.
2017-04-01 15:09:53 +02:00
Haojian Wu
ee1f3acf7b
Don't use anonymous namespace in header file.
...
Anonymous namespace should be forbidden in header files even for the
forward declarations:
* As declarations defined in anonymous namespace are internal linkage, each
translation unit which includes this header will get unique copy, which
wastes space.
* It is easy to violate C++ ODR rule.
Consider the following "foo.h":
```cpp
namespace { class Foo; }
class Bar {
public:
Foo* getFoo();
Foo* foo;
}
```
If the 'foo.h' is included in multiple `.cc` files, the compiler will
put `Foo` into a different anonymous namespace in each `.cc`, which
means there are different definitions of `Foo` in the program (a
violation of the ODR).
2017-04-01 08:57:34 +02:00
Zeke Sikelianos
c2230ca76a
generate electron.d.ts during dist creation, not during build
2017-03-31 21:35:58 -07:00
