Nitish Sakhawalkar
e77d065875
chore: node_includes header no longer needs to be at the end of the list ( #17090 )
...
Until one of the latest version of node, the definition of the DISALLOW_COPY_AND_ASSIGN macro in node was different than in chromium. That is no longer the case, so just undefining the macro in node_includes.h works.
2019-03-11 17:13:43 -07:00
Jeremy Apthorp
d228bdfb9e
gfx::NativeView is no longer NSView on mac
...
https://chromium-review.googlesource.com/c/1270343
2019-01-22 10:32:04 -08:00
Jeremy Apthorp
8948e27ced
ScopedNestableTaskAllower in MessageLoopCurrent
...
https://chromium-review.googlesource.com/c/chromium/src/+/1020288
2019-01-22 10:32:03 -08:00
Robo
52fe92d02e
feat: Upgrade to Chromium 71.0.3578.98 ( #15966 )
2019-01-11 17:00:43 -08:00
Jeremy Apthorp
5a757449b0
ScopedNestableTaskAllower doesn't take an argument
2018-10-04 00:12:54 +02:00
Zhuo Lu
d2653e8192
Fix: Prevent menu update while it's open ( #12809 )
...
* Update application menu on default runloop
Menu change should be prevented while the menu is open
* Fix code style
* Memory safety
2018-05-17 11:19:28 +10:00
deepak1556
30f1d0991b
enable chromium style checker plugin for electron and brightray targets
2018-04-19 11:12:58 -07:00
Jeremy Apthorp
f1587da480
[chromium-style] out-of-line default constructors and destructors
2018-04-19 11:12:58 -07:00
Cheng Zhao
7473b612c5
Make Menu API accept TopLevelWindow
2018-04-19 13:08:37 +09:00
Cheng Zhao
858828d343
Refactor NativeWindow (Part 6): Move NativeWindow bindings to api::TopLevelWindow ( #12596 )
...
* Add atom::api::TopLevelWindow
* Make BrowserWindow inherit TopLevelWindow
* Fix reading from wrong weak map
* Read options after setting content view
* OnWindowClosed is not guarenteed to run now
* Fix the offscreen hack in BrowserWindow
* Fix building on Linux
* Fix tests on Linux
* Fix building on Windows
2018-04-14 11:04:23 +09:00
Cheng Zhao
78468098c5
Don't store WebContents in NativeWindow
2018-03-06 16:21:18 +09:00
Cheng Zhao
973647eaa2
Rename api::Window to api::BrowserWindow
2018-02-22 12:50:47 +09:00
Cheng Zhao
bc61f2eafa
Copy the callback instead of reference
...
I don't really see how this could be a problem, likely a bug of VS 2017?
2018-01-01 19:37:59 +09:00
Cheng Zhao
7b01a8b860
Add callback parameter to Menu.popup
2018-01-01 16:26:19 +09:00
Cheng Zhao
d7bc127c60
mac: Correctly close popup menu
2018-01-01 15:40:15 +09:00
Cheng Zhao
7a8864063b
mac: Handle the case when closing all menu runners
2017-12-21 15:57:27 +09:00
Birunthan Mohanathas
4e859b4718
Remove "async" option from menu.popup()
...
All menus are async now. See "Cleanup MenuRunner API"
https://codereview.chromium.org/2790773002
2017-11-24 10:58:17 +09:00
Kevin Sawicki
6a023dc4fe
Add Menu.closePopup API on macOS
2017-02-22 10:30:28 -08:00
Kevin Sawicki
4430927f98
Add async option to menu.popup
2017-02-22 10:30:28 -08:00
Kevin Sawicki
636ef0fd29
Add async menu.popup on macOS
2017-02-22 10:30:28 -08:00
Cheng Zhao
1505a46ed0
Do not rely on Constructor to call Init
...
This makes it deterministic when the JavaScript is initialized, which
can make our logic more clear.
2016-08-02 15:15:40 +09:00
Cheng Zhao
8269e7b1ef
Suppress unresponsive event when showing menu
2016-07-11 15:31:24 +09:00
Cheng Zhao
6381f44f26
mac: Pass useDefaultAccelerator to getAcceleratorForCommandId
2016-07-07 11:50:19 -07:00
Daniel Pham
b0c72adbe1
🍎 Fix context menus only showing on primary monitor.
2016-05-26 17:43:38 -04:00
Cheng Zhao
0d4f1abdf9
Move the menu sightly higher when repositioning the menu
...
Otherwise the menu is not able to show the last menu item and the arrow
will show.
2016-05-23 21:54:06 +09:00
Cheng Zhao
b866b34ac8
The unit of position is CGFloat
2016-05-23 21:53:50 +09:00
Cheng Zhao
fca91db133
Fix showing context menu in devtools
2016-05-23 21:08:16 +09:00
Daniel Pham
bebf8eabca
🍎 Fix context menu positioning
2016-05-13 10:54:40 -04:00
Cheng Zhao
2ae52d0ff4
Make Wrappable a template class
2016-04-25 10:17:54 +09:00
Cheng Zhao
ca77c95c6d
No more need to override Menu::Popup
2016-01-22 11:27:17 -07:00
Cheng Zhao
5f195a789a
mac: Remove duplicate code of Popup
2016-01-22 11:17:12 -07:00
Cheng Zhao
360266ba5b
positioningItem => positioning_item
2016-01-22 10:51:51 -07:00
evgenyzinoviev
072ab0ddea
specify positioning item for popup menus
2016-01-22 03:18:27 +01:00
Cheng Zhao
6795bd1d96
Do not manually manage native resources
...
We should rely on the destructor to cleanup everything, instead of
putting them in the Destroy method.
2015-12-03 15:38:43 +08:00
Cheng Zhao
d56b34de3b
Make sure all native resources get freed on exit
2015-11-04 18:21:03 +08:00
Cheng Zhao
9f52b11761
Remove NativeWindow::GetWebContents
2015-06-25 14:54:00 +08:00
Cheng Zhao
f78f94d4f1
Fix building on Mac
2014-11-28 19:50:10 +08:00
Cheng Zhao
ff26c3c16f
Some coding style fixes
2014-11-28 15:59:03 +08:00
Joao Moreno
46e6b5ec3e
Allow positioning the context menu
2014-11-26 13:54:05 +01:00
Kevin Sawicki
b6b6fc3bfd
Remove All Rights Reserved after GitHub copyright
...
Closes #762
2014-10-31 11:17:05 -07:00
Cheng Zhao
7a89a08534
Update to new Chromium APIs.
2014-07-28 20:28:49 +08:00
Cheng Zhao
f176b2c58f
Switch to use MIT license.
2014-05-04 20:29:08 +08:00
Cheng Zhao
a040a96652
Discard all our custom V8 helpers, use native-mate instead.
2014-04-22 23:07:21 +08:00
Cheng Zhao
7e1c86a105
Remove use of native_type_conversions.h when possible.
2014-04-21 23:49:53 +08:00
Cheng Zhao
2efed6f910
Simplify menu api.
2014-04-21 23:40:10 +08:00
Cheng Zhao
5dae7b8658
Put converters under atom/common/native_mate_converters.
2014-04-17 13:45:14 +08:00
Cheng Zhao
e96a3abdf9
mac: Do not allow nested task when showing menu.
...
Fixes #163 .
2014-03-25 16:56:02 +08:00
Cheng Zhao
516d46444d
Move all sources under atom/.
2014-03-16 08:30:26 +08:00
