Commit graph

17891 commits

Author SHA1 Message Date
Charles Kerr
6198bbe963 add changed-only mode to cpplint 2017-12-18 10:22:51 -06:00
TheDancingCode
605f5472e5 📝 Fix mixed content warning [ci skip] (#11448) 2017-12-15 16:06:38 -05:00
Felix Rieseberg
75cdd9ec70 🔧 Linter's gotta lint 2017-12-13 16:31:02 -08:00
Felix Rieseberg
8a8aaaf16c 🔧 Allow notifications debugging (Windows) 2017-12-13 16:25:49 -08:00
Felix Rieseberg
76d9756fb9 🔧 Use LOG instead of NSLOG 2017-12-13 14:47:23 -08:00
Charles Kerr
a8b76e1a80
Merge pull request #11418 from electron/add-reg-defaults
[WIP] add back systemPreferences.registerDefaults()
2017-12-13 15:48:20 -06:00
shelley vohr
5a35a5a2b3
Upgrade Node to v8.9.3 (#11422)
* update submodule referefences for node

* update libcc and node refs

* update for cherry-picked a15d0ce

* update libcc ref to master
2017-12-13 16:32:00 -05:00
Shelley Vohr
26ad37c4d1
remove key and value bullts 2017-12-13 16:02:15 -05:00
Shelley Vohr
3fc844c15a
add loop to catch null values 2017-12-13 14:02:43 -05:00
Felix Rieseberg
61ec8df418 🔧 More detailed macOS notification logging 2017-12-13 10:31:59 -08:00
Charles Kerr
0ad99444af
Merge pull request #11426 from mikoto2000/patch-1
Fix 'electron-versioning' link in README.md
2017-12-13 09:21:41 -06:00
mikoto2000
ef7c5c8e9c
Fix 'electron-versioning' link in README.md 2017-12-13 22:18:00 +09:00
Shelley Vohr
d602a30bbc
update a few steps in upgrading-node.md 2017-12-12 22:55:37 -05:00
Charles Kerr
057f08a1f8
Merge pull request #11421 from lurch/patch-1
Fix typos
2017-12-12 21:36:35 -06:00
Andrew Scheller
debe77a910
Fix typos 2017-12-13 03:13:41 +00:00
Charles Kerr
5b6b5fe835
Merge pull request #11419 from electron/menu-bugs-take-two
fix: Menu bugs (take two)
2017-12-12 20:56:41 -06:00
Felix Rieseberg
ffd85bfaac 🔧 Allow notifications debugging (macOS) 2017-12-12 16:09:34 -08:00
Felix Rieseberg
317422f431 👷 Close popup in aftereach 2017-12-12 12:23:02 -08:00
Felix Rieseberg
8166a64f98 🔧 Last round of feedback 2017-12-12 11:25:01 -08:00
Felix Rieseberg
c4ec8b4545 🔧 Feedback 2017-12-12 11:25:01 -08:00
Felix Rieseberg
76df41b5d0 👷 Properly test x vs y 2017-12-12 11:25:01 -08:00
Felix Rieseberg
ace558f54a 👷 Hence, better testing 2017-12-12 11:25:01 -08:00
Felix Rieseberg
5b7f7c8a1a 🔧 Menu returns its properties now 2017-12-12 11:25:01 -08:00
Felix Rieseberg
ffc54967e9 🔧 Fix value shift 2017-12-12 11:25:01 -08:00
Felix Rieseberg
5a658fa5f6 👷 Add a spec 2017-12-12 11:25:01 -08:00
Felix Rieseberg
99031834ff 🔧 Cleanup 2017-12-12 11:25:01 -08:00
Felix Rieseberg
3719ee0b53 🔧 Allow for menu.popup({}) 2017-12-12 11:25:01 -08:00
Felix Rieseberg
9e660b1d32 🔧 Always find a window (or error) 2017-12-12 11:25:01 -08:00
Felix Rieseberg
4f901c6d24 🔧 Oh wow, that looks wrong 2017-12-12 11:25:01 -08:00
Shelley Vohr
6252ce466c
remove failing badDefault 2017-12-12 13:39:38 -05:00
Shelley Vohr
8b447b9291
fixing error in registerDefaults 2017-12-12 13:08:09 -05:00
Charles Kerr
5720a8e7d5
Merge pull request #11415 from electron/revert-11385-async-menu
Revert "fix: Fix `menu.popup()` bugs"
2017-12-12 08:56:12 -06:00
Charles Kerr
da4af4c90b
Merge pull request #11414 from electron/revert-11395-add-reg-defaults
Revert "Add systemPreferences.registerDefaults()"
2017-12-12 08:46:47 -06:00
Alexey Kuzmin
1c8eb03574
Revert "fix: Fix menu.popup() bugs" 2017-12-12 13:59:34 +03:00
Alexey Kuzmin
1caa04c0bf
Revert "Add systemPreferences.registerDefaults()" 2017-12-12 13:59:15 +03:00
Cheng Zhao
19f1fef040
Merge pull request #11283 from electron/fix-event-subscriber-race
Fix race condition in event_subscriber.h
2017-12-12 10:49:17 +09:00
Charles Kerr
e73fe100d5
Merge pull request #11385 from electron/async-menu
fix: Fix `menu.popup()` bugs
2017-12-11 18:02:33 -06:00
Charles Kerr
76ee1e1cb6
Merge pull request #11406 from xxczaki/master
Added Polish Electron Community
2017-12-11 17:48:33 -06:00
Charles Kerr
99c980ab40
Merge pull request #11395 from electron/add-reg-defaults
Add systemPreferences.registerDefaults()
2017-12-11 17:45:32 -06:00
Shelley Vohr
a8e67e7f61
fixes from review 2017-12-11 18:20:12 -05:00
Felix Rieseberg
927c63b477 🔧 Last round of feedback 2017-12-11 15:19:33 -08:00
Felix Rieseberg
89b90be6a2 🔧 Feedback 2017-12-11 14:43:35 -08:00
Charles Kerr
dcf2a6f388
Make 'https' explicit in the link to electronpl.github.io 2017-12-11 16:37:14 -06:00
Felix Rieseberg
f7ebfff8ae 👷 Properly test x vs y 2017-12-11 14:05:07 -08:00
Felix Rieseberg
dfd7598d48 👷 Hence, better testing 2017-12-11 14:03:04 -08:00
Felix Rieseberg
22e9d665d2 🔧 Menu returns its properties now 2017-12-11 14:03:01 -08:00
Felix Rieseberg
93b46116f4 🔧 Fix value shift 2017-12-11 13:30:35 -08:00
Anthony
c8bb23a2ff
Update README.md 2017-12-11 20:52:56 +01:00
Shelley Vohr
027e78639a
update value type to Any 2017-12-11 14:06:02 -05:00
Shelley Vohr
84bab48627
improve error handling 2017-12-11 13:11:03 -05:00