Milan Burda
4a5c5843c4
fix: <webview> not working with Trusted Types ( #27445 )
2021-01-25 10:29:25 +09:00
Milan Burda
949fd0728f
refactor: replace base::Bind() with base::BindOnce() / base::BindRepeating() ( #27447 )
2021-01-25 10:27:40 +09:00
Zhang Zhi
b11c5533e8
Update security.md ( #27449 )
2021-01-25 10:27:29 +09:00
Charles Kerr
5a8f40ae13
fix: don't throw on bad icons in BrowserWindow constructor ( #27441 )
...
* fix: do not throw if NativeImage conversion fails.
Throwing is an unannounced semver/major breaking change, so revert that
behavior but keep the rest of the #26546 refactor.
* test: add invalid icon test
* refactor: be explicit about when to throw or warn.
2021-01-25 10:24:10 +09:00
Shelley Vohr
d69e0d0573
fix: hiddenInset missing maximize button ( #27428 )
2021-01-25 09:59:06 +09:00
Cheng Zhao
9baca911a1
test: use new uuid for each ServiceWorker test ( #27444 )
2021-01-23 10:37:51 +09:00
Milan Burda
70190ec2b1
chore: update to latest TypeScript, which has built-in WeakRef declarations ( #27425 )
2021-01-22 11:25:47 -08:00
Electron Bot
fcdb7ad21a
Bump v13.0.0-nightly.20210122
2021-01-22 06:33:30 -08:00
John Kleinschmidt
034a792df1
ci: enable arm64 macOS tests ( #24832 )
...
* ci: enable arm64 macOS tests
2021-01-21 18:36:52 -05:00
Michaela Laurencin
4f930b6e42
fix: add eyedropper tool functionality to browser view ( #27275 )
2021-01-21 13:02:29 -08:00
Electron Bot
96e8620e1b
Bump v13.0.0-nightly.20210121
2021-01-21 11:33:09 -08:00
Shelley Vohr
949cfea1e9
fix: actually clear pending requests in devtoolsagenthost ( #27379 )
2021-01-21 11:00:43 -08:00
Electron Bot
c8696d2c3d
Revert "Bump v13.0.0-nightly.20210121"
...
This reverts commit 09b6db4616
.
2021-01-21 07:21:36 -08:00
Electron Bot
09b6db4616
Bump v13.0.0-nightly.20210121
2021-01-21 07:20:19 -08:00
Electron Bot
5c6ad53bd6
Revert "Bump v13.0.0-nightly.20210121"
...
This reverts commit 299bc9adc2
.
2021-01-21 07:18:45 -08:00
Electron Bot
299bc9adc2
Bump v13.0.0-nightly.20210121
2021-01-21 07:14:35 -08:00
John Kleinschmidt
e5d64da68a
Revert "Bump v13.0.0-nightly.20210121"
...
This reverts commit 6d6a785982
.
2021-01-21 10:11:30 -05:00
Electron Bot
6d6a785982
Bump v13.0.0-nightly.20210121
2021-01-21 06:32:20 -08:00
renmu123
9487afab33
docs: change semver to SemVer ( #27350 )
...
* docs: change semver to SemVer
* docs: add a Period
* docs: udpate a broken relative link
* docs: update the links
* docs: update the links
2021-01-21 15:51:02 +09:00
John Kleinschmidt
c5a41defbd
fix: enable navigator.setAppBadge/clearAppBadge ( #27067 )
2021-01-21 14:45:06 +09:00
Milan Burda
8b74361b0c
refactor: store WeakMaps in CallbacksRegistry / ObjectsRegistry ( #27037 )
2021-01-20 14:03:10 -08:00
Biru Mohanathas
7f1e3ca3de
fix: shutdown crash in DownloadItem callback ( #27342 )
...
The call stack for one of our top crashes looks like this:
```
node::Abort (node_errors.cc:241)
node::Assert (node_errors.cc:256)
node::MakeCallback (callback.cc:226)
gin_helper::internal::CallMethodWithArgs (event_emitter_caller.cc:23)
gin_helper::EmitEvent<T> (event_emitter_caller.h:51)
gin_helper::EventEmitterMixin<T>::Emit<T> (event_emitter_mixin.h:81)
electron::api::DownloadItem::OnDownloadUpdated (electron_api_download_item.cc:115)
download::DownloadItemImpl::UpdateObservers (download_item_impl.cc:482)
content::DownloadManagerImpl::Shutdown (download_manager_impl.cc:508)
content::BrowserContext::~BrowserContext (browser_context.cc:476)
```
Full stack here: https://sentry.io/share/issue/9b030a0601b547188181b543c16ecda2/
During browser shutdown, the `DownloadManager` was being cleaned up
*after* the Node environment had already been destroyed. This caused the
`DownloadItem::OnDownloadUpdated` callback to crash when trying to emit
the JS `done` event.
To prevent this, we now manually shut down the `DownloadManager`
earlier. This is also mentioned in the comment on
`DownloadManager::Shutdown`:
```
// Shutdown the download manager. Content calls this when BrowserContext is
// being destructed. If the embedder needs this to be called earlier, it can
// call it. In that case, the delegate's Shutdown() method will only be called
// once.
```
2021-01-20 11:30:08 -08:00
Chris Hartgerink
7ddc756a08
docs: correct typo in native-file-drag-drop.md ( #27387 )
...
Corrects minor typo
2021-01-20 11:28:10 -08:00
John Kleinschmidt
2153e47502
Revert "build: remove buildflags workaround ( #27372 )" ( #27410 )
...
This reverts commit e4fc47f557
.
2021-01-20 14:21:53 -05:00
Electron Bot
b6a0fcd51d
Bump v13.0.0-nightly.20210120
2021-01-20 06:33:03 -08:00
Robo
34772292f7
fix: increase stack size on windows ( #27376 )
2021-01-20 00:50:05 -08:00
Shelley Vohr
e4fc47f557
build: remove buildflags workaround ( #27372 )
2021-01-19 18:46:20 -08:00
Electron Bot
5fb1095806
Bump v13.0.0-nightly.20210119
2021-01-19 07:51:27 -08:00
Electron Bot
b0c1a2ae25
Revert "Bump v13.0.0-nightly.20210119"
...
This reverts commit 9a336a6a3b
.
2021-01-19 07:48:40 -08:00
Electron Bot
9a336a6a3b
Bump v13.0.0-nightly.20210119
2021-01-19 06:32:53 -08:00
Cheng Zhao
c3091c3a70
fix: make SetWindowButtonVisibility work for customButtonsOnHover ( #27073 )
2021-01-19 19:12:09 +09:00
David Sanders
5e7e0a4c7e
fix: improve redirect behavior in protocol module ( #26297 )
...
* fix: improve redirect behavior in protocol module
* Add test for redirection
Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
2021-01-19 19:06:14 +09:00
Samuel Maddock
4334110339
fix: prevent crash when keyboard event immediately precedes calling BrowserWindow.close() ( #27315 )
...
* fix: prevent crash when destroyed widget receives keyboard event
Activating a key to close a window will cause a silent crash. Handling the keyboard
event will lead to a nullptr dereferenced in Chromium code if the window widget has
already been destroyed.
* test: ensure BrowserWindow doesn't crash from keyboard events during close
2021-01-19 11:37:21 +09:00
riccardopiola
d7b02e123a
chore: duplicate symbols for mojom interfaces in component build ( #27186 )
...
* fix duplicate symbols in component build
* fix: duplicate symbols for mojom interfaces in component build
2021-01-19 11:31:44 +09:00
Electron Bot
b27fa567bc
Bump v13.0.0-nightly.20210118
2021-01-18 06:31:32 -08:00
Electron Bot
3b38ba2ed8
Bump v13.0.0-nightly.20210115
2021-01-15 06:33:34 -08:00
Milan Burda
2be3d03630
feat: add webFrameMain.send() / webFrameMain.postMessage() ( #26807 )
2021-01-15 09:00:37 +09:00
Electron Bot
28b6579538
Bump v13.0.0-nightly.20210114
2021-01-14 06:33:16 -08:00
David Sanders
63ca878210
chore: use markdownlint to lint the docs ( #26792 )
...
* chore: use markdownlint to lint the docs
* chore: fix markdown lints
Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
2021-01-14 17:31:26 +09:00
Shelley Vohr
40e80af9a9
fix: crash in renderer process with non-context-aware modules ( #27296 )
2021-01-13 21:06:43 -08:00
Milan Burda
dd17250a80
revert: test use emittedUntil in PDF Viewer tests ( #27273 )
...
This reverts commit 36f4ee87df
.
2021-01-13 13:49:35 -08:00
Cheng Zhao
cd42933f41
chore: remove ancient Browser::Focus implementation on Windows ( #27279 )
2021-01-13 13:46:54 -08:00
Shelley Vohr
0599487e65
refactor: use platform-specific TaskRunner to print ( #27225 )
2021-01-13 09:17:11 -08:00
Electron Bot
1c66cacf70
Bump v13.0.0-nightly.20210113
2021-01-13 06:34:32 -08:00
loc
ceda33dd5e
chore: surface webcontents load error more readily ( #22824 )
2021-01-13 18:01:51 +09:00
Cheng Zhao
9deae1c3c4
chore: do no semantic check on commit messages ( #27276 )
2021-01-12 19:37:32 -08:00
Shelley Vohr
61004723ac
build: fixup feature request template ( #27288 )
2021-01-12 17:01:19 -08:00
Electron Bot
adf0a73543
chore: bump chromium to a264339194bfa02f5ecb3b8cba449 (master) ( #27111 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2021-01-12 15:31:23 -08:00
Electron Bot
1cd72425aa
Bump v13.0.0-nightly.20210112
2021-01-12 06:33:44 -08:00
Electron Bot
d69f578179
Bump v13.0.0-nightly.20210111
2021-01-11 06:32:34 -08:00