Commit graph

510 commits

Author SHA1 Message Date
Cheng Zhao
aafc48ae2c Merge pull request #213 from 3v1n0/linux-notifications-append
Linux notifications append
2016-04-15 20:57:02 +09:00
Cheng Zhao
1b11bb56be Merge pull request #212 from deepak1556/devtools_network_controller_patch
Fix race initialising DevtoolsNetworkController
2016-04-15 19:41:54 +09:00
Cheng Zhao
593fb8cdf0 Delay notification events to next tick
It is possible that the events get emitted when calling Show(), which
would then delete the class before Show() ends, results in using members
of a deleted class.

By delaying the events to next tick we can effectively avoid this.
2016-04-15 16:20:36 +09:00
Cheng Zhao
f4c27c6d29 Store weak ref to Notification in ToastEventHandler 2016-04-15 16:14:13 +09:00
Cheng Zhao
ddee77fae4 Do not use get_Setting to determine whether notification is enabled
On Windows 10 get_Setting always returns DISABLED when the program has a
AppUserModelID.
2016-04-15 16:01:21 +09:00
Marco Trevisan (Treviño)
83cbc1182d LibnotifyNotification: use "append" when supported
This behavior can be overridden by just providing unique tags to notifications
2016-04-14 18:31:02 +02:00
Marco Trevisan (Treviño)
8962da380b LibnotifyLoader: add notify_notification_set_hint_string 2016-04-14 18:29:00 +02:00
Marco Trevisan (Treviño)
8dd7a8d7fe LibNotifyLoader: implement generic HasCapability 2016-04-14 18:24:00 +02:00
deepak1556
de60acbfde Fix race initialising DevtoolsNetworkController 2016-04-14 08:57:20 +05:30
Cheng Zhao
2f107fcbe1 Merge pull request #211 from 3v1n0/notifications-tags
Notifications tags
2016-04-13 20:12:37 +09:00
Marco Trevisan (Treviño)
1ce34fb8d2 LibnotifyNotification: add support for notification tag
We set the id of the notification if tag is provided.
As per the protocol, this should cause the old notification with same ID to be replaced.
2016-04-13 06:12:46 +02:00
Marco Trevisan (Treviño)
59ed6ad413 Notification: pass tag to Show method 2016-04-13 06:12:46 +02:00
Marco Trevisan (Treviño)
743ceed780 LibnotifyNotification: verify if the "actions" capability is supported before adding actions
This would prevent to add actions to notifier such as Ubuntu's Notify-OSD
which doesn't support them.
2016-04-13 04:43:22 +02:00
Marco Trevisan (Treviño)
a22dc8676f LibnotifyLoader: add notify_get_server_caps support 2016-04-13 04:42:01 +02:00
Marco Trevisan (Treviño)
4e7f478d1e LibnotifyLoader: add notify_get_server_info support 2016-04-13 04:02:23 +02:00
Cheng Zhao
11685faffa Hijack the Page.reload command 2016-04-12 16:35:35 +09:00
deepak1556
2b3813135c register localized media strings 2016-04-08 12:42:50 +05:30
Felix Rieseberg
b68be5c583 🏁 Notify only when enabled
- Previously, we'd attempt to create a notification no matter what the
  user's configuration was. Microsoft advises against that, because it
  can create race conditions if notifications are disabled.
- This fixes the issue.

Closes https://github.com/atom/electron/issues/4681
2016-03-15 17:10:24 -07:00
Robo
c25264113f fix devtools filesystem api and allow delegate to request stored filesystem paths 2016-03-15 07:53:40 +05:30
Robo
215a81d0e6 update devtools network interceptor to throttle uploads 2016-03-14 04:01:30 +05:30
Cheng Zhao
b68d2ba8b5 Fix compilation error on Windows 2016-03-10 15:56:13 +09:00
Cheng Zhao
5ce6592e1c Handle nullptr in RequestConextGetter 2016-03-10 14:39:07 +09:00
Cheng Zhao
82c30ef9b9 Fix RenderFrameHostChanged 2016-03-09 18:47:11 +09:00
Cheng Zhao
ead0bb0cfc Fix devtools not working 2016-03-09 14:55:46 +09:00
Cheng Zhao
d3a39540b5 Fix compilation errors on OS X 2016-03-08 23:28:28 +09:00
Cheng Zhao
baf5f384cd Pass() is deprecated for std::move 2016-03-08 20:59:29 +09:00
Cheng Zhao
948e7c4055 virutal should not be used together with override 2016-03-08 17:51:16 +09:00
Paul Betts
dba6680578 Everyone gets permission 2016-03-07 23:09:25 -08:00
Paul Betts
6517dffa04 Start to update UrlRequestContextGetter 2016-03-07 22:58:25 -08:00
Paul Betts
18a75b5124 Renamed enum in MediaStreamDeviceRequest 2016-03-07 22:38:48 -08:00
Paul Betts
d204febecf Update DevtoolsNetworkTransaction 2016-03-07 22:29:23 -08:00
Paul Betts
40c98381ab Update headers for InspectableWebContentsImpl 2016-03-07 22:18:16 -08:00
Paul Betts
157f3abe64 Not quite sure how this ever worked 2016-03-07 22:02:42 -08:00
Paul Betts
e901b1c6ca Update NetworkDelegate 2016-03-07 21:59:14 -08:00
Paul Betts
da59c0f58b basictypes.h => macros.h 2016-03-07 21:40:41 -08:00
Cheng Zhao
c61e6f3f17 Remove DefaultWebContentsDelegate 2016-02-01 21:08:52 +08:00
Cheng Zhao
7cfc9fad83 Fix compilation error 2016-01-27 23:18:42 +08:00
Robo
3b09c370d4 allow client to decide displaying web notifications 2016-01-25 22:09:36 +05:30
Felix Rieseberg
728f0f985b 🏁 🍎 Add Silent Notification Support
* Implements support for silent notifications on Windows and OS X
 * Exposes bool `silent` to Linux notification presenters
2016-01-21 09:24:42 -08:00
Cheng Zhao
f5bb23124a Change our PATH_START to 11000 2016-01-11 10:40:20 +08:00
Cheng Zhao
d6051e9580 Initialize resource bundle on browser process separately 2016-01-08 12:04:23 +08:00
Cheng Zhao
870e6a6f89 linux: Adapt to new Notification style 2015-12-25 11:52:19 +08:00
Cheng Zhao
82cef44623 win: Fire NotificationFailed when failed to show notification 2015-12-25 11:17:35 +08:00
Cheng Zhao
c81bacc840 mac: Emit closed when notification is dismissed 2015-12-25 11:12:25 +08:00
Cheng Zhao
b091f27abf win: Adapt to new Notification style 2015-12-25 11:05:48 +08:00
Cheng Zhao
5b7c7be804 Decouple notification code from content module 2015-12-25 10:16:07 +08:00
Cheng Zhao
6f81d1e29f Expose NotificationPresenter to public 2015-12-24 22:20:47 +08:00
Cheng Zhao
9897f3aab0 Add an abstract Notification class 2015-12-24 22:06:41 +08:00
Cheng Zhao
41084883cf Refactor the notification code 2015-12-24 21:55:18 +08:00
Cheng Zhao
513b6ae0d6 Do not use icon url when showing notification 2015-12-24 20:03:54 +08:00