trop[bot]
7182bc2359
fix: clang variable configuration in generated node headers ( #44201 )
...
* fix: clang variable configuration in generated node headers
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* chore: restore value in common.gypi
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* chore: update patches
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-10-11 15:25:34 -04:00
trop[bot]
868a713208
ci: don't call datadog test logging on forks ( #44195 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-10-11 09:41:24 -04:00
trop[bot]
0e9722dc50
fix: -Wunsafe-buffer-usage warning in WriteAsciiChunk() ( #44167 )
...
* fix: -Wunsafe-buffer-usage warning in WriteAsciiChunk()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: add // SAFETY comment to explain UNSAFE_BUFFERS() use
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-09 20:38:19 -05:00
trop[bot]
ca8479d859
fix: -Wunsafe-buffer-usage warning in HasWordCharacters() ( #44170 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-09 17:07:20 -05:00
trop[bot]
b30973a5de
fix: -Wunsafe-buffer-usage warnings in GetNextZoomLevel() ( #44164 )
...
fixup e8948397
2024-10-09 13:01:22 -05:00
electron-roller[bot]
90bc239f25
chore: bump chromium to 128.0.6613.186 (32-x-y) ( #44162 )
...
chore: bump chromium in DEPS to 128.0.6613.186
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-10-09 12:36:07 -04:00
John Kleinschmidt
44d2bbea0c
ci: add datadog test logging ( #44142 )
...
* ci: add datadog test logging
(cherry picked from commit 394ea2979fda0c1551df5d5bdf7c13b57d9be181)
* ci: only upload to datadog when running tests
(cherry picked from commit c3200d8f1540f78c25673a4a9d9af3b8506f9474)
2024-10-09 11:41:02 -04:00
electron-roller[bot]
da32971374
chore: bump node to v20.18.0 (32-x-y) ( #44116 )
...
* chore: bump node in DEPS to v20.18.0
* chore: update patches
* src: improve buffer.transcode performance
https://github.com/nodejs/node/pull/54153
(cherry picked from commit 669984dafcb698716fc02a03e4cf027767a6ec59)
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-10-09 09:53:06 -04:00
Samuel Attard
27c38bdead
build: add import/order eslint rule ( #44107 )
...
build: add import/order eslint rule (#44085 )
* build: add import/order eslint rule
* chore: run lint:js --fix
2024-10-02 21:36:15 -07:00
trop[bot]
bf8de29f9b
fix: remove use of deprecated API base::Hash() ( #44102 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-02 17:56:49 -05:00
Charles Kerr
058a616135
perf: use ArrayBuffer::Data() instead of GetBackingStore()->Data() (32-x-y) ( #44095 )
...
perf: use ArrayBuffer::Data() instead of GetBackingStore()->Data() (#44067 )
perf: use ArrayBuffer::Data() API
Replace our `GetBackingStore()->Data()` calls with this instead.
Explained by the V8 docs, ArrayBuffer.Data() is
> More efficient shortcut for GetBackingStore()->Data(). The
> returned pointer is valid as long as the ArrayBuffer is alive.
2024-10-02 16:37:54 -04:00
Charles Kerr
bd8b9daa74
fix: -Wunsafe-buffer-usage warnings in WebFrameRenderer::ExecuteJavaScript() (32-x-y) ( #44097 )
...
fix: -Wunsafe-buffer-usage warnings in WebFrameRenderer::ExecuteJavaScript() (#44053 )
2024-10-02 16:35:26 -04:00
electron-roller[bot]
a635dac618
chore: bump chromium to 128.0.6613.178 (32-x-y) ( #44086 )
...
chore: bump chromium in DEPS to 128.0.6613.178
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-10-01 21:57:30 -05:00
trop[bot]
653b928e0d
build: fix relative file read during npm publish ( #44092 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2024-10-01 17:19:29 -07:00
trop[bot]
98b1d305b6
build: cleanup release scripts, separate cli entrypoints from logic ( #44081 )
...
* build: cleanup release scripts, separate cli entrypoints from logic
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
* build: use repo/org constants
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2024-10-01 14:08:03 -07:00
Samuel Attard
2f519a8f2e
build: update some build dependencies ( #44070 )
...
* build: update some build dependencies (#43882 )
* build: update some build dependencies
* build: fix eslint issues after updating
* build: disable ts check on busted js example
* build: update internal types for stricter event handling
* restore url.parse behavior
* fix typing issues
* sigh
* build: update easy deps
* build: skip woa engines check
* build: s/colors/chalk
* build: node 20 on windows
2024-10-01 13:04:53 -07:00
Samuel Attard
2e84985439
build: convert all release scripts to typescript ( #44060 )
...
* build: run gha on tag not branch (#42490 )
* build: convert all release scripts to typescript (#44035 )
* build: convert all release scripts to typescript
* fix test imports
* build: fix version bumper export
* refactor: use as const
* spec: fix bad type spec
* build: use ts-node to spawn the version-bumper (#44057 )
Missed this in the tsification, we should probably call this via API instead of spawning a sub-proc?
* build: still colors
2024-10-01 10:45:06 -04:00
Charles Kerr
956677b66a
fix: -Wunsafe-buffer-usage in electron::SetFontDefaults() (32-x-y) ( #44030 )
...
* fix: -Wunsafe-buffer-usage in electron::SetFontDefaults() (#44014 )
* refactor: reduce code duplication in WebContentsPreferences::OverrideWebkitPrefs()
* refactor: limit scope of web_preferences temporary in ElectronBrowserClient::OverrideWebkitPrefs()
* chore: remove redundant static keyword on function in anonymous namespace
* refactor: slightly more explicit typing
* refactor: remove unnecessary utf16 -> utf8 -> utf16 conversion steps
* chore: remove unused #includes
* refactor: use string_view.rfind() instead of base::RSplitStringOnce()
base::RSplitStringOnce() does not exist in Chromium 128
2024-09-30 14:47:57 -04:00
trop[bot]
e69f5bc850
fix: ensure correct WebContents when checking PDFReadyToPrint (32-x-y) ( #44011 )
...
* fix: ensure correct `WebContents` when checking `PDFReadyToPrint` (#43943 )
* fix: ensure correct WebContents when checking PDFReadyToPrint
* test: fix paths on Windows
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* Update spec/api-web-contents-spec.ts
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-29 15:38:22 +02:00
trop[bot]
dad72f1925
ci: write test logging to console on Windows ( #44005 )
...
test: write logging to console on Windows
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-09-29 09:55:15 +02:00
trop[bot]
8a35e24249
fix: remove resize listener when BrowserWindow closed ( #44001 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-27 14:45:48 -04:00
trop[bot]
21a8a97c28
fix: replace deprecated libnotify API calls ( #43984 )
...
notify_notification_set_hint_string() is deprecated, so let's use
notify_notification_set_hint() instead.
Xref: 2fe1748295
2024-09-26 17:08:20 -05:00
trop[bot]
ebf189b304
perf: build g_dgettext domain name at compile time ( #43988 )
...
perf: build GettextPackage name at compile time
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-26 17:07:02 -05:00
trop[bot]
5e87aa0eb2
fix: -Wunsafe-buffer-usage warnings in GdkPixbufFromSkBitmap() ( #43979 )
...
* fix: -Wunsafe-buffer-usage warnings in GdkPixbufFromSkBitmap()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: don't change previous behavior for 0-height images
Is a 0x0 image even a thing? I'm not sure; but just in case, let's
treat it the same way the previous implementation did.
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-26 10:20:08 -05:00
trop[bot]
5224974313
test: add tests dbus notification images ( #43944 )
...
* test: add tests dbus notification images
Provide a NativeImage icon in the notification tests and then inspect
the DBus message payload's `image_data` hint to see if it's correct.
This adds test coverage for LibnotifyNotification::Show() and for
GdkPixbufFromSkBitmap().
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: use the same notification_icon.png as in main
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-25 16:48:39 -05:00
electron-roller[bot]
b4cd8c0605
chore: bump chromium to 128.0.6613.170 (32-x-y) ( #43947 )
...
chore: bump chromium in DEPS to 128.0.6613.170
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-09-25 16:45:38 -04:00
trop[bot]
3e95df701a
test: ensure sender-pid hint is set in Linux notifications ( #43950 )
...
test: expect a `sender-pid` hint in Linux notifications.
This PR ensures that the `sender-pid` hint is set for new notifications.
It also updates the spec to confirm that DBus receives the hint and that
it has the correct value.
This fixes a spec failure when running libnotify >= 0.7.12 (2022-05-05).
Starting with that version, libnotify started injecting `sender-pid` if
not provided by the client. So our tests received a slightly different
DBus payload depending on what version of libnotify was installed,
causing our deep-equals tests to fail.
By always providing and testing the `sender-pid` hint, our behavior and
tests should be consistent across distros.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-25 12:13:07 -05:00
trop[bot]
5e32d32913
fix: close all open sheets before closing window on macOS ( #43954 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Beutner <beutner.john@gmail.com>
2024-09-25 12:12:14 -05:00
trop[bot]
497ecca01e
fix: detach native view when its removed from parent on macOS ( #43923 )
...
Right now DelayedNativeViewHost attaches its underlying native view
when it's being attached to a widget but it doesn't detach it when
it's being detached. It may lead to use-after-free and crash.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Cezary Kulakowski <cezary@openfin.co>
2024-09-25 13:17:53 +02:00
trop[bot]
ff94658d46
fix: crash when focusing WebView webContents ( #43934 )
...
fix: crash when focusing WebView
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-25 13:17:37 +02:00
trop[bot]
241288d3cc
fix: -Wunsafe-buffer-usage warning in asar_util's ReadFileToString() ( #43931 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-25 11:22:24 +02:00
Charles Kerr
f4a8d8a094
refactor: remove C-style void arg type for no-arg functions (32-x-y) ( #43925 )
...
refactor: remove C-style void arg type for no-arg functions (#43884 )
A small cleanup to remove use of the C-style function declaration idiom.
2024-09-25 11:21:24 +02:00
dependabot[bot]
34bed11a7c
build(deps): bump mikefarah/yq from 4.44.1 to 4.44.3 ( #43911 )
...
Bumps [mikefarah/yq](https://github.com/mikefarah/yq ) from 4.44.1 to 4.44.3.
- [Release notes](https://github.com/mikefarah/yq/releases )
- [Changelog](https://github.com/mikefarah/yq/blob/master/release_notes.txt )
- [Commits](557dcb87b8...bbdd97482f
2024-09-23 23:26:18 -07:00
dependabot[bot]
2c5514d0fe
build(deps): bump github/codeql-action from 3.25.7 to 3.26.8 ( #43912 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.25.7 to 3.26.8.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](f079b84933...294a9d9291
2024-09-23 23:26:05 -07:00
Charles Kerr
4e74793433
fix: -Wunsafe-buffer-usage warnings in GetNextZoomLevel() ( #43894 )
...
fix: -Wunsafe-buffer-usage warnings in GetNextZoomLevel() (#43803 )
2024-09-23 22:36:51 -07:00
dependabot[bot]
9d438e594f
build(deps): bump actions/download-artifact from 4.1.7 to 4.1.8 ( #43913 )
...
Bumps [actions/download-artifact](https://github.com/actions/download-artifact ) from 4.1.7 to 4.1.8.
- [Release notes](https://github.com/actions/download-artifact/releases )
- [Commits](65a9edc588...fa0a91b85d
2024-09-23 22:31:12 -07:00
dependabot[bot]
7ad6b192a0
build(deps): bump actions/upload-artifact from 4.3.3 to 4.4.0 ( #43914 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.3.3 to 4.4.0.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](https://github.com/actions/upload-artifact/compare/v4.3.3...50769540e7f4bd5e21e526ee35c689e35e0d6874 )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 21:27:56 -07:00
dependabot[bot]
e4bdff6cc1
build(deps): bump dsanders11/github-app-commit-action from 1.4.0 to 1.5.0 ( #43915 )
...
build(deps): bump dsanders11/github-app-commit-action
Bumps [dsanders11/github-app-commit-action](https://github.com/dsanders11/github-app-commit-action ) from 1.4.0 to 1.5.0.
- [Release notes](https://github.com/dsanders11/github-app-commit-action/releases )
- [Changelog](https://github.com/dsanders11/github-app-commit-action/blob/main/.releaserc.json )
- [Commits](48d2ff8c1a...43de6da2f4
2024-09-23 21:27:32 -07:00
Shelley Vohr
8b7f96057c
fix: createWindow shouldn't load URL for webContents ( #43877 )
2024-09-23 21:55:08 +02:00
trop[bot]
8d6a5fa522
build: add support for fetching github token from sudowoodo ( #43885 )
...
* build: add support for fetching github token from sudowoodo
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
* chore: update release notes cache for tests
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
* build: support nightlies repo correctly
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
* build: post token
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2024-09-23 11:07:16 -07:00
trop[bot]
19b70a4cb4
docs: add advanced specification for Squirrel updater ( #43891 )
...
* docs: add advanced specification for Squirrel updater
Co-authored-by: Erick Zhao <ezhao@slack-corp.com>
* address feedback
Co-authored-by: Erick Zhao <ezhao@slack-corp.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Erick Zhao <ezhao@slack-corp.com>
2024-09-23 11:02:31 -07:00
dependabot[bot]
8b229743d5
build(deps): bump actions/setup-node from 4.0.2 to 4.0.4 ( #43842 )
...
Bumps [actions/setup-node](https://github.com/actions/setup-node ) from 4.0.2 to 4.0.4.
- [Release notes](https://github.com/actions/setup-node/releases )
- [Commits](60edb5dd54...0a44ba7841
2024-09-23 06:55:00 -07:00
dependabot[bot]
199bc0968b
build(deps): bump actions/checkout from 4.1.6 to 4.1.7 ( #43838 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.6 to 4.1.7.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v4.1.6...692973e3d937129bcbf40652eb9f2f61becf3332 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 06:53:54 -07:00
dependabot[bot]
fe2af7b9cd
build(deps): bump ossf/scorecard-action from 2.3.3 to 2.4.0 ( #43834 )
...
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action ) from 2.3.3 to 2.4.0.
- [Release notes](https://github.com/ossf/scorecard-action/releases )
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md )
- [Commits](dc50aa9510...62b2cac7ed
2024-09-23 06:51:16 -07:00
dependabot[bot]
1e2b2f52a1
build(deps): bump amannn/action-semantic-pull-request from 5.5.2 to 5.5.3 ( #43832 )
...
build(deps): bump amannn/action-semantic-pull-request
Bumps [amannn/action-semantic-pull-request](https://github.com/amannn/action-semantic-pull-request ) from 5.5.2 to 5.5.3.
- [Release notes](https://github.com/amannn/action-semantic-pull-request/releases )
- [Changelog](https://github.com/amannn/action-semantic-pull-request/blob/main/CHANGELOG.md )
- [Commits](cfb60706e1...0723387faa
2024-09-23 06:50:13 -07:00
dependabot[bot]
5c72872230
build(deps): bump slackapi/slack-github-action from 1.26.0 to 1.27.0 ( #43828 )
...
Bumps [slackapi/slack-github-action](https://github.com/slackapi/slack-github-action ) from 1.26.0 to 1.27.0.
- [Release notes](https://github.com/slackapi/slack-github-action/releases )
- [Commits](70cd7be8e4...37ebaef184
2024-09-23 06:46:47 -07:00
trop[bot]
192226d793
fix: -Wunsafe-buffer-usage warnings in Clipboard::WriteBuffer() ( #43811 )
...
* fix: -Wunsafe-buffer-usage warnings in Clipboard::WriteBuffer()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: add a DCHECK to confirm the BigBuffer is full
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-20 08:48:14 -05:00
trop[bot]
8ac9d16162
fix: third time screen sharing on macOS ( #43809 )
...
Because we used decrementing negative source ids for fake video id when
instantating a native macOS screen share picker, we eventually hit the
`DesktopMediaID::kFakeId = -3` in Chromium source code which displayed a
test green screen.
In this change we reserve our own fake id of `-4` and decrement the
window id integer for uniqueness instead.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Fedor Indutny <238531+indutny@users.noreply.github.com>
2024-09-19 20:33:41 -07:00
trop[bot]
2bc8797fed
refactor: NotificationPresenter::Create() returns a std::unique_ptr<> ( #43806 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-19 22:11:59 -05:00
trop[bot]
08579bdcd5
chore: fix compile issue about ambiguous error of multiple methods named 'highlight'. ( #43801 )
...
chore: fix ambiguous error of multiple methods named 'highlight'
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: bill.shen <shenyb32768@gmail.com>
2024-09-19 09:33:28 -05:00
