Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	
	
	ad16e6c647 
 
						 
						
							
							
								
								
								build: update linting deps ( #24461 )  
							
							
							
						 
						
							2020-07-08 21:19:49 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Shelley Vohr 
								
							 
						 
						
							
							
								
							
							
	
	
	659e79fc08 
 
						 
						
							
							
								
								
								refactor: prevent consistent early exception ( #24191 )  
							
							... 
							
							
							
							* refactor: prevent consistent early exception
* Use _linkedBinding where possible
* Remove dead electronBinding 
							
						 
						
							2020-06-22 20:32:45 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Robo 
								
							 
						 
						
							
							
								
							
							
	
	
	c438b93f18 
 
						 
						
							
							
								
								
								fix: ensure guest-embedder map is updated when webview is removed ( #23342 )  
							
							... 
							
							
							
							There are use cases of webview where the container holding the webview is not
actually destroyed first, instead just webview gets removed from DOM, in such
situations the browser process map is not updated accordingly and holds reference
to stale guest contents, and any window operations like scroll, resize or keyboard
events that has to chain through browser embedder will lead to UAF crash.
Ref: https://github.com/microsoft/vscode/issues/92420  
							
						 
						
							2020-04-30 21:33:14 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	
	
	5d657dece4 
 
						 
						
							
							
								
								
								build: enable JS semicolons ( #22783 )  
							
							
							
						 
						
							2020-03-20 13:28:31 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	
	
	b87b501161 
 
						 
						
							
							
								
								
								build: update eslint + eslint plugins ( #22777 )  
							
							... 
							
							
							
							* build: run eslint --fix
* chore: manually fix all hasOwnProperty errors
* chore: manually fix all void 0 vs undefined errors
* chore: manually fix all async-in-promise errors
* chore: manually fix lexical declaration in case block 
							
						 
						
							2020-03-20 11:12:18 -04:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Shelley Vohr 
								
							 
						 
						
							
							
								
							
							
	
	
	efc11563e8 
 
						 
						
							
							
								
								
								fix: properly forward properties to webview ( #22485 )  
							
							
							
						 
						
							2020-03-03 22:25:14 +00:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	1d596f616d  
						 
						
							
							
								
								
								fix: NativeImage serialization of <webview>.capturePage() result ( #20825 )  
							
							
							
						 
						
							2019-11-12 21:56:17 +01:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	093f2dd4a6  
						 
						
							
							
								
								
								chore: remove deprecated <webview>.getWebContents() ( #20986 )  
							
							
							
						 
						
							2019-11-08 15:46:35 -05:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	f1e7393e30  
						 
						
							
							
								
								
								feat: deprecate <webview>.getWebContents() ( #20726 )  
							
							
							
						 
						
							2019-11-07 09:43:19 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	d090b0cd2d  
						 
						
							
							
								
								
								perf: only access remote module when <webview>.getWebContents() is called ( #20272 )  
							
							
							
						 
						
							2019-09-20 08:54:16 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	81e9dab52f  
						 
						
							
							
								
								
								refactor: replace ipcRendererUtils.invoke() with ipcRendererInternal.invoke() ( #19574 )  
							
							
							
						 
						
							2019-08-23 15:45:50 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Alexandre Lacheze 
								
							 
						 
						
							
							
								
							
							
	e26f366405  
						 
						
							
							
								
								
								Revert: electron/electron#14487 ( #19011 )  
							
							
							
						 
						
							2019-07-11 17:25:26 -05:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	faa2710485  
						 
						
							
							
								
								
								fix: do not wait on promise returned by remote APIs ( #18990 )  
							
							... 
							
							
							
							* fix: make <webview>.loadURL async
* docs: webview.loadURL returns Promise 
							
						 
						
							2019-07-10 08:20:28 -05:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	deebde66f9  
						 
						
							
							
								
								
								feat: make async webContents / <webview> methods return a Promise ( #18792 )  
							
							
							
						 
						
							2019-06-17 12:10:02 +03:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Shelley Vohr 
								
							 
						 
						
							
							
								
							
							
	d87b3ead76  
						 
						
							
							
								
								
								chore: remove promisification deprecation callbacks ( #17907 )  
							
							... 
							
							
							
							* chore: remove promisification deprecation callbacks
* update docs
* fix smoke test
* fix executejs issue
* cleanup leftovers
* fix webContents.executeJavaScript tests
* cleanup WebContents.prototype.takeHeapSnapshot
* fix "sets arbitrary webContents as devtools" test
* fix executeJavaScriptInFrame related tests 
							
						 
						
							2019-04-30 07:08:32 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	546466b209  
						 
						
							
							
								
								
								feat: add <webview>.getWebContentsId() ( #17407 )  
							
							
							
						 
						
							2019-03-26 10:57:27 +09:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Shelley Vohr 
								
							 
						 
						
							
							
								
							
							
	
	
	38d75010c7 
 
						 
						
							
							
								
								
								chore: rename atomBinding to electronBinding ( #17419 )  
							
							
							
						 
						
							2019-03-18 12:37:06 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	3a091cdea4  
						 
						
							
							
								
								
								refactor: implement clipboard APIs without the remote module ( #17200 )  
							
							
							
						 
						
							2019-03-15 17:32:04 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Heilig Benedek 
								
							 
						 
						
							
							
								
							
							
	43ef561d48  
						 
						
							
							
								
								
								feat: enable NodeIntegrationInSubFrames for webview ( #17226 )  
							
							... 
							
							
							
							* feat: enable nodeIntegrationInSubFrames for webview
* test: add tests
* docs: document webview's nodeintegrationinsubframes
* lint: fix indent
* fix: resolve some merge bloopers 
							
						 
						
							2019-03-15 10:39:20 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	48a95f9677  
						 
						
							
							
								
								
								fix: remove non-existent gpu-crashed event on <webview> ( #17317 )  
							
							
							
						 
						
							2019-03-11 17:25:46 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	
	
	61fc95417b 
 
						 
						
							
							
								
								
								build: fix new TS linting errors ( #17279 )  
							
							... 
							
							
							
							* remove unused _args var
* handle type/variable shadowing 
							
						 
						
							2019-03-07 17:18:10 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Felix Rieseberg 
								
							 
						 
						
							
							
								
							
							
	f3fc4023cf  
						 
						
							
							
								
								
								refactor: Port renderer/web-view to TypeScript ( #17250 )  
							
							
							
						 
						
							2019-03-07 15:26:23 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	bbd1ae315a  
						 
						
							
							
								
								
								refactor: use invoke/invokeSync helpers for <webview> implementation ( #16784 )  
							
							
							
						 
						
							2019-03-01 13:33:03 -05:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Felix Rieseberg 
								
							 
						 
						
							
							
								
							
							
	2498e8d1c2  
						 
						
							
							
								
								
								refactor: Port renderer-internal to TypeScript ( #16939 )  
							
							... 
							
							
							
							* chore: make aliasify work on .ts files as well
* refactor: Port ipc-renderer-internal to TypeScript
* refactor: Correctly import internal ipcRenderer
* refactor: One more rename
* refactor: Fix one more lint issue
* refactor: Correctly reference ipcRendererInternal 
							
						 
						
							2019-02-14 17:24:25 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	36ce3e9546  
						 
						
							
							
								
								
								feat: promisify webContents.printToPDF() ( #16795 )  
							
							
							
						 
						
							2019-02-11 09:20:04 -10:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	fef262f829  
						 
						
							
							
								
								
								fix: check process.isMainFrame in sandboxed_renderer/init.js ( #16500 )  
							
							
							
						 
						
							2019-01-24 10:53:16 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	b965e54efc  
						 
						
							
							
								
								
								fix: <webview> not working with contextIsolation + sandbox ( #16469 )  
							
							
							
						 
						
							2019-01-22 10:08:16 +09:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Shelley Vohr 
								
							 
						 
						
							
							
								
							
							
	
	
	720197f9c8 
 
						 
						
							
							
								
								
								fix: correctly handle IPC for promise-based methods ( #16433 )  
							
							
							
						 
						
							2019-01-17 12:08:54 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Robo 
								
							 
						 
						
							
							
								
							
							
	52fe92d02e  
						 
						
							
							
								
								
								feat: Upgrade to Chromium 71.0.3578.98 ( #15966 )  
							
							
							
						 
						
							2019-01-11 17:00:43 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	
	
	8584c2f14b 
 
						 
						
							
							
								
								
								fix: register webview in main world when using contextIsolation ( #16067 )  
							
							
							
						 
						
							2018-12-14 15:38:35 +09:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	ab2a061b59  
						 
						
							
							
								
								
								refactor: use helpers when using the remote module in sandboxed renderers ( #15960 )  
							
							
							
						 
						
							2018-12-05 10:07:32 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	aa2b2f7c8f  
						 
						
							
							
								
								
								fix: security: don't allow arbitrary methods to be invoked on webContents via IPC ( #15919 )  
							
							
							
						 
						
							2018-12-04 16:12:21 +01:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	8483cb4aa7  
						 
						
							
							
								
								
								security: only handle related IPCs when <webview> tag is enabled ( #15859 )  
							
							... 
							
							
							
							* refactor: move guest-view-manager related IPC handling out of rpc-server
* feat: only handle related IPCs when <webview> tag is enabled 
							
						 
						
							2018-11-30 18:44:38 +09:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Adam Meyer 
								
							 
						 
						
							
							
								
							
							
	d43ef97a7b  
						 
						
							
							
								
								
								add width to webview iframe ( #15195 )  
							
							
							
						 
						
							2018-10-17 09:33:31 +09:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	d3efc52745  
						 
						
							
							
								
								
								feat: add webPreferences.enableRemoteModule option ( #13028 )  
							
							
							
						 
						
							2018-10-13 20:50:07 +03:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	b50f86ef43  
						 
						
							
							
								
								
								refactor: use separate ipc-renderer-internal / ipc-main-internal APIs for Electron internals ( #13940 )  
							
							
							
						 
						
							2018-10-07 00:48:00 +13:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	d48f9bcf7f  
						 
						
							
							
								
								
								refactor: implement <webview> methods via dedicated IPCs without the remote module ( #14377 )  
							
							
							
						 
						
							2018-10-01 10:07:50 +09:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	
	
	176a76217c 
 
						 
						
							
							
								
								
								chore: have 'use strict' consistently across our lib files ( #14721 )  
							
							
							
						 
						
							2018-09-23 00:28:50 +12:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	
	
	54ef906832 
 
						 
						
							
							
								
								
								[RFC] perf: use an internal module resolver to improve require performance ( #14633 )  
							
							... 
							
							
							
							* perf: use an internal module resolver instead of relative requires
* perf: memoize the results of getting exported Electron properties
* perf: make internal module changes consistent across sandboxed / bundled files 
							
						 
						
							2018-09-20 13:43:26 +10:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	
	
	558fff69e7 
 
						 
						
							
							
								
								
								chore: update to standard 12  
							
							
							
						 
						
							2018-09-14 14:57:01 +10:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	38419e3a6a  
						 
						
							
							
								
								
								chore: address TODO for WebContents.prototype.setSize / reportRemovedAttribute removal ( #14517 )  
							
							... 
							
							
							
							* chore: remove WebContents.prototype.setSize
* chore: remove reportRemovedAttribute
* chore: remove unused fixtures 
							
						 
						
							2018-09-11 17:58:57 +10:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	92e094c5f6  
						 
						
							
							
								
								
								fix: manually manage WebContents of webview when it is detached  
							
							
							
						 
						
							2018-09-07 15:47:58 +09:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	
	
	10176c71ff 
 
						 
						
							
							
								
								
								fix: webview.focus() should move page focus to webview ( #14427 )  
							
							
							
						 
						
							2018-09-03 11:41:54 +09:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	0ecea96048  
						 
						
							
							
								
								
								fix: use flexbox to style webview ( #14400 )  
							
							... 
							
							
							
							* fix: use flexbox to style webview
* docs: remove notes on browserplugin based webview 
							
						 
						
							2018-09-01 08:53:13 +12:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	459a2304b4  
						 
						
							
							
								
								
								fix: emit focus/blur events for webview ( #14344 )  
							
							... 
							
							
							
							* fix: emit focus/blur events for webview
* test: webview can emit focus event 
							
						 
						
							2018-08-28 13:35:44 -05:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	
	
	6736d4ef29 
 
						 
						
							
							
								
								
								fix: do not bubble up resize event from webview ( #14271 )  
							
							
							
						 
						
							2018-08-23 15:42:35 +09:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	
	
	cd8bb1d3b4 
 
						 
						
							
							
								
								
								chore: print error when removed webview attribute is used ( #14230 )  
							
							... 
							
							
							
							* chore: print error when removed webview attribute is used
* docs: document removed webview features 
							
						 
						
							2018-08-23 10:45:43 +09:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	dd5b8769be  
						 
						
							
							
								
								
								fix: use OOPIF for webview tag ( #13869 )  
							
							... 
							
							
							
							* fix: use OOIF for webview tag
* fix: do not call GetNativeView for webview
* fix: OOIPF webview's WebContents is managed by embedder frame
* fix: guest view can not be focused
* fix: clear zoom controller when guest is destroyed
* fix: implement the webview resize event
The webview is no longer a browser plugin with the resize event, use
ResizeObserver instead.
* test: disable failed tests due to OOPIF webview
* fix: embedder can be destroyed earlier than guest
This happens when embedder is manually destroyed.
* fix: don't double attach
* fix: recreate iframe when webview is reattached
* fix: resize event may happen very early
* test: some tests are working after OOPIF webview
* chore: remove unused browser plugin webview code
* fix: get embedder via closure
When the "destroyed" event is emitted, the entry in guestInstances would be
cleared.
* chore: rename browserPluginNode to internalElement
* test: make the visibilityState test more robust
* chore: guestinstance can not work with OOPIF webview
* fix: element could be detached before got response from browser 
							
						 
						
							2018-08-16 15:57:40 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	
	
	305e3aad40 
 
						 
						
							
							
								
								
								refactor: remove private webContents.getId() API ( #13674 )  
							
							
							
						 
						
							2018-07-23 18:08:36 +09:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	
	
	9d6f1a372e 
 
						 
						
							
							
								
								
								fix: create WebContents for webview on request ( #13713 )  
							
							
							
						 
						
							2018-07-21 11:11:28 +09:00