* build: test windows runner
* build: try build windows on windows?
* build: take win/cross changes
* build: use bash as default shell always
* build: configure git for windows build tools
* build: bash as default
* build: configure windows correctly
* build: use sha1sum
* build: force windows cipd init and python3 existence
* just pain
* build: restore cache on windows
* build: use build-tools gclient
* build: sync gclient vars to build windows job
* build: output depshash for debugging
* build: past sam was a silly goose
* build: depshash logging
* build: force lf endings for lock and DEPS
* build: platform strings are hard
* build: checkout on windows host
* sup
* no check
* idk
* sigh
* ...
* no double checkout
* build: yolo some stuff
* build: run gn-check for windows on linux hosts for speed
* use container...
* cry ?
* build: e d
* e d
* no log
* fix toolchain on windows cross check
* build: use powershell to add mksnapshot_args
* build: enable x86 and arm64 windows builds too
* clean up
* maybe not needed
* build: keep action around for post step
* build: configure git global on win
* build: ia32 zip manifest
* build: no patch depot_tools for tests
* build: get arm64 windows closer to working
* build: windows tar is ass
* 32 bit on 32 bit
* maybe bash
* build: set up nodejs
* correct windows sharding
* fix some spec runner stuff
* fix windows tests
* overwrite -Force
* sigh
* screen res
* wat
* logs
* ... more logs
* line endings will be the death of me
* remove 1080p force thing
* vsctools + logging
* disable some fullscreen tests on GHA
* no progress
* run all CI
* install visual studio on arm64
* windows hax for non windows
* maybe arm sdk
* clean up depshash logic
* build: use single check per platform
* ensure clean args
* fix loop
* remove debug
* update default build image sha for dispatch
* plzzzz
* one more try
* arm64 vctools
* sad
* build: fix non-dispatch windows gn check
* chore: debug datadog-ci location
* chore: update build-tools for newer toolchain
* chore: set path for datadog-ci
* try this
* chore: fixup gn check
* fixup gn-check some more
* fixup windows gn check
* chore: fixup windows gn check
* test: use cmd for Windows testing
* fixup use cmd for testing on Windows
* fixup windows GN check
* fixup npm config arch for x86
* Can we set test files via powershell
* fixup to set test files via powershell
* fixup set test files via powershell
* Don't check cross instance cache disk space on Windows
* Use separate step to set env variables for testing
* fixup Use separate step to set env variables for testing
* fixup Use separate step to set env variables for testing
* fixup Use separate step to set env variables for testing (AGAIN)
* use powershell if in powershell
* fixup use powershell if in powershell
* chore: remove no longer needed changes to depot_tools
xref: 5669094
and 5844046
* chore: try using 7zip on Windows to extract tarball
* Revert "chore: try using 7zip on Windows to extract tarball"
This reverts commit c7432b6a37857fd0746b8f1776fbd1103dba0b85.
* test: debug failing tests on GHA windows
* fix: ftbfs when including simdjson in Node.js
(cherry picked from commit 48e44c40d61b7aa843a990d4e0c8dec676b4ce8f)
* chore: try to track down Windows testing hang
* use correct timeout
* try this
* see if this helps
* try to figure out why node is running
* shard tests to try to narrow down WOA lockup
* try to narrow down problem test
* Narrow down blocking test more
* do we need a combo to repro
* see if this cleans up the tests
* fixup navigator.usb test
* remove logging from problematic tests
* Revert "shard tests to try to narrow down WOA lockup"
This reverts commit a1806583769678491814cb8b008131c32be4e8fb.
* remove logging
* debug keyboard test
* add timeout for Windows since arm64 sometimes hangs
* see if this helps
* put back original timeout
* try to use screenCapture to get screenshots of what is going on on WOA
* try using electron screencapture to debug WOA hang
* chore: turn off privacy experience
* run screenshot on both shards
* fixup screencap
* try to narrow down hanging spec
* chore: cleanup servers left open
* cleanup tests
* Revert "try to narrow down hanging spec"
This reverts commit a0f959f5382f4012a9919ac535d42c5333eb7d5f.
* cleanup test debugging
* fixup extensions spec
* cleanup unneeded items
* run wtf with 2 shards instead of 6
* Revert "run wtf with 2 shards instead of 6"
This reverts commit ca2d282129ee42c535d80f9876d6fa0dc6c08344.
* debug windows version on woa
* dump more info
* Get detailed CPU info
* revert debugging
* use same args as AppVeyor WOA for GHA WOA
* fixup use same args as AppVeyor WOA for GHA WOA
* fixup use same args as AppVeyor WOA for GHA WOA
* try to track down which tests trigger hang
* one or more of these combinations should hang
* break up web contents spec to find hang
* further break down api-web-contents to find hang
* test: ensure all webContents are closed
* test: fix require is not defined error
* see if api-web-contents spec is now good
* test: ensure all webContents are closed
* Revert "try to track down which tests trigger hang"
This reverts commit 07298d6ffeb4873ef7615a8ec3d1a6696e354ff4.
* chore: use alternate location for windows toolchain
* Reapply "try to track down which tests trigger hang"
This reverts commit 0321f76d01069ef325339b6fe6ed39700eae2b6b.
* try to narrow down problem test
* fix TEST_SHARD env var
* no, really fix TEST_SHARD env var
* see if this fixes it
* test: cleanup any remaining windows and webcontents
* see if new cleanup helps
* dont destroy webcontents for now
* fixup dont destroy webcontents for now
* Only cleanup right before process.exit
* see if this fixes the hang
* actually destroy webcontents
* Revert "Reapply "try to track down which tests trigger hang""
This reverts commit cdee7de049ce6bb5f67bbcc64882c56aa2c73027.
* see if this helps
* Revert "see if this helps"
This reverts commit 9a15a69cf7dbc456db7a61efa5b6870535bae993.
* Is it all about the web contents?
* it is all about the webcontents
but which one?
* Narrow down problem webcontents test
* try to speed up git install on WOA
* disable problematic test on WOA
* remove debugging
* remove debugging from choco installs
* Revert "disable problematic test on WOA"
This reverts commit e060fb0839b73d53cfde1f8acdca634f8e267937.
* Revert "remove debugging"
This reverts commit f18dd8b1a555f56bb06d0ea996a6eff31b424bf1.
* run against all the tests in the failing shard
* don't run visibility tests first
* remove debugging
* 3 is a magic number
* Revert "3 is a magic number"
This reverts commit 36b91ccf9f03a4b34230cd69ceca482f7d8428c1.
* match what Appveyor runs exactly
* Revert "match what Appveyor runs exactly"
This reverts commit 7260dd432216c62696e4bc864930f17c857eabbe.
* chore: sort files alphabetically
* find out what spec is leaving stuff open
* chore: Checkout PR HEAD commit
instead of merge commit
* try using app.exit instead of process.exit
* test: cleanup BrowserWindows and webContents
* Revert "chore: sort files alphabetically"
This reverts commit d9e217ffb1522076e150fce9e43a31bf56716acb.
* chore: use win32 to match process.platform
Needed for build-tools to download from PRs
* chore: cache yarn dir
* fixup cache yarn
* fixup use win32 to match process.platform
* fixup use win32 to match process.platform
* fixup cache yarn
* Add debugging for WOA hang
* Add debugging for failing keyboard lock test
* Revert "Add debugging for WOA hang"
This reverts commit 8df03d568d15a269e4026140d1158e8cdf551dec.
* try using process.kill
* add more debugging to keyboard.lock test
* Revert "Add debugging for failing keyboard lock test"
* remove debugging
* test: disable keyboard.lock on Windows
* test: disable fullscreen tests on Windows
* test: only force test suite exit on WOA
* fixup test: only force test suite exit on WOA
* cleanup tests
* extract yarn caching/install to action
* try using bash to run windows tests
* remove left over debugging
* standardize on 'win' for Windows builds
* use 'x86' for arch for manifest files
* fixup try using bash to run windows tests
* fixup use 'x86' for arch for manifest files
* standardize on 'win' for Windows builds
* fixup use 'x86' for arch for manifest files
* fixup try using bash to run windows tests
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: bump chromium in DEPS to 112.0.5576.0
* 4211172: Use the Mac ImageTransportSurface on iOS.
4211172
* 4191759: Reuse PrintBackend process from query for printing
4191759
* 4189718: Revert "[code health] Remove NotificationService use by SpellcheckService"
4189718
* 4216074: web_contents_delegate: remove content::
4216074
* 4192284: ios: Add feature flag for PartitionAlloc.
4192284
* chore: bump chromium in DEPS to 112.0.5578.0
* 4211172: Use the Mac ImageTransportSurface on iOS.
4211172
* 4067682: Define ThirdPartyCookiesUserBypass runtime feature and plumb it through to URLRequest.cookie_setting_overrides.
4067682
* chore: fixup patch indices
* 4218354: Disable the use of preserve_most on arm64 Windows
4218354
* chore: fixup patch indices
* chore: bump chromium in DEPS to 112.0.5579.0
* chore: update patches
* chore: bump chromium in DEPS to 112.0.5581.0
* chore: update patches
* refactor: use modern base values in tracing
Ref: 4210912
* refactor: remove GetFontLookupTableCacheDir
Ref: 4191820
* refactor: base value type DICTIONARY replaced with DICT
Ref: 4198081
* chore: add stub impls for WCO routing
Refs: 4182690
* refactor: rename latency metrics
Refs: 4048262
* refactor: add sanitized context to clipboard write
Ref: 4178264
* refactor: s/Rect/WindowFeatures
Ref: 4167001
* refacotr: switch mojom::NetworkHintsHandler to use SchemeHostPair instead of URL
Ref: 4185417
* chore: remove dead DecodeToken code
* refactor: refactoring geolocation manager
Ref: 4161603
* chore: iwyu net/cert/cert_verify_result.h
* build: use xcode 14
* chore: bump chromium in DEPS to 112.0.5583.0
* chore: update patches
* chore: fixup mas patches
* refactor: base::span explicit conversion checks
Ref: 4219636
* chore: bump chromium in DEPS to 112.0.5591.0
* chore: bump chromium in DEPS to 112.0.5593.0
* chore: bump chromium in DEPS to 112.0.5594.3
* chore: bump chromium in DEPS to 112.0.5597.0
* chore: update chromium patches
* 4242507: Move most of GetChromeKeySystems() into components/cdm
Ref: 4242507
It seems as though the bug this patch was trying to resolve is now fixed.
* chore: update v8 patches
* 4240798: Get rid of ShowInvalidPrinterSettingsError() in PrintManagerHost.
Ref: 4240798
* 4247938: Bump min required GTK version to 3.20
Ref: 4247938
* 4173660: Remove unused argument in BeforeUnloadCompleted
Ref: 4173660
* 4226656: Add response url to SimpleURLLoader::OnRedirectCallback
Ref: 4226656
* fixup!: 4240798: Get rid of ShowInvalidPrinterSettingsError() in PrintManager Host.
Ref: 4240798
* chore: bump chromium in DEPS to 112.0.5599.0
* chore: update patches
* 4251237: [StorageKey Cleanup] (2) Rename CreateFirstParty constructors
Ref: 4251237
* 4256866: [Extensions] Replace GetHooksForAPI with a RegisterHooksDelegate
Ref: 4256866
* chore: bump chromium in DEPS to 112.0.5601.0
* chore: update patches
* chore: bump chromium in DEPS to 112.0.5603.0
* chore: bump chromium in DEPS to 112.0.5605.0
* chore: bump chromium in DEPS to 112.0.5607.0
* update patches
* fix mas patch
* chore: bump chromium in DEPS to 112.0.5609.0
* chore: update patches
* build: update appveyor image
4072083: New toolchain for Windows 11 10.0.22621.755 SDK | 4072083
* chore: bump chromium in DEPS to 112.0.5611.0
* fix patches
* chore: update patches
* 4261434: Remove browser_watcher (1/3): Move ExitCodeWatcher to chrome/app
4261434
* 4258446: Move network::mojom::ClearDataFilter to its own mojom file
4258446
* 4128591: Enable large pdbs by default
4128591
* move dbgcore/dbghelp to extensions_to_skip
* chore: bump chromium in DEPS to 113.0.5624.0
* chore: bump chromium in DEPS to 113.0.5626.0
* chore: bump chromium in DEPS to 113.0.5628.2
* chore: bump chromium in DEPS to 113.0.5630.0
* chore: bump chromium in DEPS to 113.0.5632.0
* chore: bump chromium in DEPS to 113.0.5634.0
* chore: bump chromium in DEPS to 113.0.5636.0
* 4255184: Permit popups from fullscreen-within-tab openers
4255184
* 4297715: [mac] Introduce BluetoothLowEnergyAdapterApple to reuse CoreBluetooth
4297715
* 4301154: Remove GLContextCGL and cleanup relevant code
4301154
* 4278389: CDP: fix Page.addScriptToEvaluateOnNewDocument in iframes
4278389
* 4240798: Get rid of ShowInvalidPrinterSettingsError() in PrintManagerHost.
4240798
* 4291989: Refactor logic determining untrusted mojo invitation flag.
4291989
* 4110189: Add Select option to content touch selection menu.
4110189
* 4309923: [Extensions] Add a unit test for API permissions having features
4309923
* 4282657: Revert "[headless] Route stdio to parent console on Windows."
4282657
* 4306685: [v8] Improve V8 flag configuration to avoid errors
4306685
* 4295455: Add fallback Linux UI for when GTK 3.20 isn't available
4295455
* 4289774: Remove feature for shared sandbox policies
4289774
* 4292705: Rename WebSwapCGLLayer to ANGLESwapCGLLayer outside WebKit.
4292705
* chore: fixup patch indices
* fixup! 4297715: [mac] Introduce BluetoothLowEnergyAdapterApple to reuse CoreBluetooth
* 4289789: Remove base::JSONReader::ReadDeprecated
4289789
* 4281521: Remove `base::Value::FindKey()`
4281521
* 4276761: Update NAK constructor and GetIsCrossSite
4276761
* 4288119: Let GetUpload work with UploadInfo pointers
4288119
* 4285322: content: Move WebExposedIsolationLevel to its own public header
4285322
* 4251818: [Extensions] Make ExtensionSet moveable.
4251818
* 4299554: [json-schema-compiler] Refactor to Params::Create (14/74)
4299554
* chore: update printing patch indices
* chore: update chromium/add_maximized_parameter_to_linuxui_getwindowframeprovider.patch
Xref: 4295455
Our patch changes the signature of `LinuxUiTheme::GetWindowFrameProvider()`.
Upstream 4295455 added a new subclass (FallbackLinuxUi) so sync its version
of GetWindowFrameProvider() to match our changes.
* chore: disable node test parallel/test-intl
Disabling the test because upstream is still working on this feature.
Xref: 4237675
Xref: https://bugs.chromium.org/p/chromium/issues/detail?id=1414292
When upstream churn is done we should re-enable this test and update
it as necessary.
* win7dep: Remove ResolveCoreWinRTStringDelayload
Xref: 4277708
Upstream has removed this since Win7 support is deprecated.
This updates our `language_util_win.cc` file using the same
approach that 4277708 uses for `base/win/win_util.cc`.
* fix: remove use of ResolveCoreWinRTDelayload()
Xref: 4297979
A followup to prev commit, which removed ResolveCoreWinRTStringDelayload().
This PR follows the 4297979 approach of simply removing the calls, e.g.
4297979/4/chrome/browser/device_reauth/win/authenticator_win.cc
* fix: add d3dcompiler_47 to the zip manifest
Xref: 4285717
Xref (24-x-y): 0fb1def32b
* This clang roll breaks Linux arm 32-bit
Xref (24-x-y): 1229114494
Xref (chromium): https://crbug.com/1410101
* fix: WebUSB on ARM64 macs (#37441)
* chore: update patches
* chore: fix macOS CI build.
Xref: 4278307
That whole dir was previously being removed to save space since we don't
use it. We still don't use anything in the file, but gn needs it to exist.
* fixup! chore: fix macOS CI build.
chore: mkdir --parents does not exist on BSD; use mkdir -p
* chore: update chromium/mas_disable_remote_accessibility.patch
Xref: 4273450
Upstream added a new block of code using NSAccessibilityRemoteUIElement,
so stub it out with `#if !IS_MAS_BUILD()` same as we do everwhere else.
* chore: address code review nit :)
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* test: re-enable nan test: typedarrays-test.js
Fixes#28414.
I've confirmed this fix wfm on Linux. Pushing into a PR to get CI to run
it out on Win and Mac platforms too.
* chore: clarify comment
* test: fix NAN test string alignment
* test: (wip) add ldflags, archive file for libc++
* test: (wip) add libc++ to CircleCI
* test: (wip) add llvm flags
* test: (wip) change ldflag syntax
* test: (wip) build libc++abi as static
* fix: correct ldflags
* test: add ld env
* fix: do not commit this
* test: add lld from src to circleci
* test: add lld link to ld
* chore: preserve third_party
* seems legit
* sam swears this works kinda sort of sometimes'
:
* build: add gn visibility patch
* chore: update patches
* build: check for flatten_relative_to = false
* build: upload zip files, add to release.js validation
* debug: what the hell gn
* build: add libcxx gni to lint ignore
Linting the file adjusted the licenses array, which only contains
one value, and causes the gn check to fail later
* build: also use nan-spec-runner flags on Windows
* build: add linked flags for win32 only
* build: build libc++ as source on win
* build: clean up patch, add -fPIC for IA32
* build: delete libcxx .a files from root
* build: rename libc++.zip, clean up upload per platform
* build: fix gni lint
* ci: add libcxx gen to circleci config
* build: correct libcxx-object syntax
Co-authored-by: Samuel Attard <sam@electronjs.org>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: clavin <clavin@electronjs.org>
Co-authored-by: Samuel Attard <sattard@slack-corp.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <sam@electronjs.org>
* chore: bump chromium in DEPS to d5c9bf9e2a18fa508201a88e5803bec1d107b1ae
* chore: bump chromium in DEPS to 45f1316afae33e52c92480b34bf4f7fe4a7db898
* update patches
* WillCreateURLLoaderFactory now gets a ukm_source_id
Refs: 2346803
* ink_drop_visible_opacity -> GetInkDropVisibleOpacity
Refs: 2415368
* chore: bump chromium in DEPS to ddb5b6db5e35ab1a7b5adbd9f15373af6c35ea2a
* 2418471: PDF Viewer update: Add missing aria-labels to various buttons.
2418471
* update printing.patch given print settings mojoification
Refs: 2409467
* update patches
* content::BluetoothChooser::Event -> content::BluetoothChooserEvent
Refs: 2387901
* set_ink_drop_base_color -> SetInkDropBaseColor
Refs: 2419388
* chore: bump chromium in DEPS to ecf7c9ee830d4d85f300b461a2fa13aa40c79a4c
* update patches
* gfx::ConvertPointToPixel -> gfx::ConvertPointToPixels
Refs: 2418568
* remove ContentSettingsObserver::AllowStorage()
Refs: 2401847
* service_manager::kCrashDumpSignal -> kCrashDumpSignal
Refs: 2417073
* chore: bump chromium in DEPS to abdb7ebe5f8c8328b8f435283df90d0a3ecff7bd
* chore: bump chromium in DEPS to 2a7e138ab1066534ceb2622e8a9d2c8ebf574215
* chore: bump chromium in DEPS to ab1884e75ced904e4276851eb4e1ad89919ca93b
* chore: bump chromium in DEPS to a12413902380dcc2a73ac74d582328280a8af686
* Fixup printing patch
2428623
* Fixup OSR patch
2415128
* Make ExtensionURLLoaderFactory always owned by its |receivers_|.
2357523
* Add deprecated_default_sources_assignment_filter variable
2416496
* Fixup patch indices
* Remove several references to BrowserPlugin from content
2401031
* Remove SurfaceEmbeddingTime and LocalSurfaceIdAllocation
2415128
* Add DragOperation and AllowedDragOperations Mojo types
2196167
* chore: bump chromium in DEPS to 378450342cf6aa160663d0ce3a178a11b570c25a
* Fixup patch indices
* Remove SurfaceEmbeddingTime and LocalSurfaceIdAllocation
2415128
* Add DragOperation and AllowedDragOperations Mojo types
2196167
* 2426564: Remove global sources assignment filter value
2426564
* Fixup blink_local_frame.patch
* [XProto] Remove a subset of ui/gfx/x/x11.h
2430328
* Fixup patch indices
* Remove several references to BrowserPlugin from content
2401031
* Remove lossy ConvertSizeToPixel() methods
2419534
* serial: Use USB driver name to disambiguate ports
2413176
* Remove set_sources_filter import
* Fix ModMask usage
* [XProto] Remove usage of all Xlib headers
2392140
* [XProto] Remove usage of Xlib Visuals
2429933
* Skip Angle manifest file
2425197
* Add whole src\third_party\angle\.git directory
This directory is needed in order to properly generate gen/angle/angle_commit.h
* [libvpx] Fix HighBD config on Windows ARM64
2437745
* update patches
* fix: correct calling convention for Windows on Arm
2440717
* Add third_party/angle/.git to the archive before adding the rest of the source
* fixup source caching on Windows
* Fixup erroneous close paren
* fixup for goma issues
* This should work
* chore: bump chromium roll manually
2435142
This landed the day after we paused roller-bot and may resolve the
visibility test flakes that we're seeing. h/t to @jkleinsc for
finding this with me.
* chore: remove obsoleted cherry-pick fix for libvpx
2437745
* chore: remove obsoleted cherry-pick libvpx patch
2437745
* chore: re-export patches
* chore: add tracer comment to visibility-stat-spec.
The line numbers between the source and the CI runs don't seem to match
up, so this temp tracer is to help track the source of that difference.
* chore: bump chromium in DEPS to 7c2b8cc3b8638aee8abeb013042a6c1d15b2da6b
* update patches
* impl SortingLSH service
Refs: 2425327
* 2446525: [Flash] Remove some Flash APIs
2446525
* 2440974: Reland "Delete service_manager/embedder/switches.h"
2440974
* 2359402: Remove ContentBrowserClient::NonNetworkURLLoaderFactoryDeprecatedMap.
2359402
* 2250506: Implement tabs.removeCSS
2250506
* 2429143: Remove implicit-conversion-to-integer ConvertRectToPixel() methods.
2429143
* 2444430: Remove DataElementType::kBlob
2444430
* 2441964: Clean up WebView public API
2441964
* 2357523: Make ExtensionURLLoaderFactory always owned by its |receivers_|.
2357523
* 2461606: Use blink::mojom::PreferredColorScheme instead of blink::PreferredColorScheme
2461606
* 2461235: a11y inspect reorg: move PropertyFilter struct to a new location
2461235
* remove flash support
* fix frame_host_manager patch
* fix lint
* remove flash info from docs
* fix build
* fix osr
* chore: bump chromium in DEPS to 9269f9eb1d98d29564c2b2ab97f30c6e148c4e11
* fix visibilityState tests
* 2463049: Replace all uses of web_pref::AutoplayPolicy with mojom::AutoplayPolicy
2463049
* update patches
* fix tests harder
* 2414921: Add Group and Ungroup functions to Tabs extension API
2414921
* more test fix
* Remove all keyboard related usage of Xlib
Refs: 2436787
* fix linux build
* 2453807: [XProto] Remove usage of Xlib error handling
2453807
* lint
* fixup! 2453807: [XProto] Remove usage of Xlib error handling
* disable CalculateNativeWinOcclusion on win ci
* remove UploadBlob from docs
* Update appveyor.yml
Co-authored-by: Andy Locascio <andy@slack-corp.com>
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
Co-authored-by: Electron Bot <anonymous@electronjs.org>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
* chore: bump chromium in DEPS to 0ee01724797ab0f6deadb33bb3a0201cd2d21602
* Update patches
* Separate pdf/pdf_ppapi.h into its own target.
2292458
* [ozone/x11] Removed DesktopWindowTreeHostX11 and its DnD client.
2279199
* Move front_end html_entrypoints to data_deps
2292282
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
* chore: bump chromium in DEPS to 68d7ef9b31f3f164a967109212e84a8d756cc80f
* Update patches
* Update location of file_info.h
* Update sysroots
* chore: bump chromium in DEPS to 47114394b1c8a35438d19da7538142380551a2ce
* Update patches
* ci: update docker image to pickup new ia32 dep
* Skip .info files in dist.zip
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
* chore: add code required to use chromes spellchecker
* chore: fix linting
* chore: manifests needs buildflags now
* chore: add dictionarySuggestions to the context menu event when the spellchecker is active
* chore: enable by default for windows builds
* chore: add patch to remove incognito usage in the spellchecker
* chore: add dependencies on spellcheck common and flags
* chore: conditionally include spell check panel impl
* chore: fix deps for spellcheck feature flags
* chore: add patch for electron resources
* chore: add dependency on //components/language/core/browser
* chore: patches to make hunspell work on windows
* build: collect hunspell dictionaries into a zip file and publish
* chore: clean up patches
* chore: add docs and set spell checker url method
* chore: fix error handling
* chore: fix hash logic
* build: update hunspell filename generator
* fix: default spellchecker list to the current system locale if we can
* docs: document the language getter
* chore: patch IDS_ resources for linux builds
* feat: add spellcheck webpref flag to disable the builtin spellchecker
* chore: fix docs typo
* chore: clean up spellchecker impl as per feedback
* remove unneeded deps
Legacy print statements are syntax errors in Python 3 but print() function works as expected in both Python 2 and Python 3.
Old style exceptions are syntax errors in Python 3 but new style exceptions work as expected in both Python 2 and Python 3.
* build: fix native_mksnapshot build
When we changed our electron_mksnapshot_zip target to include the v8_context_snapshot_generator, this dependency made the `run_mksnapshot` target run which was trying to run an arm/arm64 binary on x64 hardware.
Don't use custom build args for native_mksnapshot as they are not needed
* Added comment on why snapshot_blob.bin is skipped on arm/arm64
* chore: remove duplicate and un-needed files from dist zips
* Strip chromedriver binaries
Also, fix path for files to skip
* Don't strip mksnapshot for now
Mksnapshot needs special handling for arm/arm64 because there is both an x86 and arm/arm64 binary in those cases.
Make sure certain paths/files don't make it into the dist zip
Don't build the content shell test_runner
Make sure libffmpeg.dylib gets put in the right place
Run verify-ffmpeg on Mac builds
Add ffmpeg build to VSTS
* build: [gn] add distributable zip target
* build: update the CircleCI config
- enable debug and testing builds on Mac
- run Mac release builds nightly
- run test for Mac release builds
- use shared build machines configs
* Add resources dir to zip on non mac platforms.