Cheng Zhao
aaa8e81cd4
Merge pull request #8811 from electron/clean-node-on-exit
...
Clean up node Environment on exit
2017-03-06 20:36:59 +09:00
deepak1556
e936143da2
listen for browser initiated pending nav entries too
2017-03-06 00:21:52 +05:30
deepak1556
dead1ae1ba
webContents: defer url load when there is a pending navigation entry
2017-03-06 00:10:46 +05:30
Kevin Sawicki
4d6c779839
identList -> identifiers
2017-03-03 15:28:32 -08:00
Kevin Sawicki
b879872317
Always set properties in update calls
2017-03-03 15:24:32 -08:00
Kevin Sawicki
2680ee9f8f
Add support for setting TouchBarLabel text color
2017-03-03 15:14:51 -08:00
Kevin Sawicki
9f323104e7
Remove unused include
2017-03-03 14:11:09 -08:00
Kevin Sawicki
edebb32014
Drop nullable for consistency
2017-03-03 14:07:59 -08:00
Kevin Sawicki
ca2898a60e
Check that window responds to touchBar selector for pre-10.12.1 compat
2017-03-03 14:00:39 -08:00
Kevin Sawicki
002369576f
Add initial touch bar docs
2017-03-03 14:00:39 -08:00
Kevin Sawicki
ce12dcd3b4
Add live popover icon property
2017-03-03 14:00:39 -08:00
Kevin Sawicki
a34f9d3583
Support icon property to match MenuItem
2017-03-03 14:00:39 -08:00
Kevin Sawicki
506b42b563
🎨
2017-03-03 14:00:39 -08:00
Kevin Sawicki
ecc0478e3c
Match Popover casing in macOS APIs
2017-03-03 14:00:39 -08:00
Kevin Sawicki
d1edd80ef8
Use NSTouchBar itemForIdentifier to lookup existing item
2017-03-03 14:00:39 -08:00
Kevin Sawicki
93bbe8e70b
Use device NS colors consistently
2017-03-03 14:00:39 -08:00
Kevin Sawicki
70d61869a5
Use array to create empty NSMutableArray
2017-03-03 14:00:39 -08:00
Kevin Sawicki
5fe3ac60fa
Check that atom_touch_bar_ is set
2017-03-03 14:00:39 -08:00
Kevin Sawicki
708ed9d1cd
Store ordered settings in AtomTouchBar
2017-03-03 14:00:39 -08:00
Kevin Sawicki
5f9e9d4b36
Add move live updating properties
2017-03-03 14:00:39 -08:00
Kevin Sawicki
61aa9bbff4
Add support for spacer items
2017-03-03 14:00:39 -08:00
Kevin Sawicki
f153d08297
Support setting the initial/available colors
2017-03-03 14:00:39 -08:00
Kevin Sawicki
51f1c5a557
Use SetTouchBar withe empty vector instead of DestroyTouchBar
2017-03-03 14:00:39 -08:00
Kevin Sawicki
347d472841
Remove unused clear method
2017-03-03 14:00:39 -08:00
Kevin Sawicki
b959f782f6
Rename instance variable maps
2017-03-03 14:00:39 -08:00
Kevin Sawicki
ec500b2852
Use scoped_nsobject to match Chrome implementation
2017-03-03 14:00:38 -08:00
Kevin Sawicki
812beb240b
Remove unneeded includes
2017-03-03 14:00:38 -08:00
Kevin Sawicki
823b3baed0
Use vector of dictionaries instead of mate::Arguments
2017-03-03 14:00:38 -08:00
Kevin Sawicki
98f5858b11
Initial support for dynamic properties
2017-03-03 14:00:38 -08:00
Kevin Sawicki
cbb6f8c33e
Store event listeners in each TouchBar class
2017-03-03 14:00:38 -08:00
Kevin Sawicki
1972e2eff9
Update renamed variable
2017-03-03 14:00:38 -08:00
Kevin Sawicki
28f2a4951b
touch_bar_helper_ -> atom_touch_bar_
2017-03-03 14:00:38 -08:00
Kevin Sawicki
b39b49a15a
Rename to touch_bar_helper_ to differentiate from touchBar property
2017-03-03 14:00:38 -08:00
Kevin Sawicki
14ef5c5957
Reset helper when makeTouchBar is called
2017-03-03 14:00:38 -08:00
Kevin Sawicki
ca29ec0101
Use reference
2017-03-03 14:00:38 -08:00
Kevin Sawicki
f297ba987e
touchBarFromMutatableArray -> touchBarFromItemIdentifiers
2017-03-03 14:00:38 -08:00
Kevin Sawicki
b30f7c3c94
Use std::string ctor
2017-03-03 14:00:38 -08:00
Kevin Sawicki
8500538793
Use base::SysUTF8ToNSString helper
2017-03-03 14:00:38 -08:00
Kevin Sawicki
cf7cd1f32b
hasTBDict -> hasItemWithID
2017-03-03 14:00:38 -08:00
Kevin Sawicki
48515d9ecc
Ignore objective-c header lint
2017-03-03 14:00:38 -08:00
Kevin Sawicki
b632cdd37d
Extract helper class to encapsulate touch bar items
2017-03-03 14:00:38 -08:00
Kevin Sawicki
1b5149ae7a
Few memory and scope tweaks
2017-03-03 14:00:38 -08:00
Kevin Sawicki
b16d649819
Use skia color helpers
2017-03-03 14:00:38 -08:00
Kevin Sawicki
69638a399c
Make touchBar readwrite/nullable
2017-03-03 14:00:38 -08:00
Kevin Sawicki
52905ae9b3
Get compiling against 10.10 SDK
2017-03-03 14:00:38 -08:00
Kevin Sawicki
2a00bb30c5
Use new NativeWindowObserver helper
2017-03-03 14:00:38 -08:00
Samuel Attard
ba3fbc9d1b
Fix Group items
2017-03-03 14:00:38 -08:00
Samuel Attard
28d5c8bbde
Add updateConfig ability to other items
2017-03-03 14:00:38 -08:00
Samuel Attard
dd09c91cf2
initial work on updating touch bar item config without rerender
2017-03-03 14:00:38 -08:00
Samuel Attard
d1b3ba39bd
Fix cpp linting
2017-03-03 14:00:38 -08:00
Samuel Attard
257b32b84b
Remove unused ident
2017-03-03 14:00:38 -08:00
Samuel Attard
43cc5079d8
Implement group item
2017-03-03 14:00:38 -08:00
Samuel Attard
269d899a99
Implement popOver item type (woo hoo it worked)
2017-03-03 14:00:38 -08:00
Samuel Attard
c92c4138a8
Add Slider item type and add options to the button type
2017-03-03 14:00:38 -08:00
Samuel Attard
18c7c3ece8
Make label and colorpicker types work
2017-03-03 14:00:38 -08:00
Samuel Attard
7857c83ea1
Make dynamic buttons work along with click events
2017-03-03 14:00:38 -08:00
Samuel Attard
703b5738c8
Initial TouchBar Magic
...
* Make the AtomNSWindow also a NSTouchbarDelegate
* Implement basic makeTouchBar and makeItemForIdentifier methods
* Initial sending of touch / update events through IPC to BrowserWindowObjects
TODO:
* JS API
* JS Object Converters
* Generalize methods so that popovers can work
2017-03-03 14:00:38 -08:00
Nitish Sakhawalkar
bcda67b8eb
No more extra whitespace.
2017-03-02 10:50:48 -08:00
Kevin Sawicki
7fb77ee1cb
Set isolated world security origin
2017-03-02 08:49:18 -08:00
Cheng Zhao
cf198904a4
Fix cpplint warnings
2017-03-02 17:26:15 +09:00
Cheng Zhao
1709e74958
Fix crash when the main frame is replaced
2017-03-02 17:19:00 +09:00
Cheng Zhao
24574f7299
Avoid touch an Environemnt after it gets destroyed
2017-03-02 17:19:00 +09:00
Cheng Zhao
29278e500b
Destroy node environment when a JS context in renderer is destroyed
2017-03-02 17:19:00 +09:00
Cheng Zhao
d379b05890
async handles should be closed on exit
2017-03-02 17:19:00 +09:00
Cheng Zhao
a0605275b9
Clean up node environment on exit in main process
2017-03-02 17:19:00 +09:00
Nitish Sakhawalkar
c06c4c0ccb
Reverting formatting changes made by clang format.
2017-03-01 14:04:41 -08:00
Kevin Sawicki
d009b3267a
Bump v1.6.2
2017-03-01 09:11:05 -08:00
Nitish Sakhawalkar
879082b1a6
Issue #8735:Support base URL option to loadURL for data URLs
2017-02-28 16:49:03 -08:00
Kevin Sawicki
be16e75be2
Support explicit cancelId on macOS
2017-02-24 09:05:55 -08:00
Kevin Sawicki
ef085a1f15
Remove unneeded AddRef/Release calls handled by base::Bind
2017-02-24 08:15:02 -08:00
Kevin Sawicki
6837ec8576
Check render frame host before getting context
2017-02-24 07:49:26 -08:00
Kevin Sawicki
a62c2f9e2e
Remove unused include
2017-02-24 07:37:28 -08:00
Kevin Sawicki
29f92bfb53
Extend RefCounted and add private destructor
2017-02-24 07:37:28 -08:00
Kevin Sawicki
a33ffd621f
Use callback dialog methods in RunFileChooser
2017-02-24 07:37:28 -08:00
liusi
ff513f2a84
remove the call to download_item_->Remove() on cancel
2017-02-24 14:08:21 +08:00
Kevin Sawicki
211bedf910
Invoke close callback after itemSelected runs
2017-02-22 11:47:58 -08:00
Kevin Sawicki
a8d1a7aed4
Make variables private instead of protected
2017-02-22 10:30:28 -08:00
Kevin Sawicki
2006e22aa4
🎨
2017-02-22 10:30:28 -08:00
Kevin Sawicki
ce5ac1b056
Implement ClosePopupAt on Windows/Linux
2017-02-22 10:30:28 -08:00
Kevin Sawicki
91d1af053f
Implement Menu.closePopup on Windows/Linux
2017-02-22 10:30:28 -08:00
Kevin Sawicki
6a023dc4fe
Add Menu.closePopup API on macOS
2017-02-22 10:30:28 -08:00
Kevin Sawicki
66b6b4f1cb
Map async option to MenuRunner::ASYNC flag
2017-02-22 10:30:28 -08:00
Kevin Sawicki
4430927f98
Add async option to menu.popup
2017-02-22 10:30:28 -08:00
Kevin Sawicki
b091d104f5
Add async menu.popup on Windows/Linux
2017-02-22 10:30:28 -08:00
Kevin Sawicki
636ef0fd29
Add async menu.popup on macOS
2017-02-22 10:30:28 -08:00
Kevin Sawicki
92092bed41
Bump v1.6.1
2017-02-21 08:49:50 -08:00
gellert
a1ede4a4b0
fixes os version check of vibrancy
2017-02-18 20:25:03 +01:00
deepak1556
0c022fdc36
set zoom changes for in page navigaitons
2017-02-18 01:34:32 +05:30
deepak1556
203a920c64
fix signature of zoom getter apis
2017-02-18 01:34:32 +05:30
deepak1556
5687f8b3b7
Destroy icon manager after file thread is destroyed
2017-02-17 14:16:18 +05:30
Yury Solovyov
977abc6458
Update icon loading API implementation
2017-02-16 23:16:34 +03:00
Kevin Sawicki
70849de8c4
Mark constructor as explicit
2017-02-15 08:28:55 -08:00
Kevin Sawicki
52801c4a41
Use internal IsVisible method
2017-02-15 08:28:55 -08:00
Kevin Sawicki
db79f4f450
Implement Activate instead of CanFocus
2017-02-15 08:28:55 -08:00
Kevin Sawicki
bda8af8dd3
Just use visible state in CanFocus delegate
2017-02-15 08:28:55 -08:00
Kevin Sawicki
be79417a03
Include CanFocus on Windows and map to state
2017-02-15 08:28:55 -08:00
Cheng Zhao
c127ce3e46
Merge pull request #8679 from electron/disable-active-tracker
...
Disable the ActiveVerifier
2017-02-15 11:04:36 +09:00
Kevin Sawicki
36e6501c44
Rename variable for compiler error
2017-02-14 12:30:23 -08:00
Kevin Sawicki
9be42db8d5
Merge pull request #8628 from Spacetech/master
...
Implement invalidate for non-offscreen mode
2017-02-14 11:41:16 -08:00
Kevin Sawicki
643cb5d6de
Remove unused variable
2017-02-14 11:13:23 -08:00
Kevin Sawicki
5cb6648686
Use underscore variable name for consistency
2017-02-14 11:12:30 -08:00
Kevin Sawicki
82f452568c
🎨 Minor formatting tweaks
2017-02-14 11:09:15 -08:00
Kevin Sawicki
3b7207da9f
Support removing extra parameters
2017-02-14 09:37:09 -08:00
Kevin Sawicki
9a434af03e
Clear crash keys in InitBreakpad
2017-02-14 09:37:09 -08:00
Kevin Sawicki
ba975d552a
Add setExtraParameter support on macOS
2017-02-14 09:37:09 -08:00
Kevin Sawicki
3e18d8baf5
Remove _ prefix on binding methods
2017-02-14 09:37:09 -08:00
Kevin Sawicki
c54ae66fb9
Call OnWindowScrollTouchEnd instead of Edge
2017-02-14 09:13:07 -08:00
Cheng Zhao
bad6954911
Disable the ActiveVerifier
2017-02-14 17:23:20 +09:00
liusi
d56c1909df
only emit download-item done
event once.
2017-02-14 14:39:33 +08:00
Gary Wilber
f19924bcb0
Add Invalidate method to NativeWindow and add Mac implementation
2017-02-13 19:41:24 -08:00
Kevin Sawicki
d7ab142e10
Call content::WebContentsObserver first
2017-02-13 09:09:42 -08:00
Kevin Sawicki
a746651d1c
Use dialog setter for consistency with other properties
2017-02-13 08:23:53 -08:00
Samuel Attard
e45d8079b8
Add support for a noResolveAliases property
2017-02-13 08:23:53 -08:00
deepak1556
7a0aff2bae
code cleanup
2017-02-12 01:48:24 +05:30
deepak1556
cbeaa6be87
simply handling temporary zoom levels of webview
2017-02-12 00:49:17 +05:30
deepak1556
e3fe3cc490
map webframe zoom api to use HostZoomMap
2017-02-12 00:49:17 +05:30
deepak1556
63c0e4cbb1
Add ZoomController to manager zoom changes for webcontents
2017-02-12 00:49:17 +05:30
deepak1556
07794a58aa
use zoom factor webpreference option when required.
...
* When setzoomlevel is not called for the host.
* When there is no zoom preference for the host.
2017-02-12 00:49:17 +05:30
deepak1556
b27c94368d
webContents: set zoom levels with HostZoomMap
2017-02-12 00:49:17 +05:30
Kevin Sawicki
f7f4de36af
Merge remote-tracking branch 'origin/master' into macos-open-save-panel
2017-02-09 11:25:05 -08:00
Kevin Sawicki
867bb5a94e
Add DialogSettings helper struct
2017-02-09 10:13:11 -08:00
Kevin Sawicki
7994acf0ea
Use CHROMEGTK_CALLBACK_0 and ignore gpointer data
2017-02-09 09:49:09 -08:00
Birunthan Mohanathas
c8c11e68c6
Add support for checkbox with dialog.showMessageBox
...
This adds the `checkboxLabel` and `checkboxChecked` options to display a
checkbox in the message box. Fixes #6048 .
2017-02-09 09:03:54 -08:00
Tan Wang Leng
347dc835b5
Fix code formatting
2017-02-09 21:51:11 +08:00
Tan Wang Leng
a4a71a1dc9
Change qualifier of ShowSaveDialog() parameter
...
The normal convention in the codebase is to not use references
or 'const' for primitives like 'bool' and 'int'.
2017-02-09 21:50:55 +08:00
Tan Wang Leng
b0487b7d84
Fix wrong signature for gtk's ShowSaveDialog()
2017-02-09 20:10:57 +08:00
Tan Wang Leng
1bf8270c0d
🏁 Fix dialog method calls for Windows
2017-02-09 20:10:57 +08:00
Tan Wang Leng
36209ddd90
🍎 Add additional options for Mac's open dialog
...
Support an additional attributes available in macOS's NSOpenPanel:
message.
2017-02-09 20:10:57 +08:00
Tan Wang Leng
1d612a12a1
🍎 Add additional options for Mac's save dialog
...
Support additional attributes available in macOS's NSSavePanel: message,
nameFieldLabel and showsTagField
2017-02-09 20:10:57 +08:00
Kevin Sawicki
1e581d6814
Use unique_ptr for passing VerifyRequestParams
2017-02-08 11:59:43 -08:00
Kevin Sawicki
70178adb6e
Use object for verification request
2017-02-08 11:59:43 -08:00
Kevin Sawicki
37db804099
Use NetLogWithSource since BoundNetLog no longer exists
2017-02-08 11:59:43 -08:00
Greg Nolle
e29b64a18a
modify CertVerifier Class
...
* respond to multiple similar verification requests.
* accept net error result as callback response.
2017-02-08 11:59:43 -08:00
Gary Wilber
11e1f6b56c
Fix lint errors
2017-02-08 00:05:16 -08:00
Gary Wilber
ed44b32ff5
Convert indentation to spaces
2017-02-07 23:08:03 -08:00
Gary Wilber
148898fb75
Implement invalidate for non-offscreen mode
2017-02-07 23:03:42 -08:00
Cheng Zhao
5cd18fe32a
Merge pull request #8619 from electron/mac-os-version-checks
...
Use IsAtLeastOS10_* version checks
2017-02-08 13:58:26 +09:00
Cheng Zhao
0643d98d99
Merge pull request #8616 from electron/renew-symbol-trick
...
Simplify the trick used for referencing symbols
2017-02-08 07:56:28 +09:00
Yury Solovyov
bcf0964c61
Fix more review
2017-02-07 09:55:18 -08:00
Yury Solovyov
29452364f3
Use isolate() method to get isolate
2017-02-07 09:54:22 -08:00
Yury Solovyov
c2bf5bb986
Put locker and handle scope to the top of the function. Remove unneeded header
2017-02-07 09:53:34 -08:00
Yury Solovyov
5794138ed4
Normalize path
2017-02-07 09:53:34 -08:00
Yury
1b4ee6e0d8
Image from icon node-style callback ( #2 )
...
* Try implementing node-style callbacks
* Add locker and handle scope
2017-02-07 09:53:34 -08:00
deepak1556
2e85ff1f57
Fix code style
2017-02-07 09:53:34 -08:00
Yury Solovyov
3d47c9b71d
Fix lint
2017-02-07 09:53:34 -08:00
Yury Solovyov
05cb26a174
Use object for options
2017-02-07 09:53:34 -08:00
Yury Solovyov
bec671bac8
Make size optional
2017-02-07 09:52:11 -08:00
Robo
b25b141642
create iconmanager as singleton class and cleanup code ( #1 )
...
* create iconmanager as singleton class and cleanup code
2017-02-07 09:52:11 -08:00
Yury Solovyov
1b3cd87fc9
Add icon manager to browser process
2017-02-07 09:50:17 -08:00
Yury Solovyov
602aba8723
Include proper header
2017-02-07 09:48:12 -08:00