Shelley Vohr
135454342d
remove .only from spec
2017-10-24 22:41:28 -04:00
Shelley Vohr
f7bc5481f3
add a few more tests to api_menu_spec
2017-10-24 22:40:31 -04:00
Shelley Vohr
d54148de4e
remove from spec
2017-10-24 20:31:02 -04:00
Shelley Vohr
0e6100ae17
upgrade menu spec to ES6
2017-10-24 20:27:26 -04:00
Ahmed Mohamed Ali
1e9942c1bf
Fix js coding style errors
2017-10-20 08:46:41 +02:00
Ahmed Mohamed Ali
44f91e12e1
Add tests for fix described in #10793
2017-10-19 16:15:02 +02:00
Boik
f40cc5ab54
add error code to session.setCertificateVerifyProc
2017-10-16 17:17:21 +08:00
Birunthan Mohanathas
13b9b5c0c0
Merge pull request #10746 from electron/removeuserdefault
...
Add systemPreferences.removeUserDefault()
2017-10-12 16:08:57 +03:00
Birunthan Mohanathas
06d782279c
Add systemPreferences.removeUserDefault()
...
This can be used to restore the default or global value of a `key`
previously set with `setUserDefault`.
2017-10-10 22:57:47 +03:00
Samuel Attard
ed25941c65
Add basic specs
2017-10-10 17:30:27 +11:00
Yuya Ochiai
6326c6727e
Add did-attach-webview event
2017-10-07 22:52:20 +09:00
John Kleinschmidt
15bfb86eec
Make sure test closes window
...
Newly added test was leaving window open causing tests to fail
2017-10-04 11:35:41 -04:00
Cheng Zhao
8c5bb5969c
Merge pull request #10667 from dittos/window-opacity
...
Add window opacity support
2017-10-04 15:03:45 +09:00
Daniel Ma
1bb042a661
feat(NativeWindowMac): addTabbedWindow
...
Add support for the [`NSWindow addTabbedWindow`][nsw] method on MacOSX
This plays nicely with the changes from #9052 and #9725
Usage samples available in [this commit][c] in my fork of
`electron-quick-start`
[nsw]: https://developer.apple.com/documentation/appkit/nswindow/1855947-addtabbedwindow
[c]: 79f06591df
2017-10-03 20:11:16 +09:00
Taeho Kim
7570ec9d39
Add BrowserWindow.getOpacity for consistency
2017-10-03 00:08:10 +09:00
Ted Kim
7f2c4a9e06
Add window opacity support
2017-09-29 17:49:10 +09:00
John Kleinschmidt
d9d557dcc5
CircleCI updates ( #10647 )
...
* Update CircleCi for release and test
* Update test storage dir
2017-09-28 13:05:42 -04:00
Shelley Vohr
15b0878a17
Merge pull request #10618 from electron/add-menuitembyid
...
[WIP] add getMenuItemById to Menu API
2017-09-26 22:33:05 -04:00
Shelley Vohr
3c6a7c332a
add unit test for getMenuItemById
2017-09-26 20:05:51 -04:00
Cheng Zhao
d87ea5713d
spec: It is not certain which process starts first
2017-09-25 11:19:25 +09:00
Cheng Zhao
5940231b76
spec: Do not assume which process exits first in singleton test
2017-09-25 10:49:54 +09:00
Cheng Zhao
b4075bed87
spec: Add test case for app.makeSingleInstance
2017-09-20 11:58:32 +09:00
Cheng Zhao
af329a9429
Suppress the destroy() spec on all platforms
...
It is also crashing on mac, but just not as frequent as other platforms.
2017-09-14 17:20:14 +09:00
Cheng Zhao
073583ff3d
spec: The parent option should not affect show option
2017-09-14 14:48:42 +09:00
xaviergonz
0d69738bd6
using standard javascript
2017-09-14 14:38:54 +09:00
xaviergonz
0301961c25
Update api-browser-window-spec.js
2017-09-14 14:38:54 +09:00
Cheng Zhao
2048a1a638
Merge pull request #10429 from qazbnm456/web-request-origin
...
Track the origin of webRequest events
2017-09-13 22:23:44 +09:00
Vanessa Yuen
9a7d8a0511
merge master into fix-fullscreen-with-resizable-flag.
2017-09-12 18:34:23 -04:00
Boik
2d771674bb
get webContentsId instead
2017-09-12 20:17:11 +08:00
Boik
549c30f9b2
first attempt to track the origin requesters of webRequest events
2017-09-12 15:40:35 +08:00
Cheng Zhao
10ab870237
Merge pull request #10321 from kaylanm/macos-native-tab-api
...
🍎 Add macOS native tab methods to window API
2017-09-11 18:49:56 +09:00
Cheng Zhao
cc9771a3d0
Merge pull request #10307 from liusy182/10240-theme-color-2
...
return null when theme color is transparent or not found
2017-09-11 18:40:35 +09:00
Samuel Attard
6b010614e2
Implement moveToApplicationsFolder ( #10142 )
...
* Implement moveToApplicationsFolder
* Fix tabs / spaces
* Fix linting
* Use Browser::Quit, instead of exit
* Update documentation as per feedback
* Fix spec
2017-08-31 10:37:12 -04:00
Cheng Zhao
7f4b74f8c6
spec: Compare id instead of the object
...
Otherwise it is impossible to see what's wrong.
2017-08-29 15:45:16 +09:00
Cheng Zhao
f0f17fffd8
spec: Do not test window positions
...
They were too flaky.
2017-08-29 14:23:39 +09:00
Cheng Zhao
5510d8cfb1
Revert "Revert "spec: Suppress the select-client-certificate test""
...
This reverts commit 8e989170f1
2017-08-29 14:19:22 +09:00
Cheng Zhao
68e0fbfd60
Revert "Revert "spec: Suppress the app.importCertificate test""
...
This reverts commit a7cb89aeb5
2017-08-29 14:19:21 +09:00
Cheng Zhao
6e6b097968
Revert "Revert "spec: Suppress the test that destroys WebContents in event listener""
...
This reverts commit 210652ed54
2017-08-29 14:19:19 +09:00
sungpark
eca7ff986c
add webFrame to sandboxed renderer
2017-08-23 10:52:02 -07:00
sungpark
bf07c5aebd
fix contextIsolation issue while webPreference sandbox is on
...
contextIsolation didn't work while sandbox is on. The fix is contextIsolation picked up while sandbox on
2017-08-23 10:52:02 -07:00
Michael Kaylan
b4428e7e41
🍎 Add macOS native tab methods to window API
2017-08-21 23:24:30 -04:00
Aleksei Kuzmin
8b55e6e2f5
Revert "Disable a failing test"
...
This reverts commit 9487222726
2017-08-22 11:49:53 +09:00
Aleksei Kuzmin
c0331673da
Revert "Disable a failing test"
...
This reverts commit 25c0cf0612
2017-08-21 16:48:24 +09:00
Siyuan Liu
eeb2e58ad8
return null when theme color is not found
2017-08-20 22:48:13 +08:00
Aleksei Kuzmin
25c0cf0612
Disable a failing test
...
BrowserWindow module window states resizable state works for a frameless window
2017-08-15 16:19:29 +03:00
Aleksei Kuzmin
9487222726
Disable a failing test
...
BrowserWindow module "webPreferences" option "sandbox" option can print to PDF
2017-08-15 16:19:29 +03:00
Kevin Sawicki
d943519fb4
Update text expectation for new --inspect-brk message
2017-08-15 16:19:23 +03:00
Kevin Sawicki
29dc06c89d
Configure spec UI to run in docker container
2017-08-15 16:19:22 +03:00
Aleksei Kuzmin
ba0c43e1fc
Do not run navigator.getUserMedia related test on CI build machines
2017-08-15 16:19:22 +03:00
John Kleinschmidt
72d2e176dd
Merge pull request #10160 from liusy182/liusy182-10128-asar
...
Return empty string when fs.readFile with 'utf8' option from asar file
2017-08-07 21:42:15 -04:00
John Kleinschmidt
ccdff72ee4
Merge pull request #9918 from alexstrat/add-extensions-loading-api
...
Introduce Chrome extensions management APIs independent of Dev Tools Extensions
2017-08-07 20:06:22 -04:00
Kevin Sawicki
dfec48dd44
End response and set status code for unexpected URLs
2017-08-07 13:33:01 -07:00
Kevin Sawicki
8e989170f1
Revert "spec: Suppress the select-client-certificate test"
...
This reverts commit dc1269615a
2017-08-07 12:57:01 -07:00
Kevin Sawicki
a7cb89aeb5
Revert "spec: Suppress the app.importCertificate test"
...
This reverts commit 5ccae79ea7
2017-08-07 12:56:54 -07:00
Kevin Sawicki
210652ed54
Revert "spec: Suppress the test that destroys WebContents in event listener"
...
This reverts commit b315eb83fd
2017-08-07 12:56:48 -07:00
Cheng Zhao
dc1269615a
spec: Suppress the select-client-certificate test
...
Not sure why it is not working
2017-08-02 16:07:46 +09:00
Cheng Zhao
7d7bb1581b
spec: Disable crashReporter tests for some CI machines
...
Have no idea why it is failing on our CI machines, but at least Appveyor
works fine.
2017-08-02 15:54:50 +09:00
Cheng Zhao
5ccae79ea7
spec: Suppress the app.importCertificate test
...
I have no idea why it failed, somehow the page can not load with the
provided certificated.
2017-08-02 15:17:18 +09:00
Cheng Zhao
28959da2b7
spec: Fix the event test calling done for multiple times
2017-08-02 15:06:06 +09:00
Cheng Zhao
b315eb83fd
spec: Suppress the test that destroys WebContents in event listener
...
It is crashing when Electron is built in Debug mode.
2017-08-02 11:14:06 +09:00
Cheng Zhao
4b46eca329
spec: Always run crash-reporter at last
...
So when a test crashed we can always see the stack trace.
2017-07-31 16:36:52 +09:00
Cheng Zhao
9ced85d860
Terminate tests when renderer process crashed
2017-07-31 16:24:23 +09:00
Siyuan Liu
5a48c1feed
fixes 10128
2017-07-31 09:32:45 +08:00
Birunthan Mohanathas
20ae611dd9
Merge pull request #10097 from liusy182/liusy182-browserview
...
#10039 add BrowserView.fromId
2017-07-28 01:27:47 +03:00
Siyuan Liu
ae7c1ae741
#10039 add BrowserView.fromId
2017-07-24 11:32:30 +08:00
Kevin Sawicki
1d9f69e742
Merge pull request #10008 from qazbnm456/fix-pdf-viewer
...
Fix a query string parsing problem happend to PDF Viewer
2017-07-18 09:10:55 -07:00
Kevin Sawicki
208be2a542
Set preload script on opened windows
2017-07-17 11:55:16 -07:00
Kevin Sawicki
3925bfde8e
Add spec for reloading opened window cross-origin
2017-07-17 11:55:15 -07:00
Kevin Sawicki
0c8f773dec
Remove debug logging
2017-07-17 11:55:15 -07:00
Kevin Sawicki
9d7c2e2294
Add specs for nativeWindowOpen inheritance and new-window support
2017-07-17 11:55:15 -07:00
Kevin Sawicki
86b1deedfa
Inherit enabled-sandbox in opened windows
2017-07-17 11:55:15 -07:00
Kevin Sawicki
c71b0a5441
Add spec for configuring web preferences from sandboxed new-window event
2017-07-17 11:55:15 -07:00
Boik
01d021e6a3
add a new spec for https://github.com/electron/electron/pull/10008
2017-07-15 15:00:30 +08:00
Kevin Sawicki
0a71a9b992
Merge pull request #9695 from shubham2892/alwaysOnTop-window-disappears-when-restored-fix
...
Fix an issue where alwaysOnTop window disappears when restore…
2017-07-14 10:09:13 -07:00
Kevin Sawicki
4935e8567f
Initialize level_ in initWithShell
2017-07-14 10:07:06 -07:00
Kevin Sawicki
48f5a66f87
Merge pull request #9983 from electron/devtools-mixed-sandbox
...
Fix devtools open in mixed sandbox
2017-07-14 09:41:56 -07:00
Birunthan Mohanathas
812b529881
Add app.disableDomainBlockingFor3DAPIs()
...
By default, Chromium disables 3D APIs (e.g. WebGL) until restart on a
per domain basis if the GPU processes crashes too frequently. This
function disables that behaviour.
2017-07-14 01:41:43 +03:00
Kevin Sawicki
60f563ae5f
Surface require errors so spec does not hang
2017-07-13 08:36:58 -07:00
Hari Juturu
80bd6a3e91
🎨
2017-07-11 18:36:01 -07:00
Hari Juturu
9a3b78d9fe
Fix devtools open in mixed sandbox mode
2017-07-11 18:36:00 -07:00
Alexandre Lachèze
6e3407d4a4
✅ Forgot a describe.only
2017-07-05 19:10:02 +02:00
Alexandre Lachèze
2231673b03
✅ Remove already tested part
2017-07-05 17:36:39 +02:00
Alexandre Lachèze
67cec5fd26
✅ add tests for BrowserWindow.addExtension
2017-07-05 17:21:06 +02:00
Aleksei Kuzmin
120b05e075
Fix error message of assertWithinDelta()
2017-07-04 11:56:21 +02:00
Kevin Sawicki
1c1cf0d1f2
Merge pull request #9857 from alexeykuzmin/add-enable-osr-flag
...
[WIP] Add enable_osr flag
2017-06-29 12:30:44 -07:00
Kevin Sawicki
449776f228
Don't run it statements when OSR is disabled
2017-06-29 12:26:45 -07:00
Kevin Sawicki
e37fc0e30a
Mark mixed sandbox as macOS/Windows only
2017-06-28 14:36:34 -07:00
Kevin Sawicki
506b354c1b
👕 Remove lint
2017-06-28 13:40:28 -07:00
Kevin Sawicki
6d2a5145c9
Assert loaded state
2017-06-28 13:01:22 -07:00
Kevin Sawicki
9f0d2cd39d
Use pdf-loaded event in specs
2017-06-28 12:57:05 -07:00
Kevin Sawicki
4958771b8a
Merge pull request #9852 from electron/webcontents-ignorekeyboardshortcuts
...
Add webContents.setIgnoreMenuShortcuts()
2017-06-28 10:35:02 -07:00
Aleksei Kuzmin
25e1c5d6e7
Skip "offscreen rendering" tests if OSR is not available
2017-06-28 19:34:57 +02:00
Kevin Sawicki
9dd27ba3ec
Add explicit expected value
2017-06-28 10:21:25 -07:00
Kevin Sawicki
2cd49f3036
Merge pull request #9644 from electron/webview-sandbox
...
Enable sandbox on webview
2017-06-28 10:10:25 -07:00
Kevin Sawicki
5822e718e6
Add finish helper to ensure connection
2017-06-28 09:58:23 -07:00
Kevin Sawicki
523fbe2df9
Send messages between app via socket connection
2017-06-28 09:27:19 -07:00
Kevin Sawicki
2df9e57b50
Remove unused require
2017-06-28 08:35:17 -07:00
Kevin Sawicki
7fcc00f137
Add spec for app.enableMixedSandbox()
2017-06-28 08:33:11 -07:00
Kevin Sawicki
f7539e6e8d
Remove increased timeout
2017-06-26 14:15:26 -07:00
Kevin Sawicki
c01248ce47
Remove unused require
2017-06-26 14:14:44 -07:00
Kevin Sawicki
0eaddd1565
Verify --enable-sandbox/--no-sandbox command line
2017-06-26 14:12:03 -07:00
Birunthan Mohanathas
f20f87829b
Add webContents.setIgnoreMenuShortcuts()
...
This allows you to disable application menu shortcut handling on a per
web contents basis.
2017-06-26 14:01:17 -07:00
Kevin Sawicki
14178d9826
Expose argv to preload process object
2017-06-26 13:52:19 -07:00
Birunthan Mohanathas
eb19562316
Fix crash when using file chooser in BrowserView
...
The crash was a segfault caused by a null `WebDialogHelper::window_`.
2017-06-21 16:26:38 -07:00
Shubham
1b8963ff6e
🍎 Fix full screen when resizable is set to true
2017-06-20 16:11:28 -04:00
Hari Krishna Reddy Juturu
902b34ba39
🎨
2017-06-19 08:03:02 -07:00
Hari Krishna Reddy Juturu
e546820a4a
Completing UTs
2017-06-19 07:46:14 -07:00
Hari Krishna Reddy Juturu
0b7e7458c9
WIP: Adding UT
2017-06-16 15:34:11 -07:00
Kevin Sawicki
f1a72ad108
Add spec for webview visibility change on show
2017-06-14 14:11:38 -07:00
Kevin Sawicki
45dc6fc04f
Merge pull request #9645 from dharders/issue6036-fix-windows-fullscreen-startup-toggle
...
Fix unresponsive app after fullscreen->normal state toggle (Windows)
2017-06-14 14:10:00 -07:00
dharders
909344415e
🎨 Use leave-full-screen event instead of setTimeout()
2017-06-14 11:06:33 +10:00
Kevin Sawicki
fc00bf0cc3
Add initial spec for ELECTRON_RUN_AS_NODE with --inspect-brk
2017-06-12 14:04:57 -07:00
Shubham
f001377493
🍎 Fix an issue where alwaysOnTop window disappears when restored from the application icon
2017-06-07 12:28:50 -04:00
Kevin Sawicki
c60a9d242e
Disable minimize spec on Linux CI
2017-06-06 16:58:28 -07:00
Kevin Sawicki
a53e98c0f3
Add visibilitystate test for showInactive
2017-06-06 16:45:46 -07:00
Kevin Sawicki
52137485f2
Add separate specs for hide/show/minimize visibilitychange events
2017-06-06 16:22:07 -07:00
Kevin Sawicki
28cd973805
Mention document.hidden in spec description
2017-06-06 15:20:08 -07:00
Kevin Sawicki
d2d28c42f1
Remove unused constant
2017-06-06 15:19:29 -07:00
Birunthan Mohanathas
7d2226e05e
Let Chromium manage document.visibilityState and document.hidden
...
Chromium already includes the necessary plumbing to manage the
visibility properties and `visibilitychange` event so this gets rid of
most of our custom logic for `BrowserWindow` and `BrowserView`.
Note that `webview` remains unchanged and is still affected by the issues
listed below.
User facing changes:
- The `document` visibility properties and `visibilitychange` event are
now also updated/fired in response to occlusion changes on macOS. In
other words, `document.visibilityState` will now be `hidden` on macOS
if the window is occluded by another window.
- Previously, `visibilitychange` was also fired by *both* Electron and
Chromium in some cases (e.g. when hiding the window). Now it is only
fired by Chromium so you no longer get duplicate events.
- The visiblity state of `BrowserWindow`s created with `{ show: false }`
is now initially `visible` until the window is shown and hidden.
- The visibility state of `BrowserWindow`s with `backgroundThrottling`
disabled is now permanently `visible`.
This should also fix #6860 (but not for `webview`).
2017-06-06 15:16:01 -07:00
Kevin Sawicki
53b6ee0e3f
Merge pull request #9468 from tonyganch/9296-history-state
...
Remove page url check during `history.pushState`
2017-06-05 14:47:49 -07:00
Kevin Sawicki
af1d0c45ca
Load URL after registering listener
2017-06-05 14:47:11 -07:00
Kevin Sawicki
777b5b17de
Move pushState spec chromium-spec with other history specs
2017-06-05 14:45:45 -07:00
Kevin Sawicki
9a362eed53
Merge pull request #9572 from shubham2892/api-height-menubar-macos
...
API height menubar macos
2017-06-05 10:35:16 -07:00
deepak1556
50ac7b2edd
Revert "Merge pull request #8724 from electron/defer_load_url"
...
Possible cause for #9121
This reverts commit 886b47e713479af3c9e2
2017-06-05 19:04:21 +05:30
dharders
aeb68c2369
✅ Add test for Windows fullscreen state toggle. Fix #6036
2017-06-05 11:39:15 +10:00
Kevin Sawicki
2508159a25
Use assert.fail for unexpected values
2017-05-31 08:39:49 -07:00
Kevin Sawicki
55fcb286a5
Run getGPUFeatureStatus spec on all platforms
2017-05-31 08:10:55 -07:00
Shubham
6537238c0d
🎨 code structure fix
2017-05-30 17:40:06 -04:00
Shubham
62d9bf9bae
🎨 ✅ code comments and test for getMenuBarHeight function
2017-05-30 17:26:02 -04:00
Kevin Sawicki
4a5831a733
Add initial getGPUFeatureStatus spec
2017-05-30 13:00:00 -07:00
Kevin Sawicki
5cf4995f2e
DRY up logic to check if native modules should be loaded
2017-05-30 09:15:38 -07:00
Kevin Sawicki
edd840fcc0
Only assert GPU process on macOS
2017-05-26 10:10:56 -07:00
Kevin Sawicki
9f49b71b89
Add cross-origin frame webview spec
2017-05-26 10:10:36 -07:00
Kevin Sawicki
36989e19f8
Add spec for cross-origin blockage
2017-05-26 10:10:36 -07:00
Kevin Sawicki
e735aa7dee
web-preferences -> webPreferences
2017-05-26 10:10:36 -07:00
Kevin Sawicki
f5cf6d4ddd
Add spec for native window.open from iframe
2017-05-26 10:10:36 -07:00
Kevin Sawicki
a0571e3c72
Add failing spec for native window.open returning null without allowpopups
2017-05-26 10:10:36 -07:00
Kevin Sawicki
ef01c16c6a
Add tests for more nativeWindowOpen events
2017-05-26 10:10:36 -07:00
Kevin Sawicki
9f06b6dc21
Set allowpopups attribute in nativeWindow open specs
2017-05-26 10:10:36 -07:00
Kevin Sawicki
a32b7e5cdb
Co-locate nativeWindowOpen specs
2017-05-26 10:10:36 -07:00
Kevin Sawicki
a2a7a1d8c7
Add new-window <webview> spec with nativeWindowOpen
2017-05-26 10:10:36 -07:00
Kevin Sawicki
da2b29796f
Add same domain webview nativeWindowOpen spec
2017-05-26 10:10:36 -07:00
Kevin Sawicki
a16cd0bd03
Add failing <webview> with nativeWindowOpen spec
2017-05-26 10:10:36 -07:00
Kevin Sawicki
9137a2279a
Merge pull request #9486 from electron/child-observer
...
Adding CPU & Memory metrics for App
2017-05-26 09:28:22 -07:00
Kevin Sawicki
8b14df143a
Don't assert GPU process on Linux
2017-05-26 09:14:17 -07:00
Kevin Sawicki
1e4dd9b163
Store process type as int
2017-05-26 08:53:26 -07:00
Kevin Sawicki
b5879b7399
🎨 Minor formatting/doc changes
2017-05-26 07:51:17 -07:00
Kevin Sawicki
d202c35be9
Enable crash reporter specs on Linux CI
2017-05-25 16:58:37 -07:00
Hari Juturu
de5eaf9336
Remove .only
2017-05-24 21:07:35 -07:00
Hari Juturu
939747945e
Adding CPU & Memory metrics for App
2017-05-24 21:07:35 -07:00
