Shelley Vohr
784201ecee
build: try removing Read/WriteBarrier patch ( #45393 )
...
build: try removing Read/WriteBarrier patch
2025-01-31 10:29:34 +01:00
Shelley Vohr
6e72cbb5e0
fix: multiple directory selection on Linux ( #45373 )
2025-01-30 16:34:44 +01:00
Shelley Vohr
233b99a0a8
chore: update chrome.scripting.execute logic ( #45369 )
...
chore: update chrome.scripting.execute logic
Refs:
- https://chromium-review.googlesource.com/c/chromium/src/+/6123601
- https://chromium-review.googlesource.com/c/chromium/src/+/6142377
- https://chromium-review.googlesource.com/c/chromium/src/+/6173554
2025-01-30 12:56:44 +01:00
Shelley Vohr
43e328f363
chore: update pdf_viewer_private.idl ( #45370 )
...
chore: update pdf_viewer_private.idl
- https://chromium-review.googlesource.com/c/chromium/src/+/6160067
2025-01-30 11:03:27 +01:00
John Kleinschmidt
8543820d98
build: fixup concurrent builds on protected branches ( #45355 )
2025-01-29 16:47:25 -05:00
electron-roller[bot]
93f4a93e12
chore: bump node to v22.13.1 (main) ( #45307 )
...
* chore: bump node in DEPS to v22.13.1
* chore: fixup GN build file
* https://github.com/nodejs/node/pull/55529
* https://github.com/nodejs/node/pull/55798
* https://github.com/nodejs/node/pull/55530
* module: simplify --inspect-brk handling
https://github.com/nodejs/node/pull/55679
* src: fix outdated js2c.cc references
https://github.com/nodejs/node/pull/56133
* crypto: include openssl/rand.h explicitly
https://github.com/nodejs/node/pull/55425
* build: use variable for crypto dep path
https://github.com/nodejs/node/pull/55928
* crypto: fix RSA_PKCS1_PADDING error message
https://github.com/nodejs/node/pull/55629
* build: use variable for simdutf path
https://github.com/nodejs/node/pull/56196
* test,crypto: make crypto tests work with BoringSSL
https://github.com/nodejs/node/pull/55491
* fix: suppress clang -Wdeprecated-declarations in libuv
https://github.com/libuv/libuv/pull/4486
* deps: update libuv to 1.49.1
https://github.com/nodejs/node/pull/55114
* test: make test-node-output-v8-warning more flexible
https://github.com/nodejs/node/pull/55401
* [v22.x] Revert "v8: enable maglev on supported architectures"
https://github.com/nodejs/node/pull/54384
* fix: potential WIN32_LEAN_AND_MEAN redefinition
https://github.com/c-ares/c-ares/pull/869
* deps: update nghttp2 to 1.64.0
https://github.com/nodejs/node/pull/55559
* src: provide workaround for container-overflow
https://github.com/nodejs/node/pull/55591
* build: use variable for simdutf path
https://github.com/nodejs/node/pull/56196
* chore: fixup patch indices
* fixup! module: simplify --inspect-brk handling
* lib: fix fs.readdir recursive async
https://github.com/nodejs/node/pull/56041
* lib: avoid excluding symlinks in recursive fs.readdir with filetypes
https://github.com/nodejs/node/pull/55714/
This doesn't currently play well with ASAR - this should be fixed in a follow up
* test: disable CJS permission test for config.main
This has diverged as a result of our revert of
src,lb: reducing C++ calls of esm legacy main resolve
* fixup! lib: fix fs.readdir recursive async
* deps: update libuv to 1.49.1
https://github.com/nodejs/node/pull/55114
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-01-29 15:41:00 -05:00
Robo
ecd5d0a3a4
fix: crash in gin::wrappable::secondweakcallback ( #45368 )
2025-01-29 10:20:37 -08:00
Niklas Wenzel
8cf2e46c1f
docs: reference security guide in ipcRenderer.on docs ( #45325 )
2025-01-29 12:50:20 +01:00
dependabot[bot]
50387043d1
build(deps): bump github/codeql-action from 3.28.1 to 3.28.6 ( #45351 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.1 to 3.28.6.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](b6a472f63d...17a820bf2e
2025-01-29 07:01:15 +01:00
Keeley Hammond
e715607178
build: use Python311 exe ( #45360 )
...
build: yse Python311 exe
2025-01-28 11:59:04 -08:00
Milan Burda
0e388bce3e
build: add NSPrefersDisplaySafeAreaCompatibilityMode = false to Info.plist ( #45318 )
...
build: add NSPrefersDisplaySafeAreaCompatibilityMode = false to Info.plist
2025-01-28 14:58:48 +01:00
dependabot[bot]
9457a56607
build(deps): bump actions/setup-node from 4.1.0 to 4.2.0 ( #45353 )
...
Bumps [actions/setup-node](https://github.com/actions/setup-node ) from 4.1.0 to 4.2.0.
- [Release notes](https://github.com/actions/setup-node/releases )
- [Commits](39370e3970...1d0ff469b7
2025-01-28 14:57:39 +01:00
dependabot[bot]
f9553a35d5
build(deps): bump actions/stale from 9.0.0 to 9.1.0 ( #45354 )
...
Bumps [actions/stale](https://github.com/actions/stale ) from 9.0.0 to 9.1.0.
- [Release notes](https://github.com/actions/stale/releases )
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md )
- [Commits](28ca103628...5bef64f19d
2025-01-28 14:56:34 +01:00
dependabot[bot]
e2ef160beb
build(deps): bump actions/checkout from 4.1.6 to 4.2.2 ( #45352 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.6 to 4.2.2.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v4.1.6...11bd71901bbe5b1630ceea73d27597364c9af683 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-28 10:48:35 +01:00
David Lönnhager
ae56a03e33
fix: crash parsing CLSID in shell.readShortcutLink() ( #45195 )
...
* fix: crash parsing CLSID in shell.readShortcutLink
* fix: ignore clsid if it could not be set
2025-01-27 15:22:56 -05:00
Keeley Hammond
4629e449a9
build: remove generate-sas-token ( #45347 )
2025-01-27 12:21:53 -08:00
Keeley Hammond
74c6669a8e
build: use windows builders for win-publish ( #45340 )
2025-01-24 14:43:38 -08:00
Niklas Wenzel
5c67cd9150
docs: fix broken code in drag and drop example ( #45332 )
2025-01-24 13:28:30 -08:00
Niklas Wenzel
f66a0c2acf
build: create maintainer issue template and disable blank issues ( #45309 )
...
* build: create maintainer task issue template and disable blank issues
* Implement review feedback by @dsanders11
* Rename issue template file
2025-01-24 13:28:05 -08:00
Sam Maddock
a467d0684e
feat: ServiceWorkerMain ( #45232 )
...
* feat: ServiceWorkerMain
* refactor: disconnect remote
* handle version_info_ nullptr case
* initiate finish request when possible and enumerate errors
* explicit name for test method
* oops
* fix: wait for redundant version to stop before destroying
* docs: clarify when undefined is returned
* chore: remove extra semicolons
2025-01-24 08:33:44 -05:00
electron-roller[bot]
75eac86506
chore: bump chromium to 134.0.6968.0 (main) ( #45172 )
...
* chore: bump chromium in DEPS to 134.0.6948.0
* chore: update can_create_window.patch
https://chromium-review.googlesource.com/c/chromium/src/+/6151982
no patch code changes, but had to manually apply due to upstream context shear
* chore: update proxy_config_monitor.patch
no manual changes; patch applied with fuzz 2
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6126219
* chore: update build_add_electron_tracing_category.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6149256
* chore: update adjust_accessibility_ui_for_electron.patch
https://chromium-review.googlesource.com/c/chromium/src/+/6105650
no patch code changes, but had to manually apply due to upstream context shear
* chore: e patches all
* chore: use fully-qualified path for all.gn
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6154997
* chore: do not use a variable when assigning rtc_use_h264
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6154997
* Move GlobalShortcutListenerLinux to //ui/base
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6097375
* [MPArch Guest View] Make WebPreferences queried per frame tree root
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6096390
* [Status Icons] Allow vector resources
https://chromium-review.googlesource.com/c/chromium/src/+/6139403
* [Extensions] Move MatchOriginAsFallbackBehavior to Mojom
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6141793
* Remove StrongAlias::Hasher
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6132291
* Rename text-change and select-change methods and related stuff
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6148816
* [Code Health] Remove stale feature EnableWebUsbOnExtensionServiceWorker
https://chromium-review.googlesource.com/c/chromium/src/+/6115161
* [Extensions Cleanup] Move creation of tab-based ports to factory method
https://chromium-review.googlesource.com/c/chromium/src/+/6143725
* refactor: add StatusIconGtk::SetIcon()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6139403
copied from chrome/browser/status_icons/status_icon.cc
* refactor: add TrayIconLinux::GetIcon()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6139403
* chore: update feat_allow_usage_of_sccontentsharingpicker_on_supported_platforms.patch
remove unused filter_ field
* chore: bump chromium in DEPS to 134.0.6950.0
* chore: bump chromium in DEPS to 134.0.6952.0
* chore: bump chromium in DEPS to 134.0.6954.0
* chore: bump chromium in DEPS to 134.0.6956.0
* chore: update Chromium patches
* 6165749: Check scanout support in RenderableGpuMemoryBufferPool | https://chromium-review.googlesource.com/c/chromium/src/+/6165749
* 6106730: [Win] Use DXGI swapchains and DCOMP visuals in software mode | https://chromium-review.googlesource.com/c/chromium/src/+/6106730
* chore: update patches
* chore: bump chromium in DEPS to 134.0.6958.0
* chore: bump chromium in DEPS to 134.0.6960.0
* chore: update chromium patches
* 6168371: Remove extensions GlobalShortcutListener wrapper | https://chromium-review.googlesource.com/c/chromium/src/+/6168371
* chore: update patches
* 6161637: WebUI: Leverage build_webui() in chrome://translate-internals | https://chromium-review.googlesource.com/c/chromium/src/+/6161637
* chore: bump chromium in DEPS to 134.0.6962.0
* 6177329: Remove policy.used_policy_certificates pref on ChromeOS | https://chromium-review.googlesource.com/c/chromium/src/+/6177329
* 6180524: Simplify logic in components/os_crypt/sync/BUILD.gn | https://chromium-review.googlesource.com/c/chromium/src/+/6180524
* 6144831: Enforce --disallow-v8-feature-flag-overrides in the renderer | https://chromium-review.googlesource.com/c/chromium/src/+/6144831
* chore: update patches
* chore: bump chromium in DEPS to 134.0.6964.0
* 6181010: Ensure busy cursor does not show via LaunchWithoutSandbox | https://chromium-review.googlesource.com/c/chromium/src/+/6181010
* chore: update patches
* chore: bump chromium in DEPS to 134.0.6966.0
* 6180598: [api] Remove Reallocate | https://chromium-review.googlesource.com/c/v8/v8/+/6180598
* 6170781: [Refactor] Move UninstallExtension to ExtensionRegistrar. | https://chromium-review.googlesource.com/c/chromium/src/+/6170781
* chore: update filenames.libcxx.gni
* 6168207: cdm: Remove widevine_cdm_version.h | https://chromium-review.googlesource.com/c/chromium/src/+/6168207
* chore: bump chromium in DEPS to 134.0.6968.0
* 6030552: [macOS] Allow using vibrancy with NativeWidgetNSWindowBridge | https://chromium-review.googlesource.com/c/chromium/src/+/6030552
* fix: use explicit copy to replace realloc impl
https://chromium-review.googlesource.com/c/v8/v8/+/6180598
https://issues.chromium.org/issues/331326406
As per recommendation, "File an issue with Node to explicitly copy,because they copy under the hood anyway"
* fixup! 6106730: [Win] Use DXGI swapchains and DCOMP visuals in software mode | https://chromium-review.googlesource.com/c/chromium/src/+/6106730
* fix: undefine win32 StrCat
https://chromium-review.googlesource.com/c/chromium/src/+/6172292
* fix: //device/vr:directx_helpers breaking the build
https://chromium-review.googlesource.com/c/chromium/src/+/6064548
Upstreamed in https://chromium-review.googlesource.com/c/chromium/src/+/6186102
* fix: avoid calling ui::Layer::SetFillsBoundsOpaquely
https://chromium-review.googlesource.com/c/chromium/src/+/6175787
The layer opacity is determined by the background color's alpha value
* fix: build with proprietary_codecs
The explicit setting of rtc_use_h264 is no longer needed since
https://webrtc-review.googlesource.com/c/src/+/62380
* fix: increase empty trace file size threshold
https://chromium-review.googlesource.com/c/chromium/src/+/6176642
Traces now contain a net-constants property to allow them to be converted to a net log.
These contain ~1240 new properties with formatted JSON data.
* fix: node tests missing resource management globals
https://chromium-review.googlesource.com/c/chromium/src/+/6174695
* fixup! fix: use explicit copy to replace realloc impl
* chore: disable focus handling test due to win32/ia32 regression
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
Co-authored-by: Samuel Maddock <samuelmaddock@electronjs.org>
2025-01-23 23:07:43 -05:00
Sam Maddock
996477152d
feat: contextBridge.executeInMainWorld ( #45229 )
2025-01-23 21:12:46 -05:00
Sam Maddock
e09577b123
feat: redesign preload APIs ( #45230 )
...
* feat: redesign preload APIs
* docs: remove service-worker mentions for now
* fix lint
* remove service-worker ipc code
* add filename
* fix: web preferences preload not included
* fix: missing common init
* fix: preload bundle script error
2025-01-23 21:12:23 -05:00
Felix Rieseberg
26d228ccfe
docs: Add note about directly exposing Electron APIs in preload ( #45241 )
...
* docs: Add note about directly exposing Electron APIs in preload
* Implement feedback
2025-01-23 13:59:00 -08:00
Keeley Hammond
aafb1ba72c
build: migrate Windows release builds to GHA ( #45137 )
...
* build: migrate release builds to GHA
* build: alter CI jobs release script
2025-01-23 14:10:24 -05:00
Charles Kerr
db7ef90159
chore: better logging if Node initialization fails ( #45286 )
...
feat: better logging if Node initialization fails
2025-01-23 08:55:28 -06:00
electron-roller[bot]
863faea542
chore: bump node to v22.11.0 (main) ( #44530 )
...
* chore: bump node in DEPS to v22.11.0
* src: move evp stuff to ncrypto
https://github.com/nodejs/node/pull/54911
* crypto: add Date fields for validTo and validFrom
https://github.com/nodejs/node/pull/54159
* module: fix discrepancy between .ts and .js
https://github.com/nodejs/node/pull/54461
* esm: do not interpret "main" as a URL
https://github.com/nodejs/node/pull/55003
* src: modernize likely/unlikely hints
https://github.com/nodejs/node/pull/55155
* chore: update patch indices
* crypto: add validFromDate and validToDate fields to X509Certificate
https://github.com/nodejs/node/pull/54159
* chore: fixup perfetto patch
* fix: clang warning in simdjson
* src: add receiver to fast api callback methods
https://github.com/nodejs/node/pull/54408
* chore: fixup revert patch
* fixup! esm: do not interpret "main" as a URL
* fixup! crypto: add Date fields for validTo and validFrom
* fix: move ArrayBuffer test patch
* src: fixup Error.stackTraceLimit during snapshot building
https://github.com/nodejs/node/pull/55121
* fix: bad rebase
* chore: fixup amaro
* chore: address feedback from review
* src: revert filesystem::path changes
https://github.com/nodejs/node/pull/55015
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-01-22 12:16:26 -05:00
Shelley Vohr
5aabb6bec5
fix: potential crash in chrome.tabs.update() ( #45276 )
...
fix: potential crash in chrome.tabs.update()
2025-01-22 10:02:29 -06:00
dependabot[bot]
5e05dff949
build(deps): bump actions/upload-artifact from 4.5.0 to 4.6.0 ( #45274 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.5.0 to 4.6.0.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](6f51ac03b9...65c4c4a1dd
2025-01-22 12:29:23 +01:00
Maksim Sisov
3ea623364b
feat: support global shortcuts via GlobalShortcutsPortal feature with ozone/wayland ( #45171 )
...
* fix: backport patch to fix systemd unit activation in Chromium
This backports a patch from Chromium, which fixes systemd unit
activation. That is, a globalShortcuts feature that Chromium has
needs to create a systemd unit and rename it properly. Portal's
global shortcuts uses that name afterwards to map the app with
the shortcuts bound. However, there might be a race between
Chromium binding shortcuts and renaming the unit.
This is a first step to add Portal's globalShortcuts to
Electron.
* feat: Support global shortcuts via GlobalShortcutsPortal feature
Chromium has a new feature called GlobalShortcutsPortal. It
allows clients to use Portal's globalShortcuts to register and
listen to shortcuts.
This patches adds necessary bits, which allows Electron to
use that feature.
In order to make it work, one has to add
--enable-features=GlobalShortcutsPortal
Test: tested manually with a sample app.
* docs: add GlobalShortcutsPortal feature to globalShortcuts docs
Electron supports Portal's globalShortcuts API now via Chromium, and Electron
apps can use that in a Wayland session. Update the docs with the required
feature flag that must be passed to be able to use that implementation.
2025-01-22 11:59:48 +01:00
Erick Zhao
cf67dc8898
docs: add DocCardList component for index doc ( #45275 )
2025-01-22 10:27:30 +01:00
David Sanders
d7b568a1c0
ci: fix issue workflow failures ( #45294 )
2025-01-22 09:40:10 +01:00
Charles Kerr
fe9031eb23
refactor: in StopTracing(), use string literals instead of optional<string> ( #45270 )
...
refactor: simplify StopTracing() a little by using a string_view instead of an optional<string>
We have compile-time string literals that we're passing to a method
that takes a string_view argument, so we don't need all this extra
optional<string> scaffolding
2025-01-21 17:41:52 -06:00
Charles Kerr
f5eba67f0d
refactor: simplify ParseUserScript() ( #45269 )
...
refactor: simplify ParseUserScript()
local variable user_script no longer needed after #43205
2025-01-21 15:21:56 -05:00
Charles Kerr
e1762e6e44
fix: consume the file permission callback when used ( #45267 )
...
fixes 0e5fe3f
2025-01-21 11:59:38 -06:00
Shelley Vohr
9d32b6ddfc
fix: webContents.print() with OOP printing ( #45266 )
...
* fix: webContents.print() with OOP printing
* Update patches/chromium/printing.patch
Co-authored-by: Robo <hop2deep@gmail.com>
---------
Co-authored-by: Robo <hop2deep@gmail.com>
2025-01-21 11:39:21 -05:00
David Sanders
7a413ff2ad
ci: don't fail issue triage workflows if issue not found on project ( #45252 )
2025-01-21 16:06:24 +01:00
Shelley Vohr
0090d171fd
chore: align clipboard blink::web_pref::WebPreferences with upstream ( #45277 )
...
chore: align clipboard blink::web_pref::WebPreferences with upstream
2025-01-21 06:50:36 -08:00
dependabot[bot]
980b68e9cc
build(deps): bump github/codeql-action from 3.28.0 to 3.28.1 ( #45272 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.0 to 3.28.1.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](48ab28a6f5...b6a472f63d
2025-01-21 15:12:42 +01:00
dependabot[bot]
44a630e634
build(deps): bump mikefarah/yq from 4.44.6 to 4.45.1 ( #45271 )
...
Bumps [mikefarah/yq](https://github.com/mikefarah/yq ) from 4.44.6 to 4.45.1.
- [Release notes](https://github.com/mikefarah/yq/releases )
- [Changelog](https://github.com/mikefarah/yq/blob/master/release_notes.txt )
- [Commits](4839dbbf80...8bf425b4d1
2025-01-21 15:12:29 +01:00
Shelley Vohr
81d12fa452
build: fix clang-format duplicate message ( #45235 )
2025-01-20 11:05:40 +01:00
Shelley Vohr
83666ddc36
fix: page scaling in silent mode printing ( #45218 )
2025-01-20 11:05:15 +01:00
Shelley Vohr
fa5de40f86
fix: two possible FSA crashes ( #45233 )
...
* 5786874: Change Observer: Fix crash when navigating to new page
https://chromium-review.googlesource.com/c/chromium/src/+/5786874
* 5794141: Change Observer: Fix Get*PermissionGrant crash
https://chromium-review.googlesource.com/c/chromium/src/+/5794141
2025-01-20 10:23:57 +01:00
Shelley Vohr
7d05fb2a1b
fix: broken OOP window.print() on macOS/Linux ( #45214 )
...
fix: broken OOP printing on macOS/Linux
2025-01-20 10:23:44 +01:00
Sam Maddock
51a249f380
chore: skip flaky contentTracing test ( #45240 )
2025-01-20 09:57:10 +01:00
Sam Maddock
90754e5fd2
test: quit Finder ( #45239 )
2025-01-20 09:54:26 +01:00
Shelley Vohr
0e5fe3fa60
fix: getAsFileSystemHandle failure when drag-dropping two directories ( #45234 )
...
fix: drag-dropping two directories
2025-01-20 09:54:12 +01:00
michal-pichlinski-openfin
6953f5505f
refactor: remove InspectableWebContentsViewMac in favor of the Views version ( #44628 )
...
* refactor: remove InspectableWebContentsViewMac in favor of the Views version
* cherry-pick: refactor: remove InspectableWebContentsViewMac in favor of the Views version (#41326 )
commit e67ab9a93dhttps://github.com/electron/electron/pull/42996
fixing
https://github.com/electron/electron/issues/42995
* fix: displaying select popup in window created as fullscreen window
`constrainFrameRect:toScreen:` is not being call for windows created
with `fullscreen: true` therefore `headless` mode was not being removed
and `RenderWidgetHostNSViewBridge::DisplayPopupMenu` ignored displaying
popup.
Issue could be fixed by placing additional removal of `headless` mode
in the `toggleFullScreen:`, but `orderWindow:relativeTo:` is called
both for a regular and a fullscreen window, therefore there will be
a single place fixing both cases.
Because `electron::NativeWindowMac` lifetime may be shorter than
`ElectronNSWindow` on which macOS may execute `orderWindow:relativeTo:`
we need to clear `shell_` when `NativeWindow` is being closed.
Fixes #43010 .
* fix: Content visibility when using `vibrancy`
We need to put `NSVisualEffectView` before `ViewsCompositorSuperview`
otherwise when using `vibrancy` in `BrowserWindow` `NSVisualEffectView`
will hide content displayed by the compositor.
Fixes #43003
Fixes #42336
In fact main issues reported in these tickets were not present after
cherry-picking original refactor switching to `views::WebView`, so
text could be selected and click event was properly generated. However
both issues testcases were using `vibrancy` and actual content was
invisible, because it was covered by the `NSVisualEffectView`.
* fix: EXCEPTION_ACCESS_VIOLATION crash on BrowserWindow.destroy()
Restored postponed deletion of the `NativeWindow`.
Restoration caused `DCHECK(new_parent_ui_layer->GetCompositor());` failure
in `BrowserCompositorMac::SetParentUiLayer` after the spec test:
`chrome extensions chrome.webRequest does not take precedence over Electron webRequest - http`
with stack:
```
7 Electron Framework 0x000000011fe07830 content::BrowserCompositorMac::SetParentUiLayer(ui::Layer*) + 628
8 Electron Framework 0x000000011fe0c154 content::RenderWidgetHostViewMac::SetParentUiLayer(ui::Layer*) + 220
9 Electron Framework 0x000000011fe226a8 content::WebContentsViewMac::CreateViewForWidget(content::RenderWidgetHost*) + 600
10 Electron Framework 0x000000011fd37e4c content::WebContentsImpl::CreateRenderWidgetHostViewForRenderManager(content::RenderViewHost*) + 164
11 Electron Framework 0x000000011fb32278 content::RenderFrameHostManager::CreateSpeculativeRenderFrame(content::SiteInstanceImpl*, bool, scoped_refptr<content::BrowsingContextState> const&) + 816
12 Electron Framework 0x000000011fb2ab8c content::RenderFrameHostManager::CreateSpeculativeRenderFrameHost(content::SiteInstanceImpl*, content::SiteInstanceImpl*, bool) + 1308
13 Electron Framework 0x000000011fb28598 content::RenderFrameHostManager::GetFrameHostForNavigation(content::NavigationRequest*, content::BrowsingContextGroupSwap*, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>*) + 1796
14 Electron Framework 0x000000011fa78660 content::NavigationRequest::SelectFrameHostForOnRequestFailedInternal(bool, bool, std::__Cr::optional<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>> const&) + 280
15 Electron Framework 0x000000011fa6a994 content::NavigationRequest::OnRequestFailedInternal(network::URLLoaderCompletionStatus const&, bool, std::__Cr::optional<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>> const&, bo
+ 1008
16 Electron Framework 0x000000011fa7772c content::NavigationRequest::OnRequestFailed(network::URLLoaderCompletionStatus const&) + 72
17 Electron Framework 0x000000011f8554ac content::NavigationURLLoaderImpl::NotifyRequestFailed(network::URLLoaderCompletionStatus const&) + 248
```
This was probably the reason of removing `NativeWindow` immediately
in order to cleanup `views_host_` in `WebContentsViewMac` to prevent
using layer without compositor in `WebContentsViewMac::CreateViewForWidget`.
`[ElectronNSWindowDelegate windowWillClose:]` is deleting window host
and the compositor used by the `NativeWindow` therefore detach `NativeWindow`
contents from parent. This will clear `views_host_` and prevent failing
mentioned `DCHECK`.
Fixes #42975
* chore: Applied review suggestions
* refactor: directly cleanup shell
---------
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
2025-01-17 10:21:10 -05:00
Felix Rieseberg
45f90cd5dd
docs: Why Electron? ( #45191 )
...
* docs: Why Electron?
* Apply suggestions from code review
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com>
Co-authored-by: Erick Zhao <erick@hotmail.ca>
* Update docs/why-electron.md
---------
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com>
Co-authored-by: Erick Zhao <erick@hotmail.ca>
2025-01-15 18:32:56 -05:00
Anny Yang
8294f44c74
docs: remove quickstart ( #45194 )
2025-01-15 14:42:53 -08:00
