* fix: bugprone-narrowing-conversions warning in NativeImage::memory_usage_
- fix signed / unsigned math by using base/numerics/safe_conversions
- make memory_usage_ an int64_t so it can safely take the size_t
returned by computeByteSize()
* chore: bump chromium in DEPS to 132.0.6791.1
* 5804481: [UI] Migrate remaining clients of `MenuSourceType`
https://chromium-review.googlesource.com/c/chromium/src/+/5804481
* chore: bump chromium in DEPS to 132.0.6793.1
* chore: bump chromium in DEPS to 132.0.6794.0
* chore: bump chromium in DEPS to 132.0.6797.0
* 5952404: Clean up //ui/base/resource from Lacros code.
https://chromium-review.googlesource.com/c/chromium/src/+/5952404
* 5920842: Generate combined grd for PEPC strings and use them in the element
https://chromium-review.googlesource.com/c/chromium/src/+/5920842
* 5943708: Enable DynamicSafeAreaInsets for eligible users only
https://chromium-review.googlesource.com/c/chromium/src/+/5943708
* 5937004: Remove components/services/language_detection
https://chromium-review.googlesource.com/c/chromium/src/+/5937004
* 5920322: [UI] Use mojo enum for `MenuSourceType` in ui/views/controls/
https://chromium-review.googlesource.com/c/chromium/src/+/5920322
* chore: fixup patch indices
* chore: bump chromium in DEPS to 132.0.6799.0
* chore: bump chromium in DEPS to 132.0.6801.0
* chore: bump chromium in DEPS to 132.0.6803.0
* chore: bump chromium in DEPS to 132.0.6805.1
* chore: bump chromium in DEPS to 132.0.6807.0
* chore: bump chromium in DEPS to 132.0.6809.1
* chore: bump chromium in DEPS to 132.0.6811.1
* chore: bump chromium in DEPS to 132.0.6813.1
* chore: bump chromium in DEPS to 132.0.6815.1
* chore: bump chromium in DEPS to 132.0.6817.1
* 5947724: [ui] Add missing shortcut text for VKEY_COMMAND on linux
https://chromium-review.googlesource.com/c/chromium/src/+/5947724
(cherry picked from commit 0fdf6c6e510752dcfd9d3062dff71aff55c5fdab)
* 5948024: [DNT] Fix NavigationController raw_ptr during WebContents destruction
https://chromium-review.googlesource.com/c/chromium/src/+/5948024
(cherry picked from commit f6662c3b6dd5f40691644911a2d527ae48015ccb)
* 5945209: Roll libc++ from c8eec3629a9e to e2c39ff9388b (1 revision)
https://chromium-review.googlesource.com/c/chromium/src/+/5945209
(cherry picked from commit 55b75a1456ccdb9a9771db741fed14a9706419b7)
* 5942398: Remove some chrome:: namespace from chrome/browser/win/*
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5942398
(cherry picked from commit d664ce2434e3995b628b3b252877df4efebc6825)
* chore: fixup patch indices
(cherry picked from commit 657cd6ee3470291123e8a8d0f6f189f2a3280c5d)
* 5963016: FSA: Use the profile path for base::DIR_HOME on ChromeOS
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5963016
(cherry picked from commit 69505baee6d037fe370ec10c0ffa03447a43ab34)
* chore: fixup patch indices
(cherry picked from commit c79c2c8734a82be32cd7ff6f9d70d3be5e08e50b)
* 5924816: [macOS][FSA] Block Access to Application Bundle Path
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5924816
(cherry picked from commit dbcc24fe26337d063a9623379a8e9c2b5a64ce65)
* 5962517: [media] Apply inside blink to renderer/platform/media
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5962517
(cherry picked from commit f396860717dc4692c9ee036b91a07d12f3114991)
* 5829616: MPArch based GuestViews basic implementation
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5829616
(cherry picked from commit b95772daa33fce58e0c09847c60511e8b53eacb2)
* 5953710: Expose a rust_static_library instead of raw rs file from rust_bindgen
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5953710
(cherry picked from commit 11edc865b578d1596d42a4abfb811360c960e51c)
* chore: fixup patch indices
(cherry picked from commit 7be81bdd02cff8894c4fff141d39408906164a8e)
* chore: disable ELF CREL on Linux Arm
5938657: Reapply "Enable ELF CREL, which reduces the size of ELF relocatable object files." | https://chromium-review.googlesource.com/c/chromium/src/+/5938657
(cherry picked from commit 48c5efd0b0ab8fdfafb1b8df2ef35150362df410)
* chore: bump chromium in DEPS to 132.0.6807.0
(cherry picked from commit f41da7b5a3b8da6af161ab37c7b6792de1c008d7)
* 5868889: Shared Storage: Support saved queries in selectURL
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5868889
(cherry picked from commit 4e389ef21ab0e860373b7aab0cc74beee020b2fe)
* Revert "5956408: [fastapi] Promote deprecation of FastApiTypedArray"
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5956408
(cherry picked from commit a4b8e46b34a01e72dbeeaa4fdbae1939402a4ca6)
* Revert "5962696: [mojo] Force blink headers to only be included in blink"
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5962696
(cherry picked from commit f0228c286fcb8166ff57cda4dd2b353b4c06b69a)
* chore: update patches
(cherry picked from commit 3a3c527a1de9ee4f6f3e8545a8e4ff7c6ac6fa0c)
* 5973073: [Extensions] Improve warnings parsing (host) permissions in MV3
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5973073
(cherry picked from commit c571e561e0b4ba06bd40d8ec4e9cfe59ede010c5)
* chore: update filenames.libcxx.gni
(cherry picked from commit 7677e9bfc6b18ac3556b20fd4f4888e9f2d37431)
* Apply suggestions from code review
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
(cherry picked from commit e8dd8215cff2f3f7216b31ef8edc8a3b24c56e2c)
* chore: update patches after rebase
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* Revert "docs: fix `win.getContentView(`) return type (#44464)"
This reverts commit b11c6cf9bf.
* fix: Use openURL:configuration:completionHandler instead of openUrl
Co-authored-by: alice <alice@makenotion.com>
* test: add a test
Co-authored-by: alice <alice@makenotion.com>
* fix: add dispatch_async to replace GetUIThreadTaskRunner
Co-authored-by: alice <alice@makenotion.com>
* refactor: remove unused import
Co-authored-by: alice <alice@makenotion.com>
* fix: update to use BindPostTaskToCurrentDefault
Co-authored-by: alice <alice@makenotion.com>
* test: add regression test for window focus
Co-authored-by: alice <alice@makenotion.com>
* refactor: update to explicit task runner
Co-authored-by: alice <alice@makenotion.com>
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: alice <alice@makenotion.com>
* perf: prefer NewFromUtf8Literal() over NewFromUtf8() for string literals
the string length is known at compile time and no need to call ToLocalChecked()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* perf: string length is known when calling NewFromUtf8(), so use it
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* perf: remove unnecessary calls to c_str()
these just force the code being called to have to recalculate the string length
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: move as_byte_span() to new shell/common/mac_util.h
this way it can be used by multiple mm files
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* fix: -Wunsafe-buffer-usage warnings in UNNotificationResponseToNSDictionary
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: use base::HexEncode() instead of rolling our own
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* fixup! chore: move as_byte_span() to new shell/common/mac_util.h
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* fixup! chore: move as_byte_span() to new shell/common/mac_util.h
fix: move mac_util to the right place in filenames.gni
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: bump chromium in DEPS to 131.0.6756.0
* chore: update disable_hidden.patch
no code changes; just handling upstream context shear
https://chromium-review.googlesource.com/c/chromium/src/+/5887019
* chore: update feat_expose_raw_response_headers_from_urlloader.patch
Factor out URLLoader's URLRequest configuration into a helper
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5902254
* chore: update fix_disabling_background_throttling_in_compositor.patch
no manual changes; patch applied with fuzz 1
* chore: e patches all
* 5882129: Fix basic auth issues for sub frame and sub resources | https://chromium-review.googlesource.com/c/chromium/src/+/5882129
- Add `is_request_for_navigation` param to
ElectronBrowserClient::CreateLoginDelegate().
- Propagate the flag as another undocumented property
in the app.login Event's authenticationResponseDetails object
- Side cleanup: also in CreateLoginDelegate(), use upstream's name
for the `is_request_for_main_frame` param, renamed back in
https://chromium-review.googlesource.com/c/chromium/src/+/3256171
* 5875189: [FSA] Check for DANGEROUS extension types when creating a new file. | https://chromium-review.googlesource.com/c/chromium/src/+/5875189
* chore: node ./script/gen-libc++-filenames.js
* chore: bump chromium in DEPS to 131.0.6758.0
* chore: bump chromium in DEPS to 131.0.6760.0
* chore: update patches
* [A11y] Remove Accessibility Object Model (AOM)
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5896593
* chore: bump chromium in DEPS to 131.0.6762.0
* [heap] Remove deprecated V8 flag
Refs https://chromium-review.googlesource.com/c/v8/v8/+/5904046
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
perf: use ArrayBuffer::Data() API
Replace our `GetBackingStore()->Data()` calls with this instead.
Explained by the V8 docs, ArrayBuffer.Data() is
> More efficient shortcut for GetBackingStore()->Data(). The
> returned pointer is valid as long as the ArrayBuffer is alive.
* feat: add error event for utility process
* chore: use public report api
* chore: fix lint
* doc: mark error event as experimental
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
prefactor: prefer member initializers in asar::Archive
prefactor: prefer member initializers in asar::Archive::FileInfo
prefactor: prefer member initializers in asar::IntegrityPayload
* refactor: CallMethodWithArgs() now takes a span of value handles
* perf: use std::array instead of std::vector to hold Emit arg parameter packs
* chore: remove unused gin_helper::EmitEvent(iso, obj, name, span<Local>)
* chore: iwyu mojom.h headers
* fixup! chore: iwyu mojom.h headers
make previously-indirect include dependency direct
* fixup! fixup! chore: iwyu mojom.h headers
make previously-indirect include dependency direct
* refactor: move scope scaffolding into SettletScope
idea stolen from SpellCheckScope
* refactor: move impl of PromiseBase::RejectPromise() to the cc file
* chore: remove unused #include
refactor: avoid redundant Promise.GetContext calls
Several Promise methods call `GetContext()` multiple times. From looking
at the assembly in obj/electron/electron_lib/promise.o, these redundant
calls are actually being made -- they aren't optmized out.
This PR keeps the return value in a local variable to avoid extra calls.
refactor: take a uint8_t span in ValidateIntegrityOrDie()
Doing some groundwork for fixing unsafe base::File() APIs:
- Change ValidateIntegrityOrDie() to take a span<const uint8_t> arg.
We'll need this to migrate asar's base::File API calls away from the
ones tagged `UNSAFE_BUFFER_USAGE` because the safe counterparts use
span<uint8_t> too.
- Simplify ValidateIntegrityOrDie()'s implementation by using
crypto::SHA256Hash() instead of reinventing the wheel.
Use v8::ArrayBufferView::CopyContents() instead of doing the pointer
math + memcpy() ourselves. This not only solves the buffer warnings,
but may also avoid some additional overhead:
> Copy the contents of the ArrayBufferView's buffer to an
> embedder defined memory without additional overhead that
> calling ArrayBufferView::Buffer might incur.
* fix: Launch apps with XDG_ACTIVATION_TOKEN in ozone/wayland
Ensure apps are launched with the activation token received from
xdg_activation_v1 protocol.
* add focus_launched_process option
* fix: remove use of deprecated v8::String::Value
Upstream marked v8::String::Value as `V8_DEPRECATE_SOON` last month,
so let's stop using it.
The replacement code mostly does the same as v8::String::Value();
but since our test only cares about the length and not the contents,
we get a small perf win of not needing to allocate a char array and
not needing to call Local::String::Write().
Upstream V8_DEPRECATE_SOON:
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5667299kkk
v8::String::Value() implementation:
20226b740b/src/api/api.cc (10883)
History on why we used it:
80c1a9739df49ed30f72
* Update shell/common/gin_converters/file_path_converter.h
Co-authored-by: Robo <hop2deep@gmail.com>
* fixup! Update shell/common/gin_converters/file_path_converter.h
do not return success for all non-Null non-Strings
---------
Co-authored-by: Robo <hop2deep@gmail.com>