Kevin Sawicki
a4f94b89b4
Add comment about Module path
2016-05-23 15:15:39 -07:00
Kevin Sawicki
6ac0151e65
Remove lint warnings
2016-05-23 15:14:55 -07:00
Kevin Sawicki
19fd841c30
🎨
2016-05-23 15:14:55 -07:00
Kevin Sawicki
566b0676bc
Pre-resolve electron require path
2016-05-23 15:14:55 -07:00
Kevin Sawicki
daea448b61
.coffee -> .js
2016-05-23 15:14:55 -07:00
deepak1556
f68d0f324f
deprecate app.allowNTLMCredentialsForAllDomains
2016-05-23 11:44:21 +05:30
deepak1556
62cad610e0
bring back app.allowNTLMCredentialsForAllDomains
2016-05-23 01:52:09 +05:30
Cheng Zhao
67d9ae27c3
Remove the JavaScript wrapper for setContextMenu
2016-05-20 16:18:38 +09:00
Cheng Zhao
8ac93e02c6
Merge pull request #5616 from electron/inherit-zoom
...
Inherit zoomFactor in webview
2016-05-20 00:27:06 +00:00
Cheng Zhao
4193fb1742
Merge pull request #5617 from electron/dont-return-from-on-functions
...
Remove returns from event listeners
2016-05-20 00:26:29 +00:00
Cheng Zhao
844f9e989b
Merge pull request #5611 from jviotti/fix/invalid-archive-asar-exec
...
Override `child_process.execFile` asar patch for `child_process.exec`
2016-05-20 00:24:10 +00:00
Kevin Sawicki
cc7395eea8
Remove returns from event listeners
2016-05-19 15:28:08 -07:00
Kevin Sawicki
4754e4aabb
Add zoomFactor to guest params
2016-05-19 14:32:16 -07:00
Kevin Sawicki
fef2f789cd
🎨
2016-05-19 14:30:53 -07:00
Juan Cruz Viotti
1a27ecdad4
Override child_process.execFile
asar patch for child_process.exec
...
NodeJS implements `child_process.exec` by simply passing the whole
command to `child_process.execFile`. See:
- https://github.com/nodejs/node/blob/master/lib/child_process.js#L90
- https://github.com/nodejs/node/blob/master/lib/child_process.js#L99
Electron patches `child_process.execFile` to add support for `asar`
archives by injecting logic that extracts the required files from the
`asar` to a temporary location before delegating the work to the
original `child_process.execFile`.
In order to decide whether to inject the custom `asar` extracting logic,
Electron makes use of a helper function called `splitPath()`. See:
- https://github.com/electron/electron/blob/master/lib/common/asar.js#L37
If the first argument of the returned array equals `true`, means that
the path is considered to be an `asar` archive, and thus the extraction
logic takes place. The problem is that if the command passed to
`child_process.execFile` *contains* a path to an asar archive, padded
with other commands/arguments, `splitPath()` will consider it to be an
`asar` archive, and will try to extract it, throwing a rightfully
`Invalid package` error.
Fixes: https://github.com/electron/electron/issues/5571
Signed-off-by: Juan Cruz Viotti <jviottidc@gmail.com>
2016-05-19 17:19:36 -04:00
Bruno Queiros
046cb0df8d
🎨 Use the same stack trace for both cases
2016-05-18 19:02:42 -03:00
Bruno Queiros
06e3e65c1b
🎨 Improve error message
2016-05-18 11:00:08 -03:00
Cheng Zhao
87c10b3ac2
Make non-public module accesible via remote
2016-05-18 13:57:48 +09:00
Cheng Zhao
90f52169af
No more need to check for nodeIntegration when creating guest view
2016-05-17 17:06:02 +09:00
Cheng Zhao
c1399f9bdc
Disable webview when nodeIntegration is off
2016-05-17 16:51:06 +09:00
Cheng Zhao
ecbb088ea6
Merge pull request #5542 from stevekinney/standardize-requires
...
Standardize requires
2016-05-16 10:42:12 +09:00
Steve Kinney
0d3d097ce8
💄 Standarize requires in JavaScript API
2016-05-15 09:41:30 -04:00
Steve Kinney
2317b56ac4
💄 Make the power-save-blocker a bit more concise
2016-05-15 09:36:13 -04:00
Ben Gotow
84cce6c2c1
Don't default to "Open", "Save", just let OS decide
2016-05-15 01:03:32 -05:00
Ben Gotow
40c531737d
Add buttonLabel param to showOpen/showSave dialogs
2016-05-15 01:03:32 -05:00
Cheng Zhao
88f3c34412
Merge pull request #5532 from stevekinney/patch-2
...
💄 Use ES6; clean up CoffeeScript conversion in BrowserWindow module
2016-05-15 12:38:28 +09:00
Steve Kinney
fd9c9c3be7
💄 Use spread operator instead of arguments object
2016-05-14 22:33:21 -04:00
Steve Kinney
236810a923
💄 Use ES6; clean up CoffeeScript conversion
...
💄 Destructure app module
Address linting errors
2016-05-14 22:33:20 -04:00
Cheng Zhao
88dc73ec3f
Merge pull request #5533 from stevekinney/patch-3
...
💄 Destructure globalShortcut module
2016-05-15 11:16:19 +09:00
Steve Kinney
c11d18fe06
💄 Destructure globalShortcut module
...
💄 Remove globalShortcut property
Add back the globalShortcut property
2016-05-14 21:53:42 -04:00
Steve Kinney
b1275420a3
Require download_items inline
2016-05-14 19:43:30 -04:00
Steve Kinney
e5036c0988
Use anonymous function for wrapping native classes
2016-05-14 12:28:28 -04:00
Steve Kinney
0785c3bd15
💄 Add spaces to comply with Standard
2016-05-14 11:31:08 -04:00
Steve Kinney
5dc88aa543
💄 Add ES6; Clean up from CoffeeScript conversion
2016-05-14 11:17:46 -04:00
Cheng Zhao
064af6ecb2
Merge branch '1-0-release'
2016-05-11 22:11:08 +09:00
Cheng Zhao
759a46f3d6
Use DoubleIDWeakMap for |rendererFunctions|
2016-05-11 20:40:48 +09:00
Kevin Sawicki
a32f50ef64
Use arrow function for this binding
2016-05-11 12:54:52 +02:00
Kevin Sawicki
1b2b7fc4ce
Listen for devtools-opened on webContents
2016-05-11 12:48:46 +02:00
Cheng Zhao
49ac160ff7
Move createIDWeakMap to v8Util
2016-05-11 19:30:06 +09:00
Cheng Zhao
04d59991b0
Use create function instead of IDWeakMap constructor
2016-05-11 16:15:32 +09:00
Cheng Zhao
2cd41b2f84
Merge branch 'master' of https://github.com/electron/electron
2016-05-11 15:15:15 +09:00
Cheng Zhao
0f52a6da39
Merge branch '1-0-release'
2016-05-11 15:14:56 +09:00
Cheng Zhao
ed70a11ff8
Merge pull request #5477 from danhp/download-bounce
...
Add API: app.dock.downloadFinished(filePath)
2016-05-11 09:41:08 +09:00
Daniel Pham
6dae07b76f
Add API: app.dock.downloadFinished(filePath)
2016-05-10 15:02:56 -04:00
Cheng Zhao
566bb1f708
Turn the exception in protocol.registerStandardSchemes to warning
2016-05-10 09:53:35 +09:00
Cheng Zhao
ab3122ef2a
No need to keep the deprecated APIs
...
They will be removed in next release.
2016-05-10 09:53:35 +09:00
Cheng Zhao
af0afecb45
Merge pull request #5406 from deepak1556/protocol_standard_scheme_patch
...
protocol: fix registerStandardSchemes api
2016-05-09 09:12:35 +09:00
deepak1556
70dac71639
delay protocol object creation
2016-05-08 16:44:14 +05:30
deepak1556
0f2ae385ed
allow protocol module initialization before app ready.
...
* ensure registerStandardSchemes can only be called before app ready
* ensure other protocol methods can only be used after app ready
2016-05-08 01:36:34 +05:30
Steve Kinney
91220f2a98
💄 Simplify conditional check for BrowserWindow
2016-05-07 09:13:40 -06:00