John Kleinschmidt
71c3483f55
Fix AttributeError: 'dict' object has no attribute 'required'
2018-03-15 13:20:41 -04:00
Samuel Attard
4b476f13bb
Revert "Fixes electron/electron#12147" ( #12293 )
...
* Revert "Set appropriate defaults for webview options (#12271 )"
This reverts commit c2673aa970
.
* Revert "Fixes electron/electron#12147 (#12193 )"
This reverts commit f54c94d6c9
.
2018-03-15 16:18:36 +09:00
Birunthan Mohanathas
2681e769a6
Document BrowserView.{destroy,isDestroyed} ( #12274 )
2018-03-15 16:15:56 +09:00
Charles Kerr
c2673aa970
Set appropriate defaults for webview options ( #12271 )
...
* Persist defaults to webPreferences object to JS land can read the inferred values instead of just user defined values
* Test inherited default propogation
* Refactor to remove coupling from fetching values and defaults
* Test description type
* Fix up tests
2018-03-15 13:56:46 +09:00
nous-
f54c94d6c9
Fixes electron/electron#12147 ( #12193 )
2018-03-15 13:29:32 +09:00
Shelley Vohr
9aeb61181a
Fix require on network share path ( #12282 )
...
* first pass at server/network require fix
* refactor for clarity
2018-03-15 11:45:13 +09:00
Jacob Groundwater
1f8de33e75
Change Contact Emails ( #12278 )
2018-03-15 04:37:40 +09:00
Samuel Attard
9ed9885c8d
fix remote setInterval flake ( #12263 )
2018-03-14 14:51:47 +09:00
OJ Kwon
e7181eb89c
feat(powerMonitor): expose interface to query system idle state ( #11807 )
...
* feat(BrowserWindow): expose interface to query system idle state
* test(BrowserWindow): update test cases for querySystemIdle interface
* docs(BrowserWindow): add querySystemIdle interface documentation
* refactor(powerMonitor): move querySystemIdle into powerMonitor
* test(powerMonitor): split test cases for all platform
2018-03-14 14:42:08 +09:00
Samuel Attard
90dc897f71
add missing report.length > 1 assertion ( #12257 )
2018-03-14 13:14:29 +09:00
Samuel Attard
8993a2c6ed
Enable easy rebuild of native modules for unreleased electron ( #12217 )
...
* Enable easy rebuild of native modules for unreleased electron
Sometimes when developing locally (as I found this morning) you want to rebuild native modules
against an unreleased version of Electron (in this case local master). This PR adds a simple
script to launch a local HTTP server that generates and hosts the required header and checksum
files to rebuild modules. So far only tested on macOS but should work on all OS's
* Allow custom port
* clean up serve script
* make optionality more obvious
2018-03-14 12:59:18 +09:00
Hari Juturu
704af29543
Exposing process.env status ( #12166 )
2018-03-14 12:01:40 +09:00
Cheng Zhao
134872e9c1
Merge pull request #12198 from electron/fix_crash_handler
...
Fixed passing of exception to the system crash handler
2018-03-14 11:40:11 +09:00
Robo
e741bc0577
fix crash when using getWebPreferences api with devtools webContents ( #12254 )
2018-03-14 11:19:22 +09:00
Samuel Attard
e62349cffb
Merge pull request #12253 from felixrieseberg/fix-last-crash-report
...
fix: Ensure that `getLastCrashReport()` is actually the last crash report
2018-03-14 10:36:27 +09:00
Samuel Attard
8664dd2139
Merge pull request #12190 from electron/fix-double-preload-master
...
Ensure that a document has been created before sending IPC messages
2018-03-14 10:34:05 +09:00
Felix Rieseberg
ee67211035
🔧 Linter's gotta lint
2018-03-13 17:41:02 -07:00
Felix Rieseberg
582ef30b4a
👷 Tests, how do they work
2018-03-13 17:35:55 -07:00
Felix Rieseberg
1b3568e66e
👷 Fancy test
2018-03-13 17:28:15 -07:00
Felix Rieseberg
3575dae75c
🔪 Cut typo
2018-03-13 16:58:40 -07:00
Felix Rieseberg
673335de4b
🔧 Actually test the method
2018-03-13 16:51:20 -07:00
Vanessa Yuen
48dd8f96b7
Fix broken links ( #12232 )
...
* Update system-preferences.md
* Fix broken documentation links.
2018-03-14 08:07:36 +09:00
Felix Rieseberg
72579f9bab
🔧 Sort crashes
2018-03-13 13:57:12 -07:00
John Kleinschmidt
5a81cfbbc6
Merge pull request #12241 from electron/sw-file-scheme-flaky-patch
...
spec: isolate sw file scheme spec storage with temp partition
2018-03-13 13:30:43 -04:00
deepak1556
c3bcb606a9
spec: isolate sw file scheme spec storage with temp partition
2018-03-14 02:03:55 +09:00
Samuel Attard
8e07e7483f
Merge pull request #12228 from electron/fix-window-open-not-showing
...
Parent's visibility trumps inherited 'show' option
2018-03-13 17:41:00 +09:00
Charles Kerr
e400585a0e
Apply further ES6 bikeshedding
2018-03-13 17:09:47 +09:00
Shelley Vohr
e648662cfd
Add config for trop (backporting bot) ( #12238 )
...
* add config for trop
* backportWhitelist => authorizedUsers
2018-03-13 16:39:50 +09:00
Charles Kerr
2d90e763ad
Use idiomatic ES6 when merging options
2018-03-13 16:23:39 +09:00
Charles Kerr
379bd79de4
Remove unnecessary work when merging options
2018-03-13 16:18:50 +09:00
Charles Kerr
e4d5ae53fc
Add tests
2018-03-13 15:55:48 +09:00
Felix Rieseberg
71795ecc62
fix: Incorrect warnings in webviews ( #12234 )
...
* 🔧 Get correct webContents
* 🔧 Err, webPreferences
2018-03-13 10:55:32 +09:00
Charles Kerr
685948bcaa
Parent's visibility trumps inherited 'show' option
2018-03-13 00:28:34 +09:00
Charles Kerr
dd2c2660b9
Fix desktop-id notification edge case ( #12216 )
...
* Fix desktop-id notification edge case
* Extract-method platform_util::GetDesktopName()
This removes duplicated code from libnotify_notifications.cc
and atom/common/linux/application_info.cc.
* Check for empty case in GetDesktopName().
* Move GetDesktopName() to brightray::util
* Remove unnecessary changes in platform_util
* Add a brightray::platform_util namespace
2018-03-12 16:02:47 +09:00
Charles Kerr
86af20ded0
Linux named notifications ( #12192 )
...
* Set name & desktop-entry on Linux notifications
* DBusMock now honors verbose mode flag
* Disable DBus Notification tests on ia32
2018-03-12 09:33:06 +09:00
Phil Freo
9d090e00f2
Make link to related guide/tutorial more obvious ( #12204 )
...
It's generally not a good practice to just link the word "here"
2018-03-10 23:04:07 +09:00
John Kleinschmidt
e085c01a2e
Merge pull request #12202 from electron/readme-heading
...
Add heading for README
2018-03-09 14:29:42 -05:00
Vanessa Yuen
9c0e579bd3
Add heading for README
2018-03-09 20:16:56 +01:00
Robo
06bf72da67
remove process preference lock from AtomBrowserClient ( #12194 )
2018-03-09 12:37:26 -05:00
Ales Pergl
4673c67835
Fixed passing of exception to the system crash handler
2018-03-09 15:46:27 +01:00
John Kleinschmidt
f685e389d3
Merge pull request #12196 from electron/fix_run_as_node
...
Fixed Mac build when enable_run_as_node==false
2018-03-09 09:22:42 -05:00
Ales Pergl
94299f6cd8
Fixed Mac build when enable_run_as_node==false
2018-03-09 13:33:04 +01:00
deepak1556
2bf1131dab
add NOLINT rule for include order in renderer_client_base
2018-03-09 15:19:07 +05:30
deepak1556
3cfe66e4c3
move ipc use from rvh to rfh
2018-03-09 15:01:09 +05:30
Charles Kerr
0d12fc3033
Make the linter happy
2018-03-09 17:03:00 +09:00
Cheng Zhao
30405a3441
Merge pull request #12101 from electron/upgrade-node-v9.7.0
...
Update to node v9.7.0
2018-03-09 16:41:23 +09:00
Cheng Zhao
e79b18762e
Enter context scope before InternalCallbackScope
2018-03-09 16:14:24 +09:00
Cheng Zhao
83f01096c0
When a render process is crashed, it might be reused
2018-03-09 16:13:51 +09:00
Cheng Zhao
5d2452608d
Use InternalCallbackScope for ticking event loop
2018-03-09 15:23:40 +09:00
deepak1556
50a5a69c46
update node ref fixing crash with buffer allocation
2018-03-09 15:23:40 +09:00