Shelley Vohr
a8c0ed890f
feat: surface more webContents text selection commands ( #37978 )
...
* feat: surface more text selection commands
* refactor: use options argument
* docs: correct for review
2023-05-02 21:14:29 -04:00
Robo
da0fd286b4
feat: UtilityProcess API ( #34980 )
...
* chore: initial scaffolding
* chore: implement interface and docs
* chore: address code style review
* fix: cleanup of utility process on shutdown
* chore: simplify NodeBindings::CreateEnvironment
* chore: rename disableLibraryValidation => allowLoadingUnsignedLibraries
* chore: implement process.parentPort
* chore(posix): implement stdio pipe interface
* chore(win): implement stdio interface
* chore: reenable SetNodeOptions for utility process
* chore: add specs
* chore: fix lint
* fix: update kill API
* fix: update process.parentPort API
* fix: exit event
* docs: update exit event
* fix: tests on linux
* chore: expand on some comments
* fix: shutdown of pipe reader
Avoid logging since it is always the case that reader end of
pipe will terminate after the child process.
* fix: remove exit code check for crash spec
* fix: rm PR_SET_NO_NEW_PRIVS for unsandbox utility process
* chore: fix incorrect rebase
* fix: address review feedback
* chore: rename utility_process -> utility
* chore: update docs
* chore: cleanup c++ implemantation
* fix: leak in NodeServiceHost impl
* chore: minor cleanup
* chore: cleanup JS implementation
* chore: flip default stdio to inherit
* fix: some api improvements
* Support cwd option
* Remove path restriction for modulePath
* Rewire impl for env support
* fix: add tests for cwd and env option
* chore: alt impl for reading stdio handles
* chore: support message queuing
* chore: fix lint
* chore: new UtilityProcess => utilityProcess.fork
* fix: support for uncaught exception exits
* chore: remove process.execArgv as default
* fix: windows build
* fix: style changes
* fix: docs and style changes
* chore: update patches
* spec: disable flaky test on win32 arm CI
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2022-10-19 22:49:49 -07:00
Darshan Sen
7493062555
test: add tests for valid electron module names ( #35931 )
...
* test: add tests for valid electron module names
https://github.com/electron/electron/pull/35915 landed without any
tests, so this change adds some. This also documents why these
variations exist.
Signed-off-by: Darshan Sen <raisinten@gmail.com>
* fixup! doc: rephrase comment
Signed-off-by: Darshan Sen <raisinten@gmail.com>
* fixup! test: remove "Uncaught Error:" from error regex
Signed-off-by: Darshan Sen <raisinten@gmail.com>
Signed-off-by: Darshan Sen <raisinten@gmail.com>
2022-10-11 15:59:23 +09:00
Samuel Attard
e31c96a564
fix: only override valid electron module names ( #35915 )
...
Fixes #33014
2022-10-06 19:14:03 +09:00
Jeremy Rose
f82a863f65
feat: replace scroll-touch* with generic input-event ( #35531 )
2022-09-27 12:47:46 -07:00
Milan Burda
99f4a42d41
chore: add missing .eslintrc.json files to limit imports properly ( #35719 )
2022-09-20 13:25:33 -05:00
Milan Burda
8424779906
refactor: don't expose deprecate as an internal module ( #35311 )
2022-08-15 17:09:33 +09:00
Milan Burda
d4e97483aa
refactor: only create webContents after 'will-attach-webview' ( #32941 )
2022-07-21 11:29:31 +02:00
Jeremy Rose
bad8d5e08a
fix: make preload calculation identical between sandbox & non-sandboxed ( #34531 )
2022-06-15 13:22:28 -07:00
Calvin
594dc7e24a
chore: update node types version ( #33452 )
...
* chore: update node types version
* update express types to solve type conflict
* one more yarn.lock type bump
* update another types package to fix incompatible global declarations
* remove incompatible type magicks
* update our ambient types to match the node types
* fix test type
2022-03-28 14:37:35 -07:00
Jeremy Rose
d44a187d0b
feat: remove nativeWindowOpen option ( #29405 )
...
Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
Co-authored-by: Milan Burda <milan.burda@gmail.com>
2022-01-06 09:28:03 -08:00
Charles Kerr
cac871c027
Revert "refactor: only create webContents after 'will-attach-webview' ( #30311 )" ( #31785 )
...
This reverts commit 6e43b0bcbf
2021-11-11 15:04:06 -05:00
Milan Burda
18cc33055d
chore: move libs only used in browser out of common ( #31780 )
2021-11-10 08:54:51 -08:00
Milan Burda
68b8e9be9a
chore: cleanup obsolete lib/common/remote/ipc-messages.ts ( #31756 )
2021-11-09 03:18:44 -08:00
Cheng Zhao
959b657903
chore: remove Node.js patch on Module.globalPaths ( #31275 )
...
* chore: remove Node.js patch on Module.globalPaths
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2021-10-06 09:20:05 +09:00
Robo
2a92d8f962
refactor: only access memory coordinator interface from browser process ( #31295 )
...
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3174305
2021-10-05 15:30:31 -07:00
Jeremy Rose
4fd7c2adcd
feat: make desktopCapturer main-process-only ( #30720 )
...
* feat: make desktopCapturer main-process-only
* remove --enable-api-filtering-logging
* remove test
* merge lib/browser/api/desktop-capturer.ts with lib/browser/desktop-capturer.ts
* remove desktop-capturer-get-sources event
* fix specs
* getSources needs to be async
Co-authored-by: Milan Burda <milan.burda@gmail.com>
2021-10-04 12:16:00 +09:00
Jeremy Rose
55c57808fb
feat: serialize NativeImage over ipc ( #30729 )
2021-09-07 10:37:45 -07:00
Milan Burda
8b7631228f
chore: move native-image.ts back into common ( #30838 )
2021-09-06 11:06:27 +02:00
Jeremy Rose
aa9da78edb
fix: remove ipc wrapper for nativeImage.createThumbnailFromPath ( #30728 )
2021-08-27 14:21:36 -07:00
Milan Burda
501ac15b1d
feat: add <webview>.sendToFrame() / frameId to 'ipc-message' event ( #30451 )
2021-08-25 09:46:46 +02:00
Milan Burda
aad1c0d493
feat: add <webview> 'did-redirect-navigation' event ( #30457 )
2021-08-23 10:26:00 -04:00
Milan Burda
04aafcc5ef
refactor: simplify <webview> event dispatch ( #30458 )
...
* refactor: simplify <webview> event dispatch
* Update lib/browser/guest-view-manager.ts
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
* remove undocumented new-window event properties
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2021-08-17 12:10:27 -04:00
Milan Burda
6e43b0bcbf
refactor: only create webContents after 'will-attach-webview' ( #30311 )
2021-08-03 10:08:49 -07:00
Robo
2b897c8ad8
fix: crash due to race between attach and destruction of webview ( #24344 )
2021-08-02 08:35:57 -07:00
Milan Burda
c68c65f383
refactor: implement <webview> using contextBridge ( #29037 )
...
* refactor: implement <webview> using contextBridge
* chore: address PR feedback
* chore: address PR feedback
* fix: check for HTMLIFrameElement instance in attachGuest
2021-05-15 16:42:07 +09:00
Milan Burda
2c65060ec8
chore: make raw requires type-safe ( #29006 )
...
* chore: make raw requires type-safe
* refactor: no need for separate webViewImplModule
* refactor: no need for separate guestViewInternalModule
2021-05-05 18:05:01 -07:00
Milan Burda
2086e1903c
refactor: 'focus-change' does not need guestInstanceId ( #29001 )
...
* refactor: 'focus-change' does not need guestInstanceId
* refactor: rename internal 'focus-change' event to '-focus-change'
2021-05-05 11:37:40 -07:00
Milan Burda
961b74b2ac
refactor: use "as const" for constant mappings ( #28980 )
2021-05-04 14:12:49 -07:00
Samuel Attard
e5e8ab4eea
refactor: remove more dead code post render process reuse ( #28983 )
...
* Overrides for window.history.*
* Node environment cleanup / creation logic
* Options and switches that are now static values
2021-05-04 11:30:29 -07:00
Jeremy Rose
e12a3cb59c
feat: remove deprecated additionalFeatures ( #28548 )
2021-04-19 15:46:54 -07:00
Jeremy Rose
77dcf1020a
fix: pass postData to new-window event ( #28513 )
2021-04-06 09:54:05 -07:00
Milan Burda
5b205731f6
chore: remove deprecated remote module ( #25734 )
...
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2021-03-09 17:12:40 -08:00
Milan Burda
09d7b2bc91
chore: remove deprecated shell.moveItemToTrash() ( #26723 )
2020-11-30 23:25:03 +03:00
Milan Burda
022bafc485
chore: remove deprecated crashReporter APIs ( #26695 )
2020-11-26 22:07:40 +03:00
loc
0b85fdf26c
feat: add webContents.setWindowOpenHandler API ( #24517 )
...
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2020-11-10 09:06:03 -08:00
Abhishek Shingane
d16e61dc85
fix: window.open not accepting size values with "px" at the end ( #26104 )
...
* fix: use parseInt to parse sizes
* fix: pass radix to parseInt
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: Cheng Zhao <github@zcbenz.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2020-11-02 18:55:59 +09:00
Shelley Vohr
e89abed924
fix: disable use of the vm module in the renderer ( #26087 )
2020-10-23 11:49:52 -07:00
Matt Kane
dfbb88c5f6
fix: pass module resolution paths to wrapped function ( #25891 )
2020-10-14 10:13:45 -07:00
Milan Burda
2c68bad631
refactor: create IPC_MESSAGES enum for IPC message channels ( #25694 )
2020-10-14 00:11:06 +03:00
Milan Burda
fb11a12d5b
refactor: replace a few any-s with proper types ( #25681 )
2020-10-08 03:01:23 +02:00
Milan Burda
db911f29ad
refactor: remove duplicate <webview> event list ( #25697 )
2020-10-06 15:11:26 +02:00
Jeremy Rose
1b6534b326
feat: add shell.trashItem() to replace shell.moveItemToTrash() ( #25114 )
2020-09-02 10:32:33 -07:00
George Xu
beaf60de0a
feat: add nativeImage.createThumbnailFromPath API ( #24802 )
...
* initial commit, mac implementation
* add documentation
* convert createThumbnailFromPath to async function
* windows impl protoype
* add tests
* added test
* fix
* fix test
* clean up
* update docs
* cleaning up code
* fix test
* retrigger CI
* retrigger CI
* refactor from app to native_image
* windows build
* lint
* lint
* add smart pointers, fix test
* change tests and update docs
* fix test, remove nolint
* add renderer-main process routing to fix tests
* lint
* thanks sam
* thanks sam
2020-08-24 09:36:13 -07:00
Samuel Attard
f649e604be
build: tsify asar and move to webpack js2c pipeline ( #24495 )
...
* build: tsify asar and move to webpack js2c pipeline
* build: use the webpack provider for fs-wrapper
2020-07-16 11:38:31 -07:00
Jeremy Rose
36bd940bc3
refactor: ginify NativeImage ( #24486 )
2020-07-13 14:44:12 -07:00
Samuel Attard
ad16e6c647
build: update linting deps ( #24461 )
2020-07-08 21:19:49 -07:00
Jeremy Rose
451086d7f2
chore: tsify extensions shim ( #24355 )
2020-06-30 12:49:08 -07:00
Shelley Vohr
659e79fc08
refactor: prevent consistent early exception ( #24191 )
...
* refactor: prevent consistent early exception
* Use _linkedBinding where possible
* Remove dead electronBinding
2020-06-22 20:32:45 -07:00
Milan Burda
673169a7ba
chore: remove unused deprecate.fnToProperty() ( #24069 )
2020-06-15 18:59:04 -07:00
