Jeremy Apthorp
5bdf97e7ae
test: hide child windows in webview spec ( #23682 )
2020-05-21 11:46:17 -04:00
Cheng Zhao
3137d5f011
test: multiple processes may crash in crashReporter test ( #23695 )
2020-05-21 11:43:47 -04:00
Milan Burda
df53816eea
feat: expose the desktopCapturer module in the main process ( #23548 )
2020-05-20 20:25:49 -04:00
Shelley Vohr
4b23a85475
refactor: correctly serialize nativeImage/buffer with typeUtils ( #23666 )
...
* refactor: correctly serialize nativeImage/buffer with typeUtils
* test: add serialization specs
* fix: construct from dataURL
* test: test for dataURL specificity
2020-05-20 13:42:42 -07:00
Alexey Kuzmin
33d6a99d40
test: call "expect()" on a correct call stack ( #23675 )
2020-05-20 22:18:48 +02:00
LuoJinghua
9d851b8791
net: Don't ignore the referer header in net.request ( #23386 )
2020-05-20 13:28:38 -04:00
Jeremy Apthorp
de44d28c8e
refactor: ginify Session ( #23569 )
2020-05-19 10:18:12 -07:00
Jeremy Apthorp
3f3a760a01
test: bind to 127.0.0.1 in contextBridge spec ( #23639 )
2020-05-19 10:17:40 -07:00
Jeremy Apthorp
01579cc8ed
test: add retries to another beforeunload test ( #23644 )
2020-05-19 11:06:19 +09:00
Jeremy Apthorp
c00103d274
test: fix multiple connections in inspector test ( #23648 )
...
* test: fix multiple connections in inspector test
* debug log
2020-05-19 11:05:49 +09:00
Jeremy Apthorp
7e841ceb5c
refactor: tsify net module ( #23618 )
2020-05-18 10:22:48 -07:00
John Kleinschmidt
8879a3db58
ci: use longer mocha timeout on WOA testing ( #23633 )
2020-05-18 12:33:54 -04:00
Shelley Vohr
ee0f67d541
fix: nativeImage remote serialization ( #23543 )
...
We weren't serializing nativeImages properly in the remote module, leading to gin conversion errors when trying to, for example, create a new context menu in the renderer with icons using nativeImage. This fixes that by adding a new special case to handle them.
2020-05-18 09:29:24 -07:00
Jeremy Apthorp
8bbb68be79
test: retry beforeunload test ( #23576 )
2020-05-18 11:04:41 -04:00
Milan Burda
52b50e6b33
feat: add app render-process-gone event ( #23560 )
2020-05-17 17:05:05 +02:00
Samuel Attard
9d7ba98209
refactor: remove the RenderFrameFunctionStore and use privates to memory manage ( #23592 )
2020-05-15 11:57:40 -07:00
Milan Burda
4afc756094
feat: add contents.getBackgroundThrottling() + backgroundThrottling property ( #21036 )
2020-05-14 15:11:45 +02:00
Milan Burda
7656480247
test: remove usage of the remote module from tests ( #23571 )
2020-05-14 00:33:37 +02:00
Milan Burda
fc468cce3b
test: skip remote module related tests when enable_remote_module = false ( #23557 )
2020-05-13 20:05:44 +02:00
Felix Rieseberg
dcbed18f44
feat: app.getPath('recent') ( #23381 )
...
* feat: getPath("recent")
* test: Add a spec and docs
* fix: Integrate feedback
* fix: Handle path change
* chore: Cut SetRecentPath
2020-05-13 11:27:56 +09:00
Samuel Attard
7f9b7b2e95
chore: clean up context bridge scopes and add specs for internal bridge ( #23334 )
...
* chore: clean up context bridge context scopes
* spec: add specs for internalContextBridge
2020-05-11 13:41:42 -07:00
Milan Burda
653c36b8c9
test: skip "handles Promise timeouts correctly" when ELECTRON_RUN_AS_NODE is disabled ( #23415 )
2020-05-11 14:19:39 -04:00
Alexey Kuzmin
dc3de49a08
spec: fix conditions for some tests ( #23489 )
2020-05-11 10:46:45 +09:00
Pavel Feldman
3c132dc445
chore: handle Browser.close over CDP ( #23436 )
2020-05-08 16:13:32 -07:00
Samuel Attard
091f45b879
chore: fix linting ( #23473 )
2020-05-08 11:30:37 -07:00
Samuel Attard
21900fe4f4
fix: do not initialize any extension related logic in OffTheRecord contexts ( #22772 )
2020-05-08 11:17:28 -07:00
Pavel Feldman
93f6129c80
chore: support --remote-debugging-pipe ( #23433 )
2020-05-07 21:27:55 -07:00
Jeremy Apthorp
06bf0d08dc
fix: crashReporter incompatible with sandbox on Linux ( #23265 )
2020-05-07 13:31:26 -07:00
Robo
a707a3eda3
feat: add enableWebSQL webpreference ( #23311 )
...
* feat: add enableWebSQL webpreference
* chore: update indexedDB test
2020-05-06 12:52:59 -07:00
Sorah Fukumori
f176d2494f
fix: respect system language preferences on Win/macOS ( #23247 )
...
This commit fixes https://github.com/electron/electron/issues/18829
Previously the full preferences set to OS was not given to Chromium.
Also, this commit improves fallback font selection for CJK text.
Chromium uses browser languages to determine fallback fonts on Windows,
especially kanji/han characters in CJK.
For instance, when user sets 'en-US, ja-JP' to Accept-Language,
while Chromium chooses Japanese font for kanji text, but Electron
chooses Chinese font. This is because only the first language was given
to Accept-Language on Electron.
This patch is based on https://github.com/electron/electron/pull/15532
Co-authored-by: Nitish Sakhawalkar <nitsakh@icloud.com>
Co-authored-by: Kasumi Hanazuki <kasumi@rollingapple.net>
Co-authored-by: Nitish Sakhawalkar <nitsakh@icloud.com>
Co-authored-by: Kasumi Hanazuki <kasumi@rollingapple.net>
2020-05-04 10:49:29 -07:00
shelley vohr
0f0cc51b35
refactor: return null when passing empty menu templates ( #23364 )
2020-05-04 08:19:21 -07:00
Jeremy Apthorp
8d0a612265
refactor: remove code for non-native extensions shim ( #23340 )
2020-04-30 09:38:09 -07:00
shelley vohr
f50f725a9c
fix: prevent Menu.buildFromTemplate with empty array ( #23308 )
...
Prevent issues with menu creation and subsequent pane focus from menu bar by preventing menus from being created from an empty array. I can't conceive a valid use case for this, since if one wants to remove a menu they should be be passing null to win.setMenu() or calling win.removeMenu(). This issue is also specific to top-level menus, and not submenus, so the new check and exception is scoped to top-level menus.
2020-04-30 08:29:02 -07:00
Jeremy Apthorp
176a120ec2
test: fix crashReporter test on woa ( #23242 )
...
* test: fix crashReporter test on woa
* disable some tests on woa
2020-04-23 16:08:50 -04:00
Cheng Zhao
cb6a1e2c5e
fix: set default menu in will-finish-launching event ( #23214 )
2020-04-23 10:51:31 -07:00
Jeremy Apthorp
6fa05dd123
test: refactor crashReporter tests ( #23178 )
2020-04-22 15:53:12 -07:00
Samuel Attard
96bf9ce77f
refactor: port parts of window-setup to use ctx bridge instead of being run in the main world ( #23194 )
...
* refactor: port parts of window-setup to use ctx bridge instead of being run in the main world
* chore: update ctx bridge specs for new base numbers
2020-04-22 12:42:51 -07:00
Jeremy Apthorp
c798a6e5d1
fix: block custom window.open when nativeWindowOpen is true ( #23188 )
2020-04-22 10:48:54 -07:00
Samuel Attard
0cbcee6740
fix: ensure that functions are not retained beyond their context being released ( #23207 )
2020-04-21 18:05:01 -07:00
loc
aca2e4f968
refactor: improve feature string parsing ( #23130 )
...
* test: add pre-change snapshot of new-window event
* move to .ts file for easier diff
* refactor: improve feature string parsing logic
* test: update snapshots
* update type names per review
* update comma-separated parse test
* use for loop instead of reduce per review
* tighten up types
* avoid variable guest contents id returnValue in test snapshot
2020-04-21 16:23:00 -04:00
loc
a041882192
test: add test for datalist autofills ( #23110 )
...
* test: add test for datalist autofills
* address style nits
* move fixture to spec-main
2020-04-21 12:28:31 -07:00
Charles Kerr
07654c47ec
fix: use Node's microtasks policy in node_main.cc ( #23153 )
...
Fixes #21515 .
2020-04-21 12:18:22 -07:00
Shelley Vohr
f3dc3997b1
feat: support fullScreen BrowserWindow property ( #23145 )
2020-04-20 20:25:18 -07:00
Shelley Vohr
ba3928103f
spec: fix type errors in devToolsWebContents ( #23187 )
2020-04-20 16:51:27 -07:00
Jeremy Apthorp
2541d62486
chore: remove disable_user_gesture... patch ( #23066 )
2020-04-16 15:22:39 -07:00
Samuel Attard
e4c82fdf2d
Merge pull request from GHSA-h9jc-284h-533g
2020-04-16 14:10:18 -07:00
Electron Bot
3e8d77d564
chore: bump chromium to 98ebf6c3f0b7bd96bdb1a4b42208f (master) ( #22999 )
...
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: Electron Bot <anonymous@electronjs.org>
Co-authored-by: Jeremy Apthorp <nornagon@nornagon.net>
2020-04-13 16:39:26 -07:00
loc
5154e8ff75
fix: enable workaround for nativeWindowOpen hang ( #22825 )
2020-04-13 11:37:41 -04:00
Robo
abbe7417f2
chore: fix type check in systemPreferences module specs ( #23064 )
2020-04-09 15:55:47 -07:00
Cheng Zhao
ca947307db
chore: make WebContentsView take webPreferences as parameter ( #22997 )
...
* chore: add WebContentsView.webContents helper
* chore: no need to handle webContents option
* chore: Create WebContentsView in C++
* chore: make WebContentsView accept web_preferences
* fix: nativeWindowOpen still passes WebContents to BrowserWindow
* chore: no more need of WebContentsViewRelay
* test: WebContentsView now takes options
* fix: avoid creating 2 constructors
2020-04-09 16:01:16 +09:00
Samuel Attard
0d2e967960
feat: expose electron/{process} typed modules ( #22937 )
...
* feat: expose electron/{process} typed modules
* chore: update imports for common modules
* chore: update typescript generator
* chore: remap electron/* to the internal packages
2020-04-06 17:04:09 -07:00
Jeremy Apthorp
0a78ab4b98
refactor: ginify DownloadItem ( #22924 )
2020-04-02 17:22:46 -07:00
Jeremy Apthorp
6159066c26
refactor: ginify Menu ( #22916 )
2020-04-02 16:07:56 -07:00
Samuel Attard
1d158399a6
feat: expose the sameSite value for cookies ( #22789 )
...
* feat: expose the sameSite value for cookies
* Apply suggestions from code review
Co-Authored-By: Charles Kerr <ckerr@github.com>
* Apply suggestions from code review
Align with cookie samesite values for the extensions API
https://developer.chrome.com/extensions/cookies#type-SameSiteStatus
* chore: add tests for sameSite cookies get/set
* chore: update docs parser
* chore: update docs for MessageChannel and MessagePort to have correct process information
* chore: remove LOG warning
* chore: throw error if the string->samesite conversion fails
Co-authored-by: Charles Kerr <ckerr@github.com>
2020-04-02 11:28:43 -07:00
Shelley Vohr
da67cbf551
feat: add property support for remainder of BrowserWindow ( #22771 )
...
Adds property-based support for the remainder of primitive gette/setter pairs on `BrowserWindow`.
Namely:
- `win.simpleFullScreen`
- `win.title`
- `win.visibleOnAllWorkspaces`
- `win.documentEdited`
- `win.representedFilename`
- `win.shadow`
- `win.kiosk`
- `win.menuBarVisible`
2020-04-01 08:22:32 -07:00
Cheng Zhao
14051ff945
test: do not trigger unhandled promise rejections ( #22922 )
2020-04-01 09:45:39 -04:00
Cheng Zhao
e6f2605ad0
fix: webRequest module should work with file:// protocol ( #22903 )
...
* fix: override file:// instead of intercepting
* test: webRequest module should work with file://
* fix: service work with file:// url
* fix: original_response_headers can be null
* fix: only register file:// when necessary
2020-04-01 16:38:40 +09:00
Robo
bac1c7f532
fix: ensure standard schemes are registered in nw service process ( #22867 )
...
* fix: ensure standard schemes are registered in nw service process
Refs https://github.com/electron/electron/pull/20546
* chore: add test
* chore: apply suggestions from code review
Co-Authored-By: Jeremy Apthorp <jeremya@chromium.org>
Co-authored-by: Jeremy Apthorp <jeremya@chromium.org>
2020-03-31 19:33:16 -07:00
Jeremy Apthorp
765c08c600
refactor: ginify Notification ( #22821 )
2020-03-31 11:42:32 -07:00
Samuel Attard
fea3366bc7
fix: propagate preferred color scheme to the renderer ( #22896 )
...
* fix: do not crash if the window is closed syncronously with a nativeTheme change
* fix: propogate preferred color scheme to the renderer and keep it up to date
2020-03-30 15:39:50 -07:00
Jeremy Apthorp
a3e28788ce
refactor: ginify Tray ( #22822 )
...
* refactor: ginify Tray
* lint
* improve argument parsing logic
* remove redundant imports from tray.js
* new Tray produces an instanceof Tray
* make Constructible generic
* lint
* clean up on exit
2020-03-30 10:32:02 +09:00
Jeremy Apthorp
ac501e8194
fix: heap-use-after-free in tray.popUpContextMenu ( #22842 )
2020-03-26 18:30:21 -07:00
Heilig Benedek
74372d65ae
feat: enhance native window.open to match the custom implementation's behavior ( #19703 )
...
Co-authored-by: Andy Locascio <andy@slack-corp.com>
2020-03-26 11:05:45 -07:00
Jeremy Apthorp
b327478cf0
fix: prevent remote from messing with constructor names ( #22820 )
2020-03-25 13:13:10 -07:00
CezaryKulakowski
bdef77bad8
fix: don't allow window to go behind menu bar on mac ( #22770 )
2020-03-25 11:13:43 +09:00
Jeremy Apthorp
07cd70a37e
refactor: ginify powerMonitor ( #22751 )
2020-03-24 09:03:29 -07:00
Samuel Attard
e678794dd0
build: fix beta version bumper logic for betas beyond 10 ( #22810 )
2020-03-24 09:04:12 -04:00
Samuel Attard
af46c1ed8d
fix: allow net requests to use Same-Site cookies ( #22788 )
2020-03-20 16:39:03 -07:00
Samuel Attard
60bd52880f
feat: add support for net requests to use the session cookie store ( #22704 )
2020-03-20 15:56:02 -07:00
Samuel Attard
5d657dece4
build: enable JS semicolons ( #22783 )
2020-03-20 13:28:31 -07:00
Samuel Attard
b87b501161
build: update eslint + eslint plugins ( #22777 )
...
* build: run eslint --fix
* chore: manually fix all hasOwnProperty errors
* chore: manually fix all void 0 vs undefined errors
* chore: manually fix all async-in-promise errors
* chore: manually fix lexical declaration in case block
2020-03-20 11:12:18 -04:00
Samuel Attard
aa15a2cc03
build: update typescript and webpack ( #22776 )
2020-03-19 16:55:49 -07:00
Cheng Zhao
47e27aee5b
test: no need to loadURL in menu test ( #22737 )
2020-03-19 10:49:40 +09:00
Jeremy Apthorp
c4a7eade28
refactor: ginify session.netLog ( #22732 )
2020-03-18 16:46:05 -07:00
Samuel Attard
e58a35e5aa
chore: fix net specs when rerunning locally ( #22745 )
2020-03-18 16:35:23 -07:00
Shelley Vohr
fc661ec56b
chore: update app module property support ( #22713 )
2020-03-18 10:06:41 -07:00
Samuel Attard
1ea21e42bb
chore: refactor all the net specs to be async with better error handling ( #22731 )
2020-03-18 08:59:44 -07:00
Shelley Vohr
674e4a9fdd
chore: more modules to dual prop/fn support ( #22688 )
2020-03-17 18:06:52 -07:00
Shelley Vohr
97d8caa1e0
chore: support props/fns for BrowserWindow ( #22686 )
2020-03-16 14:03:35 -07:00
Shelley Vohr
a4c4c86b9d
fix: crash on invalid zoomFactor ( #22673 )
2020-03-13 16:13:05 -07:00
Jeremy Apthorp
9c5874306d
fix: crash when destroying WebContentsView during GC ( #22674 )
2020-03-13 10:33:37 -07:00
Shelley Vohr
1b353d1ed3
chore: revert deprecated WebContents properties ( #22640 )
...
* chore: revert deprecated WebContents properties
* Fix failing zoomFactor test
2020-03-13 10:16:08 -07:00
Jeremy Apthorp
0c02d794c9
feat: add onclose method to MessagePort ( #22532 )
...
* feat: add onclose method to MessagePort
* more scope, more good
* de-flake GC test
2020-03-13 10:00:50 -07:00
Jeremy Apthorp
b4d07f76d3
feat: MessagePorts in the main process ( #22404 )
2020-03-11 18:07:54 -07:00
Erick Zhao
34e004015d
feat: add API to check if session is persistent ( #22622 )
2020-03-11 16:02:22 +09:00
Jeremy Apthorp
19314d3caf
fix: remove catch-all HandleScope ( #22531 )
2020-03-10 18:16:58 -07:00
Shelley Vohr
b607cfa220
test: test setPath for errors thrown ( #22626 )
2020-03-10 09:03:52 -07:00
Alexey Kuzmin
bf75e5a91f
build: fix build without built-in spellchecker ( #22594 )
2020-03-10 18:39:40 +09:00
Erick Zhao
3ff98e15d0
fix: prevent in-memory sessions from writing to custom spellchecker dictionary ( #22157 )
...
* fix: prevent in-memory sessions from writing to custom dictionary
* docs
* spec
2020-03-10 16:45:43 +09:00
Cheng Zhao
8075a55815
test: disable spellchecker context menu test for arm ( #22590 )
2020-03-10 11:13:41 +09:00
Samuel Attard
3e2cec83d9
feat: programmatically modify traffic light positioning ( #22533 )
...
* setter
* getter
* specs and docs
* fixup
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2020-03-05 14:22:12 -08:00
John Kleinschmidt
0201b3e571
feat(extensions): add chrome.tabs.connect API ( #22457 )
...
* feat(extensions): add chrome.tabs.connect API
* test(extensions): verify that chrome.tabs.connect port communication works
2020-03-05 09:59:32 -05:00
John Kleinschmidt
d6701ff435
feat(extensions): add chrome.i18n API ( #22455 )
...
* feat(extensions): implement chrome.i18n API
* refactor(extensions): use forward declaration for ScriptExecutor
* fix(extensions): add message filter to handle i18n GetMessageBundle
* test(extensions): add chrome.i18n tests
* fix(extensions): message filter lint error
* fix: remove exclusive test
* fix(extensions): format api feature arrays
Co-Authored-By: Jeremy Apthorp <nornagon@nornagon.net>
* fix(extensions): uncomment chrome.i18n usage in old extensions test
Co-authored-by: Jeremy Apthorp <nornagon@nornagon.net>
2020-03-05 09:56:21 -05:00
Samuel Attard
2563681583
fix: disable contextBridge object identity caching ( #21803 )
...
* fix: disable contextBridge object identity caching
* cleanup
* chore: make non-const references raw pointers
* fix: zero-param constructors are not explicit
* refactor: use base::LinkedList
Co-authored-by: Jeremy Apthorp <nornagon@nornagon.net>
2020-03-03 23:18:22 -08:00
Electron Bot
39baf68790
chore: bump chromium to 5b340c815ce15ab2efcf277ed19e9 (master) ( #22064 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: loc <andy@slack-corp.com>
Co-authored-by: Robo <hop2deep@gmail.com>
Co-authored-by: Jeremy Apthorp <nornagon@nornagon.net>
2020-03-03 13:35:05 -08:00
Cheng Zhao
0e0c8e7c6f
test: give arm machines more time to load spellchecker ( #22494 )
2020-03-03 15:03:54 +09:00
Erick Zhao
01c597a646
test: add specs for custom dictionary API ( #22158 )
...
* tests
* test: add specs for custom dictionary API
* await
2020-03-02 16:57:46 -08:00
CezaryKulakowski
0bc906853e
fix: call focus on native window on call to webContents.focus on mac ( #22323 )
...
* fix: call focus on native window on call to webContents.focus on mac
On mac call to web_contents()->Focus() is not enough so it's
necessary to call it on native window.
* fixup! fix: call focus on native window on call to webContents.focus on mac
* fixup! fix: call focus on native window on call to webContents.focus on mac
* test: close all windows after test
* fix: also match the behavior on Linux
Co-authored-by: Cheng Zhao <zcbenz@github.com>
2020-03-02 16:51:02 +09:00
Cheng Zhao
4c6150ea3d
fix: make webRequest work for CORS preflight requests ( #22407 )
...
* fix: support CORS preflight
* test: webRequest should work for CORS requests
2020-03-02 10:23:43 +09:00
Shelley Vohr
2c974915a3
fix: do not call close on sheets themselves ( #22410 )
2020-02-28 23:10:21 +00:00
