Samuel Attard
01c442de64
refactor: convert more files to typescript ( #16820 )
2019-02-12 04:22:33 -10:00
Milan Burda
36ce3e9546
feat: promisify webContents.printToPDF() ( #16795 )
2019-02-11 09:20:04 -10:00
Shelley Vohr
e790dbd737
chore: add standalone function deprecation helper ( #16782 )
2019-02-08 09:50:11 -08:00
Shelley Vohr
9ebba76c03
chore: improve existing error preservation in promisify ( #16815 )
...
This PR better preserves existing behavior in `deprecate.promisify()` in the cases where the promise fails. Previously, if a callback was only called with `data` instead of `err, data` and the promise was rejected, `data` would be populated with `err`, which could be confusing to users. This makes it such that `err` is called back on promise rejection if a callback is called with `err, data` a la Node.js.
2019-02-07 10:25:20 -08:00
Milan Burda
4211a9c69f
refactor: use ipcRendererUtils.invokeSync / ipcMainUtils.handleSync ( #16759 )
2019-02-06 09:53:28 -08:00
Milan Burda
6d674eebb1
refactor: crashReporterInit ( #16729 )
2019-02-05 12:56:44 -08:00
michtsu
392458b252
Add devtools API to inspect shared worker. ( #16615 )
2019-02-01 10:44:24 -08:00
Shelley Vohr
5a35c3a279
chore: fix promisify helper ( #16544 )
...
* chore: fix promise deprecation helper
* fix deprecations
* update deprecation tests
2019-01-25 14:23:24 -08:00
Shelley Vohr
3ca87d205f
feat: make zoomLevel/zoomFactor sync ( #16410 )
...
* feat: make zoomLevel/zoomFactor sync
* update ts defs dep
2019-01-20 23:40:27 -08:00
Shelley Vohr
720197f9c8
fix: correctly handle IPC for promise-based methods ( #16433 )
2019-01-17 12:08:54 -08:00
Robo
52fe92d02e
feat: Upgrade to Chromium 71.0.3578.98 ( #15966 )
2019-01-11 17:00:43 -08:00
Alex Greenland
dc93d94bc8
fix: support async child process methods without callback in asar ( #15927 )
...
* fix: support async child process methods without callback in asar
* fix: support async child process methods without callback in asar (improved)
2018-12-18 16:27:39 +09:00
Charles Kerr
f7528a0204
fix: fix an original-fs regression introduced in 4.0 betas ( #16028 )
...
* fix: fix an original-fs regression introduced in 4.0 betas
* chore: remove cruft from earlier draft
2018-12-12 15:32:53 -06:00
Shelley Vohr
4b18a38e9f
chore: simplify promisify helper ( #15952 )
...
chore: simplify promisify helper
2018-12-10 08:13:09 -08:00
Milan Burda
ab2a061b59
refactor: use helpers when using the remote module in sandboxed renderers ( #15960 )
2018-12-05 10:07:32 -08:00
Milan Burda
d561c5531b
feat: deprecate modules internally using remote.require in sandboxed renderer context ( #15145 )
2018-12-05 10:34:09 +01:00
Milan Burda
aa2b2f7c8f
fix: security: don't allow arbitrary methods to be invoked on webContents via IPC ( #15919 )
2018-12-04 16:12:21 +01:00
Samuel Attard
b1e69e1357
chore: update asar injection for new node internal module loader
2018-12-03 20:07:41 +05:30
Shelley Vohr
41c2685204
feat: promisify win.capturePage() ( #15743 )
...
* feat: promisify win.capturePage
* mark optional arg correctly
* Add to breaking changes doc
* properly deprecate win.capturePage
* remove change from api-contract
* document both callback and promise versions
* address docs feedback
* update promisification progress doc
2018-11-27 23:50:53 -05:00
Shelley Vohr
0a5f8611e8
chore: add promise api runtime flag ( #15841 )
...
* chore: add promise api runtime flag
* add promisification plan document
* fix process.md typo
2018-11-26 16:00:46 -05:00
Jeremy Apthorp
90d1c0b2b6
chore: don't explicitly destroy asar archives ( #15734 )
2018-11-19 13:12:41 -08:00
Shelley Vohr
a45d5960d7
chore: allow for callback => promise deprecation ( #15758 )
...
* chore: allow for callback => promise deprecation
* cb type check is sufficient
* migrate warn to always trigger
2018-11-19 12:56:26 -05:00
Jeremy Apthorp
10969b8c3c
fix: make feature strings more robust to whitespace ( #15602 )
...
Fixes #15594
2018-11-06 15:52:06 -08:00
Shelley Vohr
40874ddec6
fix: update fs methods for options param ( #15323 )
...
* fix: update fs methods for options param
* fix: update rest of fs methods with changes
2018-10-23 15:14:05 -07:00
Milan Burda
508551b81b
fix: small refactoring regressions ( #15206 )
...
* fix: require('@electron/internal/browser/guest-view-manager')
* fix: add missing crashServicePid used by tests
2018-10-17 12:18:18 -07:00
Milan Burda
d3efc52745
feat: add webPreferences.enableRemoteModule option ( #13028 )
2018-10-13 20:50:07 +03:00
Felix Rieseberg
d1b2d1a10e
fix: Remove statSyncNoException
for good ( #15092 )
...
* fix: Small JS assignment error
* fix: Call the right og method
* fix: Goodbye, statSyncNoException
2018-10-12 19:43:19 +11:00
Milan Burda
b50f86ef43
refactor: use separate ipc-renderer-internal / ipc-main-internal APIs for Electron internals ( #13940 )
2018-10-07 00:48:00 +13:00
Cheng Zhao
4c4d8c5bfa
fix: support ASAR in fs.copyFile ( #14942 )
2018-10-03 09:36:20 -07:00
Milan Burda
3ad3ade828
refactor: add prefer-const to .eslintrc + fix errors ( #14880 )
2018-10-02 11:56:31 +10:00
Milan Burda
ce38be74df
refactor: simplify process object initialization for sandboxed renderers ( #14878 )
...
Also fix `process.windowsStore`.
2018-09-30 23:24:00 +02:00
Milan Burda
c61db523c7
refactor: replace var with const / let ( #14866 )
2018-09-29 09:17:00 +10:00
Milan Burda
b499d57cfd
refactor: use error-utils for remote exception serialization / deserialization ( #14788 )
...
* refactor: use error-utils for remote exception serialization / deserialization
* fix internal process.type in sandboxed renderer
2018-09-26 15:44:55 +10:00
Milan Burda
3df739fa89
refactor: implement crashReporter.start() without the remote module ( #14434 )
2018-09-26 15:43:34 +10:00
Samuel Attard
176a76217c
chore: have 'use strict' consistently across our lib files ( #14721 )
2018-09-23 00:28:50 +12:00
Samuel Attard
54ef906832
[RFC] perf: use an internal module resolver to improve require performance ( #14633 )
...
* perf: use an internal module resolver instead of relative requires
* perf: memoize the results of getting exported Electron properties
* perf: make internal module changes consistent across sandboxed / bundled files
2018-09-20 13:43:26 +10:00
Samuel Attard
6d01952e66
chore: replace standard with eslint-config-standard and add custom rules ( #14636 )
...
* chore: replace standard with eslint-config-standard
This adds support for --cache so linting JS only takes ~1 second and only lints things that changed
It also allows us to add custom linting rules
* chore: add eslint-plugin-mocha and enable the no-exclusive-tests rule
This will block anyone from pushing / merging a `.only` test or describe
2018-09-16 03:51:23 +10:00
Samuel Attard
558fff69e7
chore: update to standard 12
2018-09-14 14:57:01 +10:00
Charles Kerr
a3f7e298cf
refactor: remove unused, duplicated code in deprecate module ( #14579 )
...
* remove obsolete tests
* remove unused deprecate API
* make a warnOnce helper for the deprecate methods
* misc. copyediting, e.g. variable names, whitespace
* test that any deprecation warns once at most
* use strict
2018-09-12 17:13:22 -05:00
Shelley Vohr
a8a610cb34
chore: remove only on deprecations api spec ( #14564 )
...
* chore: remove only
* add option to ignore missing properties
2018-09-11 23:00:41 -07:00
Shelley Vohr
2157d09956
chore: refactor deprecation apis ( #14495 )
2018-09-11 11:16:49 -07:00
Milan Burda
0821edc843
refactor: cleanup web-frame-init.js ( #14516 )
...
* refactor: add error-utils.js
* fix exception handling for asyncWebFrameMethods
* remove dead code
* handle exceptions
* rename rehydratedError to deserializedError
* Revert "handle exceptions"
This reverts commit 396b179948b137f9e525e9ebba4f7c6e9bf19429.
2018-09-11 19:56:00 +10:00
Alexey Kuzmin
382afc03ae
chore: clean up asar stuff ( #14505 )
...
* chore: reformat code
* refactor: getOrCreateArchive() for ASARs
- store cached archive in a Map
- return `null` instead of `false` on failures
* refactor: splitPath() for ASARs
- store custom extension in a constant
- remove magic numbers
- add comments
* refactor: explicitly use assert() for a developer error
* chore: remove console.log() calls
* refactor: replace "p" arguments with "pathArgument"
"path" would be a better name, but it is already taken
but the "path" Node module.
* refactor: createError() for ASARs
- return an `Error` instance
- use enum for error types
- minor improvements
* refactor: use more meaningful name for an arg than just "arg"
2018-09-10 08:29:19 -07:00
Shelley Vohr
2963e377ae
refactor: clean up asar functionality ( #14046 )
2018-09-07 19:23:47 -07:00
Shelley Vohr
9bf1fb323b
chore: add removeFunction to deprecate module ( #14468 )
...
* chore: add removeFunction function to deprecate api
* re-comment deprecate.member
2018-09-05 21:55:28 -07:00
Milan Burda
3a79eacb6f
refactor: don't expose CallbacksRegistry as an internal module ( #14389 )
2018-08-31 11:29:00 -07:00
Samuel Attard
1b7418fb7b
Revert "sec: deprecate some webPreference defaults to be secure-by-default ( #14284 )" ( #14380 )
...
This reverts commit 66d6ba8689
.
2018-08-30 09:57:49 +12:00
Samuel Attard
66d6ba8689
sec: deprecate some webPreference defaults to be secure-by-default ( #14284 )
...
* feat: deprecate default value of nodeIntegration
* Use DeprecationStatus::Stable as the default instead of shadowing
* change wording of deprecations
* chore: also deprecate kWebviewTag and kContextIsolation
* chore: do as we preach, lets be secure-by-default in the default app
2018-08-29 13:14:04 -05:00
Shelley Vohr
b785f45852
fix: override fs.realpathSync.native and fs.realpath.native ( #14031 )
...
* fix: override fs.realpathSync.native and fs.realpath.native
* spec: test new native functions
2018-08-12 00:10:55 -07:00
Shelley Vohr
8dae1c8447
fix: make asarStatsToFsStats nherit from fs.stats ( #14030 )
2018-08-11 23:20:33 -07:00