Shelley Vohr
9af5072115
chore: remove last instances of base::Bind ( #18178 )
...
* chore: remove last instances of base::Bind
* MessageBoxCallback is a OnceCallback
* convert permission helepr cbs to Once
* convert ResponseCallback to Once
2019-05-29 13:02:15 -07:00
Shelley Vohr
544d8a423c
feat: allow MenuItems to work optionally when hidden ( #16853 )
...
* feat: allow MenuItems to work optionally when hidden
* fix: actually include forward_declaration
2019-02-28 17:00:54 +00:00
deepak1556
535d264497
fix: [UI] Resolve method conflict between MenuModel, SimpleMenuModel::Delegate
...
https://chromium-review.googlesource.com/c/chromium/src/+/1230581
2018-12-03 20:07:39 +05:30
Heilig Benedek
0242818f39
feat: add registerAccelerator flag to allow menu items to optionally skip accelerator registration ( #15723 )
...
* feat: add registerAccelerator flag to allow menu items to skip registration
* docs: add docs for registerAccelerator
* docs: re-add accidentally removed line
2018-11-26 10:43:55 -08:00
Heilig Benedek
aa6f7a5d9f
fix: don't append Shift modifier text twice to accelerators ( #15400 )
...
* fix: don't append Shift modifier text twice to accelerators
* style: use the new way of creating patches
* test: add menu item accelerator display tests
* fix: allocate accelerator on the stack
* fix: adjust tests to match expected behavior on mac
2018-10-31 10:13:44 -04:00
Milan Burda
2337237d58
Refactoring: use C++11 class member variable initialization
2018-05-22 00:18:38 +02:00
Cheng Zhao
7473b612c5
Make Menu API accept TopLevelWindow
2018-04-19 13:08:37 +09:00
Shelley Vohr
53bdf22c85
clang-format atom files
2018-04-18 20:48:45 -04:00
Cheng Zhao
973647eaa2
Rename api::Window to api::BrowserWindow
2018-02-22 12:50:47 +09:00
Cheng Zhao
dc62e51ba4
Fix the cyclic reference in menu delegate ( #11967 )
...
* Fix the cyclic reference in menu delegate
* Fix menu tests due to delegate change
2018-02-20 10:11:35 -06:00
Shelley Vohr
bef4c84799
turn class into observer
2018-01-27 10:40:50 -05:00
Shelley Vohr
3399480304
first pass at menu event emission
2018-01-27 09:35:58 -05:00
Cheng Zhao
46330ac2a9
Remove the closed event of Menu
...
The callback of Menu.popup does more things, and there is actually no
request for the closed event.
2018-01-01 17:22:07 +09:00
Cheng Zhao
7b01a8b860
Add callback parameter to Menu.popup
2018-01-01 16:26:19 +09:00
Heilig Benedek
c586806609
fix flash menu being unresponsive to commands
2017-12-20 15:40:07 +09:00
Birunthan Mohanathas
4e859b4718
Remove "async" option from menu.popup()
...
All menus are async now. See "Cleanup MenuRunner API"
https://codereview.chromium.org/2790773002
2017-11-24 10:58:17 +09:00
Kevin Sawicki
2006e22aa4
🎨
2017-02-22 10:30:28 -08:00
Kevin Sawicki
6a023dc4fe
Add Menu.closePopup API on macOS
2017-02-22 10:30:28 -08:00
Kevin Sawicki
4430927f98
Add async option to menu.popup
2017-02-22 10:30:28 -08:00
Cheng Zhao
cb19efe49c
Pass FunctionTemplate in BuildPrototype
2016-08-02 18:08:12 +09:00
Cheng Zhao
1505a46ed0
Do not rely on Constructor to call Init
...
This makes it deterministic when the JavaScript is initialized, which
can make our logic more clear.
2016-08-02 15:15:40 +09:00
Cheng Zhao
b57665330c
Merge branch 'master' into chrome52
2016-07-21 05:34:36 -06:00
Cheng Zhao
6381f44f26
mac: Pass useDefaultAccelerator to getAcceleratorForCommandId
2016-07-07 11:50:19 -07:00
Cheng Zhao
1ba3907038
Update to API changes of Chrome 52
2016-07-04 15:32:43 +09:00
Cheng Zhao
8d08e215b2
Add "event" parameter for "click" handler of MenuItem
2016-06-22 11:22:14 +09:00
Cheng Zhao
7ba391da7c
Update to API changes of Chrome 51
2016-05-23 10:59:39 +09:00
Cheng Zhao
2ae52d0ff4
Make Wrappable a template class
2016-04-25 10:17:54 +09:00
Cheng Zhao
984462be44
Remove Menu::Popup
2016-01-22 11:59:08 -07:00
Cheng Zhao
ca77c95c6d
No more need to override Menu::Popup
2016-01-22 11:27:17 -07:00
Cheng Zhao
360266ba5b
positioningItem => positioning_item
2016-01-22 10:51:51 -07:00
evgenyzinoviev
072ab0ddea
specify positioning item for popup menus
2016-01-22 03:18:27 +01:00
Cheng Zhao
6795bd1d96
Do not manually manage native resources
...
We should rely on the destructor to cleanup everything, instead of
putting them in the Destroy method.
2015-12-03 15:38:43 +08:00
Cheng Zhao
d56b34de3b
Make sure all native resources get freed on exit
2015-11-04 18:21:03 +08:00
Cheng Zhao
d830badc57
Add role property for MenuItem
2015-09-02 09:42:17 +08:00
Cheng Zhao
4b9ff309ec
Add our own MenuModel class
2015-08-10 12:39:05 +08:00
Cheng Zhao
47e9deeb9a
Remove Menu::AttachToWindow
...
It makes the logic more complex without any benefit
2015-06-04 15:32:33 +08:00
Cheng Zhao
d78efe7c22
Use Local instead of Handle
2015-05-22 19:11:22 +08:00
Cheng Zhao
e81baf759a
Enable setting icon of menu item
2015-02-13 12:11:50 +08:00
Cheng Zhao
b28a241dbf
Simplify the code to call delegate method
2015-02-13 11:47:22 +08:00
Joao Moreno
46e6b5ec3e
Allow positioning the context menu
2014-11-26 13:54:05 +01:00
Cheng Zhao
ab6cb042f6
OVERRIDE => override in atom_api_menu.h
2014-11-16 10:45:53 +08:00
Kevin Sawicki
b6b6fc3bfd
Remove All Rights Reserved after GitHub copyright
...
Closes #762
2014-10-31 11:17:05 -07:00
Cheng Zhao
8d4211bd3a
win: Fix compilation errors for chrome35.
2014-07-11 12:19:01 +08:00
Cheng Zhao
3c892b8591
views: Make acceleratros work.
2014-07-04 16:54:10 +08:00
Cheng Zhao
84878c4c77
Initial work for Aura on Linux.
2014-07-02 22:49:45 +08:00
Cheng Zhao
e0e1d45859
Rename string16 to base::string16.
2014-06-28 19:49:22 +08:00
Cheng Zhao
6c7fe80ec5
Bind TrayIcon to JS.
2014-05-30 23:57:54 +08:00
Cheng Zhao
dfa1ae1c20
win: Update states when setting checked property.
2014-05-26 11:34:36 +08:00
Cheng Zhao
6a48568911
Radio menu items should have at least one item checked.
...
This is to force all platforms to match the same behavior in GTK+.
2014-05-25 15:25:36 +08:00
Cheng Zhao
f176b2c58f
Switch to use MIT license.
2014-05-04 20:29:08 +08:00
