Keeley Hammond
0cb46a3712
fix: add resource strings for file selection ( #31881 )
2021-11-17 14:13:49 -08:00
John Kleinschmidt
6aece4a83d
feat: add support for WebHID ( #30213 )
...
* feat: add support for WebHID
* Apply suggestions from code review
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
* Address review feedback
* Address review feedback
* chore: clear granted_devices on navigation
Also added test to verify devices get cleared
* fixup testing for device clear
* make sure navigator.hid.getDevices is run on correct frame
* clear granted devices on RenderFrameHost deletion/change
* manage device permissions per RenderFrameHost
This change makes sure we don't clear device permission prematurely due to child frame navigation
* Update shell/browser/api/electron_api_web_contents.cc
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
* apply review feedback from @zcbenz
* Match upstream ObjectMap
This change matches what ObjectPermissionContextBase uses to cache object permissions: https://source.chromium.org/chromium/chromium/src/+/main:components/permissions/object_permission_context_base.h;l=52;drc=8f95b5eab2797a3e26bba299f3b0df85bfc98bf5;bpv=1;bpt=0
The main reason for this was to resolve this crash on Win x64:
ok 2 WebContentsView doesn't crash when GCed during allocation
Received fatal exception EXCEPTION_ACCESS_VIOLATION
Backtrace:
gin::WrappableBase::SecondWeakCallback [0x00007FF6F2AFA005+133] (o:\gin\wrappable.cc:53)
v8::internal::GlobalHandles::InvokeSecondPassPhantomCallbacks [0x00007FF6F028F9AB+171] (o:\v8\src\handles\global-handles.cc:1400)
v8::internal::GlobalHandles::InvokeSecondPassPhantomCallbacksFromTask [0x00007FF6F028F867+391] (o:\v8\src\handles\global-handles.cc:1387)
node::PerIsolatePlatformData::RunForegroundTask [0x00007FF6F3B4D065+317] (o:\third_party\electron_node\src\node_platform.cc:415)
node::PerIsolatePlatformData::FlushForegroundTasksInternal [0x00007FF6F3B4C424+776] (o:\third_party\electron_node\src\node_platform.cc:479)
uv_run [0x00007FF6F2DDD07C+492] (o:\third_party\electron_node\deps\uv\src\win\core.c:609)
electron::NodeBindings::UvRunOnce [0x00007FF6EEE1E036+294] (o:\electron\shell\common\node_bindings.cc:631)
base::TaskAnnotator::RunTask [0x00007FF6F2318A19+457] (o:\base\task\common\task_annotator.cc:178)
base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl [0x00007FF6F2E6F553+963] (o:\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:361)
base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork [0x00007FF6F2E6EC69+137] (o:\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:266)
base::MessagePumpForUI::DoRunLoop [0x00007FF6F235AA58+216] (o:\base\message_loop\message_pump_win.cc:221)
base::MessagePumpWin::Run [0x00007FF6F235A01A+106] (o:\base\message_loop\message_pump_win.cc:79)
base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run [0x00007FF6F2E702DA+682] (o:\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:470)
base::RunLoop::Run [0x00007FF6F22F95BA+842] (o:\base\run_loop.cc:136)
content::BrowserMainLoop::RunMainMessageLoop [0x00007FF6F14423CC+208] (o:\content\browser\browser_main_loop.cc:990)
content::BrowserMainRunnerImpl::Run [0x00007FF6F144402F+143] (o:\content\browser\browser_main_runner_impl.cc:153)
content::BrowserMain [0x00007FF6F143F911+257] (o:\content\browser\browser_main.cc:49)
content::RunBrowserProcessMain [0x00007FF6EFFA7D18+112] (o:\content\app\content_main_runner_impl.cc:608)
content::ContentMainRunnerImpl::RunBrowser [0x00007FF6EFFA8CF4+1220] (o:\content\app\content_main_runner_impl.cc:1104)
content::ContentMainRunnerImpl::Run [0x00007FF6EFFA87C9+393] (o:\content\app\content_main_runner_impl.cc:971)
content::RunContentProcess [0x00007FF6EFFA73BD+733] (o:\content\app\content_main.cc:394)
content::ContentMain [0x00007FF6EFFA79E1+54] (o:\content\app\content_main.cc:422)
wWinMain [0x00007FF6EECA1535+889] (o:\electron\shell\app\electron_main.cc:291)
__scrt_common_main_seh [0x00007FF6F6F88482+262] (d:\A01\_work\6\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288)
BaseThreadInitThunk [0x00007FFEC0087034+20]
RtlUserThreadStart [0x00007FFEC1F02651+33]
✗ Electron tests failed with code 0xc0000005.
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2021-09-23 20:00:11 +09:00
Michaela Laurencin
41646d1168
feat: enable windows control overlay on Windows ( #29600 )
...
* rebase "feat: enable windows control overlay on Windows"
* correct compilation error
* fix linting errors
* modify includes and build file
* change `hidden` option to `overlay`
* add patch to fix visual layout
* add button background color parameter
* add button text color parameter
* modify `overlay` in docs and modify button hover/press transition color
* change `text` to `symbol`
* remove todo and fix `text` replacement
* add new titleBarOverlay property and remove titleBarStyle `overlay`
* update browser and frameless window docs
* remove chromium patches
* chore: update patches
* change button hover color, update trailing `_`, update test file
* add dchecks, update title bar drawing checks, update test file
* modify for mac and linux builds
* update docs with overlayColor and overlaySymbolColor
* add corner and side hit test info
* modify docs and copyright info
* modify `titlebar_overlay_` as boolean or object
* move `title_bar_style_ to `NativeWindow`
* update docs with boolean and object titlebar_overlay_
* add `IsEmpty` checks
* move get options for boolean and object checks
* fix linting error
* disable `use_lld` for macos
* Update docs/api/frameless-window.md
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* Update docs/api/frameless-window.md
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* Update docs/api/frameless-window.md
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* Apply docs suggestions from code review
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
* modify `true` option description `titleBarOverlay`
* ci: cleanup keychain after tests on arm64 mac (#30472 )
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2021-08-11 14:07:36 -04:00
Electron Bot
22a70eb803
chore: bump chromium to 92.0.4475.0 (master) ( #28462 )
...
* chore: bump chromium in DEPS to 91.0.4464.0
* chore: rebuild chromium/dcheck.patch with import-patches -3
Mechanical only; no code changes
* chore: remove content_browser_main_loop.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2725153
The function being patched (BrowserMainLoop::MainMessageLoopRun()) no
longer exists.
NB: if removing this introduces regressions the likely fix will be to
add a similar patch for ShellBrowserMainParts::WillRunMainMessageLoop()
which has similar code and was added at the same time this was removed.
* chore: rebuild chromium/put_back_deleted_colors_for_autofill.patch with import-patches -3
Mechanical only; no code changes
* chore: rebuild chromium/disable_color_correct_rendering.patch with import-patches -3
Mechanical only; no code changes
* chore: rebuild chromium/eat_allow_disabling_blink_scheduler_throttling_per_renderview.patch with patch
Mechanical only; no code changes
* chore: rebuild chromium/gpu_notify_when_dxdiag_request_fails.patch with import-patches -3
Mechanical only; no code changes
* chore: rebuild chromium/ui_gtk_public_header.patch manually
no code changes
* chore: rebuild chromium/web_contents.patch with import-patches -3
Mechanical only; no code changes
* chore: remove v8/skip_global_registration_of_shared_arraybuffer_backing_stores.patch
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2763874
This patch has been merged upstream
* chore: export patches
* chore: update add_trustedauthclient_to_urlloaderfactory.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2757969
Sync with removal of render_frame_id_
* chore: sync chromium/put_back_deleted_colors_for_autofill.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2785841
SkColorFromColorId() no longer takes theme, scheme args
* chore: sync chromium/put_back_deleted_colors_for_autofill.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2772143
Change new calls to GetDarkSchemeColor to fit our patched call signature
* chore: update add_trustedauthclient_to_urlloaderfactory.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2757969
Sync with removal of render_frame_id_ in our mojom
* chore: update chromium/frame_host_manager.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2740008
UrlInfo ctor now takes UrlInfo::OriginIsolationRequest instead of a bool
* chore: update chromium/revert_remove_contentrendererclient_shouldfork.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2755314
Upstream has removed `history_list_length_` which we were comparing to 0
to calculate our `is_initial_navigation` bool when calling ShouldFork().
ShouldFork() is ours and none of the code paths actually use that param,
so this commit removes it altogether.
* chore: update permissions_to_register
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2789074
Replace all uses of APIPermission::ID enum with Mojo type
* refactor: update return type of PreMainMessageLoopRun()
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2725153
Used to return void; now returns an int errorcode.
Note: 2725153 also has some nice doc updates about Browser's "stages"
* refactor: sync ElectronBrowserMainParts to MainParts changes
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2725153
RunMainMessageLoopParts has been replaced with WillRunMainMessageLoop
so `BrowserMainLoop::result_code_` is no longer available to us for our
exit_code_ pointer.
This variable held a dual role: (1) of course, hold the exit code, but
also (2) was a nullptr before the message loop was ready, indicating to
anyone calling SetExitCode() that we were still in startup and could
just exit() without any extra steps. exit_code_ still fulfills these two
roles but is now a base::Optional.
* chore: update ElectronBrowserMainParts::PreDefaultMainMessageLoopRun
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2725153
BrowserMainParts::BrowsePreDefaultMainMesssageLoopRun() has been
removed; move that work to the new WillRunMainMessageLoop().
* refactor: stop using CallbackList; it has been removed.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2785973
* refactor: update use of threadpools.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2773408
The upstream code is still in flux (e.g. reverts and re-lands) but the
tl;dr for this commit is (1) include thread_pool.h if you're using it
and (2) don't instantiate pools directly.
* refactor: remove routing_id from CreateLoaderAndStart
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2762858
NB: One logic branch in ProxyingURLLoaderFactory::CreateLoaderAndStart
calls std::make_unique<InProgressRequest>, which needs a routing_id.
This PR uses the member field `routing_id_` since there's no longer one
being passed into CreateLoaderAndStart.
* refactor: sync to upstream ParittionOptions churn
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2771318
PartitionOptions' enums have changed.
* refactor: update Manifest::Location usage
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2771320
tldr: s/Manifest::FOO/ManifestLocation::kFoo/
* chore: bump chromium in DEPS to 91.0.4465.0
* update patches
* refactor: update extensions::Manifest to upstream
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2771320
- extensions::Manifest::COMPONENT
+ extensions::mojom::ManifestLocation::kExternalComponent
* refactor: sync with upstream UrlInfo ctor changes
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2740008
UrlInfo ctor now takes UrlInfo::OriginIsolationRequest instead of a bool
* chore: update invocation of convert_protocol_to_json.py
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2792623
python3 is being used in parts of the upstream build, but the copy of
convert_protocol_to_json.py invoked in v8/third_party/inspector_protocol
is not python3-friendly. Node has a py2+3-friendly version of it in its
tools directory, so call it instead.
* chore: use extensions::mojom::APIPermissionID
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2791122
tldr:
- extensions::APIPermission::kFoo
+ extensions::mojom::APIPermissionID::kFoo
* chore: Remove support for TLS1.0/1.1 in SSLVersionMin policy
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2765737
Remove TLS v1.0 & 1.1 from our SSLProtocolVersionFromString() function.
This is the same change made upstream at
https://chromium-review.googlesource.com/c/chromium/src/+/2765737/8/chrome/browser/ssl/ssl_config_service_manager_pref.cc
* fixup! chore: update ElectronBrowserMainParts::PreDefaultMainMessageLoopRun
* chore: Use IDType for permission change subscriptions.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2791431
tldr: {Subscribe,Unsubscribe}PermissionStatusChange's tag type used to
be an int; now it's the new SubscriptionId type (which is an IdType64).
* chore: sync PowerMonitor code to upstream refactor
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2752635
tldr: PowerMonitor has been split into PowerStateObserver,
PowerSuspendObserver, and PowerThermalObserver to reduce number of tasks
posted to consumers who only need notifications for one of those things
instead of all of them.
* chore: use PartitionOptions's new Cookies field
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2771318
* Revert "refactor: remove routing_id from CreateLoaderAndStart"
This reverts commit 8c9773b87a3c84f9073a47089eb2b6889d745245.
8c9773b was only a partial fix; reverting to start & try again.
* update patches
* chore: bump chromium in DEPS to 91.0.4466.0
* chore: update chromium/accelerator.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2795472
tldr: sync patch with upstream renamed variable & macro names.
* chore: update chromium/gtk_visibility.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2796200
tldr: no code changes; just updating the diff to apply cleanly.
note: ooh upstream Wayland hacking!
* chore: update chromium/picture-in-picture.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2710023
tldr: no code changes; just updating the diff to apply cleanly.
* chore: update chromium/worker_feat_add_hook_to_notify_script_ready.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2775573
tldr: no code changes; just updating the diff to apply cleanly.
* chore: export_all_patches
* chore: update chromium/feat_add_set_theme_source_to_allow_apps_to.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2796511
tldr: NotifyObservers has been renamed to NotifyOnNativeThemeUpdated,
so update the invocation in our patch.
* chore: update ElectronBrowserClient w/upstream API
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2797454
tldr: GetDevToolsManagerDelegate() was returning an owned raw pointer.
Replaced it with CreateDevToolsManagerDelegate() which uses unique_ptr<>.
* chore: handle new content::PermissionType::FILE_HANDLING in toV8()
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2762201
`file-handling` string confirmed in https://chromium-review.googlesource.com/c/chromium/src/+/2762201/18/chrome/browser/ui/webui/settings/site_settings_helper.cc
* refactor: remove routing_id from CreateLoaderAndStart pt 1
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2762858
Part 1: the easiest ones
* 2796724: Support Python3
https://chromium-review.googlesource.com/c/infra/luci/python-adb/+/2796724
* chore: bump chromium in DEPS to 91.0.4468.0
* 2668974: WebShare: Implement SharingServicePicker
https://chromium-review.googlesource.com/c/chromium/src/+/2668974
* 2802766: Apply modernize-make-unique to media/
https://chromium-review.googlesource.com/c/chromium/src/+/2802766
* 2802823: Apply modernize-make-unique to gpu/
https://chromium-review.googlesource.com/c/chromium/src/+/2802823
* 2803041: Apply modernize-make-unique to remaining files
https://chromium-review.googlesource.com/c/chromium/src/+/2803041
* 2798873: Convert GtkKeyBindingsHandler build checks to runtime checks
https://chromium-review.googlesource.com/c/chromium/src/+/2798873
* 2733595: [ch-r] Parse ACCEPT_CH H2/3 frame and restart with new headers if needed
https://chromium-review.googlesource.com/c/chromium/src/+/2733595
* chore: update patch indices
* 2795107: Remove unused PermissionRequest IDs.
https://chromium-review.googlesource.com/c/chromium/src/+/2795107
* chore: bump chromium in DEPS to 91.0.4469.0
* chore: fixup patch indices
* chore: bump chromium in DEPS to 91.0.4469.5
* PiP 1.5: Add microphone, camera, and hang up buttons to the PiP window
https://chromium-review.googlesource.com/c/chromium/src/+/2710023
* fixup! refactor: remove routing_id from CreateLoaderAndStart
* refactor: use URLLoaderNetworkServiceObserver for auth requests from SimpleURLLoader
* fixup! chore: fixup patch indices
* 2724817: Expand scope of wasm-eval to all URLs
https://chromium-review.googlesource.com/c/chromium/src/+/2724817
* Fixup patch after rebase
* chore: bump chromium in DEPS to 91.0.4472.0
* 2797341: [ozone/x11] Enabled the global shortcut listener.
https://chromium-review.googlesource.com/c/chromium/src/+/2797341
* 2805553: Reland Add GTK ColorMixers to ColorPipeline P1
https://chromium-review.googlesource.com/c/chromium/src/+/2805553
* 2804366https://chromium-review.googlesource.com/c/chromium/src/+/2804366
* 2784730: Fix crash on AX mode change in NativeViewHost without a Widget
https://chromium-review.googlesource.com/c/chromium/src/+/2784730
* chore: update patch indices
* 2810174: Add PdfAnnotationsEnabled policy.
https://chromium-review.googlesource.com/c/chromium/src/+/2810174
* 2807829: Allow capturers to indicate if they want a WakeLock or not.
https://chromium-review.googlesource.com/c/chromium/src/+/2807829
* chore: bump chromium in DEPS to 92.0.4473.0
* chore: bump chromium in DEPS to 92.0.4474.0
* chore: bump chromium in DEPS to 92.0.4475.0
* chore: update patches
* chore: updates patches
* chore: update is_media_key patch to handle new ozone impl
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2797341
* fix: ExecuteJavascript requests now need to be flagged as non-bf-aware
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2787195
* chore: icon_util_x11 is now icon_util_linux
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2791362
* build: update sysroots
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2628496
* build: fix missing symbols on linux build
* use_ozone and use_x11 are not exclusive
* new button view to build for pip
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2797341
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2804366
* chore: fix broken gtk_util color patch
* chore: remove patch conflict
* build: update linux manifests
* chore: build bttlb on all platforms for pip
* chore: add thread_pool include for views delegate win
* chore: fix lint
* chore: add node patches for V8 changes
* build: add missing base include on windows
* fix: update frame host manager patch for new state transitions
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2714464
* chore: update windows zip manifests
* chore: update mac zip manifests
* chore: fix patch linting
* refactor: implement missing URLLoaderNetworkServiceObserver methods
It is against The Mojo Rules to leave hanging callbacks. These always
have to be called.
Refs: 186528aab92622e91c4493077afbfb4e33ee0ad3https://chromium-review.googlesource.com/c/chromium/src/+/2709931
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: Samuel Attard <sattard@slack-corp.com>
2021-04-15 10:44:35 -07:00
John Kleinschmidt
c5a41defbd
fix: enable navigator.setAppBadge/clearAppBadge ( #27067 )
2021-01-21 14:45:06 +09:00
Electron Bot
46f3491c7d
chore: bump chromium to 6b9fa6b352d824d052222e1abe541 (master) ( #25558 )
...
* chore: bump chromium in DEPS to d5c9bf9e2a18fa508201a88e5803bec1d107b1ae
* chore: bump chromium in DEPS to 45f1316afae33e52c92480b34bf4f7fe4a7db898
* update patches
* WillCreateURLLoaderFactory now gets a ukm_source_id
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2346803
* ink_drop_visible_opacity -> GetInkDropVisibleOpacity
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2415368
* chore: bump chromium in DEPS to ddb5b6db5e35ab1a7b5adbd9f15373af6c35ea2a
* 2418471: PDF Viewer update: Add missing aria-labels to various buttons.
https://chromium-review.googlesource.com/c/chromium/src/+/2418471
* update printing.patch given print settings mojoification
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2409467
* update patches
* content::BluetoothChooser::Event -> content::BluetoothChooserEvent
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2387901
* set_ink_drop_base_color -> SetInkDropBaseColor
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2419388
* chore: bump chromium in DEPS to ecf7c9ee830d4d85f300b461a2fa13aa40c79a4c
* update patches
* gfx::ConvertPointToPixel -> gfx::ConvertPointToPixels
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2418568
* remove ContentSettingsObserver::AllowStorage()
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2401847
* service_manager::kCrashDumpSignal -> kCrashDumpSignal
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2417073
* chore: bump chromium in DEPS to abdb7ebe5f8c8328b8f435283df90d0a3ecff7bd
* chore: bump chromium in DEPS to 2a7e138ab1066534ceb2622e8a9d2c8ebf574215
* chore: bump chromium in DEPS to ab1884e75ced904e4276851eb4e1ad89919ca93b
* chore: bump chromium in DEPS to a12413902380dcc2a73ac74d582328280a8af686
* Fixup printing patch
https://chromium-review.googlesource.com/c/chromium/src/+/2428623
* Fixup OSR patch
https://chromium-review.googlesource.com/c/chromium/src/+/2415128
* Make ExtensionURLLoaderFactory always owned by its |receivers_|.
https://chromium-review.googlesource.com/c/chromium/src/+/2357523
* Add deprecated_default_sources_assignment_filter variable
https://chromium-review.googlesource.com/c/chromium/src/+/2416496
* Fixup patch indices
* Remove several references to BrowserPlugin from content
https://chromium-review.googlesource.com/c/chromium/src/+/2401031
* Remove SurfaceEmbeddingTime and LocalSurfaceIdAllocation
https://chromium-review.googlesource.com/c/chromium/src/+/2415128
* Add DragOperation and AllowedDragOperations Mojo types
https://chromium-review.googlesource.com/c/chromium/src/+/2196167
* chore: bump chromium in DEPS to 378450342cf6aa160663d0ce3a178a11b570c25a
* Fixup patch indices
* Remove SurfaceEmbeddingTime and LocalSurfaceIdAllocation
https://chromium-review.googlesource.com/c/chromium/src/+/2415128
* Add DragOperation and AllowedDragOperations Mojo types
https://chromium-review.googlesource.com/c/chromium/src/+/2196167
* 2426564: Remove global sources assignment filter value
https://chromium-review.googlesource.com/c/chromium/src/+/2426564
* Fixup blink_local_frame.patch
* [XProto] Remove a subset of ui/gfx/x/x11.h
https://chromium-review.googlesource.com/c/chromium/src/+/2430328
* Fixup patch indices
* Remove several references to BrowserPlugin from content
https://chromium-review.googlesource.com/c/chromium/src/+/2401031
* Remove lossy ConvertSizeToPixel() methods
https://chromium-review.googlesource.com/c/chromium/src/+/2419534
* serial: Use USB driver name to disambiguate ports
https://chromium-review.googlesource.com/c/chromium/src/+/2413176
* Remove set_sources_filter import
* Fix ModMask usage
* [XProto] Remove usage of all Xlib headers
https://chromium-review.googlesource.com/c/chromium/src/+/2392140
* [XProto] Remove usage of Xlib Visuals
https://chromium-review.googlesource.com/c/chromium/src/+/2429933
* Skip Angle manifest file
https://chromium-review.googlesource.com/c/angle/angle/+/2425197
* Add whole src\third_party\angle\.git directory
This directory is needed in order to properly generate gen/angle/angle_commit.h
* [libvpx] Fix HighBD config on Windows ARM64
https://chromium-review.googlesource.com/c/chromium/src/+/2437745
* update patches
* fix: correct calling convention for Windows on Arm
https://chromium-review.googlesource.com/c/v8/v8/+/2440717
* Add third_party/angle/.git to the archive before adding the rest of the source
* fixup source caching on Windows
* Fixup erroneous close paren
* fixup for goma issues
* This should work
* chore: bump chromium roll manually
https://chromium-review.googlesource.com/c/chromium/src/+/2435142
This landed the day after we paused roller-bot and may resolve the
visibility test flakes that we're seeing. h/t to @jkleinsc for
finding this with me.
* chore: remove obsoleted cherry-pick fix for libvpx
https://chromium-review.googlesource.com/c/chromium/src/+/2437745
* chore: remove obsoleted cherry-pick libvpx patch
https://chromium-review.googlesource.com/c/chromium/src/+/2437745
* chore: re-export patches
* chore: add tracer comment to visibility-stat-spec.
The line numbers between the source and the CI runs don't seem to match
up, so this temp tracer is to help track the source of that difference.
* chore: bump chromium in DEPS to 7c2b8cc3b8638aee8abeb013042a6c1d15b2da6b
* update patches
* impl SortingLSH service
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2425327
* 2446525: [Flash] Remove some Flash APIs
https://chromium-review.googlesource.com/c/chromium/src/+/2446525
* 2440974: Reland "Delete service_manager/embedder/switches.h"
https://chromium-review.googlesource.com/c/chromium/src/+/2440974
* 2359402: Remove ContentBrowserClient::NonNetworkURLLoaderFactoryDeprecatedMap.
https://chromium-review.googlesource.com/c/chromium/src/+/2359402
* 2250506: Implement tabs.removeCSS
https://chromium-review.googlesource.com/c/chromium/src/+/2250506
* 2429143: Remove implicit-conversion-to-integer ConvertRectToPixel() methods.
https://chromium-review.googlesource.com/c/chromium/src/+/2429143
* 2444430: Remove DataElementType::kBlob
https://chromium-review.googlesource.com/c/chromium/src/+/2444430
* 2441964: Clean up WebView public API
https://chromium-review.googlesource.com/c/chromium/src/+/2441964
* 2357523: Make ExtensionURLLoaderFactory always owned by its |receivers_|.
https://chromium-review.googlesource.com/c/chromium/src/+/2357523
* 2461606: Use blink::mojom::PreferredColorScheme instead of blink::PreferredColorScheme
https://chromium-review.googlesource.com/c/chromium/src/+/2461606
* 2461235: a11y inspect reorg: move PropertyFilter struct to a new location
https://chromium-review.googlesource.com/c/chromium/src/+/2461235
* remove flash support
* fix frame_host_manager patch
* fix lint
* remove flash info from docs
* fix build
* fix osr
* chore: bump chromium in DEPS to 9269f9eb1d98d29564c2b2ab97f30c6e148c4e11
* fix visibilityState tests
* 2463049: Replace all uses of web_pref::AutoplayPolicy with mojom::AutoplayPolicy
https://chromium-review.googlesource.com/c/chromium/src/+/2463049
* update patches
* fix tests harder
* 2414921: Add Group and Ungroup functions to Tabs extension API
https://chromium-review.googlesource.com/c/chromium/src/+/2414921
* more test fix
* Remove all keyboard related usage of Xlib
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2436787
* fix linux build
* 2453807: [XProto] Remove usage of Xlib error handling
https://chromium-review.googlesource.com/c/chromium/src/+/2453807
* lint
* fixup! 2453807: [XProto] Remove usage of Xlib error handling
* disable CalculateNativeWinOcclusion on win ci
* remove UploadBlob from docs
* Update appveyor.yml
Co-authored-by: Andy Locascio <andy@slack-corp.com>
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
Co-authored-by: Electron Bot <anonymous@electronjs.org>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2020-10-15 18:30:41 -07:00
Electron Bot
8bbdc224ac
chore: bump chromium to 6d130075d378a64187360ba4e7820 (master) ( #24256 )
...
* chore: bump chromium in DEPS to 7fb9778894d73378bff51087ce869ea5aa6e5d5d
* chore: bump chromium in DEPS to 83da426e53d423f0530fc23433b6d2c4d0548442
* update patches
* remove chromeos-only TtsControllerDelegate
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2255314
* SharedUserScriptMaster -> SharedUserScriptManager
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2258357
* avoid deprecated DISALLOW_COPY_AND_ASSIGN
https://groups.google.com/a/chromium.org/forum/#!msg/cxx/qwH2hxaEjac/TUKq6eqfCwAJ
* chore: bump chromium in DEPS to b2eaf9ff4e6b03267bf279583ea20ceb2b25e9d0
* update patches
* rename GetHighContrastColorScheme -> GetPlatformHighContrastColorScheme
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2250224
* remove vulkan info collection
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2252818
* add max_xcode_version build var
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2264867
* add missing headers
* chore: bump chromium in DEPS to cded18ca1138f7e8efc904f077ddcca34f0135cf
* update patches
* add empty floc blocklist to BrowserProcessImpl
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2240873
* chore: bump chromium in DEPS to f06602226cd80bf677b2ce013a94a2fb7f6ac58d
* chore: bump chromium in DEPS to 747aa4bfc74fc6cf7f08ee72624cd69ae41ae28d
* chore: bump chromium in DEPS to 31c0105e50fcc4e94de33e5c8602c755ace4a32b
* chore: update patches
* Reland "[base] Stop including check.h, notreached.h, etc. in logging.h"
https://chromium-review.googlesource.com/c/chromium/src/+/2264297
* X11 and Ozone: make sure gfx::AcceleratedWidget to be uint32_t
https://chromium-review.googlesource.com/c/chromium/src/+/2260554
* Move zygote from //services/service_manager back to //content
https://chromium-review.googlesource.com/c/chromium/src/+/2252466
* chore: update v8 patches
* [XProto] Remove usage of Shape extension
https://chromium-review.googlesource.com/c/chromium/src/+/2262113
* fixup! add empty floc blocklist to BrowserProcessImpl
* Require macOS 10.15.1 sdk
https://chromium-review.googlesource.com/c/chromium/src/+/2238504
* Use newer Xcode version 11.5.0
* update src cache
* chore: bump chromium in DEPS to 60a9883e35db3f6f91916f0878e88e1849c17b11
* chore: update patches
* Reland "Reland "New toolchain for Windows 10 19041 SDK""
https://chromium-review.googlesource.com/c/chromium/src/+/2255527
* update patches
* Convert raw NonClientFrameViews to unique_ptrs
https://chromium-review.googlesource.com/c/chromium/src/+/2240417
* [printing] Move PrintHostMsg_DidPreviewDocument_Params to print.mojom
https://chromium-review.googlesource.com/c/chromium/src/+/2257035
* chore: bump chromium in DEPS to 12c233c2a85bfa28fb279f390121ba681e52a71b
* chore: update patches
* Removing oppressive language for the directory chrome/browser/apps
https://chromium-review.googlesource.com/c/chromium/src/+/2269822
* Inclusion: rename SpellcheckLanguageBlacklistPolicyHandler
https://chromium-review.googlesource.com/c/chromium/src/+/2267646
* Clean up duplicate WebContents "is fullscreen" functions
https://chromium-review.googlesource.com/c/chromium/src/+/2275148
* Adds icon loading service with sandbox for Windows.
https://chromium-review.googlesource.com/c/chromium/src/+/1987273
* No more Vulkan info collection for UMA on Windows
https://chromium-review.googlesource.com/c/chromium/src/+/2252818
* fix lint
* chore: update buildflag conditions
* chore: bump chromium in DEPS to a837d4c4230ace4f10b2768728f4044b7995dfa5
* update hunspell files
* chore: update patches
* Make content::FileSelectListener a RefCounted
https://chromium-review.googlesource.com/c/chromium/src/+/2275338
* fix build failures on MAS
* update patches
* fixup! Reland "[base] Stop including check.h, notreached.h, etc. in logging.h"
* fix build on windows
* Check for GDI exhaustion if window creation fails
https://chromium-review.googlesource.com/c/chromium/src/+/2244124
* chore: bump chromium in DEPS to 2c9b2a73be4ef9ec22d8b6da8e174cb80753f125
* chore: update patches
* Network Service: Move DeleteCookiePredicate into public folder
https://chromium-review.googlesource.com/c/chromium/src/+/2264186
* chore: bump chromium in DEPS to fa2606299bcc02c362528d26b5dcf8c8a0db0735
* chore: bump chromium in DEPS to d9c235d1227204dbae3708daae851573a3566b94
* chore: bump chromium in DEPS to 2f82c284243c035f49a747fd1ead6c44b4b31093
* chore: update patches
* Move creating the LayerTreeSettings into blink.
https://chromium-review.googlesource.com/c/chromium/src/+/2267720
* chore: bump chromium in DEPS to 914112f1d9af9e4974059dc403da62699a55550f
* update patches
* chore: bump chromium in DEPS to e0bc1ffae6393fc543a2da94c88167df75859b36
* refactor: match upstream print preview handling (#24452 )
* update patches
* chore: bump chromium in DEPS to 0881423156abe084164b51ab58ce93a8bd380524
* update patches
* update patches
* give a type to pendingPromise
* chore: bump chromium in DEPS to 11a8c1534b16d130075d378a64187360ba4e7820
* update patches
* 2272609: Move //services/service_manager/sandbox to //sandbox/policy.
https://chromium-review.googlesource.com/c/chromium/src/+/2272609
* update patches
* fixup! 2272609: Move //services/service_manager/sandbox to //sandbox/policy.
* fixup! 2272609: Move //services/service_manager/sandbox to //sandbox/policy.
* 2264511: Cookies: Update SetCanonicalCookie to return CookieAccessResult
https://chromium-review.googlesource.com/c/chromium/src/+/2264511
* chore: fix setAlwaysOnTop test
The window must be visible for state to be updated properly.
* Revert "Migrate modules/desktop_capture and modules/video_capture to webrtc::Mutex."
https://webrtc-review.googlesource.com/c/src/+/179080
* update patches
Co-authored-by: Andy Locascio <andy@slack-corp.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
Co-authored-by: Electron Bot <anonymous@electronjs.org>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
2020-07-13 21:13:34 -04:00
Samuel Attard
6bcf67e051
feat: enable builtin spellchecker ( #20692 )
...
* chore: add code required to use chromes spellchecker
* chore: fix linting
* chore: manifests needs buildflags now
* chore: add dictionarySuggestions to the context menu event when the spellchecker is active
* chore: enable by default for windows builds
* chore: add patch to remove incognito usage in the spellchecker
* chore: add dependencies on spellcheck common and flags
* chore: conditionally include spell check panel impl
* chore: fix deps for spellcheck feature flags
* chore: add patch for electron resources
* chore: add dependency on //components/language/core/browser
* chore: patches to make hunspell work on windows
* build: collect hunspell dictionaries into a zip file and publish
* chore: clean up patches
* chore: add docs and set spell checker url method
* chore: fix error handling
* chore: fix hash logic
* build: update hunspell filename generator
* fix: default spellchecker list to the current system locale if we can
* docs: document the language getter
* chore: patch IDS_ resources for linux builds
* feat: add spellcheck webpref flag to disable the builtin spellchecker
* chore: fix docs typo
* chore: clean up spellchecker impl as per feedback
* remove unneeded deps
2019-10-31 13:11:51 -07:00
Shelley Vohr
ae6f08d56e
fix: correct 'Entire screen' to ' Entire Screen' ( #20276 )
2019-09-20 10:16:47 -04:00
Heilig Benedek
9ccd6aa0dd
feat: enable picture-in-picture mode for video tags ( #17686 )
...
* feat: enable picture in picture mode for video tags
* test: add test to verify picture in picture support
* lint: fix indent
* fix: clean up after rebase
* test: update test with 16:9 test video
* fix: .paches after rebase
2019-08-22 19:17:50 +09:00
Electron Bot
d008d217f9
chore: bump chromium to 2a7aff41ce73adc0eeee67d364989 (master) ( #18505 )
...
* chore: bump chromium in DEPS to 07463d3cd628b037c11f36022cb4c788db4628e3
* chore: update patches
* fix: Don't leak system network context when nw service is disabled
https://chromium-review.googlesource.com/c/chromium/src/+/1632494
NetworkService is now deleted by using SequnceLocalStorageSlot
on the IO thread when the service is disabled, which expects
all associated NetworkContexts on that sequence to be destroyed.
* chore: bump chromium in DEPS to 7c16850e7e40990e141f47101b737ec1092175a1
* fix: Destroy all network contexts before primary network context
* Simplify out-of-process service registration
https://chromium-review.googlesource.com/c/chromium/src/+/1615882
* [ThreadPool] Rename base::ThreadPool to base::ThreadPoolInstance
https://chromium-review.googlesource.com/c/chromium/src/+/1634851
* chore: update patches
* fix: -Winconsistent-missing-override warnings
* chore: bump chromium in DEPS to 93ebfaccc12715df1d5426797998eed0932f7ae1
* Change CreateBrowserMainParts to return unique_ptrs
https://chromium-review.googlesource.com/c/chromium/src/+/1632532
* chore: update patches
* chore: bump chromium in DEPS to e656555ffb87bdd05e248d0a3ef9dd9d3433e17b
* chore: bump chromium in DEPS to 111e7a8d2e3ae9d70e535009d6afb066ac906063
* chore: bump chromium in DEPS to 9b6b84670d32a7aff41ce73adc0eeee67d364989
* chore: update patches
* chore: remove ShouldInterceptResourceAsStream as it is removed upstream
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1639597
* chore: remove ResourceDispatcherHostCreated as it is removed upstream
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1610892
* chore: CreateWithStrongBinding --> CreateWithSelfOwnedReceiver
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1636722
* chore: rename all blink media enums
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1639237
* chore: add accidentally removed patch content back
2019-06-03 20:44:12 -07:00
Robo
82322968a3
refactor: printing implementation ( #15143 )
...
* refactor: basic printing
* move build files to chromium_src/BUILD.gn
* remove dependency on chrome prerender sources
* spec: move printing specs behind feature flag
* build: register pdf compositor service
2018-11-09 14:42:34 +11:00
Heilig Benedek
a82bcc7e3c
refactor: move printing out of chromium_src ( #15023 )
...
* remove printing related things from chromium_src
* chore: add printing build flag and patch
* fix: include PrintingService on other platforms too
* fix: printing_handler is only needed on Windows
* fix: format BUILD.gn properly
* fix: rename printing build flag to avoid conflict with chromium
* fix: place previously missed printing calls behind build flag
* fix: accidentally renamed flag in patch file
* fix: don't include all printing strings
* fix: allow ShowItemInFolder and OpenItem to block, fixing a DCHECK crash
* fix: make things compile, some changes got lost while rebasing
* fix: remove rogue line from BUILD.gn
* chore: update patch description
* style: lint fix
* chore: use chromium printing buildflag, move node related stuff out of patch
* revert: remove ScopedAllowBlockingForTesting call
* fix: fix my rebase blooper
* fix: re-add header lost during rebase, update patch
* fix: add <map> include, tweak the patch a bit
* revert: remove rogue diff from patch
* fix: clean up after rebase
2018-10-13 12:57:04 +11:00
Jeremy Apthorp
647322e299
native_desktop_media_list.h depends on //chrome/app:generated_resources
2018-10-09 14:38:00 -07:00
Keeley Hammond