Commit graph

6689 commits

Author SHA1 Message Date
Stephen Niedzielski
0b245b96e4 Update docs for globalShortcut.register
Document return value for globalShortcut.register and common failure scenario.

Fix: #3600
2015-11-26 22:38:47 -07:00
Cheng Zhao
42454b07d0 Merge pull request #3595 from jviotti/jviotti/fix/3512/execFile-override-exec-permissions
🐛 Fix missing execution permission bit in execFile override
2015-11-27 11:39:45 +08:00
Juan Cruz Viotti
585ff9062c 🐛 Fix missing execution permission bit in execFile override
Consider an electron application that uses `execFile` to run a script
that lives within the application code base:

```coffee
child_process = require 'child_process'
child_process.execFile __dirname + '/script.sh', (error) ->
  throw error if error?
```

An application like this will fail when being packaged in an `asar` with
an following error:

```
Error: spawn EACCES
```

Electron overrides certain `fs` functions to make them work within an
`asar` package. In the case of `execFile`, the file to be executed is
extracted from the `asar` package into a temporary file and ran from
there.

The problem is that during the extraction, the original permissions of
the file are lost.

We workaround this by:

1. Extending `asar.stat` to return whether a file is executable or not,
  which is information that's already saved in the `asar` header.

2. Setting execution permissions on the extracted file if the above
  property holds true.

Fixes: https://github.com/atom/electron/issues/3512
2015-11-26 23:30:23 -04:00
Plusb Preco
43b73a0ced Merge remote-tracking branch 'refs/remotes/atom/master' 2015-11-27 12:19:47 +09:00
Cheng Zhao
932cd92bf6 Fix wrong deprecation wrappers of BrowserWindow 2015-11-27 10:30:51 +08:00
Cheng Zhao
ed866900e7 Merge pull request #3594 from atom/public-env
Add ELECTRON_RUN_AS_NODE environment variable
2015-11-26 21:51:35 +08:00
Cheng Zhao
59402eb23f Add ELECTRON_NO_ATTACH_CONSOLE env var
Close #1556.
2015-11-26 21:11:28 +08:00
Cheng Zhao
682b48095a docs: Add example 2015-11-26 20:44:07 +08:00
Cheng Zhao
6534a0e616 docs: Add Environment Variables 2015-11-26 20:37:48 +08:00
Cheng Zhao
b1e6d4f64c Check ELECTRON_RUN_AS_NODE env var 2015-11-26 20:37:21 +08:00
Cheng Zhao
5ee9e61445 Update brightray for #1369 2015-11-26 19:10:43 +08:00
Cheng Zhao
a551b8eaaa Merge pull request #3590 from vQuagliaro/doc-windows-open-file
[doc] open-file and open-url events are only available on OS X
2015-11-26 18:34:12 +08:00
Vincent Quagliaro
fe4638ef33 📝 open-file and open-url events are only available on OS X 2015-11-26 09:09:45 +01:00
Cheng Zhao
086734cb57 Merge pull request #3588 from atom/fix-fullscreen-crash
Clears the delegate when window is going to be closed
2015-11-26 14:10:17 +08:00
Cheng Zhao
b0d4aa211d Fix compatibility with activate-with-no-open-windows event 2015-11-26 13:57:48 +08:00
Cheng Zhao
6c1878d15b mac: Clears the delegate when window is going to be closed
Since EL Capitan it is possible that the methods of delegate would get
called after the window has been closed.

Refs atom/atom#9584.
2015-11-26 13:56:56 +08:00
Cheng Zhao
8ce19d8059 Merge pull request #3586 from atom/ipc-fasterer
Ensure calling webview.send will not block the renderer
2015-11-26 13:15:08 +08:00
Cheng Zhao
9c62be8fc9 Improve the deprecation notice for ipc module
Close #3577.
2015-11-26 11:06:56 +08:00
Cheng Zhao
873bfd0538 Merge pull request #3574 from preco21/master
Update as upstream
2015-11-26 11:02:01 +08:00
Cheng Zhao
ec88567683 Merge pull request #3573 from rprichard/fix_3565
Fix https://github.com/atom/electron/issues/3565 by adding a typeof
2015-11-26 11:00:29 +08:00
Paul Betts
789380dfad Ensure calling webview.send will not block the renderer
When the browser process is busy, calling webview.send (a method that appears
on its face to be non-blocking) will actually block, because most webview methods
are remoted to a guest view instance in the browser. Instead, define a few methods
which will instead send its call over an async IPC message.
2015-11-25 15:54:30 -08:00
Plusb Preco
34aecc9327 Update as upstream 2015-11-25 08:55:04 +09:00
Ryan Prichard
0f5a3baff4 Fix https://github.com/atom/electron/issues/3565 by adding a typeof 2015-11-24 16:49:52 -06:00
Cheng Zhao
bf5e9e4f4d Merge pull request #3568 from laiso/fix_docs
docs: s/loadUrl/loadURL/g in docs-translations/
2015-11-24 22:03:46 +08:00
laiso
4acbd3e03f s/loadUrl/loadURL/g in docs-translations/ 2015-11-24 21:02:14 +09:00
Cheng Zhao
b9fd095b04 docs: Mark code blocks 2015-11-24 18:40:50 +08:00
Cheng Zhao
24e892dd17 Update brightray for #3550 2015-11-24 18:39:16 +08:00
Cheng Zhao
bab603d33a Merge pull request #3550 from etiktin/support_proxy_bypass_list
Add support for --proxy-bypass-list command line argument
2015-11-24 18:38:33 +08:00
Cheng Zhao
fe88cb01fc Merge pull request #3531 from deepak1556/fetch_job_nocontent_patch
protocol: handle http responses with no content
2015-11-24 15:45:07 +08:00
Cheng Zhao
a4a14a5f0e Update brightray for #3458 2015-11-24 15:14:48 +08:00
Cheng Zhao
e634dc567e Merge pull request #3561 from preco21/master
Update as upstream
2015-11-24 13:40:16 +08:00
Plusb Preco
6e6cee3ac6 Small fixes 2015-11-24 10:23:52 +09:00
Plusb Preco
6636effb1d Update as upstream
* Update as upstream
* Add caution of translation version
2015-11-24 10:21:30 +09:00
Plusb Preco
d353a3a204 Merge remote-tracking branch 'refs/remotes/atom/master' 2015-11-23 20:34:00 +09:00
Cheng Zhao
c2197d8a05 Merge pull request #3554 from meowlab/docs-fix
docs: Fix deprecated usage tips
2015-11-23 18:19:37 +08:00
Cheng Zhao
9e74b10825 Merge pull request #3548 from dongjoon-hyun/fix_typos_in_koKR_api_ipc_main
Fix typos in Korean api/ipc-main.md
2015-11-23 17:45:48 +08:00
Cheng Zhao
422e40d08c Merge pull request #3544 from dongjoon-hyun/fix_typo
Fix a typo in Korean quick-start tutotial
2015-11-23 17:45:44 +08:00
Cheng Zhao
e98d4c4a2e Merge pull request #3549 from bengotow/fix-hide-others
Remove trailing colons from default menu roles
2015-11-23 17:44:06 +08:00
Plusb Preco
54f16a5568 Merge remote-tracking branch 'refs/remotes/atom/master' 2015-11-23 18:23:15 +09:00
Cheng Zhao
360a747acf Merge pull request #3542 from etiktin/fix_menu_item_using_deprcated_api
Fix menu-item using deprecated API
2015-11-23 17:11:44 +08:00
Cheng Zhao
ba8b448c36 docs: Add indent for items in list
Some markdown renderers require it to be able to render the list
correctly.
2015-11-23 16:59:15 +08:00
Cheng Zhao
634fef2508 Merge pull request #3537 from etiktin/make_BrowserWindow_options_optional
Make BrowserWindow options argument optional
2015-11-23 16:56:30 +08:00
Cheng Zhao
812e105d4f Merge pull request #3535 from etiktin/use_the_correct_docs_version
Use the correct docs version
2015-11-23 16:45:26 +08:00
Cheng Zhao
1a1d5aba94 Merge pull request #3533 from preco21/master
Update as upstream
2015-11-23 16:41:02 +08:00
Sunny
6d46c3a75e docs: Fix deprecated usage tips 2015-11-23 13:40:23 +08:00
Eran Tiktin
baab0486f0 Add documentation for --proxy-bypass-list
Depends on atom/brightray#179
2015-11-22 23:44:20 +02:00
Robo
167f11e797 protocol: handle http responses with no content 2015-11-23 01:07:14 +05:30
Ben Gotow
fbdef9e112 Remove trailing colons from default menu roles
`hideothers` and `unhide` had trailing colons which prevented them from being enabled / working in the default app. #3543
2015-11-22 09:08:35 -08:00
Dongjoon Hyun
df570269e3 Fix typos in Korean api/ipc-main.md 2015-11-22 23:16:56 +09:00
Dongjoon Hyun
10a7ecee46 Add space, too 2015-11-22 19:55:36 +09:00