Milan Burda
d78f37ec8f
refactor: use node scheme imports in spec ( #38487 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com>
2023-06-15 10:42:27 -04:00
Samuel Attard
5d657dece4
build: enable JS semicolons ( #22783 )
2020-03-20 13:28:31 -07:00
Charles Kerr
c83f836faf
refactor: prefer using app.whenReady() ( #21972 )
...
* docs: add references to app.whenReady() in isReady
* refactor: prefer app.whenReady()
In the docs, specs, and lib, replace instances of `app.once('ready')`
(seen occasionally) and `app.on('ready')` (extremely common) with
`app.whenReady()`.
It's better to encourage users to use whenReady():
1. it handles the edge case of registering for 'ready' after it's fired
2. it avoids the minor wart of leaving an active listener alive for
an event that wll never fire again
2020-02-03 22:43:22 +00:00
Jeremy Apthorp
92b9525cfd
feat: enable mixed-sandbox mode by default ( #15894 )
2019-01-22 10:44:28 -08:00
Milan Burda
5bd6de52e0
feat: add app.enableSandbox() ( #14999 )
2018-10-10 15:32:09 +11:00
Milan Burda
3ad3ade828
refactor: add prefer-const to .eslintrc + fix errors ( #14880 )
2018-10-02 11:56:31 +10:00
Samuel Attard
558fff69e7
chore: update to standard 12
2018-09-14 14:57:01 +10:00
John Kleinschmidt
828e317360
Fix flaky sandbox tests
...
Windows apparently has issues running opening two windows at once which is causing flakiness on the mixed sandbox tests.
2018-08-13 09:30:20 -07:00
Hari Juturu
80bd6a3e91
🎨
2017-07-11 18:36:01 -07:00
Hari Juturu
9a3b78d9fe
Fix devtools open in mixed sandbox mode
2017-07-11 18:36:00 -07:00
Kevin Sawicki
5822e718e6
Add finish helper to ensure connection
2017-06-28 09:58:23 -07:00
Kevin Sawicki
523fbe2df9
Send messages between app via socket connection
2017-06-28 09:27:19 -07:00
Kevin Sawicki
7fcc00f137
Add spec for app.enableMixedSandbox()
2017-06-28 08:33:11 -07:00
Kevin Sawicki
0eaddd1565
Verify --enable-sandbox/--no-sandbox command line
2017-06-26 14:12:03 -07:00
Hari Krishna Reddy Juturu
902b34ba39
🎨
2017-06-19 08:03:02 -07:00
Hari Krishna Reddy Juturu
e546820a4a
Completing UTs
2017-06-19 07:46:14 -07:00
Hari Krishna Reddy Juturu
0b7e7458c9
WIP: Adding UT
2017-06-16 15:34:11 -07:00
