Milan Burda 
								
							 
						 
						
							
							
								
							
							
	
	
	455f57322f 
 
						 
						
							
							
								
								
								refactor: use TypeError instead of generic Error when appropriate ( #39209 )  
							
							... 
							
							
							
							refactor: use TypeError instead of generic Error when appropriate 
							
						 
						
							2023-07-25 12:08:46 -04:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	
	
	71fb19ea14 
 
						 
						
							
							
								
								
								chore: upgrade to eslint v8 ( #38472 )  
							
							... 
							
							
							
							chore: upgrade to eslint@8 
							
						 
						
							2023-05-30 13:10:22 +02:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	
	
	82af000a37 
 
						 
						
							
							
								
								
								chore: cleanup eslint suppressions ( #38417 )  
							
							... 
							
							
							
							* chore: cleanup eslint suppressions
* address feedback
* revert script/lib/azput.js
* revert spec/fixtures/apps/remote-control/main.js
* address feedback
* revert typings/internal-ambient.d.ts 
							
						 
						
							2023-05-25 10:09:17 +09:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	
	
	2f79444535 
 
						 
						
							
							
								
								
								refactor: separate WEB_VIEW_ATTRIBUTES / WEB_VIEW_ERROR_MESSAGES ( #36972 )  
							
							
							
						 
						
							2023-01-25 16:08:46 +01:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Jeremy Rose 
								
							 
						 
						
							
							
								
							
							
	
	
	b9464d89b8 
 
						 
						
							
							
								
								
								fix: remove undocumented feature and flaky test for webview resize event ( #36154 )  
							
							
							
						 
						
							2022-10-27 16:44:53 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									daief 
								
							 
						 
						
							
							
								
							
							
	
	
	ff4816367e 
 
						 
						
							
							
								
								
								refactor: handle uncaught promise error ( #35484 )  
							
							
							
						 
						
							2022-10-27 16:16:26 +09:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	
	
	d4e97483aa 
 
						 
						
							
							
								
								
								refactor: only create webContents after 'will-attach-webview' ( #32941 )  
							
							
							
						 
						
							2022-07-21 11:29:31 +02:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	
	
	f172136752 
 
						 
						
							
							
								
								
								chore: remove undocumented page-title-set webview event ( #34533 )  
							
							
							
						 
						
							2022-06-22 17:18:42 +09:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	
	
	99ee1fc0eb 
 
						 
						
							
							
								
								
								fix: will-attach-webview handler modifying params.instanceId does not break <webview> ( #32386 )  
							
							
							
						 
						
							2022-01-12 16:41:20 +09:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Charles Kerr 
								
							 
						 
						
							
							
								
							
							
	
	
	cac871c027 
 
						 
						
							
							
								
								
								Revert "refactor: only create webContents after 'will-attach-webview' ( #30311 )" ( #31785 )  
							
							... 
							
							
							
							This reverts commit 6e43b0bcbf 
							
						 
						
							2021-11-11 15:04:06 -05:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	
	
	fe7f296339 
 
						 
						
							
							
								
								
								refactor: remove duplicate contextIsolation from getWebPreference() ( #31730 )  
							
							
							
						 
						
							2021-11-08 11:57:56 -05:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Jeremy Rose 
								
							 
						 
						
							
							
								
							
							
	
	
	55c57808fb 
 
						 
						
							
							
								
								
								feat: serialize NativeImage over ipc ( #30729 )  
							
							
							
						 
						
							2021-09-07 10:37:45 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	
	
	04aafcc5ef 
 
						 
						
							
							
								
								
								refactor: simplify <webview> event dispatch ( #30458 )  
							
							... 
							
							
							
							* refactor: simplify <webview> event dispatch
* Update lib/browser/guest-view-manager.ts
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
* remove undocumented new-window event properties
Co-authored-by: Jeremy Rose <jeremya@chromium.org> 
							
						 
						
							2021-08-17 12:10:27 -04:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	
	
	6e43b0bcbf 
 
						 
						
							
							
								
								
								refactor: only create webContents after 'will-attach-webview' ( #30311 )  
							
							
							
						 
						
							2021-08-03 10:08:49 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Robo 
								
							 
						 
						
							
							
								
							
							
	
	
	2b897c8ad8 
 
						 
						
							
							
								
								
								fix: crash due to race between attach and destruction of webview ( #24344 )  
							
							
							
						 
						
							2021-08-02 08:35:57 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	
	
	c5ad7ed0cd 
 
						 
						
							
							
								
								
								refactor: remove guestInstanceId from WebPreferences ( #30280 )  
							
							... 
							
							
							
							* refactor: remove guestInstanceId from WebPreferences
* refactor: remove WebViewManager::GetEmbedder 
							
						 
						
							2021-07-28 15:32:53 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	
	
	c68c65f383 
 
						 
						
							
							
								
								
								refactor: implement <webview> using contextBridge ( #29037 )  
							
							... 
							
							
							
							* refactor: implement <webview> using contextBridge
* chore: address PR feedback
* chore: address PR feedback
* fix: check for HTMLIFrameElement instance in attachGuest 
							
						 
						
							2021-05-15 16:42:07 +09:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	
	
	49ef1fe342 
 
						 
						
							
							
								
								
								refactor: use WeakMap instead of hidden V8 properties to store WebViewImpl ( #29049 )  
							
							
							
						 
						
							2021-05-07 17:56:22 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	
	
	25f5c01cec 
 
						 
						
							
							
								
								
								refactor: remove setupWebViewAttributes gymnastics ( #29032 )  
							
							
							
						 
						
							2021-05-07 09:07:47 +02:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	
	
	cbba602eae 
 
						 
						
							
							
								
								
								chore: cleanup dead <webview> related code ( #29039 )  
							
							
							
						 
						
							2021-05-06 13:56:05 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	
	
	dab9a88413 
 
						 
						
							
							
								
								
								refactor: invoke loadURL in SrcAttribute instead of sending IPC directly ( #29031 )  
							
							
							
						 
						
							2021-05-06 13:55:32 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	
	
	2c65060ec8 
 
						 
						
							
							
								
								
								chore: make raw requires type-safe ( #29006 )  
							
							... 
							
							
							
							* chore: make raw requires type-safe
* refactor: no need for separate webViewImplModule
* refactor: no need for separate guestViewInternalModule 
							
						 
						
							2021-05-05 18:05:01 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	
	
	2086e1903c 
 
						 
						
							
							
								
								
								refactor: 'focus-change' does not need guestInstanceId ( #29001 )  
							
							... 
							
							
							
							* refactor: 'focus-change' does not need guestInstanceId
* refactor: rename internal 'focus-change' event to '-focus-change' 
							
						 
						
							2021-05-05 11:37:40 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	
	
	476e908269 
 
						 
						
							
							
								
								
								fix: <webview> focus / blur events don't work with contextIsolation enabled ( #29004 )  
							
							
							
						 
						
							2021-05-05 11:31:44 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	
	
	961b74b2ac 
 
						 
						
							
							
								
								
								refactor: use "as const" for constant mappings ( #28980 )  
							
							
							
						 
						
							2021-05-04 14:12:49 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Shelley Vohr 
								
							 
						 
						
							
							
								
							
							
	
	
	95e26e2fd4 
 
						 
						
							
							
								
								
								refactor: use URL API ( #28583 )  
							
							
							
						 
						
							2021-04-09 14:22:18 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	
	
	5b205731f6 
 
						 
						
							
							
								
								
								chore: remove deprecated remote module ( #25734 )  
							
							... 
							
							
							
							Co-authored-by: Jeremy Rose <jeremya@chromium.org> 
							
						 
						
							2021-03-09 17:12:40 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Jeremy Rose 
								
							 
						 
						
							
							
								
							
							
	
	
	706d9ede9b 
 
						 
						
							
							
								
								
								refactor: only allow internal messages from the main process ( #27676 )  
							
							
							
						 
						
							2021-02-09 17:12:26 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	
	
	79b3393768 
 
						 
						
							
							
								
								
								chore: remove bunch of usages of any ( #27512 )  
							
							
							
						 
						
							2021-01-29 12:41:59 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	
	
	4a5c5843c4 
 
						 
						
							
							
								
								
								fix: <webview> not working with Trusted Types ( #27445 )  
							
							
							
						 
						
							2021-01-25 10:29:25 +09:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	
	
	5ee9cc202b 
 
						 
						
							
							
								
								
								fix: ensure that internal messages are sent from the main process ( #26429 )  
							
							
							
						 
						
							2020-11-12 06:20:01 +03:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Jeremy Rose 
								
							 
						 
						
							
							
								
							
							
	
	
	34156c424c 
 
						 
						
							
							
								
								
								fix: [webview] fix missing properties on events when contextIsolation: true ( #26289 )  
							
							
							
						 
						
							2020-11-04 11:15:20 +09:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	
	
	d25fa7b075 
 
						 
						
							
							
								
								
								refactor: store <webview> attributes as typed Map ( #26307 )  
							
							
							
						 
						
							2020-11-03 15:02:23 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	
	
	2c68bad631 
 
						 
						
							
							
								
								
								refactor: create IPC_MESSAGES enum for IPC message channels ( #25694 )  
							
							
							
						 
						
							2020-10-14 00:11:06 +03:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									David Sanders 
								
							 
						 
						
							
							
								
							
							
	
	
	b194030a34 
 
						 
						
							
							
								
								
								chore: cleanup some typos in comments ( #25770 )  
							
							
							
						 
						
							2020-10-13 10:25:21 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	
	
	fb11a12d5b 
 
						 
						
							
							
								
								
								refactor: replace a few any-s with proper types ( #25681 )  
							
							
							
						 
						
							2020-10-08 03:01:23 +02:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	
	
	db911f29ad 
 
						 
						
							
							
								
								
								refactor: remove duplicate <webview> event list ( #25697 )  
							
							
							
						 
						
							2020-10-06 15:11:26 +02:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	
	
	8df4faa8f0 
 
						 
						
							
							
								
								
								chore: cleanup typings/internal-electron.d.ts ( #25711 )  
							
							
							
						 
						
							2020-10-02 04:52:29 +02:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	
	
	ad16e6c647 
 
						 
						
							
							
								
								
								build: update linting deps ( #24461 )  
							
							
							
						 
						
							2020-07-08 21:19:49 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Shelley Vohr 
								
							 
						 
						
							
							
								
							
							
	
	
	659e79fc08 
 
						 
						
							
							
								
								
								refactor: prevent consistent early exception ( #24191 )  
							
							... 
							
							
							
							* refactor: prevent consistent early exception
* Use _linkedBinding where possible
* Remove dead electronBinding 
							
						 
						
							2020-06-22 20:32:45 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Robo 
								
							 
						 
						
							
							
								
							
							
	
	
	c438b93f18 
 
						 
						
							
							
								
								
								fix: ensure guest-embedder map is updated when webview is removed ( #23342 )  
							
							... 
							
							
							
							There are use cases of webview where the container holding the webview is not
actually destroyed first, instead just webview gets removed from DOM, in such
situations the browser process map is not updated accordingly and holds reference
to stale guest contents, and any window operations like scroll, resize or keyboard
events that has to chain through browser embedder will lead to UAF crash.
Ref: https://github.com/microsoft/vscode/issues/92420  
							
						 
						
							2020-04-30 21:33:14 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	
	
	5d657dece4 
 
						 
						
							
							
								
								
								build: enable JS semicolons ( #22783 )  
							
							
							
						 
						
							2020-03-20 13:28:31 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	
	
	b87b501161 
 
						 
						
							
							
								
								
								build: update eslint + eslint plugins ( #22777 )  
							
							... 
							
							
							
							* build: run eslint --fix
* chore: manually fix all hasOwnProperty errors
* chore: manually fix all void 0 vs undefined errors
* chore: manually fix all async-in-promise errors
* chore: manually fix lexical declaration in case block 
							
						 
						
							2020-03-20 11:12:18 -04:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Shelley Vohr 
								
							 
						 
						
							
							
								
							
							
	
	
	efc11563e8 
 
						 
						
							
							
								
								
								fix: properly forward properties to webview ( #22485 )  
							
							
							
						 
						
							2020-03-03 22:25:14 +00:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	1d596f616d  
						 
						
							
							
								
								
								fix: NativeImage serialization of <webview>.capturePage() result ( #20825 )  
							
							
							
						 
						
							2019-11-12 21:56:17 +01:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	093f2dd4a6  
						 
						
							
							
								
								
								chore: remove deprecated <webview>.getWebContents() ( #20986 )  
							
							
							
						 
						
							2019-11-08 15:46:35 -05:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	f1e7393e30  
						 
						
							
							
								
								
								feat: deprecate <webview>.getWebContents() ( #20726 )  
							
							
							
						 
						
							2019-11-07 09:43:19 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	d090b0cd2d  
						 
						
							
							
								
								
								perf: only access remote module when <webview>.getWebContents() is called ( #20272 )  
							
							
							
						 
						
							2019-09-20 08:54:16 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	81e9dab52f  
						 
						
							
							
								
								
								refactor: replace ipcRendererUtils.invoke() with ipcRendererInternal.invoke() ( #19574 )  
							
							
							
						 
						
							2019-08-23 15:45:50 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Alexandre Lacheze 
								
							 
						 
						
							
							
								
							
							
	e26f366405  
						 
						
							
							
								
								
								Revert: electron/electron#14487 ( #19011 )  
							
							
							
						 
						
							2019-07-11 17:25:26 -05:00