Commit graph

425 commits

Author SHA1 Message Date
Adam Roben
2025b60968 Make devtools work when web security is enabled
These changes bring our copy of devtools_ui.cc in line with
https://chromium.googlesource.com/chromium/src.git/+/43.0.2357.92/chrome/browser/ui/webui/devtools_ui.cc

Without these changes, opening the devtools prints errors like:

    [0602/165604:ERROR:CONSOLE(0)] "Refused to display 'chrome-devtools://devtools/inspector.html?can_dock=true&toolbarColor=rgba(223,223,223,1)&textColor=rgba(0,0,0,1)&experiments=true' in a frame because it set 'X-Frame-Options' to 'DENY'.", source: about:blank (0)
    [0602/165604:ERROR:CONSOLE(1514)] "Uncaught SecurityError: Sandbox access violation: Blocked a frame at "chrome-devtools://devtools" from accessing a frame at "null".  The frame being accessed is sandboxed and lacks the "allow-same-origin" flag.", source: chrome-devtools://devtools/devtools.js (1514)
2015-06-02 16:56:17 -04:00
Cheng Zhao
a9a5765544 Remove trailing space 2015-05-27 15:02:01 +08:00
Cheng Zhao
bf99380c5d Merge pull request #107 from deepak1556/devtools_patch
method to reset devtools agent host
2015-05-26 16:15:04 +08:00
Cheng Zhao
0f64da9dfc Implement NetworkDelegate::OnFirstPartyOnlyCookieExperimentEnabled 2015-05-22 14:56:28 +08:00
Cheng Zhao
66d49a5241 ProxyResolverV8::EnsureIsolateCreated is removed 2015-05-22 14:54:33 +08:00
Cheng Zhao
37bd7fe331 Remove parameter |by_user| in NotificationClosed 2015-05-22 14:51:16 +08:00
Cheng Zhao
0cbf8b6cd2 Implement PermissionManager 2015-05-22 14:50:41 +08:00
deepak1556
145c18f4c8 method to reset agent_host 2015-05-18 19:26:03 +05:30
Paul Betts
a18e5d7d5c Come Correct with memory management 2015-05-05 22:35:48 -07:00
Paul Betts
dbe969b5c5 Fix indentation 2015-05-05 22:28:00 -07:00
Paul Betts
9737ba3e37 Explicitly create HttpAuthHandlerFactory
The CreateDefault method does not set a URLSecurityManager, so the code will
fall-back to disabling all built-in authentication. Instead, use the default
URLSecurityManager which will use IE Security Zones on Windows to determine
whether a URL is part of the Local Intranet zone or on non-Windows, default
proxy rules will be used (i.e. would a default proxy map vs. connect direct).
2015-05-04 15:49:00 -07:00
Cheng Zhao
e65f0941e0 Merge pull request #100 from atom/chrome42
Upgrade to Chrome 42
2015-04-22 12:12:47 +08:00
Paul Betts
a0e5d36305 Free some stuff 2015-04-21 14:09:48 -07:00
Cheng Zhao
7e88fe107d linux: Pass v8 snapshot's fd to child process 2015-04-21 21:43:30 +08:00
Cheng Zhao
90b255f2cd Fix API changes 2015-04-21 18:54:57 +08:00
Paul Betts
5d82bab10d Use DBus to detect indicator, not testing for files like an animal 2015-04-20 15:31:24 -07:00
Paul Betts
7c52838ece Fix the build on OS X 2015-04-20 13:29:10 -07:00
Paul Betts
3357dc0ef7 Set icon for notification, and disable action on Ubuntu 2015-04-20 13:22:18 -07:00
Paul Betts
a31ce8ce50 Make PlatformNotificationService pass along the icon 2015-04-20 13:21:18 -07:00
Paul Betts
b8689dc6cc Add a parameter to ShowNotification for the icon 2015-04-20 13:20:50 -07:00
Robo
4ae52721c4 detecting focus on devtools webcontents 2015-04-01 15:22:53 +05:30
Cheng Zhao
4e14c8634b Fix building on Windows 2015-03-18 12:55:02 +08:00
Cheng Zhao
54e58ae255 Fix compilation on Linux 2015-03-16 14:45:19 +08:00
Cheng Zhao
1a53e293dd Use DevToolsAPI instead of InspectorFrontendAPI
Now InspectorFrontendAPI is available in the iframe, we have to call DevToolsAPI
which delegates the call.
2015-03-11 14:51:37 -07:00
Cheng Zhao
56a1691588 MEDIA_LOOPBACK_AUDIO_CAPTURE renamed to MEDIA_DESKTOP_AUDIO_CAPTURE 2015-03-08 20:04:25 -07:00
Cheng Zhao
bb8da7ec7e Fix browser_context.cc 2015-03-08 19:56:45 -07:00
Cheng Zhao
5e1a4e1222 Fix url_request_context_getter.cc 2015-03-08 19:54:27 -07:00
Cheng Zhao
f04ee342ea Remove RemoteDebuggingServer class 2015-03-08 19:53:37 -07:00
Cheng Zhao
2837b730f2 Fix network_delegate.cc 2015-03-08 19:47:12 -07:00
Cheng Zhao
95f0f25dc4 Fix inspectable_web_contents_impl.cc 2015-03-08 19:38:40 -07:00
Cheng Zhao
a5026907e4 Implement PlatformNotificationService 2015-03-08 19:37:13 -07:00
Cheng Zhao
99e2dbd6e8 Fix inspectable_web_contents_impl.h 2015-03-08 19:13:17 -07:00
Cheng Zhao
8467fee8d8 Fix devtools_manager_delegate.cc 2015-03-08 19:07:53 -07:00
Cheng Zhao
c0356f0269 Fix ui/gfx/geometry headers 2015-03-08 19:02:38 -07:00
Cheng Zhao
5e4c90f264 NotificationError is discarded 2015-02-03 10:57:33 -08:00
Cheng Zhao
1c65f5d7d9 Fix cpplint warning 2015-02-03 10:57:25 -08:00
Cheng Zhao
c874219101 Use the new devtools API 2015-02-03 10:57:25 -08:00
Cheng Zhao
dc01ba5a72 scoped_ptr.PassAs is deprecated 2015-02-03 10:57:25 -08:00
Cheng Zhao
02d632c4f7 Fix change of ShowDesktopNotification API 2015-02-03 10:57:25 -08:00
Cheng Zhao
98bf5bf3ed Implement CheckMediaAccessPermission
Part of the fixes for #1017.
2015-01-23 15:13:04 -08:00
Cheng Zhao
4bbe026d48 register DIR_CACHE and DIR_USER_CACHE in path service 2015-01-18 21:00:47 -08:00
Cheng Zhao
c9463d815c linux: Override DIR_APP_DATA before loading .js 2015-01-18 17:34:36 -08:00
Cheng Zhao
76e3d56760 Make DIR_APP_DATA available on Linux 2015-01-18 17:19:25 -08:00
Cheng Zhao
5b4e5a7e55 Override DIR_USER_DATA as data path 2015-01-18 16:59:57 -08:00
Cheng Zhao
964e1d6bb6 Override DIR_APP_DATA on Linux 2015-01-18 16:42:32 -08:00
Cheng Zhao
167995119a Use current exe's icon as default window icon.
Fixes atom/atom-shell#863.
2015-01-15 15:30:04 -08:00
Cheng Zhao
0e0079956c Add support for --ignore-certificate-errors 2015-01-06 20:36:20 -08:00
Cheng Zhao
1166a56ceb Add a way to custom http cache backend 2015-01-05 13:29:16 -08:00
Cheng Zhao
ff0afc688d Fix devtools window can not minimize
Closes atom/atom-shell#941.
2015-01-04 22:32:49 -08:00
Cheng Zhao
51ef072de5 Implement GetDevToolsManagerDelegate, fixes atom/atom-shell#969 2015-01-02 15:18:24 -08:00
Cheng Zhao
dc86ab58a9 Remove DownloadManagerDelegate
Having a partial implemented DownloadManagerDelegate will cause crashes under
certain places.
2014-12-17 13:13:19 -08:00
Cheng Zhao
2c81fb4719 Fix compilation warnings due to API changes 2014-12-09 22:39:44 -08:00
Cheng Zhao
289d3b54f3 Add DevToolsManagerDelegateA 2014-12-09 22:39:44 -08:00
Cheng Zhao
8ec5b5ad20 DevToolsClientHost is discarded 2014-12-09 22:39:44 -08:00
Cheng Zhao
06eff5cd8c linux: Add a way to set WM_CLASS for devtools window 2014-11-24 16:03:55 +08:00
Cheng Zhao
601ee75bcf linux: Use native window frame for devtools
Fixes atom/atom-shell#646.
2014-11-06 19:08:41 +08:00
Cheng Zhao
c4aebe3ba1 No need to write "virtual" when we have "override" 2014-11-06 19:08:41 +08:00
Frank Hale
513d84cd3e Make devtools window maximizable 2014-11-03 11:10:14 -05:00
Cheng Zhao
dbfa9b5660 mac: Clean delegate before releasing window 2014-11-03 22:12:33 +08:00
Cheng Zhao
b75dc9b08d mac: Close the devtools window before releasing it
Sometime simply releasing it may leave it open for a while.
2014-11-03 22:05:16 +08:00
Cheng Zhao
92244500c6 mac: Clean delegate after closing window 2014-11-03 21:46:59 +08:00
Cheng Zhao
74025ee985 Enable setting devtools to not able to dock 2014-11-03 21:32:11 +08:00
Cheng Zhao
6b49e23312 Fix leaking WebContents from devtools. 2014-10-27 16:42:54 +08:00
Cheng Zhao
7b39673215 No need for "virtual" when "override" is used 2014-10-27 16:39:54 +08:00
Cheng Zhao
f809fef22d OVERRIDE => override 2014-10-23 11:10:39 +08:00
Cheng Zhao
6d62b0960e Fix building on Linux 2014-10-13 11:03:37 +08:00
Cheng Zhao
733931c7ad Fix loading devtools 2014-10-11 19:00:30 +08:00
Cheng Zhao
5bec155c81 Adapt to API changes of Chrome 38 2014-10-11 16:38:27 +08:00
Cheng Zhao
09678cc485 Clean the callback after executed 2014-10-01 15:18:34 +08:00
Cheng Zhao
ea28f518d3 Add handling of user media requests 2014-10-01 11:07:29 +08:00
Cheng Zhao
30025fe6ef Set toolbar color for devtools. 2014-09-09 18:28:02 +08:00
Cheng Zhao
c58bf15345 mac: Send focus/blur event to devtools web contents. 2014-09-09 17:57:23 +08:00
Cheng Zhao
a6627a7286 Add a method in InspectableWebContentDelegate to set icon for devtools window. 2014-09-09 15:29:35 +08:00
Cheng Zhao
f013a98920 views: Use new devtools resizing strategy. 2014-09-01 20:09:08 +08:00
Cheng Zhao
2a8691d981 mac: Use new devtools resizing strategy. 2014-09-01 19:18:12 +08:00
Cheng Zhao
4107089363 Use new devtools resizing strategy from Chrome 37. 2014-09-01 19:15:07 +08:00
Cheng Zhao
f8c8c415eb Fix cpplint warnings. 2014-08-31 20:05:14 +08:00
Cheng Zhao
6010539914 Don't create empty url request job factory. 2014-08-31 19:57:15 +08:00
Cheng Zhao
dca1c51b32 Fix API changes of Chrome37. 2014-08-31 18:43:01 +08:00
Cheng Zhao
47bc6a29a7 Print console output of devtools. 2014-08-28 12:53:35 +08:00
Cheng Zhao
20efd82c98 Implement zoom messages for devtools. 2014-08-26 15:07:06 +08:00
Cheng Zhao
6e420d5137 Cleanup URLRequestContextGetter.
In brightray line length limit is 100 so we could make code formatted more
tidy.
2014-08-20 15:26:53 +08:00
Cheng Zhao
3fefdcba0d Move creation of URLRequestJobFactoryImpl into default delegate. 2014-08-20 14:48:02 +08:00
Cheng Zhao
c30f11f38c Add Delegate for URLRequestContextGetter. 2014-08-20 14:39:09 +08:00
Cheng Zhao
44bfa328f1 Add --proxy-server switch. 2014-08-20 11:49:18 +08:00
Cheng Zhao
d136c44792 Add --no-proxy-server switch. 2014-08-20 11:44:45 +08:00
Cheng Zhao
8c73e6aba4 Implement --host-resolver-rules switch. 2014-08-15 12:42:11 +08:00
Cheng Zhao
052ddd961f Implement --host-rules switch. 2014-08-15 12:30:50 +08:00
Cheng Zhao
b06970fda0 Remove unneeded headers and declarations. 2014-08-13 17:39:25 +08:00
Cheng Zhao
da3bafd490 Pass parameter by pointers when creating job factory.
1. The caller needs to modify protocol_handlers.
2. We need to make sure protocol_handlers and interceptors are not touched
   if user doesn't create a job factory.
2014-08-13 17:31:33 +08:00
Cheng Zhao
604361f93d Pass ProtocolHandlerScopedVector by value. 2014-08-13 16:16:01 +08:00
Cheng Zhao
b95b621dfc Add url_request_context_getter getter for BrowserContext. 2014-08-13 16:09:32 +08:00
Cheng Zhao
3f9f778274 Clean handlers when custom job factory is used. 2014-08-13 16:05:22 +08:00
Cheng Zhao
2d03c983e4 Give user a chance to create custom URLRequestJobFactory. 2014-08-13 15:48:16 +08:00
Cheng Zhao
d01aa51686 using content::BrowserThread 2014-08-13 15:11:23 +08:00
Cheng Zhao
f05199d4e4 Don't be too strict on media requests. 2014-08-11 23:22:49 +08:00
Cheng Zhao
eafa888757 Enable devtools experiments. 2014-08-11 10:42:50 +08:00
Cheng Zhao
760f7ed24f Fix "warning: field 'widget_' is uninitialized when used here". 2014-08-09 09:34:06 +08:00
Cheng Zhao
4ed7934567 mac: Close devtools when web contents is destroyed.
After the BRYInspectableWebContentsView is added as subview to other
NSWindow owned by users, the view_ would not be dealloc when the web
contents got destroyed, which made the devtools window a ghost.
2014-08-08 12:45:26 +08:00
Cheng Zhao
f455798c05 Fix cpplint warnings. 2014-08-07 10:50:50 +08:00
Cheng Zhao
e5a57b02d8 Focus on devtools when it is opened on Mac. 2014-08-07 10:48:02 +08:00
Haojian Wu
5a5c92ad2d Add remote debugging support. 2014-07-30 22:19:05 +08:00
Cheng Zhao
7b6fbff40d Implement BrowserClient::GetDefaultDownloadDirectory(). 2014-07-28 17:48:55 +08:00
Cheng Zhao
a866718b49 Initialize ProxyResolverV8 at very early phrase.
In atom-shell we need to ensure node environment is initialized after the
ProxyResolverV8 has been initialized.
2014-07-28 15:28:38 +08:00
Cheng Zhao
a8e879d0c5 mac: Fix blank page after devtools is opened. 2014-07-28 12:40:38 +08:00
Cheng Zhao
f552dc7ba4 mac: Fix the notification presenter of new API. 2014-07-28 11:52:26 +08:00
Cheng Zhao
e52a089ec2 mac: Remove usages of WebContentsView. 2014-07-28 09:34:42 +08:00
Cheng Zhao
d47a94b1fe DispatchBeforeUnload is now a method of WebContents. 2014-07-27 11:27:05 +00:00
Cheng Zhao
9821cd1f58 web_contents_view.h has been hidden from user. 2014-07-27 11:27:04 +00:00
Cheng Zhao
a98199511a Implement GetGuestManagerDelegate. 2014-07-27 11:27:04 +00:00
Cheng Zhao
8bf3e084f1 Interface of ProxyResolverV8 has changed. 2014-07-27 11:27:04 +00:00
Cheng Zhao
bb87492897 No more need to init aura::Env. 2014-07-27 11:27:04 +00:00
Cheng Zhao
6dd580526e Refactor notification presenter for new desktop notification interface. 2014-07-27 11:27:04 +00:00
Cheng Zhao
4e63780e4a Prototype of WebContentsDestroyed has changed. 2014-07-27 10:27:19 +00:00
Cheng Zhao
a318b1c5d1 views: Use DesktopNativeWidgetAura for menu view. 2014-07-14 15:56:04 +08:00
Cheng Zhao
46e765f79b Fix crash when closing docked devtools by clicking close button.
We need to send ack for the close message, so we should destroy web contents
after the beforeunload event has fired.
2014-07-13 10:08:28 +08:00
Cheng Zhao
9d4e977c01 win: Fix window frame on detached window. 2014-07-12 21:26:29 +08:00
Cheng Zhao
8d3f615e61 win: Setup font. 2014-07-12 19:46:26 +08:00
Cheng Zhao
0f5b427648 Always shows window frame except for maximized window on Unity. 2014-07-12 11:45:24 +08:00
Cheng Zhao
a080d2c5bb Remove GetNativeView() when compiled with views toolkit. 2014-07-11 23:32:00 +08:00
Cheng Zhao
4b57e1f4f8 Warn about using GetNativeView() in views. 2014-07-11 23:14:20 +08:00
Cheng Zhao
891b7434db Separate the message parsing into a new function. 2014-07-11 23:03:42 +08:00
Cheng Zhao
de08cc1d52 No need for custom dealloc. 2014-07-11 22:22:03 +08:00
Cheng Zhao
e553e11226 Use shortcut way to create scoped_ptr. 2014-07-11 21:55:57 +08:00
Cheng Zhao
739b352de6 Only init WMState on Linux. 2014-07-09 20:06:31 +08:00
Cheng Zhao
d5283b2337 Allow access FileSystem api in devtools.
It is required by the load/save feature of profilers.
2014-07-09 15:38:53 +08:00
Cheng Zhao
1fbeb11371 Send message ack to devtools. 2014-07-09 15:34:10 +08:00
Cheng Zhao
a5bb24284e views: Follow WidgetDelegateView's convention on deleting self.
It could avoid invoking WidgetDelegate's methods when the delegate has been
deleted as a view.
2014-07-09 11:08:17 +08:00
Cheng Zhao
81d31b1d49 Remove Windows's devtools implementation. 2014-07-09 10:37:54 +08:00
Cheng Zhao
0a7b1fdd87 Add new devtools messages in Chrome 35. 2014-07-09 10:26:01 +08:00
Cheng Zhao
7a196933bb views: Don't leak ViewsDelegate. 2014-07-09 10:26:01 +08:00
Cheng Zhao
651ebdde65 views: Remember bounds of devtools window. 2014-07-09 10:26:01 +08:00
Cheng Zhao
4fb4b2d7ba views: Implement undocked devtools. 2014-07-09 10:26:01 +08:00
Cheng Zhao
e574bf6d0f views: Initial docked devtools implementation. 2014-07-09 10:26:01 +08:00
Cheng Zhao
4048d491f0 views: Use chromium's custom frame view. 2014-07-09 10:26:01 +08:00
Cheng Zhao
da5daecb1d Initialize aura environment. 2014-07-09 10:26:01 +08:00
Cheng Zhao
02f52f7e20 Allow override BrowserMainParts::InitProxyResolverV8. 2014-07-09 10:26:01 +08:00
Cheng Zhao
8f3546ed30 Initialize screen for aura. 2014-07-09 10:26:01 +08:00
Cheng Zhao
bad7b95ed7 Add ViewsDelegate, required when using views::Widget on aura. 2014-07-09 10:26:01 +08:00
Cheng Zhao
48ed03eb39 Initialize Linux UI. 2014-07-09 10:26:01 +08:00
Cheng Zhao
d4e81da19a Make BrowserMainParts's overrides available on all platforms. 2014-07-09 10:26:01 +08:00
Cheng Zhao
7050b7944f Remove devtools view on Linux.
GTK+ has been replaced, we need to rewrite the whole thing.
2014-07-09 10:24:10 +08:00
Cheng Zhao
563d6e87ff Fix cpplint warning. 2014-07-09 10:24:10 +08:00
Cheng Zhao
1722532e6d No need to remember dock state.
All devtools states are remembered by devtools itself now.
2014-07-09 10:24:10 +08:00
Cheng Zhao
7a2dc3fc4f mac: Make focus back to browser window when devtools is closed. 2014-07-09 10:24:10 +08:00
Cheng Zhao
2efeaa268f Place DevTools WebContents underneath inspected WebContents.
This commit has this strategy implemented on Mac.

See https://code.google.com/p/chromium/issues/detail?id=318751.
2014-07-09 10:24:10 +08:00
Cheng Zhao
7d130c9697 mac: Revert to simplest undocked-only devtools.
This makes porting Chrome's devtools easier.
2014-07-09 10:24:10 +08:00
Adam Roben
8f367f6b35 More coding style fixes 2014-07-07 14:42:30 -04:00
Adam Roben
e86c409e6b Update DevToolsWindow to use views and aura
This is required to make it work in Chrome 35.
2014-07-07 14:27:23 -04:00
Adam Roben
f65246b3cd Fix coding style 2014-07-07 14:27:02 -04:00