Commit graph

20 commits

Author SHA1 Message Date
Cheng Zhao
dd5b8769be fix: use OOPIF for webview tag (#13869)
* fix: use OOIF for webview tag

* fix: do not call GetNativeView for webview

* fix: OOIPF webview's WebContents is managed by embedder frame

* fix: guest view can not be focused

* fix: clear zoom controller when guest is destroyed

* fix: implement the webview resize event

The webview is no longer a browser plugin with the resize event, use
ResizeObserver instead.

* test: disable failed tests due to OOPIF webview

* fix: embedder can be destroyed earlier than guest

This happens when embedder is manually destroyed.

* fix: don't double attach

* fix: recreate iframe when webview is reattached

* fix: resize event may happen very early

* test: some tests are working after OOPIF webview

* chore: remove unused browser plugin webview code

* fix: get embedder via closure

When the "destroyed" event is emitted, the entry in guestInstances would be
cleared.

* chore: rename browserPluginNode to internalElement

* test: make the visibilityState test more robust

* chore: guestinstance can not work with OOPIF webview

* fix: element could be detached before got response from browser
2018-08-16 15:57:40 -07:00
Shelley Vohr
284aca68c0
clang-format brightray 2018-04-17 21:46:27 -04:00
Kevin Sawicki
d7321ed980 Add brightray prefix to include paths from within brightray 2017-05-19 08:46:15 -07:00
Kevin Sawicki
c4608c0f37 Fix build/include_alpha linter violations in brightray 2017-05-19 08:46:15 -07:00
Cheng Zhao
fc33eb99f7 Unsubscribe from NSNotificationCenter when WebContents is destroyed
Due to ref-counted references the NSView is not destroyed immediately
when WebContents is destroyed, so it is not reliable to do this in
the destructor.
2015-09-17 11:19:08 +08:00
Cheng Zhao
352f758cd1 Make DevToolsFocused in OS X 2015-09-15 11:24:35 +08:00
Cheng Zhao
c30f458d4f Add IsDevToolsViewFocused method 2015-09-15 11:04:46 +08:00
Cheng Zhao
c0b9fd415d Revert "Make bottom corner more round"
This reverts commit f9a64dde5da537f615cd7080a335c6304c6a814e.
2015-08-26 15:56:39 +08:00
Cheng Zhao
eb709a9a8f Fix building on OS X 2015-08-25 20:55:07 +08:00
Robo
26f4d09b2c implement for osx 2015-08-07 16:24:45 +05:30
Cheng Zhao
935d1e142f Make bottom corner more round 2015-07-20 18:24:24 +08:00
Cheng Zhao
2a8691d981 mac: Use new devtools resizing strategy. 2014-09-01 19:18:12 +08:00
Cheng Zhao
7050b7944f Remove devtools view on Linux.
GTK+ has been replaced, we need to rewrite the whole thing.
2014-07-09 10:24:10 +08:00
Cheng Zhao
563d6e87ff Fix cpplint warning. 2014-07-09 10:24:10 +08:00
Cheng Zhao
2efeaa268f Place DevTools WebContents underneath inspected WebContents.
This commit has this strategy implemented on Mac.

See https://code.google.com/p/chromium/issues/detail?id=318751.
2014-07-09 10:24:10 +08:00
Cheng Zhao
7d130c9697 mac: Revert to simplest undocked-only devtools.
This makes porting Chrome's devtools easier.
2014-07-09 10:24:10 +08:00
Cheng Zhao
5e0dd5c687 Remove from notification center when web contents is destroyed. 2014-04-23 11:20:12 +08:00
Cheng Zhao
39f5f52423 Fix flash of page while resizing devtools NSSplitView divider. 2013-12-12 18:46:46 +08:00
Adam Roben
fa9a1d7b35 Support undocking the devtools view into its own window 2013-03-27 12:35:01 -04:00
Adam Roben
b2a79856ef Add InspectableWebContents
This class can be used to create a content::WebContents that can be inspected
by the Chrome Dev Tools. This requires embedding applications to copy
content_shell.pak into their resource bundle.

Right now the dev tools are always docked to the bottom of the view; we don't
yet support undocking or changing the docked side.

Fixes #1.
2013-03-14 09:05:42 -04:00