Jeremy Apthorp
bdceea6aca
fix: enable spell checking, which broke in upgrade to ch66
...
Chromium commit [03563dd163][1] changed the way that the
spellcheck-enabled status was checked, defaulting to false.
Added the first (!) test for spellchecking, too.
Fixes #13608 .
[1]: https://chromium.googlesource.com/chromium/src/+/03563dd1635a028d286beaf8b4f3d637cc4a8830
2018-07-11 10:27:56 -07:00
Milan Burda
28fd571d0c
refactoring: use std::make_unique<T> ( #13245 )
2018-06-18 16:32:55 +09:00
Thiago de Arruda
6ff111a141
perf: don't use JSON to send the result of ipcRenderer.sendSync
. ( #8953 )
...
* Don't use JSON to send the result of `ipcRenderer.sendSync`.
- Change the return type of AtomViewHostMsg_Message_Sync from `base::string16`
to `base::ListValue`
- Adjust lib/browser/api/web-contents.js and /lib/renderer/api/ipc-renderer.js
to wrap/unwrap return values to/from array, instead of
serializing/deserializing JSON.
This change can greatly improve `ipcRenderer.sendSync` calls where the return
value contains Buffer instances, because those are converted to Array before
being serialized to JSON(which has no efficient way of representing byte
arrays).
A simple benchmark where remote.require('fs') was used to read a 16mb file got
at least 5x faster, not to mention it used a lot less memory. This difference
tends increases with larger buffers.
* Don't base64 encode Buffers
* Don't allocate V8ValueConverter on the heap
* Replace hidden global.sandbox with NodeBindings::IsInitialized()
* Refactoring: check NodeBindings::IsInitialized() in V8ValueConverter
* Refactor problematic test to make it more reliable
* Add tests for NaN and Infinity
2018-06-13 17:38:31 +10:00
Shelley Vohr
94e825378c
remove webFrame.registerURLSchemeAsSecure() deprecation
2018-05-23 09:33:57 -07:00
bughit
4fcd178c36
expose WebFrame#routingId ( #12614 )
...
* expose WebFrame#routingId and pass it to WebContents frame specific events along with frameProcessId; add WebContets.did-start-navigation event
* fix compilation error on ia32 Windows
2018-04-26 19:17:55 +09:00
Jeremy Apthorp
f1587da480
[chromium-style] out-of-line default constructors and destructors
2018-04-19 11:12:58 -07:00
Jeremy Apthorp
e6695cf2ec
[chromium-style] override / virtual warnings
2018-04-19 11:12:10 -07:00
Jeremy Apthorp
a635f078c6
[chromium-style] auto variable type must not deduce to a raw pointer type
2018-04-19 11:10:52 -07:00
Shelley Vohr
c6f4bbd143
also format missing .cc files
2018-04-18 20:48:45 -04:00
Shelley Vohr
53bdf22c85
clang-format atom files
2018-04-18 20:48:45 -04:00
OJ Kwon
4c51c03779
feat(performspellcheck): queue spell check request asynchronously ( #12112 )
...
* feat(spellcheckrequest): implement spellcheckrequest
* feat(performspellcheck): queue spell check request asynchronously
2018-04-09 15:18:50 +09:00
Jeremy Apthorp
a7352e57d5
WebFrame.setVisualZoomLevelLimits sets user-agent scale constraints ( #12488 )
...
Fixes #11216 .
2018-04-02 18:20:13 -04:00
deepak1556
5684f8886f
REVIEW: move ipc use from rvh to rfh
2018-03-20 10:13:15 +03:00
Samuel Attard
f80b328937
WebExceptionCode has been removed
2018-03-20 10:13:14 +03:00
deepak1556
3cfe66e4c3
move ipc use from rvh to rfh
2018-03-09 15:01:09 +05:30
Cheng Zhao
fdd66bd76d
Merge pull request #11607 from bughit/frame_navigation_api
...
frame navigation API
2018-02-26 15:50:11 +09:00
Cheng Zhao
ccf30e0934
Coding style fixes
2018-02-26 15:19:44 +09:00
shelley vohr
0e5b6f9300
Upgrade to node v9.3.0 ( #11507 )
...
* update submodule refs for node v9.3.0
* Define "llvm_version" for Node.js build
* NODE_MODULE_CONTEXT_AWARE_BUILTIN -> NODE_BUILTIN_MODULE_CONTEXT_AWARE
* update NodePlatform to MultiIsolatePlatform
* fix linting error
* update node ref
* REVIEW: Explicitly register builtin modules
https://github.com/nodejs/node/pull/16565
* update libcc ref
* switch libcc to c62
* REVIEW: Address node api changes
- Always start the inspector agent for https://github.com/nodejs/node/pull/17085
- Set the tracing controller for node https://github.com/nodejs/node/pull/15538
- Isolate data creation now requires plaform https://github.com/nodejs/node/pull/16700
2018-02-23 10:22:00 +09:00
Aleksei Kuzmin
b02edd014a
Rename CompositionUnderline to ImeTextSpan
...
https://chromium-review.googlesource.com/609524
2018-02-23 10:21:23 +09:00
bughit
88b887fe47
frame navigation API
2018-02-21 18:50:15 -05:00
Shelley Vohr
211b542ae4
remove setZoomLevelLimits
2018-02-20 08:57:48 -05:00
shelley vohr
a55fd06aa2
Revert "Merge pull request #11737 from kwonoj/feat-cache-capacity" ( #11906 )
...
This reverts commit 181169b743
, reversing
changes made to baced3152f
.
2018-02-13 10:49:27 -05:00
Samuel Attard
181169b743
Merge pull request #11737 from kwonoj/feat-cache-capacity
...
feat(webframe): export set cache capacity interface
2018-02-13 06:02:25 +11:00
OJ Kwon
e869c27041
feat(worditerator): bump up worditerator into latest
2018-02-06 15:31:18 -08:00
OJ Kwon
d172e29270
feat(webframe): export set cache capacity interface
2018-01-25 20:43:01 -08:00
deepak1556
fd297722a8
Note about incorrect usage of blink::SchemeRegistry methods
2018-01-02 16:37:10 +09:00
deepak1556
83d2917363
fix: manually set spellchecker for sub frames
2017-12-20 12:48:02 +05:30
Cheng Zhao
b27e42f3f7
Fix indentions
2017-12-19 10:42:36 +09:00
Hugo Mano
ae7b96991c
Add webFrame.setIsolatedWorldSecurityOrigin
...
Move vector to cc file
Map executed javascript in isolated world to url
Some 💅
Documentation
Use WebSource[] as argument in executeJavaScriptInIsolatedWorld
Refactor and lint with @poiru’s comments
Remove duplicate call
Typo
Lint
2017-12-19 10:36:03 +09:00
Hugo Mano
389edb6229
Add webFrame.setIsolatedWorldHumanReadableName
2017-12-19 10:36:03 +09:00
Hugo Mano
f74f113d23
Add webFrame.setIsolatedWorldContentSecurityPolicy
2017-12-19 10:36:03 +09:00
Alexandre Lachèze
936d8c1117
Add webframe. executeJavaScriptInIsolatedWorld
...
Attempt runInIsolatedWorldContext
Replace RunInIsolatedWorldContext by GetIsolatedWorldGlobalObject
Fix linting
Remove useless getIsolatedWorldGlobalObject
Add support for scriptExecutionType
2017-12-19 10:36:03 +09:00
Ales Pergl
7a73b1d523
Fixed crash in atom::api::SpellCheckClient
...
The class didn't save the V8 context for the spell checking JS function. When
it later tried to call the JS function and there was no active context, V8
crashed.
I also optimized the spell checking loop by introducing `SpellCheckScope` and
reusing the V8 handles throughout the whole loop.
2017-12-06 14:50:20 +01:00
Aleksei Kuzmin
5fb0f005c5
Convert SpellCheckPanel SpellCheckPanelHost IPC to mojo
...
https://chromium-review.googlesource.com/c/chromium/src/+/515323
2017-11-24 10:58:17 +09:00
deepak1556
778772710a
intialize WebTextCheckClient https://codereview.chromium.org/2791753003
2017-08-15 16:19:22 +03:00
Kevin Sawicki
45db999593
Extend blink::WebTextCheckClient in atom::api::SpellCheckClient
2017-08-15 16:19:21 +03:00
Aleksei Kuzmin
48821a6d2a
Fix compilation
2017-08-15 16:19:21 +03:00
Aleksei Kuzmin
7a4ca08a8d
The Blink Rename
2017-08-15 16:19:20 +03:00
Cheng Zhao
e43b34b8f8
Use blink::SchemeRegistry over WebSecurityPolicy
...
The latter is removing some APIs we use.
2017-04-27 16:34:52 +09:00
Cheng Zhao
481b04358e
Fix blink API changes
2017-04-27 16:34:52 +09:00
Cheng Zhao
6be10ffef2
Fix more API changes due to name changes
2017-04-27 16:34:52 +09:00
deepak1556
7a0aff2bae
code cleanup
2017-02-12 01:48:24 +05:30
deepak1556
e3fe3cc490
map webframe zoom api to use HostZoomMap
2017-02-12 00:49:17 +05:30
Cheng Zhao
6d5339b74e
insertText is deprecated
2017-02-06 10:34:29 -08:00
Kevin Sawicki
602db2e04f
🎨
2017-01-19 09:05:59 +02:00
Kevin Sawicki
d6eb0d6629
Implement insertCSS on webFrame
2017-01-19 09:05:59 +02:00
Cheng Zhao
497f5a1199
Update files for Chrome 54 API changes
2017-01-19 09:05:59 +02:00
Paul Frazee
04fa85f67f
removed unused iostream include
2016-12-12 12:51:48 -08:00
Paul Frazee
bacf6511a6
remove unneeded deprecations couts
2016-12-12 12:51:48 -08:00
Paul Frazee
a46040a4fa
log deprecation notices for webframe
2016-12-12 12:51:48 -08:00