* chore: allow conditional disable of the site instance override patches at runtime
* feat: add app.allowRendererProcessReuse property to allow runtime disable of site instance overrides
spec: add tests for the new allowRendererProcessReuse property
feat: add console warnings / errors for loading non context-aware native modules
* Only error if the patch is disabled
* Warn all the time, this will ship in Electron 7
Fixes: #18503
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1576232
For whatever reason Chromium made this change and then made the default
//content behavior to return false for all IsDataResourceGzipped
requests. This PR updates our ContentClient impl to return the correct
values.
Notes: Fixed issues where some `chrome://*` URLs would not render
correctly
This fixes#18459 by improving the handling of contractions in the spellcheck API. Specifically, it now accepts contraction words where the spellchecker recognizes the whole word, and not, as previously, just if it recognizes all of its parts.
* chore: remove last instances of base::Bind
* MessageBoxCallback is a OnceCallback
* convert permission helepr cbs to Once
* convert ResponseCallback to Once
This PR ameliorates an issue whereby minimizable and closable weren't respected in customButtonsOnHover mode. maximizable isn't addressable here, since it's been blanket disabled in newer versions of macOS owing to an issue with the NSWindowStyleMaskFullSizeContentView style mask.
* Compare final data instead of url
The behavior of did-finish-load and getURL has changed for redirects when
using NetworkService, so the test fails for NetworkService.
Comparing the finally received data makes the test more reliable.
* Implement intercept APIs
* Setting mimeType should set "content-type" header
* Passing no argument should not throw JS error
* Don't access api namespace in ProxyingURLLoaderFactory
* No need to create AtomURLLoaderFactory every time
* No use of weak factory
Previously the enum list ended with entries copied values
from base::PATH_ entries, so the subsequent entry (PATH_END)
had a value in (base::PATH_START..base::PATH_END].
This only a correctness patch. atom::PATH_END doesn't appear
to be used anywhere and it was the only atom::PATH_ enum
bitten by this.
Windows debug isn't logging because of a DCHECK failure during startup. This changes the logger initialization to use the absolute path, so that logging works again.