Cheng Zhao
82452e7924
win: Fix assertion when getting printers
2018-01-02 16:54:36 +09:00
deepak1556
769fbd0d3b
REVIEW: register BrowserChildProcessObserver once main message loop is ready
2018-01-02 16:37:11 +09:00
deepak1556
1b30cac372
Don't delay node module initialization
2018-01-02 16:37:11 +09:00
deepak1556
a1592446da
REVIEW: access GetApplicationLocale on sequence that allows IO
2018-01-02 16:37:08 +09:00
deepak1556
ebb0e46380
REVIEW: create AtomNetworkDelegate on the IO thread
2018-01-02 16:37:08 +09:00
deepak1556
e30131f30b
Initialize isolate holder in standalone node mode
2018-01-02 16:37:07 +09:00
deepak1556
88e53b1b5e
REVIEW: destroy process singleton on sequence where IO is allowed
2018-01-02 16:37:07 +09:00
deepak1556
b4e6516ad8
fix dcheck failure with invalid UTF8 string conversion for base::Value
2018-01-02 16:37:05 +09:00
Cheng Zhao
d04ae88426
The RenderWidgetHostView might not be available when showing menu
2018-01-01 19:37:59 +09:00
Cheng Zhao
bc61f2eafa
Copy the callback instead of reference
...
I don't really see how this could be a problem, likely a bug of VS 2017?
2018-01-01 19:37:59 +09:00
Cheng Zhao
46330ac2a9
Remove the closed event of Menu
...
The callback of Menu.popup does more things, and there is actually no
request for the closed event.
2018-01-01 17:22:07 +09:00
Cheng Zhao
7b01a8b860
Add callback parameter to Menu.popup
2018-01-01 16:26:19 +09:00
Cheng Zhao
d7bc127c60
mac: Correctly close popup menu
2018-01-01 15:40:15 +09:00
Cheng Zhao
7a8864063b
mac: Handle the case when closing all menu runners
2017-12-21 15:57:27 +09:00
Cheng Zhao
088042841d
win: Correctly close popup menu
2017-12-21 15:26:32 +09:00
Cheng Zhao
e4770c7604
Coding style fixes
2017-12-20 18:48:09 +09:00
Heilig Benedek
ef7357dedc
update tests for menu closed event and call cancel on closePopup
2017-12-20 15:40:07 +09:00
Heilig Benedek
bcef6eb3df
document menu closed event and fix styling issue
2017-12-20 15:40:07 +09:00
Heilig Benedek
c586806609
fix flash menu being unresponsive to commands
2017-12-20 15:40:07 +09:00
Shelley Vohr
3fc844c15a
add loop to catch null values
2017-12-13 14:02:43 -05:00
Shelley Vohr
6252ce466c
remove failing badDefault
2017-12-12 13:39:38 -05:00
Shelley Vohr
8b447b9291
fixing error in registerDefaults
2017-12-12 13:08:09 -05:00
Alexey Kuzmin
1caa04c0bf
Revert "Add systemPreferences.registerDefaults()"
2017-12-12 13:59:15 +03:00
Cheng Zhao
19f1fef040
Merge pull request #11283 from electron/fix-event-subscriber-race
...
Fix race condition in event_subscriber.h
2017-12-12 10:49:17 +09:00
Shelley Vohr
a8e67e7f61
fixes from review
2017-12-11 18:20:12 -05:00
Shelley Vohr
84bab48627
improve error handling
2017-12-11 13:11:03 -05:00
Shelley Vohr
c5aeda1fdd
fixes from code review
2017-12-11 00:20:26 -05:00
Shelley Vohr
18ee34f1a1
add method binding and error guards
2017-12-10 11:25:43 -05:00
Shelley Vohr
1ccad4a7e9
fix capitalization and clean logic
2017-12-10 11:04:05 -05:00
Shelley Vohr
f82086e6d3
first pass at adding infra for registerDefaults
2017-12-10 00:45:49 -05:00
deepak1556
19de41b764
BrowserClient::CanCreateWindow is no longer called on the IO thread
...
https://codereview.chromium.org/2821473002
2017-12-07 09:47:32 +05:30
Thiago de Arruda
897712359f
Implement powerMonitor "suspend"/"resume" events for Linux.
2017-12-05 08:12:44 -03:00
Cheng Zhao
24b3ee3a4a
Revert some unnecessary changes
2017-12-05 16:50:25 +09:00
Cheng Zhao
cb3a9c69ab
Add a SessionPreferences to manage session related data
...
By design the BrowserClient should not be aware of the api:: classes.
2017-12-05 15:59:15 +09:00
Cheng Zhao
776e8afa2b
Coding style changes
2017-12-05 11:50:06 +09:00
Samuel Attard
e535ba4808
Don't know why we suddenly need this, but hey :/
2017-12-05 11:35:54 +09:00
Samuel Attard
d1aded2831
Appease the almighty linter
2017-12-05 11:35:53 +09:00
Samuel Attard
3b80ee0655
Move global preload implementation to be session based
2017-12-05 11:35:53 +09:00
Samuel Attard
448ccc261d
Use const references
2017-12-05 11:35:27 +09:00
Samuel Attard
0ddd078aaf
Add ability to set global preload scripts
2017-12-05 11:35:27 +09:00
Cheng Zhao
d598aa1a67
Merge pull request #11300 from electron/external-devtools
...
Add API to set arbitrary WebContents as devtools
2017-12-05 10:35:49 +09:00
deepak1556
903a5b5100
fix dcheck comparison between unsigned long vs int
2017-12-01 17:55:21 +01:00
Cheng Zhao
6b408de884
Allow using docked devtools for webview
2017-12-01 11:56:58 +09:00
Cheng Zhao
5e4914700e
Enable using external WebContents as devtools
2017-12-01 10:35:23 +09:00
Thiago de Arruda
68bceb9575
Fix race condition in event_subscriber.h
2017-11-29 12:57:47 -03:00
Ales Pergl
f3c32647af
Sanitized notification delegate implementation
...
I made `brightray::NotificationDelegate` back into just an interface and
extracted the implementation used by `PlatformNotificationService`, so that
the main process notification implementation can inherit only the interface.
2017-11-24 10:58:53 +09:00
deepak1556
a0be734ccb
Fix client certificate private key handling api
2017-11-24 10:58:53 +09:00
Birunthan Mohanathas
4e859b4718
Remove "async" option from menu.popup()
...
All menus are async now. See "Cleanup MenuRunner API"
https://codereview.chromium.org/2790773002
2017-11-24 10:58:17 +09:00
Aleksei Kuzmin
338604239d
Cleanup MenuRunner API
...
https://codereview.chromium.org/2790773002
2017-11-24 10:58:17 +09:00
Aleksei Kuzmin
1073c9b1ed
Fix compilation of atom/browser/api/atom_api_app.cc
...
Refactor client cert private key handling.
https://codereview.chromium.org/2898573002
2017-11-24 10:58:17 +09:00
