Rob Brackett
64a84dee3b
Add isLoadingMainFrame
method to WebContents.
...
Also switch `webContents.executeJavaScript` to check it instead of `isLoading`.
There doesn’t seem to be a reasonable public way to get this information out of Chromium, so it’s synthesized here based on WebContentsObserver callbacks.
Fixes #5183 .
2016-04-18 10:37:08 -07:00
Cheng Zhao
cb947873c4
Merge pull request #5161 from electron/felix/iss5097
...
AutoUpdate Windows: Don't spawn if running
2016-04-15 20:10:03 +09:00
Felix Rieseberg
a5b93211e6
AutoUpdate Windows: Don't spawn if running
...
Previously, the auto updater would run as many squirrel processes
as told. This introduces a little change where instead of spawning
a second process, we attach to the already running process - or, if
different arguments are passed, return and emit an error.
This is not failsafe, but it ensures that we don't run into simple
race condition crashes.
Closes $5097
2016-04-14 11:22:28 -07:00
Cheng Zhao
31eb793fb0
Avoid adding a new option to webPreferences
2016-04-14 10:50:07 +09:00
Cheng Zhao
8f0e594007
Fix lint warnings
2016-04-13 23:10:31 +09:00
Cheng Zhao
43c44da50b
Correctly set initial visibilityState
2016-04-13 23:07:28 +09:00
Cheng Zhao
07a4c52919
Reduces the IPC messages used for visibilityState
2016-04-13 21:36:43 +09:00
Cheng Zhao
92882c358a
No more need to delay did-fail-load event
2016-04-13 19:33:59 +09:00
Cheng Zhao
2fbe06a2a5
Handle the Page.reload command coming from devtools
2016-04-12 16:36:12 +09:00
Kevin Sawicki
8d8d5878a3
Rename ATOM_ ipc event prefix to ELECTRON_
2016-04-07 09:04:55 -07:00
Kevin Sawicki
400efa1b7d
Fallback to using the last argument as the callback
2016-04-01 12:54:06 -07:00
Robo
7016fbe258
browser: fix disposition value for new-window event
2016-04-01 08:14:29 +05:30
Zeke Sikelianos
b5afad9da7
avoid using eslint comment exceptions
2016-03-30 17:00:34 -07:00
Zeke Sikelianos
42e7ee2b4a
finish standardizing!
2016-03-30 17:00:33 -07:00
Zeke Sikelianos
4e2f1311e0
replace __proto__ with Object.setPrototype
2016-03-30 17:00:33 -07:00
Zeke Sikelianos
2c3cacdc08
standardize by hand
2016-03-30 17:00:33 -07:00
Zeke Sikelianos
e6698102c9
standardize by hand
2016-03-30 17:00:33 -07:00
Zeke Sikelianos
4794385fac
first pass at standardizing; suite still passing!
2016-03-30 17:00:30 -07:00
Sergey Bekrin
4ac08870d0
Tweak error messages for dialog API
2016-03-30 23:07:13 +03:00
Sergey Bekrin
7f78781800
Improve error reporting when using invalid argument types for dialog API methods
2016-03-23 10:44:11 +03:00
Kevin Sawicki
4127b524d5
Destructure params directly
2016-03-22 13:11:42 -07:00
Kevin Sawicki
43746727aa
Use direct params instead of rest params
2016-03-22 13:11:42 -07:00
Kevin Sawicki
4f4dc2f4d8
Use destructuring assigment
2016-03-22 13:11:42 -07:00
Cheng Zhao
a52285596e
Merge pull request #4846 from atom/rest-parameters
...
Use rest parameters
2016-03-21 21:03:28 +09:00
Cheng Zhao
e08b48ab48
Merge pull request #4840 from atom/undefined-menu-accelerator
...
Undefined menu accelerator
2016-03-21 21:02:44 +09:00
Kevin Sawicki
8889c29866
Use rest parameters
2016-03-18 11:51:02 -07:00
Kevin Sawicki
6aa452cda4
Set _setDeprecatedOptionsCheck on exports
2016-03-18 09:06:03 -07:00
Kevin Sawicki
7668c1ea0b
Use deprecate.warn instead of deprecate.log
2016-03-18 09:02:58 -07:00
Zeke Sikelianos
344dda4029
ignore set menu item fields
2016-03-17 16:20:23 -07:00
Kevin Sawicki
737ffd8d7c
Improve deprecated message on webPreferences options
2016-03-17 13:37:08 -07:00
Kevin Sawicki
c31882749d
Correct typos in comments
2016-03-17 13:37:08 -07:00
Kevin Sawicki
15397bf879
Report deprecated BrowserWindow options
2016-03-17 13:37:07 -07:00
Kevin Sawicki
0e5e230c03
Remove lint errors due to rebase
2016-03-11 11:25:56 -08:00
Kevin Sawicki
3c11f5dc4d
Remove returns from event handlers
2016-03-11 11:25:56 -08:00
Kevin Sawicki
0ee3446109
Use undefined instead of void 0
2016-03-11 11:25:56 -08:00
Kevin Sawicki
a3f08c9b51
Use arrow functions to replace old CoffeeScript => this wrappers
2016-03-11 11:25:56 -08:00
Kevin Sawicki
6b1748d6d6
Don't collect results from delegate.menuWillShow
2016-03-11 08:55:48 -08:00
Kevin Sawicki
3a08aa37de
Don't collect results from Menu::_callMenuWillShow
2016-03-11 08:55:48 -08:00
Kevin Sawicki
93939089ec
Don't collect results in Menu.setApplicationMenu
2016-03-11 08:55:48 -08:00
Arek Sredzki
fcc1f4d7ed
Finalized browser-window show & hide events, added tests & fixed os x implementation
2016-03-10 13:51:31 -08:00
Arek Sredzki
c1267b2320
Added 'show' & 'hide' events to browser-window, fixed visibilitychange event in renderer
2016-03-10 13:51:31 -08:00
Arek Sredzki
ee61ab2d26
Cache browser visibility state & emit visibilitychange event on change
...
Fixes #3788
2016-03-10 13:51:31 -08:00
Kevin Sawicki
006c77a00f
Update requires paths
2016-03-08 11:14:22 -08:00
Kevin Sawicki
70aa9b06ee
Move JavaScript to root lib/ folder
2016-03-08 11:14:21 -08:00