Charles Kerr
d663b4eaee
fix: fix gn cpplint warnings ( #14583 )
...
* chore: fix cpplint 'include_what_you_use' warnings
Typically by including <memory>, <utility> etc.
* chore: fix 'static/global string constant' warning
Use C style strings instead of std::string.
Style guide forbids non-trivial static / global variables. https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables
/home/charles/electron/electron-gn/src/electron/script/cpplint.js
* refactor: remove global string variables.
Fix 'global string variables are not permitted' linter warnings
by using the base::NoDestructor<> wrapper to make it explicit that
these variables are never destroyed.
The style guide's take on globals with nontrivial destructors:
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables
* fix: initializer error introduced in last commit
* fix: remove WIP file that was included by accident
* fix: include order
* fix: include order
* fix: include order
* fix: include order, again
2018-09-12 19:25:56 -05:00
Milan Burda
28fd571d0c
refactoring: use std::make_unique<T> ( #13245 )
2018-06-18 16:32:55 +09:00
Jeremy Apthorp
f1587da480
[chromium-style] out-of-line default constructors and destructors
2018-04-19 11:12:58 -07:00
Cheng Zhao
7473b612c5
Make Menu API accept TopLevelWindow
2018-04-19 13:08:37 +09:00
Shelley Vohr
c6f4bbd143
also format missing .cc files
2018-04-18 20:48:45 -04:00
Cheng Zhao
858828d343
Refactor NativeWindow (Part 6): Move NativeWindow bindings to api::TopLevelWindow ( #12596 )
...
* Add atom::api::TopLevelWindow
* Make BrowserWindow inherit TopLevelWindow
* Fix reading from wrong weak map
* Read options after setting content view
* OnWindowClosed is not guarenteed to run now
* Fix the offscreen hack in BrowserWindow
* Fix building on Linux
* Fix tests on Linux
* Fix building on Windows
2018-04-14 11:04:23 +09:00
Aleš Pergl
0937b84b01
Use content origin in screen coordinates for calculating popup menu position ( #12180 )
2018-03-09 05:48:35 +09:00
Cheng Zhao
413fdc6f0d
views: Show menu on window's content view
2018-03-06 16:21:18 +09:00
Cheng Zhao
973647eaa2
Rename api::Window to api::BrowserWindow
2018-02-22 12:50:47 +09:00
Cheng Zhao
d04ae88426
The RenderWidgetHostView might not be available when showing menu
2018-01-01 19:37:59 +09:00
Cheng Zhao
bc61f2eafa
Copy the callback instead of reference
...
I don't really see how this could be a problem, likely a bug of VS 2017?
2018-01-01 19:37:59 +09:00
Cheng Zhao
7b01a8b860
Add callback parameter to Menu.popup
2018-01-01 16:26:19 +09:00
Cheng Zhao
088042841d
win: Correctly close popup menu
2017-12-21 15:26:32 +09:00
Cheng Zhao
e4770c7604
Coding style fixes
2017-12-20 18:48:09 +09:00
Heilig Benedek
ef7357dedc
update tests for menu closed event and call cancel on closePopup
2017-12-20 15:40:07 +09:00
Birunthan Mohanathas
4e859b4718
Remove "async" option from menu.popup()
...
All menus are async now. See "Cleanup MenuRunner API"
https://codereview.chromium.org/2790773002
2017-11-24 10:58:17 +09:00
Aleksei Kuzmin
338604239d
Cleanup MenuRunner API
...
https://codereview.chromium.org/2790773002
2017-11-24 10:58:17 +09:00
Kevin Sawicki
ce5ac1b056
Implement ClosePopupAt on Windows/Linux
2017-02-22 10:30:28 -08:00
Kevin Sawicki
91d1af053f
Implement Menu.closePopup on Windows/Linux
2017-02-22 10:30:28 -08:00
Kevin Sawicki
66b6b4f1cb
Map async option to MenuRunner::ASYNC flag
2017-02-22 10:30:28 -08:00
Kevin Sawicki
b091d104f5
Add async menu.popup on Windows/Linux
2017-02-22 10:30:28 -08:00
Cheng Zhao
1505a46ed0
Do not rely on Constructor to call Init
...
This makes it deterministic when the JavaScript is initialized, which
can make our logic more clear.
2016-08-02 15:15:40 +09:00
Cheng Zhao
b57665330c
Merge branch 'master' into chrome52
2016-07-21 05:34:36 -06:00
Cheng Zhao
8269e7b1ef
Suppress unresponsive event when showing menu
2016-07-11 15:31:24 +09:00
Cheng Zhao
1ba3907038
Update to API changes of Chrome 52
2016-07-04 15:32:43 +09:00
Brian R. Bondy
732936713a
GetNativeScreen -> GetScreen
2016-05-13 11:07:17 +09:00
Cheng Zhao
272592415d
Fix building on non-mac
2016-04-25 10:34:41 +09:00
Cheng Zhao
2ae52d0ff4
Make Wrappable a template class
2016-04-25 10:17:54 +09:00
Cheng Zhao
ca77c95c6d
No more need to override Menu::Popup
2016-01-22 11:27:17 -07:00
Cheng Zhao
0e3a3d0748
views: Remove PopupAtPoint
2016-01-22 11:25:16 -07:00
Cheng Zhao
360266ba5b
positioningItem => positioning_item
2016-01-22 10:51:51 -07:00
evgenyzinoviev
072ab0ddea
specify positioning item for popup menus
2016-01-22 03:18:27 +01:00
Cheng Zhao
9f52b11761
Remove NativeWindow::GetWebContents
2015-06-25 14:54:00 +08:00
Cheng Zhao
ff26c3c16f
Some coding style fixes
2014-11-28 15:59:03 +08:00
Joao Moreno
c06e844ef4
fix build
2014-11-26 15:28:03 +01:00
Joao Moreno
46e6b5ec3e
Allow positioning the context menu
2014-11-26 13:54:05 +01:00
Kevin Sawicki
b6b6fc3bfd
Remove All Rights Reserved after GitHub copyright
...
Closes #762
2014-10-31 11:17:05 -07:00
Cheng Zhao
a95679c212
Enable mnemonics in menu, fixes atom/atom#3844
2014-10-16 21:22:22 +08:00
Cheng Zhao
69a89303d0
Fix building on Linux
2014-10-13 11:03:56 +08:00
Cheng Zhao
1c415b0666
win: No more need to convert to DIP point for context menu.
2014-07-28 20:44:11 +08:00
Cheng Zhao
10c52bd6a6
Fix building on Linux.
2014-07-28 20:28:53 +08:00
Cheng Zhao
21949e2f0c
views: Don't retain MenuRunner on heap.
...
Sometimes the MenuHost would crash when the window is closed, the author
didn't recommend using MenuRunner on stack, but since we always run the
menu synchronously, this is no problem.
2014-07-21 21:42:01 +08:00
Cheng Zhao
adec718503
win: Fix showing menu on High DPI display.
2014-07-13 22:22:56 +08:00
Cheng Zhao
49160819d2
linux: Implement context menu with views.
2014-07-10 12:07:01 +08:00
