Commit graph

365 commits

Author SHA1 Message Date
Adam Roben
24fbf6e2ef Build before running cpplint
Let's make sure things build before we check coding style. If it doesn't
even build, who cares about the style?
2013-11-17 18:15:45 -05:00
Adam Roben
991133b8e9 Fix cpplint errors in browser_context.h 2013-11-17 18:15:10 -05:00
Adam Roben
74661c342f Fix cpplint errors in browser_client.h 2013-11-17 18:13:10 -05:00
Adam Roben
80dab9d862 Fix cpplint errors in web_ui_controller_factory.cc 2013-11-17 18:12:05 -05:00
Adam Roben
57ae05b636 Fix cpplint errors in url_request_context_getter.cc 2013-11-17 18:11:47 -05:00
Adam Roben
843b21a3e8 Fix cpplint errors in network_delegate.cc 2013-11-17 18:09:21 -05:00
Adam Roben
784e270a4f Fix cpplint errors in inspectable_web_contents_impl.cc 2013-11-17 18:08:34 -05:00
Adam Roben
c97a22ef8d Fix cpplint errors in inspectable_web_contents.cc 2013-11-17 17:54:14 -05:00
Adam Roben
ef5992b0eb Fix cpplint errors in devtools_ui.cc 2013-11-17 17:53:38 -05:00
Adam Roben
dfb8a809ee Fix cpplint errors in default_web_contents_delegate.cc 2013-11-17 17:52:24 -05:00
Adam Roben
0c13adb134 Don't require all files to have a copyright/license header
The LICENSE file at the root of the repository is enough.
2013-11-17 17:52:05 -05:00
Adam Roben
a35a57c3c4 Fix cpplint errors in browser_main_parts.cc 2013-11-17 17:51:19 -05:00
Adam Roben
cc4aeb995b Fix cpplint errors in browser_context.cc 2013-11-17 17:42:56 -05:00
Adam Roben
101a7bfa21 Fix cpplint errors in browser_client.cc 2013-11-17 17:39:01 -05:00
Adam Roben
43f3d0acdc Run cpplint as part of our CI build
This will help ensure a consistent C++ coding style.
2013-11-17 17:38:09 -05:00
Adam Roben
904cb1a564 Merge pull request #33 from brightray/linux
builds on Linux
2013-11-17 14:03:56 -08:00
Patrick Reynolds
ceb8113ca6 current libchromiumcontent 2013-11-16 01:14:51 -06:00
Patrick Reynolds
5ae0b3094c current libchromiumcontent 2013-11-16 00:49:53 -06:00
Patrick Reynolds
c0543d9b46 current libchromiumcontent 2013-11-15 23:04:02 -06:00
Patrick Reynolds
a18842de1a give member variables trailing _
- also, reorder member variables to come after methods
2013-11-15 22:22:25 -06:00
Patrick Reynolds
7e1a4003df don't force all applications to link libencryptor.a 2013-11-15 22:18:59 -06:00
Patrick Reynolds
282639a79a implement dev tools 2013-11-15 14:23:52 -06:00
Patrick Reynolds
85a86a9621 current libchromiumcontent 2013-11-13 23:50:23 -06:00
Patrick Reynolds
3b3d6b2938 current libchromiumcontent 2013-11-13 23:48:06 -06:00
Patrick Reynolds
cbb00f77c2 current libchromiumcontent 2013-11-13 23:22:50 -06:00
Patrick Reynolds
616cb8212d current libchromiumcontent 2013-11-13 22:17:02 -06:00
Patrick Reynolds
236e993ac5 use linux branch of libchromiumcontent 2013-11-13 01:45:08 -06:00
Patrick Reynolds
e6cdeead3e link libencryptor 2013-11-13 00:42:14 -06:00
Patrick Reynolds
5e7359bc5a don't build Linux sources on other platforms 2013-11-12 11:51:25 -06:00
Patrick Reynolds
80cdf77a77 use merged master of libchromiumcontent 2013-11-12 11:43:29 -06:00
Patrick Reynolds
f6784a1801 move gtk dependency to brightray 2013-11-12 10:19:42 -06:00
Patrick Reynolds
72b41ed31b pick up chrome_sandbox changes 2013-11-11 18:15:22 -06:00
Patrick Reynolds
7ebb19b9b1 use linux branch of libchromiumcontent 2013-11-11 16:34:27 -06:00
Patrick Reynolds
90db457258 move -fno-rtti into brightray.gypi target_defaults 2013-11-09 01:03:46 -06:00
Patrick Reynolds
6053911bd2 Merge branch 'master' into linux 2013-11-08 20:53:43 -06:00
Patrick Reynolds
c6ce51863a implement GetNativeView 2013-11-07 23:42:15 -06:00
Patrick Reynolds
90e619a6d9 fix typo 2013-11-07 17:25:51 -06:00
Patrick Reynolds
04b9bd21f8 WIP: builds (but displys nothing) on Linux 2013-11-07 14:02:35 -06:00
Adam Roben
bd02203151 Merge pull request #32 from brightray/appcache-hang
Fix a hang on quit when application cache is used
2013-10-23 09:17:39 -07:00
Adam Roben
ae1e26bddd Fix a hang on quit when application cache is used
If you navigated to a page that used the HTML Application Cache, you'd see a
hang on quit with a backtrace like so:

+     2825 content::ContentMain(int, char const**, content::ContentMainDelegate*)  (in libchromiumcontent.dylib) + 64  [0xb33190]
+       2825 ???  (in libchromiumcontent.dylib)  load address 0x1c9000 + 0x96b261  [0xb34261]
+         2825 ???  (in libchromiumcontent.dylib)  load address 0x1c9000 + 0x96a409  [0xb33409]
+           2825 content::BrowserMain(content::MainFunctionParams const&)  (in libchromiumcontent.dylib) + 200  [0x14290b8]
+             2825 ???  (in libchromiumcontent.dylib)  load address 0x1c9000 + 0x1265426  [0x142e426]
+               2825 content::BrowserMainLoop::~BrowserMainLoop()  (in libchromiumcontent.dylib) + 17  [0x14294a1]
+                 2825 content::BrowserMainLoop::~BrowserMainLoop()  (in libchromiumcontent.dylib) + 357  [0x1429625]
+                     2825 brightray::BrowserMainParts::~BrowserMainParts()  (in ) + 70  [0x68df6]
+                       2825 scoped_ptr<brightray::BrowserContext, base::DefaultDeleter<brightray::BrowserContext> >::~scoped_ptr()  (in ) + 23  [0x68ff7]
+                         2825 scoped_ptr<brightray::BrowserContext, base::DefaultDeleter<brightray::BrowserContext> >::~scoped_ptr()  (in ) + 23  [0x69297]
+                           2825 base::internal::scoped_ptr_impl<brightray::BrowserContext, base::DefaultDeleter<brightray::BrowserContext> >::~scoped_ptr_impl()  (in ) + 23  [0x692b7]
+                             2825 base::internal::scoped_ptr_impl<brightray::BrowserContext, base::DefaultDeleter<brightray::BrowserContext> >::~scoped_ptr_impl()  (in ) + 50  [0x692f2]
+                               2825 base::DefaultDeleter<brightray::BrowserContext>::operator()(brightray::BrowserContext*) const  (in ) + 46  [0x6916e]
+                                   2825 brightray::BrowserContext::~BrowserContext()  (in ) + 127  [0x672bf]
+                                     2825 base::SupportsUserData::~SupportsUserData()  (in libchromiumcontent.dylib) + 57  [0xccc019]
+                                       2825 ???  (in libchromiumcontent.dylib)  load address 0x1c9000 + 0xb03230  [0xccc230]
+                                         2825 ???  (in libchromiumcontent.dylib)  load address 0x1c9000 + 0xb0324e  [0xccc24e]
+                                           2825 ???  (in libchromiumcontent.dylib)  load address 0x1c9000 + 0x14c4239  [0x168d239]
+                                             2825 content::StoragePartitionImpl::~StoragePartitionImpl()  (in libchromiumcontent.dylib) + 17  [0x16899a1]
+                                               2825 content::StoragePartitionImpl::~StoragePartitionImpl()  (in libchromiumcontent.dylib) + 491  [0x1689bab]
+                                                 2825 content::ChromeAppCacheService::DeleteOnCorrectThread() const  (in libchromiumcontent.dylib) + 66  [0x1424f32]
+                                                   2825 content::ChromeAppCacheService::~ChromeAppCacheService()  (in libchromiumcontent.dylib) + 50  [0x1424e32]
+                                                     2825 appcache::AppCacheService::~AppCacheService()  (in libchromiumcontent.dylib) + 301  [0x2b8ad2d]
+                                                       2825 ???  (in libchromiumcontent.dylib)  load address 0x1c9000 + 0x29c9b81  [0x2b92b81]
+                                                         2825 ???  (in libchromiumcontent.dylib)  load address 0x1c9000 + 0x29c9da4  [0x2b92da4]
+                                                           2825 appcache::AppCacheDiskCache::~AppCacheDiskCache()  (in libchromiumcontent.dylib) + 17  [0x2b78c71]
+                                                             2825 appcache::AppCacheDiskCache::~AppCacheDiskCache()  (in libchromiumcontent.dylib) + 135  [0x2b78d17]
+                                                               2825 disk_cache::BackendImpl::~BackendImpl()  (in libchromiumcontent.dylib) + 17  [0x25979a1]
+                                                                 2825 disk_cache::BackendImpl::~BackendImpl()  (in libchromiumcontent.dylib) + 305  [0x2597af1]
+                                                                   2825 base::WaitableEvent::Wait()  (in libchromiumcontent.dylib) + 50  [0xccd942]
+                                                                     2825 base::WaitableEvent::TimedWait(base::TimeDelta const&)  (in libchromiumcontent.dylib) + 347  [0xccdb3b]
+                                                                       2825 base::ConditionVariable::Wait()  (in libchromiumcontent.dylib) + 35  [0xcccbb3]
+                                                                         2825 pthread_cond_wait$UNIX2003  (in libsystem_c.dylib) + 71  [0x964d3089]
+                                                                           2825 _pthread_cond_wait  (in libsystem_c.dylib) + 833  [0x9644d280]
+                                                                             2825 __psynch_cvwait  (in libsystem_kernel.dylib) + 10  [0x94b8e8e2]

BackendImpl was waiting on BrowserThread::CACHE, but that thread had already
been stopped. The solution is to destroy the BrowserContext before threads have
been stopped. We now do this in BrowserMainParts::PostMainMessageLoopRun, which
matches content_shell.
2013-10-23 12:16:25 -04:00
Adam Roben
8ff43b034c Merge pull request #13 from brightray/devtools-scheme
Use "chrome-devtools://" scheme for devtools
2013-10-11 07:29:27 -07:00
Cheng Zhao
f623ddf7fc Cleanup unused headers, data members and functions. 2013-10-11 07:17:53 -04:00
Cheng Zhao
2cd6dd791e Setup devtools in the correct phase.
* RegisterDevToolsClientHostFor should be called right after the agent_host and
  the frontend host are created.
* SetupDevToolsFrontendClient should be called before the devtools window is
  going to start navigation.
2013-10-11 07:17:03 -04:00
Cheng Zhao
9d29c8eb7c Use the "chrome-devtools://" scheme to open devtools. 2013-10-10 16:56:52 -04:00
Adam Roben
c949fd931c Merge pull request #31 from brightray/less-flashing
Fix flashing in devtools views
2013-10-10 13:29:14 -07:00
Adam Roben
6b9e61c65d Fix flashing in WebContents we create
If the embedding app creates them it's up to them to fix this.
2013-10-10 16:24:22 -04:00
Adam Roben
8ae459e9fa Work around http://crbug.com/279472 for devtools views 2013-10-10 14:17:30 -04:00
Adam Roben
c0e744db78 Update libchromiumcontent to use Xcode's clang
* vendor/libchromiumcontent 759a8d0...21d99bd (1):
  > Merge pull request #28 from brightray/xcode-clang
2013-10-09 12:58:36 -04:00
Adam Roben
d06ac20947 Update to latest libchromiumcontent
* vendor/libchromiumcontent bfb2d7b...759a8d0 (1):
  > Remove googleurl/ from the distribution
2013-10-08 13:20:43 -04:00
Adam Roben
1f1f93465b Make MediaStreamDevicesController::Accept/Deny public again
Clients rely on this.
2013-10-07 17:04:40 -04:00