Charles Kerr
bb4374ee2c
fix: potential null dereference in normalizeSpawnArguments() patch ( #42260 )
...
fix: potential null deref in normalizeSpawnArguments() patch
Use upstream's practice of using `env = options.env || process.env`.
Previously, we were unconditionally assigning CRASHDUMP_SIGNAL_FD
and CRASHPAD_HANDLER_PID to options.env.
2024-05-27 10:41:42 +02:00
electron-roller[bot]
653d0f009e
chore: bump node to v20.13.1 (main) ( #42088 )
...
* chore: bump node in DEPS to v20.13.0
* crypto: enable NODE_EXTRA_CA_CERTS with BoringSSL
https://github.com/nodejs/node/pull/52217
* test: skip test for dynamically linked OpenSSL
https://github.com/nodejs/node/pull/52542
* lib, url: add a `windows` option to path parsing
https://github.com/nodejs/node/pull/52509
* src: use dedicated routine to compile function for builtin CJS loader
https://github.com/nodejs/node/pull/52016
* test: mark test as flaky
https://github.com/nodejs/node/pull/52671
* build,tools: add test-ubsan ci
https://github.com/nodejs/node/pull/46297
* src: preload function for Environment
https://github.com/nodejs/node/pull/51539
* chore: fixup patch indices
* deps: update c-ares to 1.28.1
https://github.com/nodejs/node/pull/52285
* chore: handle updated filenames
- https://github.com/nodejs/node/pull/51999
- https://github.com/nodejs/node/pull/51927
* chore: bump node in DEPS to v20.13.1
* events: extract addAbortListener for safe internal use
https://github.com/nodejs/node/pull/52081
* module: print location of unsettled top-level await in entry points
https://github.com/nodejs/node/pull/51999
* fs: add stacktrace to fs/promises
https://github.com/nodejs/node/pull/49849
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-05-13 11:43:14 -04:00
Cheng Zhao
d13a93fb61
chore: remove node patches by using the preload feature ( #41080 )
2024-01-24 09:54:32 -06:00
Shelley Vohr
9c94fd7afb
chore: upgrade to Node.js v20 ( #40545 )
...
* chore: upgrade to Node.js v20
* src: allow embedders to override NODE_MODULE_VERSION
https://github.com/nodejs/node/pull/49279
* src: fix missing trailing ,
https://github.com/nodejs/node/pull/46909
* src,tools: initialize cppgc
https://github.com/nodejs/node/pull/45704
* tools: allow passing absolute path of config.gypi in js2c
https://github.com/nodejs/node/pull/49162
* tools: port js2c.py to C++
https://github.com/nodejs/node/pull/46997
* doc,lib: disambiguate the old term, NativeModule
https://github.com/nodejs/node/pull/45673
* chore: fixup Node.js BSSL tests
* https://github.com/nodejs/node/pull/49492
* https://github.com/nodejs/node/pull/44498
* deps: upgrade to libuv 1.45.0
https://github.com/nodejs/node/pull/48078
* deps: update V8 to 10.7
https://github.com/nodejs/node/pull/44741
* test: use gcUntil() in test-v8-serialize-leak
https://github.com/nodejs/node/pull/49168
* module: make CJS load from ESM loader
https://github.com/nodejs/node/pull/47999
* src: make BuiltinLoader threadsafe and non-global
https://github.com/nodejs/node/pull/45942
* chore: address changes to CJS/ESM loading
* module: make CJS load from ESM loader (https://github.com/nodejs/node/pull/47999 )
* lib: improve esm resolve performance (https://github.com/nodejs/node/pull/46652 )
* bootstrap: optimize modules loaded in the built-in snapshot
https://github.com/nodejs/node/pull/45849
* test: mark test-runner-output as flaky
https://github.com/nodejs/node/pull/49854
* lib: lazy-load deps in modules/run_main.js
https://github.com/nodejs/node/pull/45849
* url: use private properties for brand check
https://github.com/nodejs/node/pull/46904
* test: refactor `test-node-output-errors`
https://github.com/nodejs/node/pull/48992
* assert: deprecate callTracker
https://github.com/nodejs/node/pull/47740
* src: cast v8::Object::GetInternalField() return value to v8::Value
https://github.com/nodejs/node/pull/48943
* test: adapt test-v8-stats for V8 update
https://github.com/nodejs/node/pull/45230
* tls: ensure TLS Sockets are closed if the underlying wrap closes
https://github.com/nodejs/node/pull/49327
* test: deflake test-tls-socket-close
https://github.com/nodejs/node/pull/49575
* net: fix crash due to simultaneous close/shutdown on JS Stream Sockets
https://github.com/nodejs/node/pull/49400
* net: use asserts in JS Socket Stream to catch races in future
https://github.com/nodejs/node/pull/49400
* lib: fix BroadcastChannel initialization location
https://github.com/nodejs/node/pull/46864
* src: create BaseObject with node::Realm
https://github.com/nodejs/node/pull/44348
* src: implement DataQueue and non-memory resident Blob
https://github.com/nodejs/node/pull/45258
* sea: add support for V8 bytecode-only caching
https://github.com/nodejs/node/pull/48191
* chore: fixup patch indices
* gyp: put filenames in variables
https://github.com/nodejs/node/pull/46965
* build: modify js2c.py into GN executable
* fix: (WIP) handle string replacement of fs -> original-fs
* [v20.x] backport vm-related memory fixes
https://github.com/nodejs/node/pull/49874
* src: make BuiltinLoader threadsafe and non-global
https://github.com/nodejs/node/pull/45942
* src: avoid copying string in fs_permission
https://github.com/nodejs/node/pull/47746
* look upon my works ye mighty
and dispair
* chore: patch cleanup
* [api] Remove AllCan Read/Write
https://chromium-review.googlesource.com/c/v8/v8/+/5006387
* fix: missing include for NODE_EXTERN
* chore: fixup patch indices
* fix: fail properly when js2c fails in Node.js
* build: fix js2c root_gen_dir
* fix: lib/fs.js -> lib/original-fs.js
* build: fix original-fs file xforms
* fixup! module: make CJS load from ESM loader
* build: get rid of CppHeap for now
* build: add patch to prevent extra fs lookup on esm load
* build: greatly simplify js2c modifications
Moves our original-fs modifications back into a super simple python script action, wires up the output of that action into our call to js2c
* chore: update to handle moved internal/modules/helpers file
* test: update @types/node test
* feat: enable preventing cppgc heap creation
* feat: optionally prevent calling V8::EnableWebAssemblyTrapHandler
* fix: no cppgc initialization in the renderer
* gyp: put filenames in variables
https://github.com/nodejs/node/pull/46965
* test: disable single executable tests
* fix: nan tests failing on node headers missing file
* tls,http2: send fatal alert on ALPN mismatch
https://github.com/nodejs/node/pull/44031
* test: disable snapshot tests
* https://github.com/nodejs/node/pull/47887
* https://github.com/nodejs/node/pull/49684
* https://github.com/nodejs/node/pull/44193
* build: use deps/v8 for v8/tools
Node.js hard depends on these in their builtins
* test: fix edge snapshot stack traces
https://github.com/nodejs/node/pull/49659
* build: remove js2c //base dep
* build: use electron_js2c_toolchain to build node_js2c
* fix: don't create SafeSet outside packageResolve
Fixes failure in parallel/test-require-delete-array-iterator:
=== release test-require-delete-array-iterator ===
Path: parallel/test-require-delete-array-iterator
node:internal/per_context/primordials:426
constructor(i) { super(i); } // eslint-disable-line no-useless-constructor
^
TypeError: object is not iterable (cannot read property Symbol(Symbol.iterator))
at new Set (<anonymous>)
at new SafeSet (node:internal/per_context/primordials:426:22)
* fix: failing crashReporter tests on Linux
These were failing because our change from node::InitializeNodeWithArgs to
node::InitializeOncePerProcess meant that we now inadvertently called
PlatformInit, which reset signal handling. This meant that our intentional
crash function ElectronBindings::Crash no longer worked and the renderer process
no longer crashed when process.crash() was called. We don't want to use Node.js'
default signal handling in the renderer process, so we disable it by passing
kNoDefaultSignalHandling to node::InitializeOncePerProcess.
* build: only create cppgc heap on non-32 bit platforms
* chore: clean up util:CompileAndCall
* src: fix compatility with upcoming V8 12.1 APIs
https://github.com/nodejs/node/pull/50709
* fix: use thread_local BuiltinLoader
* chore: fixup v8 patch indices
---------
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
2023-11-30 09:51:35 -05:00
electron-roller[bot]
1766511e34
chore: bump node to v18.18.0 (main) ( #39915 )
...
* chore: bump node in DEPS to v18.18.0
* child_process: harden against prototype pollution
https://github.com/nodejs/node/pull/48726
* deps: upgrade to libuv 1.46.0
https://github.com/nodejs/node/pull/49591
* module: reduce url invocations in esm/load.js
https://github.com/nodejs/node/pull/48337
* Revert "test: remove test-crypto-keygen flaky designation"
https://github.com/nodejs/node/pull/48652
* fix: FTBTFS in ada dep
https://github.com/ada-url/ada/pull/464
https://github.com/ada-url/idna/pull/31
* fix: force_colors snapshot line number
* chore: fixup patch indices
* chore: update filenames.json
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2023-09-20 16:13:43 -04:00
electron-roller[bot]
ab08803959
chore: bump node to v18.17.0 (main) ( #39154 )
...
* chore: bump node in DEPS to v18.17.0
* chore: update build_modify_js2c_py_to_allow_injection_of_original-fs_and_custom_embedder_js.patch
Xref: https://github.com/nodejs/node/pull/46930
manually sync patch to minor upstream code shear
* chore: update build_ensure_native_module_compilation_fails_if_not_using_a_new.patch
Xref: https://github.com/nodejs/node/pull/48248
manually sync patch to minor upstream code shear
* chore: update fix_expose_the_built-in_electron_module_via_the_esm_loader.patch
Xref: https://github.com/nodejs/node/pull/47824
chore: upstream func throwIfUnsupportedURLProtocol() has been removed, so no need to patch it
* chore: update api_pass_oomdetails_to_oomerrorcallback.patch
Xref: https://github.com/nodejs/node/pull/47695
manually sync patch to minor upstream code shear
* chore: remove fix_prevent_changing_functiontemplateinfo_after_publish.patch
Xref: https://github.com/nodejs/node/pull/46979 (upstreamed patch)
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/2718147 (related)
* chore: update fix_adapt_debugger_tests_for_upstream_v8_changes.patch
Xref: https://github.com/nodejs/node/pull/47274
manually sync patch to minor upstream code shear
some tests moved from sequential to parallel
* chore: remove fix_libc_buffer_overflow_in_string_view_ctor.patch
Xref: fix_libc_buffer_overflow_in_string_view_ctor.patch
patch is no longer needed due to upstream bump to ada 2.2.0
* chore: remove fix_preventing_potential_oob_in_ada_no_scheme_parsing.patch
Xref: https://github.com/nodejs/node/pull/47339
patch is no longer needed due to upstream bump to ada 2.2.0
* chore: rebuild filenames.json
several files removed/added/changed upstream
* chore: update build_add_gn_build_files.patch
upstream dep histogram 0.11.7 moved its include path from src/ to include/
Xref: https://github.com/nodejs/node/pull/47742
* chore: update fix_crypto_tests_to_run_with_bssl.patch
Xref: https://github.com/nodejs/node/pull/47160
BoringSSL doesn't support BIO_s_secmem() (a secure heap variant of
BIO_s_mem()), so use BIO_s_mem() instead.
Related discussion of secure heap support in BoringSSL:
https://boringssl-review.googlesource.com/c/boringssl/+/54309
* fix: ftbfs in node dep ada
* fix: ftbfs in node dep uvwasi
* chore: rebuild patches
* chore: update fix_handle_boringssl_and_openssl_incompatibilities.patch
Upstream used `BIO_s_secmem()`, a secure heap variant of `BIO_s_mem()`.
BoringSSL doesn't support it, so this PR opts for `BIO_s_mem()` instead.
Upstream Node.js change that prompted this:
https://github.com/nodejs/node/pull/47160
Related discussion of BoringSSL support of secure heap:
https://boringssl-review.googlesource.com/c/boringssl/+/54309
* fix: work around Node 18 isURL() regression
* chore: sort script/node-disabled-tests.json alphabetically
* test: add parallel/test-snapshot-argv1 to disabled list
test: add parallel/test-snapshot-namespaced-builtin to disabled list
We don't support that type of snapshotting at the moment.
* chore: disable flaky node test parallel/test-dgram-send-cb-quelches-error
fails upstream in v18.x on my box as well
* ci: ensure spawned node tests have ELECTRON_RUN_AS_NODE set
* fixup! fix: work around Node 18 isURL() regression
fix: infinite loop regression
* fixup! fix: work around Node 18 isURL() regression
* chore: patch fixtures/errors/force_colors.snapshot
The line numbers in the stacktrace from our v8 build don't match what
Node's tests are expecting, so update the stacktrace to match our build.
The specific numbers probably aren't t needed for the force_colors test,
which is trying to see whether or not the lines are greyed out. One option
is to upstream a test change to stop hardcoding the stacktrace.
* fixup! fix: work around Node 18 isURL() regression
fix; pull in upstream bugfix
* fixup! ci: ensure spawned node tests have ELECTRON_RUN_AS_NODE set
chore: do not inject ELECTRON_RUN_AS_NODE in test-assert-colors.js
* chore: disable flaky node test parallel/test-debugger-random-port-with-inspect-port
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2023-08-08 17:52:51 -05:00
electron-roller[bot]
de192c2db2
chore: bump node to v18.16.0 (main) ( #37973 )
...
* chore: bump node in DEPS to v18.16.0
* build,test: add proper support for IBM i
https://github.com/nodejs/node/pull/46739
* lib: enforce use of trailing commas
https://github.com/nodejs/node/pull/46881
* src: add initial support for single executable applications
https://github.com/nodejs/node/pull/45038
* lib: do not crash using workers with disabled shared array buffers
https://github.com/nodejs/node/pull/41023
* src: remove shadowed variable in OptionsParser::Parse
https://github.com/nodejs/node/pull/46672
* src: allow embedder control of code generation policy
https://github.com/nodejs/node/pull/46368
* src: allow optional Isolate termination in node::Stop()
https://github.com/nodejs/node/pull/46583
* lib: fix BroadcastChannel initialization location
https://github.com/nodejs/node/pull/46864
* chore: fixup patch indices
* chore: sync filenames.json
* fix: add simdutf dep to src/inspector BUILD.gn
- https://github.com/nodejs/node/pull/46471
- https://github.com/nodejs/node/pull/46472
* deps: replace url parser with Ada
https://github.com/nodejs/node/pull/46410
* tls: support automatic DHE
https://github.com/nodejs/node/pull/46978
* fixup! src: add initial support for single executable applications
* http: unify header treatment
https://github.com/nodejs/node/pull/46528
* fix: libc++ buffer overflow in string_view ctor
https://github.com/nodejs/node/pull/46410
* test: include strace openat test
https://github.com/nodejs/node/pull/46150
* fixup! fixup! src: add initial support for single executable applications
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2023-04-18 22:23:11 +02:00
electron-roller[bot]
1d9a4ab02c
chore: bump node to v18.13.0 (main) ( #36818 )
...
* chore: bump node in DEPS to v18.13.0
* child_process: validate arguments for null bytes
https://github.com/nodejs/node/pull/44782
* bootstrap: merge main thread and worker thread initializations
https://github.com/nodejs/node/pull/44869
* module: ensure relative requires work from deleted directories
https://github.com/nodejs/node/pull/42384
* src: add support for externally shared js builtins
https://github.com/nodejs/node/issues/44000
* lib: disambiguate `native module` to `binding`
https://github.com/nodejs/node/pull/45673
* test: convert test-debugger-pid to async/await
https://github.com/nodejs/node/pull/45179
* deps: upgrade to libuv 1.44.2
https://github.com/nodejs/node/pull/42340
* src: fix cppgc incompatibility in v8
https://github.com/nodejs/node/pull/43521
* src: use qualified `std::move` call in node_http2
https://github.com/nodejs/node/pull/45555
* build: fix env.h for cpp20
https://github.com/nodejs/node/pull/45516
* test: remove experimental-wasm-threads flag
https://github.com/nodejs/node/pull/45074
* src: iwyu in cleanup_queue.cc
https://github.com/nodejs/node/pull/44983
* src: add missing include for `std::all_of`
https://github.com/nodejs/node/pull/45541
* deps: update ICU to 72.1
https://github.com/nodejs/node/pull/45068
* chore: fixup patch indices
* chore: remove errant semicolons
- https://github.com/nodejs/node/pull/44179
- https://github.com/nodejs/node/pull/44193
* src: add support for externally shared js builtins
https://github.com/nodejs/node/pull/44376
* chore: add missing GN filenames
* deps: update nghttp2 to 1.51.0
https://github.com/nodejs/node/pull/45537
* chore: disable more Node.js snapshot tests
The Snapshot feature is currently disabled
* chore: disable ICU timezone tests
Node.js uses a different version of ICU than Electron so they
will often be out of sync.
* chore: disable threadpool event tracing test
Event tracing is not enabled in embedded Node.js
* chore: fixup patch indices
* chore: comments from review
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2023-01-11 11:33:48 +01:00
Robo
2c723d7e84
fix: enable crashpad for ELECTRON_RUN_AS_NODE processes ( #36460 )
...
* wip: enable crashpad for node processes
fix: add PID testing method
wip: plumb fd into child_process in node
* node::ProcessInitializationFlags::kNoDefaultSignalHandling
* chore: clean up debug logging
* chore: gate platform includes
* test: clean up node process test
* fix: pass pid in node_main
* chore: cleanup impl
* chore: fixup patch method definition
* fix: expose bound methods to node_main
* fix: remove bound methods
* fix: crashpad connection for all ELECTRON_RUN_AS_NODE processes
* chore: fix typo
* chore: address review feedback
* chore: delay crashpad initialization
* chore: ensure options.env, code hygiene
* chore: add argv test, check for process.env over {}
* fix: fix test, return options.env immutability
Co-authored-by: VerteDinde <keeleymhammond@gmail.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
2022-11-29 10:33:54 -05:00
