Kevin Sawicki
86b1deedfa
Inherit enabled-sandbox in opened windows
2017-07-17 11:55:15 -07:00
Kevin Sawicki
c71b0a5441
Add spec for configuring web preferences from sandboxed new-window event
2017-07-17 11:55:15 -07:00
Kevin Sawicki
0a71a9b992
Merge pull request #9695 from shubham2892/alwaysOnTop-window-disappears-when-restored-fix
...
Fix an issue where alwaysOnTop window disappears when restore…
2017-07-14 10:09:13 -07:00
Kevin Sawicki
4935e8567f
Initialize level_ in initWithShell
2017-07-14 10:07:06 -07:00
Alexandre Lachèze
6e3407d4a4
✅ Forgot a describe.only
2017-07-05 19:10:02 +02:00
Alexandre Lachèze
2231673b03
✅ Remove already tested part
2017-07-05 17:36:39 +02:00
Alexandre Lachèze
67cec5fd26
✅ add tests for BrowserWindow.addExtension
2017-07-05 17:21:06 +02:00
Aleksei Kuzmin
120b05e075
Fix error message of assertWithinDelta()
2017-07-04 11:56:21 +02:00
Kevin Sawicki
449776f228
Don't run it statements when OSR is disabled
2017-06-29 12:26:45 -07:00
Aleksei Kuzmin
25e1c5d6e7
Skip "offscreen rendering" tests if OSR is not available
2017-06-28 19:34:57 +02:00
Shubham
1b8963ff6e
🍎 Fix full screen when resizable is set to true
2017-06-20 16:11:28 -04:00
Kevin Sawicki
45dc6fc04f
Merge pull request #9645 from dharders/issue6036-fix-windows-fullscreen-startup-toggle
...
Fix unresponsive app after fullscreen->normal state toggle (Windows)
2017-06-14 14:10:00 -07:00
dharders
909344415e
🎨 Use leave-full-screen event instead of setTimeout()
2017-06-14 11:06:33 +10:00
Shubham
f001377493
🍎 Fix an issue where alwaysOnTop window disappears when restored from the application icon
2017-06-07 12:28:50 -04:00
Kevin Sawicki
c60a9d242e
Disable minimize spec on Linux CI
2017-06-06 16:58:28 -07:00
Kevin Sawicki
a53e98c0f3
Add visibilitystate test for showInactive
2017-06-06 16:45:46 -07:00
Kevin Sawicki
52137485f2
Add separate specs for hide/show/minimize visibilitychange events
2017-06-06 16:22:07 -07:00
Kevin Sawicki
28cd973805
Mention document.hidden in spec description
2017-06-06 15:20:08 -07:00
Birunthan Mohanathas
7d2226e05e
Let Chromium manage document.visibilityState
and document.hidden
...
Chromium already includes the necessary plumbing to manage the
visibility properties and `visibilitychange` event so this gets rid of
most of our custom logic for `BrowserWindow` and `BrowserView`.
Note that `webview` remains unchanged and is still affected by the issues
listed below.
User facing changes:
- The `document` visibility properties and `visibilitychange` event are
now also updated/fired in response to occlusion changes on macOS. In
other words, `document.visibilityState` will now be `hidden` on macOS
if the window is occluded by another window.
- Previously, `visibilitychange` was also fired by *both* Electron and
Chromium in some cases (e.g. when hiding the window). Now it is only
fired by Chromium so you no longer get duplicate events.
- The visiblity state of `BrowserWindow`s created with `{ show: false }`
is now initially `visible` until the window is shown and hidden.
- The visibility state of `BrowserWindow`s with `backgroundThrottling`
disabled is now permanently `visible`.
This should also fix #6860 (but not for `webview`).
2017-06-06 15:16:01 -07:00
deepak1556
50ac7b2edd
Revert "Merge pull request #8724 from electron/defer_load_url"
...
Possible cause for #9121
This reverts commit 886b47e713
, reversing
changes made to 479af3c9e2
.
2017-06-05 19:04:21 +05:30
dharders
aeb68c2369
✅ Add test for Windows fullscreen state toggle. Fix #6036
2017-06-05 11:39:15 +10:00
Kevin Sawicki
5cf4995f2e
DRY up logic to check if native modules should be loaded
2017-05-30 09:15:38 -07:00
Kevin Sawicki
36989e19f8
Add spec for cross-origin blockage
2017-05-26 10:10:36 -07:00
Kevin Sawicki
e735aa7dee
web-preferences -> webPreferences
2017-05-26 10:10:36 -07:00
Kevin Sawicki
f5cf6d4ddd
Add spec for native window.open from iframe
2017-05-26 10:10:36 -07:00
Kevin Sawicki
92f14f8d52
printerList() -> getPrinters()
2017-05-18 10:14:55 -07:00
Kevin Sawicki
84a9b6a42d
Merge remote-tracking branch 'origin/master' into renaesop_master
2017-05-18 10:08:40 -07:00
Cheng Zhao
9bed0ffdbf
Merge pull request #9440 from brenca/osr-fixes
...
Additional small OSR fixes
2017-05-17 17:14:27 +09:00
Thiago de Arruda
5654ff0d43
Add test for #9387
2017-05-16 09:07:41 -03:00
Heilig Benedek
802501fb04
update osr specs
2017-05-13 02:14:30 +02:00
Ryohei Ikegami
7ac93045b7
Merge branch 'master' into native-window-open
2017-05-11 13:51:43 +09:00
Kevin Sawicki
8c856922f3
Merge pull request #9292 from 22222/issue8911
...
Fix #8911
2017-05-09 09:06:26 -07:00
renaesop
dfcc882dcc
Add a test for webcontents.printerList
.
2017-05-09 10:38:03 +08:00
22222
042b511a27
Fix #8911
2017-05-03 12:47:00 -05:00
Thiago de Arruda
a8640fb8a3
Add test to verify memory is released after sandboxed popup is closed
2017-05-01 11:30:07 -03:00
deepak1556
5e976be43b
remove page-title-updated workaround for #3380
2017-05-01 16:53:55 +09:00
deepak1556
e4524ce42e
add spec
2017-05-01 16:53:55 +09:00
Ryohei Ikegami
3c5179b717
Merge branch 'native-window-open' of github.com:seanchas116/electron into native-window-open
2017-04-30 19:37:23 +09:00
Ryohei Ikegami
0034b306f5
Add test for nativeWindowOpen + contextIsolation
2017-04-30 19:33:40 +09:00
Ryohei Ikegami
edeac2f59e
Split test HTML file into separate ones
2017-04-30 18:54:08 +09:00
Ryohei Ikegami
1d73e84a29
Merge branch 'master' into native-window-open
2017-04-27 12:03:55 +09:00
Kevin Sawicki
dc8b43901b
Merge pull request #9108 from yuya-oc/add-macos-sheet-events
...
Add sheet-begin and sheet-end events to macOS BrowserWindow
2017-04-20 10:33:31 -07:00
Kevin Sawicki
6b13fab83a
Wait for full screen event before leaving kiosk mode
2017-04-19 09:13:26 -07:00
Ryohei Ikegami
91f31506ef
Skip native addon test in Windows
2017-04-19 00:11:23 +09:00
Yuya Ochiai
75184046f6
Add events to manage sheets of macOS BrowserWindow
2017-04-15 16:26:45 +09:00
Ryohei Ikegami
659722924d
Don't show BrowserWindow in test
2017-04-06 11:44:20 +09:00
Ryohei Ikegami
349ea3a15a
Add test for native addon after reload
2017-04-06 11:43:57 +09:00
Ryohei Ikegami
61fa8693d2
Merge branch 'master' into native-window-open
2017-04-04 20:54:37 +09:00
Ryohei Ikegami
051e133ce3
Add test for opeing HTML file
2017-04-04 19:05:13 +09:00
Kevin Sawicki
e699e88b4c
Add initial tabbingIdentifier spec
2017-03-30 13:46:58 -07:00
Ryohei Ikegami
3af9f572ac
Fix spec description
2017-03-19 20:10:25 +09:00
Ryohei Ikegami
6bbfe89f96
Add spec for useNativeWindowOpen
2017-03-19 18:11:20 +09:00
Kevin Sawicki
6fcb784f6e
Add failing spec for no callback
2017-03-06 10:49:23 -08:00
Kevin Sawicki
f549bda9fc
Merge pull request #8799 from nitsakh/baseURLForDataURL
...
Support base URL option to loadURL for data URLs
2017-03-06 10:25:53 -08:00
deepak1556
eb827eb020
update spec
2017-03-06 00:10:46 +05:30
deepak1556
dead1ae1ba
webContents: defer url load when there is a pending navigation entry
2017-03-06 00:10:46 +05:30
Nitish Sakhawalkar
d75db0ea1a
Fixed js lint issues.
2017-03-02 14:37:09 -08:00
Nitish Sakhawalkar
370562b129
Moving data url test outside post navigation block. Trailing separator comment in the docs.
2017-03-02 12:14:18 -08:00
Nitish Sakhawalkar
e8c0813f46
Changes based on review.
2017-03-02 10:58:39 -08:00
Nitish Sakhawalkar
879082b1a6
Issue #8735:Support base URL option to loadURL for data URLs
2017-02-28 16:49:03 -08:00
Kevin Sawicki
70010fdb8e
Add spec for Buffer global
2017-02-14 08:42:34 -08:00
Cheng Zhao
c72438f09f
WebInspector has been split up
2017-02-06 10:34:29 -08:00
Kevin Sawicki
dc1c11a841
Merge pull request #8487 from leethomas/feature/osx-relative-window-levels
...
Feature/macOS relative window levels
2017-01-30 15:34:24 -08:00
leethomas
edbb786fb4
use kCGMinimumWindowLevelKey to get the minimum level
2017-01-26 19:12:10 -08:00
Kevin Sawicki
76e5589a31
Schedule function after executeJavaScript completes
2017-01-26 16:15:10 -08:00
Kevin Sawicki
2cfa67bdff
Remove linter warning
2017-01-26 09:59:07 -08:00
Kevin Sawicki
a851695bb9
Clear interval before setting new one
2017-01-26 09:57:53 -08:00
Kevin Sawicki
e2e33a8cf0
Guard against destroyed window or web contents
2017-01-26 09:57:00 -08:00
Kevin Sawicki
515f689814
Use helper function to show last dev tools panel
2017-01-26 09:42:45 -08:00
leethomas
9e189b9d2d
fix js lint errors
2017-01-26 07:14:47 -08:00
leethomas
1234b61fa6
spec to ensure an error is thrown when relativeLevel is set out of bounds
2017-01-25 19:39:57 -08:00
Kevin Sawicki
8e39aea34a
Merge pull request #8478 from deepak1556/load_url_max_char_patch
...
WebContents: emit did-fail-load event when url exceeds character limit
2017-01-25 09:46:40 -08:00
deepak1556
d8a16a8ffb
fix spec
2017-01-25 14:20:33 +05:30
Kevin Sawicki
6bb331356e
Finish spec when full screen is left
2017-01-24 11:55:13 -08:00
Kevin Sawicki
284ca3114b
Wait for window to transition before leaving full screen
2017-01-24 11:55:13 -08:00
deepak1556
593a3de850
add spec
2017-01-23 19:57:47 +05:30
Kevin Sawicki
873e6e5e6b
Append form to body before submitting
2017-01-19 09:05:59 +02:00
Kevin Sawicki
f7bdf5d04e
Merge pull request #8399 from watilde/feature/fixes-8338
...
save a fullscreen state when Kiosk mode is called
2017-01-17 13:03:51 -08:00
Kevin Sawicki
1d824d4645
Assert document visibility in main context
2017-01-16 13:03:38 -08:00
Kevin Sawicki
3f7b3c4bd7
Implement window overrides in main context
2017-01-16 12:38:16 -08:00
Kevin Sawicki
95054f443f
Enable context isolation on child windows
2017-01-16 12:38:16 -08:00
Kevin Sawicki
33b6ab11f2
Assert context state after reload
2017-01-16 12:38:16 -08:00
Kevin Sawicki
802ed62d5b
Remove trailing comma
2017-01-16 12:38:16 -08:00
Kevin Sawicki
b348cdeae8
Set page variable using webFrame.executeJavaScript
2017-01-16 12:38:16 -08:00
Kevin Sawicki
ea2273dde5
Assert built-in prototype isolation
2017-01-16 12:38:16 -08:00
Kevin Sawicki
ad3b837ad5
Rename option to contextIsolation
2017-01-16 12:38:16 -08:00
Kevin Sawicki
2928fe5c43
Add initial isolated world spec
2017-01-16 12:38:16 -08:00
Daijiro Wachi
b97db68f0c
add tests to fullScreen and Kiosk
2017-01-14 00:05:04 +01:00
Kevin Sawicki
97dd680b32
Remove linter errors
2017-01-12 10:28:08 -08:00
Kevin Sawicki
8098ca3b66
Remove unneeded nextTick and assert array
2017-01-12 10:28:08 -08:00
Kevin Sawicki
c5da330cdf
Add failing spec for sandboxed window.open
2017-01-12 10:28:08 -08:00
Kevin Sawicki
d8366115f5
Add spec for resizable frameless window
2017-01-09 10:01:38 -08:00
Kevin Sawicki
abea1196de
Add spec for closing from will-navigate listener
2016-12-28 13:40:07 -08:00
Kevin Sawicki
2fa9ca1f6d
Merge pull request #8156 from sindresorhus/remove-dock-window-level
...
🍎 Document that the `dock` window level is deprecated
2016-12-12 09:39:08 -08:00
Kevin Sawicki
1a0fbf84f9
Merge pull request #8165 from geoff-addepar/geoff/fix-sandbox-printing
...
Fix printing with the sandbox enabled
2016-12-12 09:26:52 -08:00
Sindre Sorhus
3dde669ee8
🍎 Remove deprecated dock
window level
...
According to the Apple docs, the `NSDockWindowLevel` constant is deprecated: https://developer.apple.com/reference/appkit/nsdockwindowlevel?language=objc
2016-12-09 12:46:49 +01:00
Geoff Lywood
5345b08d24
Fix printing with the sandbox enabled
...
Closes #7984
2016-12-07 17:40:18 -08:00
Kevin Sawicki
03263bb5b6
Add failing BrowserWindow.fromDevToolsWebContents spec
2016-12-06 10:36:59 -08:00
Kevin Sawicki
b0a1e2988b
Add spec for BrowserWindow.fromWebContents
2016-12-06 10:36:59 -08:00
Kevin Sawicki
b29f7b9acb
Clear interval before assert
2016-12-06 09:25:55 -08:00
Kevin Sawicki
c2f516067f
Add missing r in variable name
2016-12-06 09:22:29 -08:00
Kevin Sawicki
58cae1d8de
Clear interval before destroying window
2016-12-06 09:22:08 -08:00
Kevin Sawicki
10386edea5
Default timeout to 30 seconds on CI and 10 seconds locally
2016-11-29 14:29:35 -08:00
Kevin Sawicki
df179ed28d
Merge pull request #8092 from poiru/setcursorautohide
...
Add BrowserWindow.setCursorAutoHide
2016-11-29 13:36:58 -08:00
Kevin Sawicki
d7e7c2b17f
Assert single window from closeWindow helper
2016-11-29 11:29:20 -08:00
Kevin Sawicki
1afa41477d
Don't use this.skip() since after hooks won't be run
2016-11-29 10:56:58 -08:00
Kevin Sawicki
217848ca52
Assert windows are not leaking across tests
2016-11-29 10:56:17 -08:00
Birunthan Mohanathas
18c49285a8
Add BrowserWindow.setAutoHideCursor for macOS
...
The `disableAutoHideCursor` BrowserWindow option can be used to control
auto-hiding behavior when the window is created. This new API is needed
to dynamically change the behavior after the fact.
2016-11-29 09:46:00 -08:00
Kevin Sawicki
774b2f99f2
Merge pull request #8038 from electron/danhp/close-file-preview
...
Add 'win.closeFilePreview()'
2016-11-28 14:47:06 -08:00
Kevin Sawicki
a7395118af
Merge pull request #7952 from the-ress/window-setappid
...
Added BrowserWindow.setAppDetails to set user model id, icon and relaunch command
2016-11-28 14:46:14 -08:00
Kevin Sawicki
3897a88082
Use skip for setAppDetails spec
2016-11-28 14:43:18 -08:00
Kevin Sawicki
0a61aad499
Add initial previewFile/closeFilePreview test
2016-11-28 14:32:15 -08:00
Kevin Sawicki
6f29d7211e
Move restore/unmaximize specs near state ones
2016-11-22 13:32:39 -08:00
Kevin Sawicki
63eec70350
Assert bounds when restoring
2016-11-22 13:22:30 -08:00
Kevin Sawicki
c0d9175bc3
Try specs without setTimeout calls
2016-11-22 13:14:17 -08:00
Kevin Sawicki
238beb72ee
Remove .only call
2016-11-22 11:41:02 -08:00
Samuel Attard
97b4f12112
Fix linting issues
2016-11-22 16:13:08 +11:00
Samuel Attard
926cabec78
Add spec for maximize restore positioning
2016-11-22 16:07:19 +11:00
Samuel Attard
67f33cdb60
Add failing spec for window size after restore
2016-11-22 15:49:47 +11:00
Kevin Sawicki
d4ba5b4638
Add spec for zoomToPageWidth
2016-11-21 08:45:46 -08:00
Tereza Tomcova
782417b1fa
Added tests for BrowserWindow.setAppDetails
2016-11-18 21:34:01 +01:00
Kevin Sawicki
eeffa42513
Merge pull request #7923 from jhen0409/patch-1
...
Add support remove / clear for chrome.storage
2016-11-15 09:04:45 -08:00
Jhen
8b30439d7f
Update devtools extension spec for chrome.storage
2016-11-15 19:58:08 +08:00
deepak1556
4deb7c6fa7
fix lint error
2016-11-12 07:16:48 +05:30
Kevin Sawicki
134f8afbe6
Add specs for content type on POST forms
2016-11-11 10:54:01 -08:00
Kevin Sawicki
50019f39e9
🎨
2016-11-11 10:54:01 -08:00
Kevin Sawicki
cbb68f6980
Remove quotes around key
2016-11-11 10:54:01 -08:00
deepak1556
61576c39be
uploadData => uploadRawData
2016-11-11 10:54:01 -08:00
deepak1556
ad5f944185
add spec
2016-11-11 10:53:36 -08:00
gellert
5e62d28e50
adds test, adds view to AtomNSWindow and minor fixes
2016-11-11 08:49:57 -08:00
Samuel Attard
9f18a6e65c
Use ES6 template strings, fix docs and remove _ERROR_ IPC event
2016-11-03 09:33:47 -07:00
Samuel Attard
857e1da6a3
Make executeJavaScript return a Promise so that caught errors can be sent to the caller
2016-11-03 09:33:47 -07:00
Samuel Attard
75b010ce63
Add sync executeJavaScript test
2016-11-03 09:33:47 -07:00
Kevin Sawicki
038718717c
Add initial ready-to-show spec
2016-10-31 12:40:49 -07:00
Samuel Attard
a0284a9bc5
Add spec for window.open with webPreferences set to null
2016-10-07 12:13:04 +11:00
Michael Vasseur
edd80d88a9
Update BrowserWindow's test to check additional features upon window.open() call
2016-10-05 13:45:15 +02:00
Kevin Sawicki
d942694695
openedWindow -> popupWindow
2016-09-30 08:54:24 -07:00
Kevin Sawicki
766f5afabd
Explicitly close popup window
2016-09-30 08:50:41 -07:00
Kevin Sawicki
e16fa08e61
🎨
2016-09-30 08:38:21 -07:00
Kevin Sawicki
3bed19d70d
Add spec for BrowserWindow.setAlwaysOnTop
2016-09-28 09:23:52 -07:00
Thiago de Arruda
47fd41715f
Add some tests for "sandbox" option
2016-09-27 06:01:47 -03:00
Phil Haack
cadbd7beb1
Merge pull request #7145 from electron/device-scale-factor-failures
...
Get specs passing on displays using certain device scale factors
2016-09-09 07:38:23 -07:00
Kevin Sawicki
7c26fe46b8
=== -> !==
2016-09-08 17:12:53 -07:00
Kevin Sawicki
68c67b64c5
Use delta when scale factor is above 2 and odd
2016-09-08 16:24:11 -07:00
Kevin Sawicki
59a49f6f96
Use bounds helper in failing specs
2016-09-08 16:20:46 -07:00
Kevin Sawicki
7494e286d9
Put actual value first
2016-09-08 16:20:45 -07:00
Kevin Sawicki
d88f70caa2
Use single assert bounds helper
2016-09-08 16:20:45 -07:00
Kevin Sawicki
71fac07a93
Add scale factor assert helpers
2016-09-08 16:20:45 -07:00
Kevin Sawicki
aaf2bb2751
Add spec for deleting Buffer global in preload
2016-09-08 10:34:09 -07:00
Kevin Sawicki
c754b5efdc
Add failing spec for state changes resizing frameless window
2016-08-15 12:30:26 -07:00