Milan Burda
a369a4172b
refactor: move notifications from brightray to atom ( #15209 )
2018-10-17 20:01:11 +02:00
deepak1556
8e125b2953
REVIEW: Remove the notification close-closure in favour of an explicit method
...
https://chromium-review.googlesource.com/c/chromium/src/+/744205
2018-06-19 11:49:40 +10:00
Shelley Vohr
c6f4bbd143
also format missing .cc files
2018-04-18 20:48:45 -04:00
shelley vohr
0e5b6f9300
Upgrade to node v9.3.0 ( #11507 )
...
* update submodule refs for node v9.3.0
* Define "llvm_version" for Node.js build
* NODE_MODULE_CONTEXT_AWARE_BUILTIN -> NODE_BUILTIN_MODULE_CONTEXT_AWARE
* update NodePlatform to MultiIsolatePlatform
* fix linting error
* update node ref
* REVIEW: Explicitly register builtin modules
https://github.com/nodejs/node/pull/16565
* update libcc ref
* switch libcc to c62
* REVIEW: Address node api changes
- Always start the inspector agent for https://github.com/nodejs/node/pull/17085
- Set the tracing controller for node https://github.com/nodejs/node/pull/15538
- Isolate data creation now requires plaform https://github.com/nodejs/node/pull/16700
2018-02-23 10:22:00 +09:00
Zhuo Lu
29f9929703
Organize code
2018-02-10 03:19:47 -08:00
Zhuo Lu
be118d4f13
Make it able to set close button text
2018-02-10 03:19:47 -08:00
Ales Pergl
f3c32647af
Sanitized notification delegate implementation
...
I made `brightray::NotificationDelegate` back into just an interface and
extracted the implementation used by `PlatformNotificationService`, so that
the main process notification implementation can inherit only the interface.
2017-11-24 10:58:53 +09:00
Aleksei Kuzmin
624b63a1ca
Move "atom/common/node_includes.h" to the end of the includes list
...
https://github.com/electron/electron/issues/10363
2017-11-24 10:58:17 +09:00
Tony Ganch
f694b64d71
FIXME: DesktopNotificationDelegate has been removed
...
Related CL: https://codereview.chromium.org/2906883003
2017-11-24 10:58:16 +09:00
Samuel Attard
dc8b583363
Merge pull request #10944 from electron/fix-notification-ref-crash
...
Close the previous notification on multiple calls to show
2017-10-28 12:33:30 +13:00
Matt Crocker
ca8f45a501
Notifications should emit close on close, not eventual GC
2017-10-27 00:04:19 -07:00
Samuel Attard
fe9069c028
Close the previous notification on multiple calls to show
2017-10-27 16:22:21 +13:00
Charlie Hess
db081d95d5
Review CommentZ.
2017-08-21 13:53:50 -07:00
Charlie Hess
2b9b186fd1
Rename soundName → sound.
2017-08-17 17:28:14 -07:00
Charlie Hess
0cfae1cc2b
Plumb in the macOS soundName property for notifications.
2017-08-17 13:31:20 -07:00
Milan Burda
d5df114bb4
🎨 Make Notification getters const methods
2017-06-30 16:54:31 +02:00
Milan Burda
a196bf97bc
🍎 Add subtitle to Notification properties
2017-06-30 16:54:28 +02:00
Samuel Attard
3774482859
Update notification PR as per feedback
2017-06-28 17:00:19 +10:00
Samuel Attard
7eb14243eb
Refactor notification options
2017-06-24 21:39:06 +10:00
Samuel Attard
17e737eba2
s/label/text
2017-06-23 21:04:39 +10:00
Samuel Attard
4f0d48f164
Add support for notification actions on macOS
2017-06-23 20:50:20 +10:00
Cheng Zhao
5fa2831756
Coding style fixes
2017-05-31 16:17:29 +09:00
Samuel Attard
3938373ecb
Fix linting errors and add isSupported
2017-05-30 20:27:24 +10:00
Samuel Attard
686b1388b1
Fix linting issues
2017-05-30 19:12:36 +10:00
Samuel Attard
5048425e6e
Update implementation as per feedback
2017-05-30 19:06:51 +10:00
Samuel Attard
6cdfb43e4e
Emit a close event
2017-05-29 21:33:43 +10:00
Samuel Attard
9aa6b83f86
Fix compilation and click events on macOS
2017-05-29 21:22:44 +10:00
Samuel Attard
c741b584a1
Remove OS specific implementations
2017-05-29 21:18:18 +10:00
Samuel Attard
c6196810a6
Code cleanup
2017-05-23 02:05:13 +10:00
Samuel Attard
7c38633d1e
Initial semi-working windows implementation
2017-05-23 02:05:13 +10:00
Samuel Attard
5dd4d6a961
macOS implementation of notifications in the main process
2017-05-23 02:05:13 +10:00
