Cheng Zhao
4cf6884dd4
fix: detect screen readers by testing their existences ( #39988 )
2023-09-28 11:17:42 -04:00
marekharanczyk
94585f5889
fix: propagate layout call to all children of InspectableWebContentsViewViews ( #39994 )
...
Propagate layout call to all children of InspectableWebContentsViewViews.
When BrowserView bounds are set from js, those might not trigger layout
immediately, sometimes propagating InvalidateLayout call to parent.
View is marked as needing layout, expecting to receive it from parent on
next layout call. The problem is that BrowserView's view is added as child
of InspectableWebContentsViews which does not call setBounds (which
would trigger layout) on all of it's children when doing it's layout,
so it skips propagating Layout call to its children BrowserViews views,
even though those were marked as needing layout.
Call base class View::Layout which will iterate over views' children
and call Layout on those that were marked as needing them.
Fixes #39993 .
2023-09-28 11:17:21 -04:00
John Kleinschmidt
43a646ed85
build: log uploads to GitHub ( #40034 )
2023-09-28 11:15:52 -04:00
dependabot[bot]
f628ce67dd
build(deps): bump get-func-name from 2.0.0 to 2.0.2 ( #40013 )
...
Bumps [get-func-name](https://github.com/chaijs/get-func-name ) from 2.0.0 to 2.0.2.
- [Release notes](https://github.com/chaijs/get-func-name/releases )
- [Commits](https://github.com/chaijs/get-func-name/commits/v2.0.2 )
---
updated-dependencies:
- dependency-name: get-func-name
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-28 10:44:16 +02:00
Shelley Vohr
c8156c3c57
fix: failure on immutable webContents.print(options) ( #39985 )
...
fix: failure on immutable webContents.print(options)
2023-09-28 10:41:46 +02:00
Tomasz
689d1b76de
feat: add middle click event to tray ( #39926 )
...
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2023-09-27 14:21:15 -04:00
Robert Günzler
480f48b2fc
feat: enable dark mode on GTK UIs ( #38977 )
...
feat: port DarkModeManagerLinux
This is needed after https://bugs.chromium.org/p/chromium/issues/detail?id=998903
and replaces the previous workaround to detect dark mode on GTK.
Detect system dark theme preference via xdg settings portal:
https://flatpak.github.io/xdg-desktop-portal/#gdbus-org.freedesktop.portal.Settings
Closes: https://github.com/electron/electron/issues/38961
Closes: https://github.com/electron/electron/issues/28838
Signed-off-by: Robert Günzler <r@gnzler.io>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2023-09-27 14:17:40 -04:00
Erick Zhao
a0ae691a9c
docs: document type-specific module aliases ( #39685 )
2023-09-27 11:07:04 -04:00
Bruno Henrique da Silva
f943b8c940
fix: set window contents as opaque to decrease DWM GPU usage ( #39895 )
...
* set window contents as opaque to decrease DWM GPU usage
* chore: add more context to ShouldWindowContentsBeTransparent
2023-09-27 10:42:46 -04:00
Shelley Vohr
b7c9c895b5
build: fix with enable_pdf_viewer = false ( #39990 )
...
build: fix with enable_pdf_viewer = false
2023-09-27 10:09:53 -04:00
Shelley Vohr
1ba321b733
fix: rounded corners on vibrant macOS modals ( #39979 )
...
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2023-09-27 15:12:37 +02:00
Cheng Zhao
ad57867594
fix: apply size constraints to NSWindow ( #39975 )
2023-09-27 11:11:24 +02:00
Cheng Zhao
e613595982
build: allow overriding electron version ( #39974 )
2023-09-27 14:49:10 +09:00
NoxFly
624ae024e2
docs: Quick Start | Electron Forge chapter requirements updated ( #39639 )
...
* Update quick-start.md
Added a note to a pre-require of Electron Forge.
Otherwise users will have an error `Cannot make for rpm, the following external binaries need to be installed: rpmbuild`
* Add two required steps for Electron Forge to build without errors
* Update docs/tutorial/quick-start.md
Co-authored-by: Erick Zhao <erick@hotmail.ca>
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca>
2023-09-27 08:56:39 +09:00
michal-pichlinski-openfin
2190793fe6
fix: disable background throttling also in the viz::DisplayScheduler ( #38924 )
...
* fix: disable background throttling also in the `viz::DisplayScheduler`
`viz::DisplayScheduler` is responsible for drawing and swapping frames
in the `DisplayScheduler::DrawAndSwap` which is called from the
`DisplayScheduler::AttemptDrawAndSwap` if the `DisplayScheduler::ShouldDraw`
returns true. `ShouldDraw` depends on the `DisplayScheduler` visibility
and when it is not visible then it returns false.
In order to keep producing frames, disabling `backgroundThrottling`
should also prevent changing `DisplayScheduler` visibility to false.
`DisplayScheduler` lives in the `ui::Compositor` where every
`electron::NativewWindow` has its own `Compositor`. `electron::NativewWindow`
may be host of the multiple `electron::api::WebContents` instances which may
have different `WebPreferences` settings. Therefore if at least one
of the `WebContents` requires disabling throttling then all other `WebContents`
using the same window will have it disabled in the `ui::Compositor`.
BREAKING CHANGE:
`backgroundThrottling` set to false will disable frames throttling
in the `BrowserWindow` for all `WebContents` displayed by it.
Close: [#31016 ](https://github.com/electron/electron/issues/31016 )
* fixup! fix: disable background throttling also in the `viz::DisplayScheduler`
* fixup! fix: disable background throttling also in the `viz::DisplayScheduler`
* fixup! fix: disable background throttling also in the `viz::DisplayScheduler`
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2023-09-26 16:00:46 -04:00
Milan Burda
fa215f1009
chore: add deprecated app.runningUnderRosettaTranslation to breaking-changes.md ( #39897 )
...
chore: add deprecated app.runningUnderRosettaTranslation to breaking-changes.md
2023-09-26 13:42:56 -04:00
John Kleinschmidt
943bfa89ce
test: fixup parallel/test-node-output-error test ( #39972 )
2023-09-25 16:23:05 -04:00
Milan Burda
d75a852743
refactor: use type enum in file stats for asar archive ( #39889 )
2023-09-25 13:17:24 +02:00
David Sanders
18f517d8a6
test: vendor node-is-valid-window ( #39965 )
2023-09-25 12:43:57 +02:00
Leon
fdf1ecec47
docs: correct v24 Alpha date ( #39963 )
2023-09-24 23:03:29 -07:00
John Kleinschmidt
beb52ce61c
build: update patch ( #39950 )
2023-09-22 10:33:29 -07:00
Erick Zhao
2085aae915
docs: esm tutorial ( #39722 )
...
* docs: esm tutorial
* Update esm.md
* Update docs/tutorial/esm.md
Co-authored-by: Michaela Laurencin <35157522+mlaurencin@users.noreply.github.com>
* table adjustment
* fix lint
* Update docs/tutorial/esm.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
* Update docs/tutorial/esm.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
* Update docs/tutorial/esm.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
* Update docs/tutorial/esm.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
* Update docs/tutorial/esm.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
* Update esm.md
---------
Co-authored-by: Michaela Laurencin <35157522+mlaurencin@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
2023-09-22 09:49:16 -07:00
Fredy Whatley
7c2df8860b
docs: tiny update on example message-ports.md ( #39884 )
...
Update message-ports.md
fix multiplying object * a number. It would multiply number * number.
2023-09-21 11:46:23 -04:00
github-actions[bot]
56e45baeb8
build: update appveyor image to latest version - e-119.0.6019.2 ( #39924 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com>
2023-09-21 09:49:04 -04:00
Robo
5f712fa325
chore: cherry-pick tls shutdown crash fix from upstream ( #39928 )
2023-09-21 09:47:31 -04:00
John Kleinschmidt
ba8915242a
ci: fix linux builds of forks ( #39933 )
2023-09-21 12:10:46 +02:00
Milan Burda
c9eb3deab5
chore: remove deprecated scroll-touch-{begin,end,edge} events ( #39814 )
...
* chore: remove deprecated `scroll-touch-{begin,end,edge}` events
* update spec/ts-smoke
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2023-09-20 17:41:29 -04:00
Valentin Hăloiu
58fd8825d2
fix: add support for ELECTRON_OZONE_PLATFORM_HINT env var ( #39792 )
...
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2023-09-20 16:21:23 -04:00
Milan Burda
6a8b70639b
fix: app.runningUnderARM64Translation() always returning true on Windows ARM64 ( #39920 )
...
fix: app.runningUnderARM64Translation() always returning true on ARM64
2023-09-20 16:15:19 -04:00
electron-roller[bot]
1766511e34
chore: bump node to v18.18.0 (main) ( #39915 )
...
* chore: bump node in DEPS to v18.18.0
* child_process: harden against prototype pollution
https://github.com/nodejs/node/pull/48726
* deps: upgrade to libuv 1.46.0
https://github.com/nodejs/node/pull/49591
* module: reduce url invocations in esm/load.js
https://github.com/nodejs/node/pull/48337
* Revert "test: remove test-crypto-keygen flaky designation"
https://github.com/nodejs/node/pull/48652
* fix: FTBTFS in ada dep
https://github.com/ada-url/ada/pull/464
https://github.com/ada-url/idna/pull/31
* fix: force_colors snapshot line number
* chore: fixup patch indices
* chore: update filenames.json
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2023-09-20 16:13:43 -04:00
electron-roller[bot]
28eda03aba
chore: bump chromium to 119.0.6019.2 (main) ( #39925 )
...
* chore: bump chromium in DEPS to 119.0.6018.4
* chore: update patches
* chore: bump chromium in DEPS to 119.0.6019.2
* chore: update patches
* 4876292: Roll libc++ from 7cee6b00d34a to 3e8a3b3c5d49 (6 revisions)
https://chromium-review.googlesource.com/c/chromium/src/+/4876292
* 4851616: [Extensions] Enable matchOriginAsFallback for dynamic content scripts
https://chromium-review.googlesource.com/c/chromium/src/+/4851616
* 4869393: [Extensions UserScripts] Add error messages for script matching errors
https://chromium-review.googlesource.com/c/chromium/src/+/4869393
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2023-09-20 16:08:26 -04:00
George Xu
7685f27b31
feat: expose app accessibility transparency settings api ( #39631 )
...
* feat: expose app accessibility transparency settings api
* docs: fix typo
* chore: add doc
* change to property
* add as property instead of method
* chore: fix lint
* rename function name in header
---------
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
2023-09-20 12:48:02 -07:00
Shelley Vohr
463586a6c5
chore(deps): roll nan to pick up upstreams ( #39916 )
2023-09-20 15:37:10 +02:00
electron-roller[bot]
a39c0ee659
chore: bump chromium to 119.0.6017.0 (main) ( #39922 )
...
* chore: bump chromium in DEPS to 119.0.6017.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-09-20 11:30:38 +02:00
github-actions[bot]
0b0a8a5ef3
build: update appveyor image to latest version, e-119.0.6006.0 ( #39908 )
...
build: update appveyor image to latest version
Co-authored-by: jkleinsc <jkleinsc@users.noreply.github.com>
2023-09-19 23:46:47 -07:00
electron-roller[bot]
986becdb4d
chore: bump chromium to 119.0.6016.0 (main) ( #39898 )
...
* chore: bump chromium in DEPS to 119.0.6016.0
* chore: update patches
* 4839124: Rename chrome/app/ branding strings
https://chromium-review.googlesource.com/c/chromium/src/+/4839124
* 4846834: Clean up PrintRenderFrameHelper interaction with Blink.
https://chromium-review.googlesource.com/c/chromium/src/+/4846834
* 4850759: Cache bounds of document pip windows
https://chromium-review.googlesource.com/c/chromium/src/+/4850759
* 4864669: Roll libc++ from 84fb809dd6da to 68a6f0b88287 (352 revisions)
https://chromium-review.googlesource.com/c/chromium/src/+/4864669
* 4863987: Remove five gpu workarounds.
https://chromium-review.googlesource.com/c/chromium/src/+/4863987
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2023-09-19 19:34:56 +02:00
Samuel Attard
75ea294b6f
build: use afs on aks instead of circle cache ( #39881 )
...
* build: use afs on aks instead of circle cache
* build: do not use aks logic on linux hosts checking out for macOS
* build: fix gn-check could-be-aks
* build: sigh
* build: no ls mnt
* build: keep build alive while debugging
* build: make debuggable
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2023-09-19 03:12:14 -07:00
spencer17x
18717ee62d
docs: add a more detailed explanation to cookies.flushStore() ( #37572 )
...
* docs: cookies.flushStore()
* docs: modify cookies.flushStore()
* Update docs/api/cookies.md
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2023-09-18 16:51:46 -04:00
electron-roller[bot]
73e33bc876
chore: bump chromium to 119.0.6006.0 (main) ( #39774 )
...
* chore: bump chromium in DEPS to 119.0.5994.0
* chore: update patches
* Add some more debugging for navigation origin & process lock mismatch
https://chromium-review.googlesource.com/c/chromium/src/+/4829483
* chore: bump chromium in DEPS to 119.0.5996.2
* chore: bump chromium in DEPS to 119.0.5997.0
* chore: bump chromium in DEPS to 119.0.6000.0
* chore: bump chromium in DEPS to 119.0.6002.0
* 4781766: Port remaining control color ids to the color pipeline
https://chromium-review.googlesource.com/c/chromium/src/+/4781766
* 4846057: Preloading: Move prefetch_prefs to chrome/browser/preloading/
https://chromium-review.googlesource.com/c/chromium/src/+/4846057
* chore: fixup patch indices
* 4848108: Pass v8::Isolate into FromV8Value calls on blink API
https://chromium-review.googlesource.com/c/chromium/src/+/4848108
* 4834471: Reland "[api] allow v8::Data as internal field"
https://chromium-review.googlesource.com/c/v8/v8/+/4834471
* 4808884: Major overhaul of ExceptionState in the v8 bindings
https://chromium-review.googlesource.com/c/chromium/src/+/4808884
* 4791643: [sandbox] Add a TRUSTED_SPACE and TRUSTED_LO_SPACE to the V8 heap
https://chromium-review.googlesource.com/c/v8/v8/+/4791643
* chore: bump chromium in DEPS to 119.0.6005.0
* 4776268: [v8][etw] Enables filtering of ETW tracing by URL
https://chromium-review.googlesource.com/c/chromium/src/+/4776268
* chore: fixup patch indices
* 4673258: WebSQL: Disable WebSQL by default
https://chromium-review.googlesource.com/c/chromium/src/+/4673258
* chore: bump chromium in DEPS to 119.0.6006.0
* chore: update patches
* 4854732: Reland^2 "[iterator-helpers] Unship due to incompat"
https://chromium-review.googlesource.com/c/v8/v8/+/4854732
* 4794133: [AWC] Add `display-state` CSS @media feature
https://chromium-review.googlesource.com/c/chromium/src/+/4794133
* fixup! Add some more debugging for navigation origin & process lock mismatch
* Revert "fixup! Add some more debugging for navigation origin & process lock mismatch"
This reverts commit 38fef075fc5690f7db6d4bbcabbe877a1618a964.
* 4858437: Revert "[iOS] Delete GN flags for mach absolute time ticks"
https://chromium-review.googlesource.com/c/chromium/src/+/4858437
* refactor: fix_crash_loading_non-standard_schemes_in_iframes.patch (#39879 )
* chore: 4869108: handle absolute and relative gn imports in autoninja
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4869108
* chore: set GOMA_DIR for autoninja
* Revert "chore: 4869108: handle absolute and relative gn imports in autoninja"
This reverts commit d94c7720bab96d1de25499383948da2cb8862d90.
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Robo <hop2deep@gmail.com>
2023-09-18 16:44:09 -04:00
John Kleinschmidt
c8544e25df
build: fixup autoninja ( #39896 )
...
chore: set GOMA_DIR for autoninja
(cherry picked from commit 94f24bde4dd19764fbbae083f5970b007c9dc8b2)
(cherry picked from commit 90c1f6e1cb8d22d94dd01791dc4b9c3e0a7e86fc)
2023-09-18 16:43:27 -04:00
Milan Burda
9c7086074e
docs: add missing ipcRenderer.off() / ipcRenderer.addListener() aliases ( #39816 )
...
* docs: add missing `ipcRenderer.off()` / `ipcRenderer.addListener()` aliases
* Update docs/api/ipc-renderer.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
* fix ipcRenderer.removeListener
* update ts-smoke
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
2023-09-19 01:58:20 +09:00
Milan Burda
d7e4bb6608
chore: remove no-op fullscreenWindowTitle option ( #39815 )
2023-09-19 01:55:47 +09:00
David Sanders
706653d5e4
ci: fix issue-commented workflow sytnax ( #39875 )
2023-09-17 19:23:59 -07:00
John Kleinschmidt
65952abc99
test: fixup node flakes ( #39871 )
...
chore: fixup node flakes
2023-09-15 03:43:13 -07:00
Athul Iddya
50ce02c312
fix: check PipeWire init before creating generic capturer ( #39846 )
...
Check if PipeWire can be initialized before creating generic capturer.
This harmonizes the conditions with the ones used in Linux
implementations of DesktopCapturer::CreateRawScreenCapturer and
DesktopCapturer::CreateRawWindowCapturer.
2023-09-14 15:50:20 -04:00
Milan Burda
fb6b92076e
fix: prevent gin_helper::Locker heap allocation ( #39847 )
...
fix: prevent gin_helper::Locker heap allocation
2023-09-14 15:48:43 -04:00
David Sanders
d6c04a3787
ci: ignore actions taken by triage bot ( #39855 )
...
* ci: ignore actions taken by triage bot
* ci: don't remove blocked label on bot comment
2023-09-14 14:01:07 -04:00
Samuel Attard
2791474a01
build: run on circle hosts for forks ( #39858 )
2023-09-14 11:07:11 -04:00
Charles Kerr
f6e8a42c48
refactor: remove unused fields, methods in gin_helper::Locker ( #39803 )
...
* refactor: remove unused field gin_helper::Locker::g_is_browser_process
refactor: remove unused field gin_helper::Locker::g_is_renderer_process
refactor: make field const gin_helper::Locker::locker_
* refactor: remove unused declaration gin_helper::Locker::new()
refactor: remove unused declaration gin_helper::Locker::delete()
* refactor: make field const electron::JavascriptEnvironment::locker_
* refactor: remove unused #include gin_helper/locker.h
2023-09-12 16:53:20 -07:00
David Sanders
650ef9a51c
build: update @electron/lint-roller to 1.9.0 ( #39812 )
2023-09-12 12:38:31 +02:00
