Samuel Attard
731240e0e9
Use USER_WANTS_NO_MORE_DIALOGS constant for -1 magic number
2018-03-06 11:19:15 +09:00
Charles Kerr
a5a068b2ee
fix cpplint errors
...
atom/browser/atom_javascript_dialog_manager.cc:39: Lines should be <= 80 characters long [whitespace/line_length] [2]
atom/browser/atom_javascript_dialog_manager.cc:39: If/else bodies with multiple statements require braces [readability/braces] [4]
atom/browser/atom_javascript_dialog_manager.cc:62: Lines should be <= 80 characters long [whitespace/line_length] [2]
atom/browser/atom_javascript_dialog_manager.cc:89: If/else bodies with multiple statements require braces [readability/braces] [4]
2018-03-06 11:19:15 +09:00
Charles Kerr
2435ffaf09
fix cpplint error
...
atom/browser/atom_javascript_dialog_manager.h:9: Include "map" not in alphabetical order [build/include_alpha] [4]
2018-03-06 11:19:15 +09:00
Samuel Attard
795447f61a
Implement dialog (alert/confirm) blocking as a user switch after the first dialog
...
* This is to enable more browser-like behavior so that users who run third-party code
will not be DOS'ed with alerts and confirms. This is already handled like this
in most major browsers so this will greatly help these developers
2018-03-06 11:19:15 +09:00
Shelley Vohr
199cf31b9e
deprecate screen.getMenuBarHeight
2018-03-05 19:45:51 -05:00
Aleksei Kuzmin
52c0864cb8
Use version 0.0.0-dev everywhere
2018-03-05 16:24:48 +01:00
Shelley Vohr
bf491de9fe
fix styling and add spec
2018-02-28 00:22:42 -08:00
Shelley Vohr
2abc69780e
move native-mate back into the api layer
2018-02-27 13:00:42 -08:00
Shelley Vohr
837a2d4bbd
appease the linter
2018-02-26 22:25:09 -08:00
Samuel Attard
b722150d87
Don't cast manually for NativeWindow*
2018-02-27 16:13:17 +11:00
Samuel Attard
5336b4a89c
Pass arguments instance through the chain in order to throw error
2018-02-27 16:11:58 +11:00
Shelley Vohr
e84d7c0cda
add warning when addTabbedWindow is called on self
2018-02-26 14:47:36 -08:00
Cheng Zhao
53229e3d6c
Fix network delegate race condition ( #12044 )
...
* Fix race condition when getting network delegate
* Remove the evil URLRequestContextGetter::network_delegate
* Move the arguments instead of const referrencing
Safer and more efficient.
2018-02-26 06:23:59 -08:00
Cheng Zhao
f7786a9e48
Merge pull request #11230 from electron/upgrade-to-chromium-62
...
Upgrade to Chromium 62
2018-02-26 14:20:21 +09:00
kaylie
da9f12d1e2
restore old cb
2018-02-25 14:19:40 -08:00
Cheng Zhao
39e0433570
Fix build error after rebasing
2018-02-23 10:22:00 +09:00
shelley vohr
0e5b6f9300
Upgrade to node v9.3.0 ( #11507 )
...
* update submodule refs for node v9.3.0
* Define "llvm_version" for Node.js build
* NODE_MODULE_CONTEXT_AWARE_BUILTIN -> NODE_BUILTIN_MODULE_CONTEXT_AWARE
* update NodePlatform to MultiIsolatePlatform
* fix linting error
* update node ref
* REVIEW: Explicitly register builtin modules
https://github.com/nodejs/node/pull/16565
* update libcc ref
* switch libcc to c62
* REVIEW: Address node api changes
- Always start the inspector agent for https://github.com/nodejs/node/pull/17085
- Set the tracing controller for node https://github.com/nodejs/node/pull/15538
- Isolate data creation now requires plaform https://github.com/nodejs/node/pull/16700
2018-02-23 10:22:00 +09:00
Aleksei Kuzmin
f5d207f8f0
Improve process launch handle sharing API.
...
https://codereview.chromium.org/2950153002
2018-02-23 10:21:24 +09:00
deepak1556
5eb0a89579
REVIEW: let browser context manage cookie change sub list
2018-02-23 10:21:24 +09:00
Aleksei Kuzmin
9fa08fdbc0
Merge views::CustomButton into views::Button.
...
https://chromium-review.googlesource.com/617407
2018-02-23 10:21:24 +09:00
Aleksei Kuzmin
6f00e4a014
REVIEW: Implements core logic for Pixel Canvas
...
https://codereview.chromium.org/2877483003
2018-02-23 10:21:24 +09:00
deepak1556
25d966110e
FIXME: PDF component IPC should be converted to Mojo.
...
https://codereview.chromium.org/2455543002
2018-02-23 10:21:23 +09:00
deepak1556
62635f43f4
base::LaunchOptions fds_to_remap is no longer a pointer
...
https://codereview.chromium.org/2950153002
2018-02-23 10:21:23 +09:00
deepak1556
248d572077
REVIEW: Subscribe to cookie store for changes in place of CookieMonsterDelegate
2018-02-23 10:21:23 +09:00
Aleksei Kuzmin
412b9e9ad8
Move IDMap to base namespace.
...
https://chromium-review.googlesource.com/618801
2018-02-23 10:21:23 +09:00
Aleksei Kuzmin
8f78bd3307
Remove was_ignored_by_handler from frame_messages.h
...
https://chromium-review.googlesource.com/587701
2018-02-23 10:21:23 +09:00
Aleksei Kuzmin
91a339b625
viz: Move BeginFrame(Args|Ack) to components/viz/common/frame_sinks
2018-02-23 10:21:23 +09:00
Aleksei Kuzmin
1a9b056e93
Move CompositorFrameSink and FrameSinkManager mojom from cc to viz
2018-02-23 10:21:23 +09:00
Aleksei Kuzmin
abc6003640
viz: Move BeginFrameSource to components/viz/common/frame_sinks
2018-02-23 10:21:23 +09:00
Aleksei Kuzmin
76683c0af5
viz: Move CopyOutput(Request|Result)=> components/viz/common/quads
2018-02-23 10:21:23 +09:00
Shelley Vohr
128cb7f5b2
updates to build flags and comp errors
2018-02-23 10:21:23 +09:00
deepak1556
75c17cf846
Use generic base::Value::SetKey
...
Remove base::Value::SetDoubleWithoutPathExpansion
https://chromium-review.googlesource.com/591654
Remove base::Value::SetStringWithoutPathExpansion
https://chromium-review.googlesource.com/592368
Remove base::Value::SetIntegerWithoutPathExpansion
https://chromium-review.googlesource.com/591655
2018-02-23 10:21:23 +09:00
Cheng Zhao
3be92f550c
Better clarity and fix typo
2018-02-23 09:15:13 +09:00
Cheng Zhao
816a96c2cc
Update font settings in api::WebContents
2018-02-22 19:01:45 +09:00
Cheng Zhao
c87fc2426d
Handle transparent WebContents in api::BrowserWindow
2018-02-22 19:01:45 +09:00
Cheng Zhao
c611eb061d
Move InputEventObserver to api::BrowserWindow
2018-02-22 19:01:45 +09:00
Cheng Zhao
aa3eafcea1
Move closing logic to api::BrowserWindow
...
Closing a BrowserWindow is essentially closing a WebContents, the logic
should not be in NativeWindow.
2018-02-22 19:01:45 +09:00
Cheng Zhao
66fab65a1a
Add NativeWindowObserver::OnCloseButtonClicked
2018-02-22 19:01:45 +09:00
Cheng Zhao
a25b49a127
Add ExtendedWebContentsObserver
2018-02-22 19:01:45 +09:00
Cheng Zhao
a3124e8873
Use observer to provide OnRendererUnresponsive
2018-02-22 19:01:45 +09:00
Cheng Zhao
bffb31c337
Remove OnMessageReceived from NativeWindow
2018-02-22 19:01:45 +09:00
Cheng Zhao
44e7282b4b
The UpdateDraggableRegions does not share implementations
2018-02-22 19:01:45 +09:00
Cheng Zhao
c2aa312e0c
Check weak ptr before using it
2018-02-22 19:01:45 +09:00
Cheng Zhao
384b03d49b
UpdateDraggableRegionViews is redundant
2018-02-22 19:01:45 +09:00
Cheng Zhao
6650a06339
Move RenderViewCreated logic to api::BrowserWindow
2018-02-22 19:01:45 +09:00
Cheng Zhao
c256a43139
Move ready-to-show to api::BrowserWindow
2018-02-22 19:01:45 +09:00
Cheng Zhao
0d9a157914
Turn api::Window into a WebContentsObserver
2018-02-22 19:01:45 +09:00
Cheng Zhao
973647eaa2
Rename api::Window to api::BrowserWindow
2018-02-22 12:50:47 +09:00
shelley vohr
193febd18c
deprecate boolean highlightMode param ( #11993 )
...
* deprecate boolean highlightMode param
* add process.noDeprecations check
* fix native method override
* add todo
2018-02-20 22:30:32 -06:00
shelley vohr
c2575c4944
remove app.getAppMemoryInfo ( #11985 )
...
* remove app.getMemoryInfo
* semicolons are important
2018-02-20 18:52:33 -06:00