Charles Kerr
726d439399
refactor: replace base::StringPrintf() calls with absl::StrFormat() ( #44515 )
...
refactor: replace base::StringPrintf() calls with absl::StFormat()
The former is now a pass-through for the latter and is slated for removal
Xref: https://issues.chromium.org/issues/40241565
https://chromium-review.googlesource.com/c/chromium/src/+/4907781
2024-11-04 12:58:16 -06:00
Shelley Vohr
c63d0d61e7
chore: bump Node.js to v22.9.0 ( #44281 )
...
* chore: bump Node.js to v22.9.0
* build: drop base64 dep in GN build
https://github.com/nodejs/node/pull/52856
* build,tools: make addons tests work with GN
https://github.com/nodejs/node/pull/50737
* fs: add fast api for InternalModuleStat
https://github.com/nodejs/node/pull/51344
* src: move package_json_reader cache to c++
https://github.com/nodejs/node/pull/50322
* crypto: disable PKCS#1 padding for privateDecrypt
https://github.com/nodejs-private/node-private/pull/525
* src: move more crypto code to ncrypto
https://github.com/nodejs/node/pull/54320
* crypto: ensure valid point on elliptic curve in SubtleCrypto.importKey
https://github.com/nodejs/node/pull/50234
* src: shift more crypto impl details to ncrypto
https://github.com/nodejs/node/pull/54028
* src: switch crypto APIs to use Maybe<void>
https://github.com/nodejs/node/pull/54775
* crypto: remove DEFAULT_ENCODING
https://github.com/nodejs/node/pull/47182
* deps: update libuv to 1.47.0
https://github.com/nodejs/node/pull/50650
* build: fix conflict gyp configs
https://github.com/nodejs/node/pull/53605
* lib,src: drop --experimental-network-imports
https://github.com/nodejs/node/pull/53822
* esm: align sync and async load implementations
https://github.com/nodejs/node/pull/49152
* esm: remove unnecessary toNamespacedPath calls
https://github.com/nodejs/node/pull/53656
* module: detect ESM syntax by trying to recompile as SourceTextModule
https://github.com/nodejs/node/pull/52413
* test: adapt debugger tests to V8 11.4
https://github.com/nodejs/node/pull/49639
* lib: update usage of always on Atomics API
https://github.com/nodejs/node/pull/49639
* test: adapt test-fs-write to V8 internal changes
https://github.com/nodejs/node/pull/49639
* test: adapt to new V8 trusted memory spaces
https://github.com/nodejs/node/pull/50115
* deps: update libuv to 1.47.0
https://github.com/nodejs/node/pull/50650
* src: use non-deprecated v8::Uint8Array::kMaxLength
https://github.com/nodejs/node/pull/50115
* src: update default V8 platform to override functions with location
https://github.com/nodejs/node/pull/51362
* src: add missing TryCatch
https://github.com/nodejs/node/pull/51362
* lib,test: handle new Iterator global
https://github.com/nodejs/node/pull/51362
* src: use non-deprecated version of CreateSyntheticModule
https://github.com/nodejs/node/pull/50115
* src: remove calls to recently deprecated V8 APIs
https://github.com/nodejs/node/pull/52996
* src: use new V8 API to define stream accessor
https://github.com/nodejs/node/pull/53084
* src: do not use deprecated V8 API
https://github.com/nodejs/node/pull/53084
* src: do not use soon-to-be-deprecated V8 API
https://github.com/nodejs/node/pull/53174
* src: migrate to new V8 interceptors API
https://github.com/nodejs/node/pull/52745
* src: use supported API to get stalled TLA messages
https://github.com/nodejs/node/pull/51362
* module: print location of unsettled top-level await in entry points
https://github.com/nodejs/node/pull/51999
* test: make snapshot comparison more flexible
https://github.com/nodejs/node/pull/54375
* test: do not set concurrency on parallelized runs
https://github.com/nodejs/node/pull/52177
* src: move FromNamespacedPath to path.cc
https://github.com/nodejs/node/pull/53540
* test: adapt to new V8 trusted memory spaces
https://github.com/nodejs/node/pull/50115
* build: add option to enable clang-cl on Windows
https://github.com/nodejs/node/pull/52870
* chore: fixup patch indices
* chore: add/remove changed files
* esm: drop support for import assertions
https://github.com/nodejs/node/pull/54890
* build: compile with C++20 support
https://github.com/nodejs/node/pull/52838
* deps: update nghttp2 to 1.62.1
https://github.com/nodejs/node/pull/52966
* src: parse inspector profiles with simdjson
https://github.com/nodejs/node/pull/51783
* build: add GN build files
https://github.com/nodejs/node/pull/47637
* deps,lib,src: add experimental web storage
https://github.com/nodejs/node/pull/52435
* build: add missing BoringSSL dep
* src: rewrite task runner in c++
https://github.com/nodejs/node/pull/52609
* fixup! build: add GN build files
* src: stop using deprecated fields of v8::FastApiCallbackOptions
https://github.com/nodejs/node/pull/54077
* fix: shadow variable
* build: add back incorrectly removed SetAccessor patch
* fixup! fixup! build: add GN build files
* crypto: fix integer comparison in crypto for BoringSSL
* src,lib: reducing C++ calls of esm legacy main resolve
https://github.com/nodejs/node/pull/48325
* src: move more crypto_dh.cc code to ncrypto
https://github.com/nodejs/node/pull/54459
* chore: fixup GN files for previous commit
* src: move more crypto code to ncrypto
https://github.com/nodejs/node/pull/54320
* Fixup Perfetto ifdef guards
* fix: missing electron_natives dep
* fix: node_use_node_platform = false
* fix: include src/node_snapshot_stub.cc in libnode
* 5507047: [import-attributes] Remove support for import assertions
https://chromium-review.googlesource.com/c/v8/v8/+/5507047
* fix: restore v8-sandbox.h in filenames.json
* fix: re-add original-fs generation logic
* fix: ngtcp2 openssl dep
* test: try removing NAPI_VERSION undef
* chore(deps): bump @types/node
* src: move more crypto_dh.cc code to ncrypto
https://github.com/nodejs/node/pull/54459
* esm: remove unnecessary toNamespacedPath calls
https://github.com/nodejs/node/pull/53656
* buffer: fix out of range for toString
https://github.com/nodejs/node/pull/54553
* lib: rewrite AsyncLocalStorage without async_hooks
https://github.com/nodejs/node/pull/48528
* module: print amount of load time of a cjs module
https://github.com/nodejs/node/pull/52213
* test: skip reproducible snapshot test on 32-bit
https://github.com/nodejs/node/pull/53592
* fixup! src: move more crypto_dh.cc code to ncrypto
* test: adjust emittedUntil return type
* chore: remove redundant wpt streams patch
* fixup! chore(deps): bump @types/node
* fix: gn executable name on Windows
* fix: build on Windows
* fix: rename conflicting win32 symbols in //third_party/sqlite
On Windows otherwise we get:
lld-link: error: duplicate symbol: sqlite3_win32_write_debug
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:47987
>>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj
lld-link: error: duplicate symbol: sqlite3_win32_sleep
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48042
>>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj
lld-link: error: duplicate symbol: sqlite3_win32_is_nt
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48113
>>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj
lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_unicode
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48470
>>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj
lld-link: error: duplicate symbol: sqlite3_win32_unicode_to_utf8
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48486
>>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj
lld-link: error: duplicate symbol: sqlite3_win32_mbcs_to_utf8
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48502
>>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj
lld-link: error: duplicate symbol: sqlite3_win32_mbcs_to_utf8_v2
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48518
>>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj
lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_mbcs
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48534
>>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj
lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_mbcs_v2
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48550
>>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj
* docs: remove unnecessary ts-expect-error after types bump
* src: move package resolver to c++
https://github.com/nodejs/node/pull/50322
* build: set ASAN detect_container_overflow=0
https://github.com/nodejs/node/issues/55584
* chore: fixup rebase
* test: disable failing ASAN test
* win: almost fix race detecting ESRCH in uv_kill
https://github.com/libuv/libuv/pull/4341
2024-11-04 13:41:56 -05:00
Charles Kerr
e3f2ca1425
chore: remove use of banned absl::optional ( #44513 )
...
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5805666
2024-11-04 12:37:04 -06:00
Charles Kerr
f5bdbdb1e8
refactor: more inline constexpr string view ( #44498 )
...
* chore: remove unused electron::kHidProductIdKey
* refactor: make electron::kHidDeviceNameKey inline constexpr std::string_view
refactor: make electron::kHidGuidKey inline constexpr std::string_view
* refactor: make serial_chooser_context keys inline constexpr std::string_view
* refactor: make native_window keys inline constexpr std::string_view
* refactor: make electron::options keys inline constexpr std::string_view pt 1
* fixup! refactor: make electron::options keys inline constexpr std::string_view pt 1
chore: make kElectronNativeWindowKey a base::cstring_view
ui::Widget::GetNativeWindowProperty requires a const char*
* refactor: make electron::options keys inline constexpr std::string_view pt 2
* refactor: make electron::options keys inline constexpr std::string_view pt 3
* refactor: make electron::options keys inline constexpr std::string_view pt 4
* refactor: make electron::options keys inline constexpr std::string_view pt 5
* refactor: make electron::options keys inline constexpr std::string_view pt 6
* refactor: make electron::options keys inline constexpr std::string_view pt 7
* refactor: make electron::options keys inline constexpr std::string_view pt 8
* chore: remove unused file shell/common/options_switches.cc
* docs: add code comment explaining use of base::cstring_view
* fixup! fixup! refactor: make electron::options keys inline constexpr std::string_view pt 1
* chore: use consistent capitalization of the word 'fullscreen'
2024-11-04 12:27:49 -06:00
electron-roller[bot]
48801be8e9
chore: bump chromium to 132.0.6807.0 (main) ( #44360 )
...
* chore: bump chromium in DEPS to 132.0.6791.0
* 5804481: [UI] Migrate remaining clients of `MenuSourceType`
https://chromium-review.googlesource.com/c/chromium/src/+/5804481
* chore: try revert PA CL
* chore: bump chromium in DEPS to 132.0.6793.0
* chore: bump chromium in DEPS to 132.0.6794.0
* 5952404: Clean up //ui/base/resource from Lacros code.
https://chromium-review.googlesource.com/c/chromium/src/+/5952404
* 5920842: Generate combined grd for PEPC strings and use them in the element
https://chromium-review.googlesource.com/c/chromium/src/+/5920842
* 5943708: Enable DynamicSafeAreaInsets for eligible users only
https://chromium-review.googlesource.com/c/chromium/src/+/5943708
* chore: fixup patch indices
* 5937004: Remove components/services/language_detection
https://chromium-review.googlesource.com/c/chromium/src/+/5937004
* 5920322: [UI] Use mojo enum for `MenuSourceType` in ui/views/controls/
https://chromium-review.googlesource.com/c/chromium/src/+/5920322
* chore: bump chromium in DEPS to 132.0.6797.0
* 5947724: [ui] Add missing shortcut text for VKEY_COMMAND on linux
https://chromium-review.googlesource.com/c/chromium/src/+/5947724
* chore: fixup patch indices
* 5948024: [DNT] Fix NavigationController raw_ptr during WebContents destruction
https://chromium-review.googlesource.com/c/chromium/src/+/5948024
* 5945209: Roll libc++ from c8eec3629a9e to e2c39ff9388b (1 revision)
https://chromium-review.googlesource.com/c/chromium/src/+/5945209
* chore: bump chromium in DEPS to 132.0.6799.0
* chore: bump chromium in DEPS to 132.0.6801.0
* chore: bump chromium in DEPS to 132.0.6803.0
* 5942398: Remove some chrome:: namespace from chrome/browser/win/*
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5942398
* 5963016: FSA: Use the profile path for base::DIR_HOME on ChromeOS
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5963016
* chore: fixup patch indices
* chore: bump chromium in DEPS to 132.0.6805.0
* 5924816: [macOS][FSA] Block Access to Application Bundle Path
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5924816
* 5962517: [media] Apply inside blink to renderer/platform/media
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5962517
* 5829616: MPArch based GuestViews basic implementation
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5829616
* 5953710: Expose a rust_static_library instead of raw rs file from rust_bindgen
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5953710
* chore: fixup patch indices
* chore: disable ELF CREL on Linux Arm
5938657: Reapply "Enable ELF CREL, which reduces the size of ELF relocatable object files." | https://chromium-review.googlesource.com/c/chromium/src/+/5938657
* chore: bump chromium in DEPS to 132.0.6807.0
* 5868889: Shared Storage: Support saved queries in selectURL
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5868889
* Revert "5956408: [fastapi] Promote deprecation of FastApiTypedArray"
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5956408
* Revert "5962696: [mojo] Force blink headers to only be included in blink"
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5962696
* chore: update patches
* 5973073: [Extensions] Improve warnings parsing (host) permissions in MV3
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/5973073
* chore: update filenames.libcxx.gni
* Apply suggestions from code review
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-11-04 09:10:00 -05:00
Charles Kerr
9137d96ef4
refactor: remove unused C string ToV8() gin converter ( #44500 )
2024-11-01 18:11:46 -05:00
Charles Kerr
a720c8daf6
perf: remove isolate scope from DidProcessTask() ( #44439 )
2024-10-29 23:25:40 -05:00
Charles Kerr
b3c2e83243
refactor: prefer inline constexpr string_view for string constants ( #44405 )
...
* refactor: BaseWindow::OnExecuteAppCommand() now takes a std::string_view
* refactor: NativeWindow::NotifyWindowExecuteAppCommand() takes a std::string_view
* refactor: AppCommandToString() returns a std::string_view, is now constexpr
* refactor: make kBrowserBackward, kBrowserForward inline constexpr std::string_view
Xref: https://abseil.io/tips/140
https://groups.google.com/a/chromium.org/g/chromium-dev/c/jROTxMo_m2Q/m/HgciN2KsAgAJ
* refactor: use inline constexpr string_view for kDevice*Key constants
Xref: https://abseil.io/tips/140
https://groups.google.com/a/chromium.org/g/chromium-dev/c/jROTxMo_m2Q/m/HgciN2KsAgAJ
* refactor: IsEnvSet now takes a base::cstring_view
* refactor: use inline constexpr cstring_view for kRunAsNode
* refactor: use inline constexpr string_view for kPDF*PluginName
* refactor: use base::FilePath::FromASCII() since "internal-pdf-viewer" is ascii
* chore: remove unused shell/common/electron_constants.cc
* fixup! refactor: IsEnvSet now takes a base::cstring_view
2024-10-29 10:30:12 +01:00
Robo
739688214b
fix: keep gdk_pixbuf a dynamic dependency ( #44423 )
2024-10-29 09:44:20 +09:00
Sam Maddock
348801b20e
fix: crash on netlog connection error ( #44406 )
...
* fix: crash on netlog connection error
* refactor: remove default PromiseBase constructor
* Revert "refactor: remove default PromiseBase constructor"
This reverts commit 9292324a0d5f9e63ba8f73f63dfff1d48eb2f38f.
* remove dcheck
2024-10-28 10:24:54 +01:00
Charles Kerr
83d7040096
fix: -Wunsafe-buffer-usage warning in didRegisterForRemoteNotificationsWithDeviceToken ( #44348 )
...
* chore: move as_byte_span() to new shell/common/mac_util.h
this way it can be used by multiple mm files
* fix: -Wunsafe-buffer-usage warnings in UNNotificationResponseToNSDictionary
* refactor: use base::HexEncode() instead of rolling our own
* fixup! chore: move as_byte_span() to new shell/common/mac_util.h
* fixup! chore: move as_byte_span() to new shell/common/mac_util.h
fix: move mac_util to the right place in filenames.gni
2024-10-23 14:18:22 -05:00
electron-roller[bot]
0d948da4b9
chore: bump chromium to 132.0.6787.0 (main) ( #44329 )
...
* chore: bump chromium in DEPS to 132.0.6785.0
* chore: bump chromium in DEPS to 132.0.6787.0
* 5837702: mac fullscreen: always show traffic lights
https://chromium-review.googlesource.com/c/chromium/src/+/5837702
* 5892572: Move SimpleMenuModel out of ui/base
https://chromium-review.googlesource.com/c/chromium/src/+/5892572
* 5938185: Remove lacros code from //ui/base/clipboard
https://chromium-review.googlesource.com/c/chromium/src/+/5938185
* chore: fixup patch indices
* 5939514: Wire up the preference of overlay scrollbars to the ChromeOS settings
https://chromium-review.googlesource.com/c/chromium/src/+/5939514
* chore: fixup patch indices
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-10-20 19:02:21 -05:00
Sam Maddock
87bd665e41
feat: expose frame & move properties to console-message event object ( #43617 )
...
* feat: expose frame on console-message event
refactor: use property names similar to ServiceWorker's console-message event
refactor: don't use deprecated params in tests
doc: console-message breaking change
chore: add deprecation warning
docs: restore deprecated argument descriptions
* move console-message deprecations to v34
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-10-18 16:07:06 -04:00
John Beutner
35aeab6ecd
fix: respect setAlwaysOnTop before showInactive on Linux under X11 ( #44078 )
...
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-10-18 14:29:52 -04:00
electron-roller[bot]
089f233054
chore: bump chromium to 132.0.6781.0 (main) ( #44301 )
...
* chore: bump chromium in DEPS to 132.0.6781.0
* chore: update patches
* 5933789: [MappableSI] Remove kill-switch from RenderableGpuMemoryBufferVideoFramePool.
https://chromium-review.googlesource.com/c/chromium/src/+/5933789
* 5938992: Reland: Remove `force_guest_profile` param from context getters.
https://chromium-review.googlesource.com/c/chromium/src/+/5938992
* 5928743: spanification: Add WTF::String::FromUTF8(span<>) overloads
https://chromium-review.googlesource.com/c/chromium/src/+/5928743
* 5898835: Update windows SDK version to 10.0.26100.1742
https://chromium-review.googlesource.com/c/chromium/src/+/5898835
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-10-17 20:00:59 -04:00
electron-roller[bot]
d801bad5d2
chore: bump chromium to 132.0.6779.0 (main) ( #44273 )
...
* chore: bump chromium in DEPS to 132.0.6779.0
* chore: update patches
* 5904951: controlledframe: Disable File System Access for <controlledframe>
https://chromium-review.googlesource.com/c/chromium/src/+/5904951
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-10-16 21:41:31 -04:00
Shelley Vohr
df45474b58
fix: ensure utilityProcess only emits one 'exit' event ( #44243 )
...
fix: ensure utilityProcess only emits one exit
2024-10-16 10:47:12 +02:00
Charles Kerr
b5acebf3ba
fix: -Wunsafe-buffer-usage warnings in TaskbarHost::SetThumbarButtons() ( #44238 )
...
* fix: -Wunsafe-buffer-usage warnings in TaskbarHost::SetThumbarButtons()
* fixup! fix: -Wunsafe-buffer-usage warning in ChunkedDataPipeReadableStream (#44211 )
2024-10-15 18:31:44 -05:00
electron-roller[bot]
36b7cf341e
chore: bump chromium to 131.0.6776.0 (main) ( #44137 )
...
* chore: bump chromium in DEPS to 131.0.6763.0
* chore: bump chromium in DEPS to 131.0.6764.0
* update patches
* chore: bump chromium in DEPS to 131.0.6766.0
* chore: update patches
* Use PathInfo in FileSystemAccess code
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5872329
* Modernize image utilities.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5905226
* [DevTools] move feature flags to the devtools directory
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5913878
* chore: bump chromium in DEPS to 131.0.6768.0
* chore: update patches
* Remove experimental credshelper flags
Refs 4017a6c8b4https://chromium-review.googlesource.com/c/chromium/src/+/5917286
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5905621
* chore: script/gen-libc++-filenames.js
* chore: bump chromium in DEPS to 131.0.6770.0
* chore: update patches
* chore: bump chromium in DEPS to 131.0.6772.0
* chore: update patches
* [UI] Add alias for mojo version of `MenuSourceType`
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5803393
* Update Background Color for Task Manager Refresh
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5875259
* chore: bump chromium in DEPS to 131.0.6774.0
* chore: bump chromium in DEPS to 131.0.6776.0
* chore: update patches
* chore: update filenames.libcxx.gni
* esm: remove --no-import-harmony-assertions
https://github.com/nodejs/node/pull/54890
* 5507047: [import-attributes] Remove support for import assertions
| https://chromium-review.googlesource.com/c/v8/v8/+/5507047
* fixup: Change gfx::[PNG|JPEG]Codec::Decode to return a SkBitmap
* chore: bump chromium in DEPS to 131.0.6778.0
* Revert "chore: bump chromium in DEPS to 131.0.6778.0"
This reverts commit fb9092fc51700651aa4a245931f71ec1ca55a274.
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <nornagon@electronjs.org>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-10-15 11:51:11 -04:00
Charles Kerr
566c72cd46
fix: -Wunsafe-buffer-usage warning in ChunkedDataPipeReadableStream ( #44211 )
...
* chore: rename v8_value_serializer.cc,h to v8_util.cc,h
* feat: add electron::util::as_byte_span(v8::Local<v8::ArrayBuffer>)
* fix: -Wunsafe-buffer-usage warnings in ChunkedDataPipeReadableStream::ReadInternal()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5619253
* refactor: restore node buffer span util
* refactor: remove redundant span wrapper
2024-10-14 10:46:24 +02:00
Sam Maddock
8b3d70a2a3
feat: add WebFrameMain detached property ( #43473 )
...
* feat: add WebFrameMain detached property
fix: throw instead of returning null senderFrame
test: detached frames
fix: ensure IPCs of pending deletion RFHs are dispatched
fix: lookup WFM by FTN ID to dispatch IPCs
feat: add frame.isDestroyed()
return null
fix: return undefined
docs: add null to all frame properties
refactor: option c, return null and emit warning
refactor: add routingId & processId to navigation events
test: null frame property
docs: clarify warning message
better wording
clarify null frame
fix: browserwindow spec
* maybe fix 🤷
* fix: use updated util #43722
* docs: add notice for frame change of behavior
* docs: clarify why frame properties may be null
* lint
* wip
* fix: content::FrameTreeNodeId lookup and converter
* refactor: avoid holey array deoptimization
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-10-11 18:33:53 -04:00
Charles Kerr
527efc01a4
fix: -Wunsafe-buffer-usage warnings when read()ing and write()ing integers ( #44185 )
2024-10-11 14:29:00 -05:00
Charles Kerr
b5227b4a17
fix: -Wunsafe-buffer-usage warnings in GetNextZoomLevel() ( #44149 )
...
fixup e8948397
2024-10-09 09:12:48 -05:00
Keeley Hammond
08d315da14
refactor: revert url::DomainIs() for cookie domains ( #44153 )
...
build: revert DomainIs refactor
2024-10-08 18:39:37 -07:00
electron-roller[bot]
bcbc8d3bb2
chore: bump chromium to 131.0.6762.0 (main) ( #44117 )
...
* chore: bump chromium in DEPS to 131.0.6756.0
* chore: update disable_hidden.patch
no code changes; just handling upstream context shear
https://chromium-review.googlesource.com/c/chromium/src/+/5887019
* chore: update feat_expose_raw_response_headers_from_urlloader.patch
Factor out URLLoader's URLRequest configuration into a helper
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5902254
* chore: update fix_disabling_background_throttling_in_compositor.patch
no manual changes; patch applied with fuzz 1
* chore: e patches all
* 5882129: Fix basic auth issues for sub frame and sub resources | https://chromium-review.googlesource.com/c/chromium/src/+/5882129
- Add `is_request_for_navigation` param to
ElectronBrowserClient::CreateLoginDelegate().
- Propagate the flag as another undocumented property
in the app.login Event's authenticationResponseDetails object
- Side cleanup: also in CreateLoginDelegate(), use upstream's name
for the `is_request_for_main_frame` param, renamed back in
https://chromium-review.googlesource.com/c/chromium/src/+/3256171
* 5875189: [FSA] Check for DANGEROUS extension types when creating a new file. | https://chromium-review.googlesource.com/c/chromium/src/+/5875189
* chore: node ./script/gen-libc++-filenames.js
* chore: bump chromium in DEPS to 131.0.6758.0
* chore: bump chromium in DEPS to 131.0.6760.0
* chore: update patches
* [A11y] Remove Accessibility Object Model (AOM)
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5896593
* chore: bump chromium in DEPS to 131.0.6762.0
* [heap] Remove deprecated V8 flag
Refs https://chromium-review.googlesource.com/c/v8/v8/+/5904046
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2024-10-07 18:06:47 -05:00
Charles Kerr
684e345f68
fix: deprecated API and -Wunsafe-buffer-usage warnings in AsarFileValidator ( #44068 )
...
* refactor: const correctness
* refactor: extract-method AsarFileValidator::EnsureHashExists()
* refactor: replace use of deprecated crypto API
https://crbug.com/364687923
* refactor: use span API in AsarFileValidator::OnRead()
* refactor: replace use of deprecated crypto API
https://crbug.com/364687923
* fixup! refactor: use span API in AsarFileValidator::OnRead()
fix: electron-ia32-testing FTBFS
2024-10-02 16:44:28 -04:00
Charles Kerr
9df092e034
fix: remove use of deprecated API base::Hash() ( #44076 )
2024-10-02 16:36:06 -04:00
electron-roller[bot]
1fc2064f6a
chore: bump chromium to 131.0.6750.0 (main) ( #44066 )
...
* chore: bump chromium in DEPS to 131.0.6750.0
* Clean up stale base::Feature "RestrictFileURLNavigation"
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5891262
* chore: update mas_avoid_private_macos_api_usage.patch
Comment out some new private macOS API use.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5837702
Xref: https://electronhq.slack.com/archives/C5VT8SQ8K/p1727807285899389
* chore: e patches all
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-01 19:34:32 -04:00
Charles Kerr
06bce8166b
fix: -Wunsafe-buffer-usage warnings in ElectronAccessibilityUI ctor ( #44055 )
...
fix: -Wunsafe-buffer-usage warnings in ElectronAccessibilityUI constructor
2024-10-01 10:05:46 -07:00
Charles Kerr
1d4b86cb3e
fix: -Wunsafe-buffer-usage warnings in AddComponentResourceEntries() ( #44024 )
...
fix: -Wunsafe-buffer-usage warnings in ElectronComponentExtensionResourceManager::AddComponentResourceEntries()
just replace pointer-and-length args with a span
2024-09-30 11:01:24 -05:00
Charles Kerr
77f7ba96ca
fix: -Wunsafe-buffer-usage in electron::SetFontDefaults() ( #44014 )
...
* refactor: reduce code duplication in WebContentsPreferences::OverrideWebkitPrefs()
* refactor: limit scope of web_preferences temporary in ElectronBrowserClient::OverrideWebkitPrefs()
* chore: savepoint
* chore: savepoint
* chore: savepoint
* chore: savepoint
* chore: remove logging
* fix: unconditionally write
* chore: naming
* chore: add code comments
* chore: more code comments
* chore: remove unrelated changes
* chore: remove redundant static keyword on function in anonymous namespace
* refactor: naming
* refactor: naming
* refactor: naming
* refactor: slightly more explicit typing
* refactor: remove unnecessary utf16 -> utf8 -> utf16 conversion steps
* chore: remove unused #includes
2024-09-30 15:09:36 +02:00
electron-roller[bot]
af58931efa
chore: bump chromium to 131.0.6744.0 (main) ( #43948 )
...
* chore: bump chromium in DEPS to 131.0.6738.0
* chore: bump chromium in DEPS to 131.0.6740.0
* 5889025: [LaCrOS] Remove LaCrOS screen capturer. | https://chromium-review.googlesource.com/c/chromium/src/+/5889025
* https://boringssl.googlesource.com/boringssl.git/+/40dd94116ba03678226443ba20c5887459c9bf16/crypto/fipsmodule/digest/digests.c.inc
* chore: update patches
* 5878695: Add IsolationInfo for embedders handling external protocols | https://chromium-review.googlesource.com/c/chromium/src/+/5878695
* 5854304: [UI] Remove alias of mojom | https://chromium-review.googlesource.com/c/chromium/src/+/5854304
* chore: bump chromium in DEPS to 131.0.6742.0
* chore: update patches
* chore: bump chromium in DEPS to 131.0.6744.0
* fixup! 5889025: [LaCrOS] Remove LaCrOS screen capturer. | https://chromium-review.googlesource.com/c/chromium/src/+/5889025
* chore: e patches all
* chore: update chore_provide_iswebcontentscreationoverridden_with_full_params.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5894233
* [UI] Remove alias of mojom 'WindowShowState'
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5854304
* chore: gen-libc++-filenames.js
* chore: partially revert https://chromium-review.googlesource.com/c/chromium/src/+/5894233
see patch commit message for description
* Clean up stale base::Feature "kFileSystemAccessLocalUNCPathBlock"
This feature is always on by default and doesn't have active finch
experiments.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5881253
* fix: asar integrity test recognizes SIGABRT as a crash
https://chromium-review.googlesource.com/c/chromium/src/+/5882758
ValidateIntegrityOrDie() exits via LOG(FATAL)'s call to
base::ImmediateCrash(). There's been churn there upstream between
5332940 and 5882758 on whether to use SIGTRAP or SIGABRT. For now,
let's accept both until the churn is done.
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: alice <alice@makenotion.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-30 14:54:44 +02:00
Charles Kerr
eb40d2cbfa
fix: FTBFS when building with enable_plugins = false ( #44003 )
...
* fix: do not build electron_plugin_info_host_impl.cc when plugins are disabled
it fails to build from source with this error:
../../content/public/browser/plugin_service.h:17:2: error: "Plugins should be enabled"
17 | #error "Plugins should be enabled"
* fix: FTBFS in printing_utils.cc when ENABLE_PDF is false
* fixup! fix: do not build electron_plugin_info_host_impl.cc when plugins are disabled
fix BUILD.gn linting
2024-09-29 17:10:34 -05:00
Robo
f68184a9f9
feat: add error event for utility process ( #43774 )
...
* feat: add error event for utility process
* chore: use public report api
* chore: fix lint
* doc: mark error event as experimental
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-27 10:17:06 +09:00
Charles Kerr
8397fef3ef
chore: remove unused nogncheck includes ( #43964 )
2024-09-26 17:09:42 -05:00
Charles Kerr
852f9ff329
perf: build g_dgettext domain name at compile time ( #43960 )
...
perf: build GettextPackage name at compile time
2024-09-26 13:10:30 -04:00
Charles Kerr
a974b74e82
fix: replace deprecated libnotify API calls ( #43962 )
...
notify_notification_set_hint_string() is deprecated, so let's use
notify_notification_set_hint() instead.
Xref: 2fe1748295
2024-09-26 11:21:45 -05:00
Shelley Vohr
da6ab92353
fix: ensure correct WebContents when checking PDFReadyToPrint ( #43943 )
...
* fix: ensure correct WebContents when checking PDFReadyToPrint
* test: fix paths on Windows
2024-09-26 10:54:13 -04:00
Charles Kerr
ddd45db6ca
fix: -Wunsafe-buffer-usage warnings in GdkPixbufFromSkBitmap() ( #43956 )
...
* fix: -Wunsafe-buffer-usage warnings in GdkPixbufFromSkBitmap()
* refactor: don't change previous behavior for 0-height images
Is a 0x0 image even a thing? I'm not sure; but just in case, let's
treat it the same way the previous implementation did.
2024-09-26 08:32:43 -05:00
John Beutner
c8895d0547
fix: close all open sheets before closing window on macOS ( #43706 )
2024-09-25 13:23:49 +02:00
Charles Kerr
1d3b1284c4
test: ensure sender-pid hint is set in Linux notifications ( #43928 )
...
test: expect a `sender-pid` hint in Linux notifications.
This PR ensures that the `sender-pid` hint is set for new notifications.
It also updates the spec to confirm that DBus receives the hint and that
it has the correct value.
This fixes a spec failure when running libnotify >= 0.7.12 (2022-05-05).
Starting with that version, libnotify started injecting `sender-pid` if
not provided by the client. So our tests received a slightly different
DBus payload depending on what version of libnotify was installed,
causing our deep-equals tests to fail.
By always providing and testing the `sender-pid` hint, our behavior and
tests should be consistent across distros.
2024-09-25 13:20:36 +02:00
electron-roller[bot]
30fbeec036
chore: bump chromium to 131.0.6734.0 (main) ( #43769 )
...
* chore: bump chromium in DEPS to 130.0.6723.4
* chore: bump chromium in DEPS to 131.0.6724.0
* chore: update patches
* chore: update libc++ filenames
* 5844369: controlledframe: Disable Web Bluetooth for <webview> & <controlledframe>
https://chromium-review.googlesource.com/c/chromium/src/+/5844369
* (multiple CLs): Use an opaque type for FrameTreeNode IDs
5807683: Use an opaque type for FrameTreeNode IDs, part 1 | https://chromium-review.googlesource.com/c/chromium/src/+/5807683
5829746: Use an opaque type for FrameTreeNode IDs, part 2 | https://chromium-review.googlesource.com/c/chromium/src/+/5829746
5836903: Use an opaque type for FrameTreeNode IDs, part 7 | https://chromium-review.googlesource.com/c/chromium/src/+/5836903
5837249: Use an opaque type for FrameTreeNode IDs, part 8 | https://chromium-review.googlesource.com/c/chromium/src/+/5837249
5836564: Use an opaque type for FrameTreeNode IDs, part 12 | https://chromium-review.googlesource.com/c/chromium/src/+/5836564
5837180: Use an opaque type for FrameTreeNode IDs, part 15 | https://chromium-review.googlesource.com/c/chromium/src/+/5837180
* 5822889: [task] Make GetForegroundTaskRunner non-virtual
https://chromium-review.googlesource.com/c/v8/v8/+/5822889
* 5833297: Remove unused inner WebContents attach params
https://chromium-review.googlesource.com/c/chromium/src/+/5833297
* 5806403: Shift PowerMonitor to non static
https://chromium-review.googlesource.com/c/chromium/src/+/5806403
* 5666874: [3/N] Remove old OnPowerChange in PowerObserver
https://chromium-review.googlesource.com/c/chromium/src/+/5666874
* 5829085: [v8] Differentiate between UserVisible and BestEffort task runners
https://chromium-review.googlesource.com/c/chromium/src/+/5829085
* 5791112: [webrtc] Use `c/b/permissions/system` for system permissions
https://chromium-review.googlesource.com/c/chromium/src/+/5791112
* 5825636: [Extensions] Create WebContentsObservers with ExtensionsBrowserClient
https://chromium-review.googlesource.com/c/chromium/src/+/5825636
* fixup! (multiple CLs): Use an opaque type for FrameTreeNode IDs
* fixup! 5791112: [webrtc] Use `c/b/permissions/system` for system permissions https://chromium-review.googlesource.com/c/chromium/src/+/5791112
* chore: bump chromium in DEPS to 131.0.6726.0
* chore: update patches
* chore: update libc++ filenames
* 5858119: Declutter: Allow opening to a specific feature
https://chromium-review.googlesource.com/c/chromium/src/+/5858119
* fix: macOS SDK 15 error
Not sure exactly what changed in the upgrade to macOS SDK 15, but it triggered a new error:
```
electron/shell/browser/ui/message_box_mac.mm:84:7: error: multiple methods named 'highlight:' found with mismatched result, parameter type or attributes
```
The `highlight:` selector a few lines down was ambiguous because the object type of the `NSArray` was not specified. Specifying `NSButton` as the element type makes the selector unambiguous for type checking.
* 5854143: [File Download Access Prevention] Obfuscate download file for enterprise deep scan
https://chromium-review.googlesource.com/c/chromium/src/+/5854143
* 5854811: Use kNotAllowedError instead of kSecurityError for Web MIDI
https://chromium-review.googlesource.com/c/chromium/src/+/5854811
* chore: bump chromium in DEPS to 131.0.6728.0
* chore: update patches
* disable invalid test
* chore: bump chromium in DEPS to 131.0.6730.0
* chore: update patches
* update build tools target commit for new macOS SDK
* chore: update libc++ file names
* chore: bump chromium in DEPS to 131.0.6732.0
* chore: bump chromium in DEPS to 131.0.6734.0
* 5856527: [UI] Use mojo enum for `WindowShowState` in ui/
https://chromium-review.googlesource.com/c/chromium/src/+/5856527
* chore: update build-tools sha to include macOD 15.0 SDK
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: alice <alice@makenotion.com>
2024-09-25 06:19:39 -05:00
Shelley Vohr
bcf4095ace
fix: crash when focusing WebView webContents ( #43921 )
...
fix: crash when focusing WebView
2024-09-24 18:19:04 -05:00
CezaryKulakowski
e64a66bfd3
fix: detach native view when its removed from parent on macOS ( #43627 )
...
Right now DelayedNativeViewHost attaches its underlying native view
when it's being attached to a widget but it doesn't detach it when
it's being detached. It may lead to use-after-free and crash.
2024-09-24 15:28:36 +02:00
Charles Kerr
79627deea3
refactor: add SerialChooserController::web_contents_ ( #43823 )
...
Add a `base::WeakPtr<WebContents>` field to SerialChooserController and
stop subclassing from WebContentsObserver. This follows the Observer docs:
> don't create a `WebContentsObserver` just to be able to check
> for a null `WebContentsObserver::web_contents()`.
> Use a `base::WeakPtr<WebContents>` instead.
2024-09-23 22:38:13 -07:00
Charles Kerr
9598d88b7c
refactor: remove C-style void arg type for no-arg functions ( #43884 )
...
A small cleanup to remove use of the C-style function declaration idiom.
2024-09-23 22:37:32 -07:00
Charles Kerr
33d7c9ac3e
refactor: hide printing impl details in api::WebContents ( #43893 )
...
* refactor: move api::WebContents::OnGetDeviceNameToUse() into an anonymous namespace
* refactor: move api::WebContents::OnPDFCreated() into an anonymous namespace
* refactor: remove unused #include
2024-09-23 22:36:55 -07:00
Charles Kerr
e894839709
fix: -Wunsafe-buffer-usage warnings in GetNextZoomLevel() ( #43803 )
2024-09-21 17:21:02 -05:00
Charles Kerr
d100921289
refactor: NotificationPresenter::Create() returns a std::unique_ptr<> ( #43794 )
2024-09-19 19:02:49 -05:00
BILL SHEN
855f219301
chore: fix compile issue about ambiguous error of multiple methods named 'highlight'. ( #43773 )
...
chore: fix ambiguous error of multiple methods named 'highlight'
2024-09-19 13:01:36 +02:00
