Haojian Wu
ee1f3acf7b
Don't use anonymous namespace in header file.
...
Anonymous namespace should be forbidden in header files even for the
forward declarations:
* As declarations defined in anonymous namespace are internal linkage, each
translation unit which includes this header will get unique copy, which
wastes space.
* It is easy to violate C++ ODR rule.
Consider the following "foo.h":
```cpp
namespace { class Foo; }
class Bar {
public:
Foo* getFoo();
Foo* foo;
}
```
If the 'foo.h' is included in multiple `.cc` files, the compiler will
put `Foo` into a different anonymous namespace in each `.cc`, which
means there are different definitions of `Foo` in the program (a
violation of the ODR).
2017-04-01 08:57:34 +02:00
Zeke Sikelianos
c2230ca76a
generate electron.d.ts during dist creation, not during build
2017-03-31 21:35:58 -07:00
Zeke Sikelianos
c00bac5c0b
add a convenience script for manually generating API JSON
2017-03-31 21:09:23 -07:00
Zeke Sikelianos
9a10486514
generate and upload electron.d.ts with each release
2017-03-31 21:01:55 -07:00
joshaber
ee7389bb6d
Rename to make VS happy
2017-03-31 22:57:56 -04:00
joshaber
4f3d3557cc
Notify that the cert changed
2017-03-31 21:51:29 -04:00
Zeke Sikelianos
a686237d9b
Merge pull request #9080 from electron/fixup-docs-5
...
Add missing finalUpdate prop
2017-03-31 18:29:16 -07:00
joshaber
bde2a597f3
Decode all the intermediates
2017-03-31 21:27:49 -04:00
joshaber
69defc5166
Encode all the intermediates
2017-03-31 21:27:33 -04:00
Samuel Attard
f757912f90
Add missing finalUpdate prop
2017-04-01 12:11:34 +11:00
Kevin Sawicki
372f209363
Merge pull request #9079 from electron/fix-dialog-args
...
Move normalizeAccessKeys docs to showMessageBox method
2017-03-31 16:35:31 -07:00
Kevin Sawicki
6d516fbae3
Move normalizeAccessKeys docs to right method
2017-03-31 15:08:03 -07:00
Haojian Wu
f506047a9b
Remove an extra blank line.
2017-03-31 21:56:19 +02:00
joshaber
302ca8669d
Slightly better conversion
2017-03-31 15:44:47 -04:00
Kevin Sawicki
a724b6555f
Bump v1.6.5
2017-03-31 12:10:09 -07:00
Kevin Sawicki
0faa15c6ca
Merge pull request #9074 from electron/tabbing-mode-version-guard
...
Only define NSWindowTabbingModeDisallowed on pre-10.12 SDKs
2017-03-31 12:09:54 -07:00
Haojian Wu
22035e2d6d
Fix cpplint: at least two spaces between code and comments.
2017-03-31 20:59:27 +02:00
Kevin Sawicki
08db63c3cc
Only define NSWindowTabbingModeDisallowed on pre-10.12
2017-03-31 11:28:55 -07:00
Kevin Sawicki
8a01ebef63
Merge pull request #9053 from electron/enable-crash-reporter-upload-windows
...
Pass `uploadToServer` option to windows crash reporter
2017-03-31 11:28:35 -07:00
joshaber
141a5ad73f
Maybe this is a valid conversion?
2017-03-31 14:16:26 -04:00
Haojian Wu
8ae91682cb
Lines should be <= 80 characters.
2017-03-31 20:09:13 +02:00
joshaber
16cc79354c
Errrrybody's a scoped_refptr now
2017-03-31 13:53:42 -04:00
joshaber
deae70de4d
Dummy out the certificate FromV8 converter
2017-03-31 13:53:31 -04:00
Kevin Sawicki
d677a436ec
🎨
2017-03-31 10:42:43 -07:00
Thiago de Arruda
460fb9cdb9
Add tests for uploadToServer option.
2017-03-31 13:48:07 -03:00
Thiago de Arruda
f0d447cd68
Pass uploadToServer to windows crash reporter
2017-03-31 13:46:30 -03:00
Philip Jackson
1c80102218
📝 Document passing null to Menu.setApplicationMenu
...
[ci skip]
2017-03-31 16:42:03 +13:00
Kevin Sawicki
96407d9c17
Merge pull request #9057 from electron/upgrade-libcc-for-ffmpeg-linking-fix
...
Upgrade libcc for ffmpeg linking fix
2017-03-30 15:15:32 -07:00
Kevin Sawicki
39fdc26921
Time out after 5 minutes
2017-03-30 14:39:48 -07:00
Kevin Sawicki
c85d667e66
Upgrade libcc to latest master
2017-03-30 14:37:19 -07:00
Kevin Sawicki
90d0179fe9
Use correct dll name
2017-03-30 14:36:52 -07:00
Kevin Sawicki
b85ebb00aa
Tweak logged messages
2017-03-30 14:36:52 -07:00
Kevin Sawicki
7873130019
Add comment to codecs app script
2017-03-30 14:36:52 -07:00
Kevin Sawicki
6b8f840da0
Add script to verify ffmpeg without proprietary codecs
2017-03-30 14:36:52 -07:00
Kevin Sawicki
740de02d6c
builds -> Support
2017-03-30 14:36:52 -07:00
Kevin Sawicki
5b4f715d2e
Add test page to check for proprietary codecs
2017-03-30 14:36:52 -07:00
Kevin Sawicki
c8951d0d4d
Upgrade libcc for ffmpeg linking fix
2017-03-30 14:36:52 -07:00
Kevin Sawicki
76529b5065
Merge pull request #9067 from electron/check-name-param-directly
...
Check name directly instead of arguments length
2017-03-30 14:35:56 -07:00
joshaber
edf61d41ba
Link against the Security frameworks
2017-03-30 17:26:11 -04:00
joshaber
7b044ffe0e
Compile these lovely files
2017-03-30 17:26:03 -04:00
joshaber
653b2d15c3
Expose the certificate trust panel as part of app
2017-03-30 17:25:55 -04:00
joshaber
64369cd07f
Show a certificate trust panel
2017-03-30 17:25:44 -04:00
Haojian Wu
328cf4789b
Should override the virtual destructor.
2017-03-30 23:19:43 +02:00
Haojian Wu
e8abee9ca9
Replace C-style casts with static_cast.
2017-03-30 23:05:47 +02:00
Kevin Sawicki
fcb7cbc54a
Check name directly instead of arguments length
2017-03-30 14:03:00 -07:00
Kevin Sawicki
a2588c1fd9
Merge pull request #9052 from tonyganch/native_tabs
...
Native tabs on macOS
2017-03-30 14:02:19 -07:00
Haojian Wu
ff745e1a82
Use prefix increment in for loops.
2017-03-30 22:56:21 +02:00
Haojian Wu
8d8c7ce6ad
Correct type cast.
2017-03-30 22:53:20 +02:00
Kevin Sawicki
6f27d466a5
Move tabbingIdentifier out of webPreferences list
2017-03-30 13:49:00 -07:00
Kevin Sawicki
42300ae58e
Make tabbing identifier var local
2017-03-30 13:47:11 -07:00
