Electron Bot
716cb28430
chore: bump chromium to 1e9f9a24aa12 (master) ( #17880 )
...
* chore: bump chromium in DEPS to 1e9f9a24aa12bea9cf194a82a7e249bd1242ec4f
* chore: update patches
* Make WebContents' theme color a base::Optional<SkColor>
https://chromium-review.googlesource.com/c/chromium/src/+/1540022
* update autofill patch for incorrect header includes
* Move Shell messages to web_test and rename to BlinkTest.
https://chromium-review.googlesource.com/c/chromium/src/+/1525181
* Make PlatformNotificationServiceImpl a KeyedService.
https://chromium-review.googlesource.com/c/chromium/src/+/1336150
* Move MediaPlayerId to its own file.
https://chromium-review.googlesource.com/c/chromium/src/+/1547057
* Remove net/base/completion_callback.h, which is no longer used
https://chromium-review.googlesource.com/c/chromium/src/+/1552821
* AW NS: support file scheme cookies
https://chromium-review.googlesource.com/c/chromium/src/+/1533486
* Remove SecurityInfo and adapt remaining consumers
https://chromium-review.googlesource.com/c/chromium/src/+/1509455
* Remove deprecated type-specific number to string conversion functions
https://chromium-review.googlesource.com/c/chromium/src/+/1545881
* DevTools: Adding new performance histograms for launch of top 4 tools
https://chromium-review.googlesource.com/c/chromium/src/+/1506388
* Update include paths for //base/hash/hash.h
https://chromium-review.googlesource.com/c/chromium/src/+/1544630
* build: Disable ensure_gn_version gclient hook for mac CI checkout
* update patches
* use maybe version of v8::String::NewFromTwoByte
* bump appveyor image version
* fix mac ci hopefully
* Convert enum to enum class for MenuAnchorPosition
https://chromium-review.googlesource.com/c/chromium/src/+/1530508
* use maybe version of ToObject
* RenderViewHost::GetProcess is no longer const
* Unrefcount AuthChallengeInfo
https://chromium-review.googlesource.com/c/chromium/src/+/1550631
* MenuButtonController takes Button rather than MenuButton
https://chromium-review.googlesource.com/c/chromium/src/+/1500935
* add //ui/views_bridge_mac to deps to fix link error
* forward declare views::Button in atom::MenuDelegate
* more v8 patches
* base/{=> hash}/md5.h
https://chromium-review.googlesource.com/c/chromium/src/+/1535124
* gfx::{PlatformFontWin => win}::*
https://chromium-review.googlesource.com/c/chromium/src/+/1534178
* fix v8 patches
* [base] Rename TaskScheduler to ThreadPool
https://chromium-review.googlesource.com/c/chromium/src/+/1561552
* use internal_config_base for bytecode_builtins_list_generator
avoids windows link errors
* FIXME: temporarily disable v8/breakpad integration
* FIXME: temporarily disable prevent-will-redirect test
* FIXME: disable neon on aarch64 pending crbug.com/953815
* update to account for WebCursor refactor
https://chromium-review.googlesource.com/c/chromium/src/+/1562755
* enable stack dumping on appveyor
* Revert "FIXME: disable neon on aarch64 pending crbug.com/953815"
This reverts commit 57f082026be3d83069f2a2814684abf4dc9e7b53.
* fix: remove const qualifiers to match upstream
* fix: remove const qualifiers to match upstream in cc files as well
* don't throw an error when testing if an object is an object
* use non-deprecated Buffer constructor
* Remove net::CookieSameSite::DEFAULT_MODE enum value
https://chromium-review.googlesource.com/c/chromium/src/+/1567955
* depend on modded dbus-native to work around buffer deprecation
https://github.com/sidorares/dbus-native/pull/262
* revert clang roll to fix arm build on linux
* fixup! depend on modded dbus-native to work around buffer deprecation
need more coffee
* update coffee-script
* robustify verify-mksnapshot w.r.t. command-line parameters
* Revert "robustify verify-mksnapshot w.r.t. command-line parameters"
This reverts commit a49af01411f684f6025528d604895c3696e0bc57.
* fix mksnapshot by matching args
* update patches
* TMP: enable rdp on appveyor
* Changed ContentBrowserClient::CreateQuotaPermissionContext() to return scoped_refptr.
https://chromium-review.googlesource.com/c/chromium/src/+/1569376
* Make content::ResourceType an enum class.
https://chromium-review.googlesource.com/c/chromium/src/+/1569345
* fixup! Make content::ResourceType an enum class.
* turn off rdp
* use net::CompletionRepeatingCallback instead of base::Callback<void(int)>
* remove disable_ensure_gn_version_gclient_hook.patch
* copy repeating callback instead of std::move
* fix lint
* add completion_repeating_callback.h include
2019-04-20 10:20:37 -07:00
Charles Kerr
ed31cfebc9
fix: check for pane focus before removing it. ( #17164 )
...
Fixes #16883 . This bug seems to have been introduced in the #15302 's
menu a11y refactor and is new in 5-0-x.
2019-03-04 09:47:59 -06:00
Cheng Zhao
323b688ab8
fix: check the root window in MenuBar::SetPanelFocus ( #16581 )
2019-01-29 13:21:32 -08:00
Sylvester Keil
2e91bf1e15
Fix GTK menubar item color ( #15878 )
...
Use menubar item color (not menu item color).
Closes #15194
2018-11-30 09:28:45 -08:00
Heilig Benedek
894ae1b3f5
refactor: Improve accessibility of menus ( #15302 )
...
* refactor: improve menubar keyboard accessibility
* fix: create a temporary widget for tray icon context menu
* fix: focus menu bar with Alt when autohide is off
* fix: make menu bar focus work more like the native menus
* fix: only focus menu bar if it's not already focused
* fix: track accelerator registration to avoid duplicates
* docs: add docs for & notation in app menu item names
* fix: only try to activate accelerator if it's registered
* fix: add friend to monitor window focus change
* style: add <memory> include
2018-10-29 13:08:46 -05:00
Shelley Vohr
c9bc3471e7
fix: get background color from GtkMenuBar#menubar ( #14785 )
...
* fix: get background color from GtkMenuBar#menubar
* expose libgtkui::GetBgColor
2018-09-25 13:57:06 -07:00
Charles Kerr
d663b4eaee
fix: fix gn cpplint warnings ( #14583 )
...
* chore: fix cpplint 'include_what_you_use' warnings
Typically by including <memory>, <utility> etc.
* chore: fix 'static/global string constant' warning
Use C style strings instead of std::string.
Style guide forbids non-trivial static / global variables. https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables
/home/charles/electron/electron-gn/src/electron/script/cpplint.js
* refactor: remove global string variables.
Fix 'global string variables are not permitted' linter warnings
by using the base::NoDestructor<> wrapper to make it explicit that
these variables are never destroyed.
The style guide's take on globals with nontrivial destructors:
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables
* fix: initializer error introduced in last commit
* fix: remove WIP file that was included by accident
* fix: include order
* fix: include order
* fix: include order
* fix: include order, again
2018-09-12 19:25:56 -05:00
Jeremy Apthorp
6f91af9343
chore: fix various chromium-style errors in windows ( #13394 )
...
These errors weren't previously picked up because the GN build wasn't running on Windows.
2018-06-25 22:30:00 +02:00
Aleksei Kuzmin
4a38c2d800
Remove deprecated View::SetLayoutManager
...
https://chromium-review.googlesource.com/844760
2018-06-19 11:49:43 +10:00
Milan Burda
2337237d58
Refactoring: use C++11 class member variable initialization
2018-05-22 00:18:38 +02:00
Jeremy Apthorp
da0fd10423
refactor: chromium-style warnings in linux code ( #12949 )
2018-05-16 14:12:45 -05:00
Jeremy Apthorp
8fa48d1c04
fix: unused variable warnings in linux code ( #12950 )
2018-05-15 13:49:27 -05:00
Charles Kerr
f8b8dc1494
Simplify views/menu_bar focus management ( #12536 )
...
* Simplify views/menu_bar focus management
* Make the linter happy
* Remove NativeWindowView focus manager listener API
* remove unnecessary change
* MenuBar ctor now takes a views::View
2018-04-05 21:53:08 -05:00
Charles Kerr
558ef7352d
Better GTK+ Menu color support ( #12300 )
...
* Better GTK+ Menu color support
* Fix 'invisible menu' issue (#12275 )
* Now updates menu text color when focus changes!
* Better caching of colors when system theme changes
* Removed all GTK+ deprecation warnings from menubar
* Don't highlight menu text on mouseover in GTK+
* Fix textColor declaration scope error
* Simplify FocusManager connection management a bit
* Make the linter happy
* Decouple MenuBar view recoloring from rebuilding
This way we don't need to rebuild the subview each time a recolor
is needed, e.g. when window focus changes or the system theme changes
* Don't iterate child views if we don't need to
* Move variable declaration outside of a loop
* More efficient iteration of MenuBar children
* Cleaner MenuButton bounds testing
* Fix oops
* Add a nullptr check in MenuBar::GetItemCount()
* Simplify iteration in MenuBar::RebuildChildren()
* Make the linter happy
* Fix signed-unsigned comparison
* Remove declarations of nonexistent methods
* Make SubmenuButton accessor const
* Cleaner accelerator iteration
* Windows fixes
2018-03-17 06:37:36 +09:00
Charles Kerr
56859531cd
fix floating reference glib warning ( #11948 )
...
use gtk_widget_destroy() rather than g_object_unref() on the floating temporary menubar widget that we use to calculate colors
2018-02-19 00:12:54 -06:00
Charles Kerr
5e7a5ce3a9
run clang-format on changed sources
2018-02-15 15:20:55 -06:00
Charles Kerr
381ed2e2b2
remove GTK+ 2 specific code
2018-02-15 14:57:45 -06:00
Charles Kerr
3710e0e38b
make the linter happier
2018-02-09 19:34:37 -06:00
Charles Kerr
3f5ce6d74f
fix gtk3 deprecation warnings setting menubar colors
2018-02-09 19:04:59 -06:00
Aleksei Kuzmin
e0d7b7d0fc
Clean up views::Background.
...
https://chromium-review.googlesource.com/c/chromium/src/+/520702
2017-11-24 10:58:17 +09:00
Aleksei Kuzmin
93b3d8cb49
Changed top/bottom & left/right border parameters on BoxLayout to take single gfx::Insets parameter.
...
https://chromium-review.googlesource.com/c/chromium/src/+/515902
2017-11-24 10:58:17 +09:00
Kevin Sawicki
9945fc5148
Don't destroy menu delegate until OnMenuClosed fires
2017-08-15 16:19:21 +03:00
Heilig Benedek
df911593d8
Fix menubar animations being incorrect in RTL layout
2017-05-21 22:36:10 +02:00
Cheng Zhao
be29ea4dad
libgtk2ui => libgtkui
2017-02-06 10:34:29 -08:00
Kevin Sawicki
98387e50cc
Focus window on menu bar click
2016-10-24 11:49:51 +09:00
Kevin Sawicki
9cae04edde
Remove unused ButtonListener
2016-10-03 10:26:18 -07:00
Kevin Sawicki
b3b9994ce8
Configure ink drops on menu bar buttons ( #7397 )
...
* Add ink drop to menu bar buttons
* Pass background color to submenu button
* Sort includes
2016-09-29 09:15:12 -07:00
Kevin Sawicki
2faf00dc19
Only use default accelerator in Windows/Linux app menu
2016-07-07 11:50:19 -07:00
Florent Delayen
4d55175649
Execute click handlers for top level menu items
2016-06-25 16:51:43 +02:00
Cheng Zhao
aca37c8974
Update menubar color when theme changes
2016-06-21 18:05:01 +09:00
Brian R. Bondy
f93fa53aea
Update linux menu overrides
2016-05-13 11:07:17 +09:00
Cheng Zhao
698700716b
Show menu by clicking the menu button
2016-01-05 12:05:27 +08:00
Cheng Zhao
43bfce26a7
Do not behave like bookmarkbar menu
2016-01-05 11:57:58 +08:00
Paul Betts
af28900189
Fix up Chrome47 changes
2015-12-07 13:27:05 -08:00
Cheng Zhao
c7468278df
Change the window class names
2015-04-14 16:18:57 +08:00
Kevin Sawicki
b6b6fc3bfd
Remove All Rights Reserved after GitHub copyright
...
Closes #762
2014-10-31 11:17:05 -07:00
Cheng Zhao
9546120ce4
linux: Fix API changes of Chrome 37.
2014-09-01 20:10:14 +08:00
Cheng Zhao
1dabd20d99
win: Underline's color tends to be a little lighter.
2014-08-18 15:41:57 +08:00
Cheng Zhao
b8bfe8a9ad
views: Always hide accelerator when submenu is activated.
2014-08-18 14:58:52 +08:00
Cheng Zhao
a230daa998
views: Pressing "Alt+Key" should bring up the menu bar.
2014-08-18 14:52:44 +08:00
Cheng Zhao
ba41634ad6
views: Show menubar's submenu when "Alt+Key" is pressed.
2014-08-18 14:42:21 +08:00
Cheng Zhao
e9536508a5
views: Show menubar's accelerator when "Alt" is pressed.
2014-08-18 14:12:12 +08:00
Cheng Zhao
965f2b1b6b
views: Draw underline in menu bar for accelerators.
2014-08-18 13:36:00 +08:00
Cheng Zhao
e25417ab31
linux: Use "fg" of GtkStyle as text color, fixes #555 .
2014-08-18 10:29:21 +08:00
Cheng Zhao
009e0790fe
linux: Draw menubar text and background with native theme, fixes #540 .
2014-08-05 18:05:34 +08:00
Cheng Zhao
b9fc5474c5
win: Use system's menu bar color.
2014-07-25 15:20:25 +08:00
Cheng Zhao
92a0a4cf6c
views: Filter out the "&" in window menu.
2014-07-25 14:53:19 +08:00
Cheng Zhao
0f18d63f7f
views: Implement the window menu bar.
2014-07-17 14:23:28 +08:00
Cheng Zhao
2ee7caccfe
views: Add an empty menu bar.
2014-07-16 22:12:57 +08:00