mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
28482 commits 1 branch 183 tags 5.3 GiB
Commit graph

14 commits

Author SHA1 Message Date
Shelley Vohr
1729a9868c
fix: use BlockedRequest struct to handle webRequest data (#42647) 
Fixes an issue where Chromium could crash on a dangling unretained pointer in one of several webRequest functions. This was happening as a result of the fact that we had outstanding blocking requests continue to reference state owned by ProxyingWebsocket and ProxyingURLLoaderFactory after the requests were destroyed.

This had been going on for a few years, and was likely leading to some ongoing memory issues. To fix this, we need to ensure that all state is cleaned up in OnRequestWillBeDestroyed. I chose to create a new BlockedRequest struct to do so, which approximates the approach that upstream takes. The complexities of doing so also made our templated approach more trouble than it felt worth, so i pried that apart into separate handlers.
 2024-07-02 14:02:49 +02:00
Milan Burda
f6e8544ef6
refactor: use replaceAll() instead of replace() when appropriate (#39721) 
refactor: use replaceAll() instead of replace() when appropriate
 2023-09-07 15:50:14 +09:00
Milan Burda
f27b034045
test: convert a few more specs to async/await (#39712) 2023-09-04 12:33:29 +02:00
Milan Burda
d78f37ec8f
refactor: use node scheme imports in spec (#38487) 
Co-authored-by: Milan Burda <miburda@microsoft.com>
 2023-06-15 10:42:27 -04:00
electron-roller[bot]
de192c2db2
chore: bump node to v18.16.0 (main) (#37973) 
* chore: bump node in DEPS to v18.16.0

* build,test: add proper support for IBM i

https://github.com/nodejs/node/pull/46739

* lib: enforce use of trailing commas

https://github.com/nodejs/node/pull/46881

* src: add initial support for single executable applications

https://github.com/nodejs/node/pull/45038

* lib: do not crash using workers with disabled shared array buffers

https://github.com/nodejs/node/pull/41023

* src: remove shadowed variable in OptionsParser::Parse

https://github.com/nodejs/node/pull/46672

* src: allow embedder control of code generation policy

https://github.com/nodejs/node/pull/46368

* src: allow optional Isolate termination in node::Stop()

https://github.com/nodejs/node/pull/46583

* lib: fix BroadcastChannel initialization location

https://github.com/nodejs/node/pull/46864

* chore: fixup patch indices

* chore: sync filenames.json

* fix: add simdutf dep to src/inspector BUILD.gn

- https://github.com/nodejs/node/pull/46471
- https://github.com/nodejs/node/pull/46472

* deps: replace url parser with Ada

https://github.com/nodejs/node/pull/46410

* tls: support automatic DHE

https://github.com/nodejs/node/pull/46978

* fixup! src: add initial support for single executable applications

* http: unify header treatment

https://github.com/nodejs/node/pull/46528

* fix: libc++ buffer overflow in string_view ctor

https://github.com/nodejs/node/pull/46410

* test: include strace openat test

https://github.com/nodejs/node/pull/46150

* fixup! fixup! src: add initial support for single executable applications

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2023-04-18 22:23:11 +02:00
Jeremy Rose
fda8ea9277
feat: add protocol.handle (#36674) 2023-03-27 10:00:55 -07:00
Milan Burda
ed7b5c44a2
feat: add types to webRequest filter (#30914) 2023-02-27 11:16:59 -08:00
Jeremy Rose
a3e3efe4c4
test: use node helpers for events.once and setTimeout promise (#37374) 2023-02-23 15:53:53 -08:00
Milan Burda
f97d68c4bf
test: convert functions to async & eliminate duplicates (#37316) 
test: convert functions to async

Co-authored-by: Milan Burda <miburda@microsoft.com>
 2023-02-20 12:30:57 +01:00
Milan Burda
cf10c19c33
test: cleanup let xyz = null as unknown as T; (#37335) 2023-02-19 01:24:24 -08:00
Milan Burda
ea848bc1c5
test: use webContents.create() in type-safe way (#37281) 
test: use (webContents as typeof ElectronInternal.WebContents).create()

Co-authored-by: Milan Burda <miburda@microsoft.com>
 2023-02-16 15:41:41 +01:00
Milan Burda
4bc6b15f53
refactor: move spec helpers to spec/lib (#37010) 
Co-authored-by: Milan Burda <miburda@microsoft.com>
 2023-01-25 13:01:25 -08:00
Milan Burda
5fd7a43970
test: replace (webContents as any).destroy() with webContents.destroy() (#36653) 
Co-authored-by: Milan Burda <miburda@microsoft.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
 2022-12-14 16:07:38 -05:00
Jeremy Rose
db7c92fd57
test: drop now-empty remote runner (#35343) 
* test: drop the now-empty remote runner from CI

* move fixtures to spec-main

* remove remote runner

* fix stuff

* remove global-paths hack

* move ts-smoke to spec/

* fix test after merge

* rename spec-main to spec

* no need to ignore spec/node_modules twice

* simplify spec-runner a little

* no need to hash pj/yl twice

* undo lint change to verify-mksnapshot.py

* excessive ..

* update electron_woa_testing.yml

* don't search for test-results-remote.xml

it is never produced now
 2022-08-16 15:23:13 -04:00
Renamed from spec-main/api-web-request-spec.ts (Browse further)