refactor: replace base::StringPrintf() calls with absl::StFormat()
The former is now a pass-through for the latter and is slated for removal
Xref: https://issues.chromium.org/issues/402415654907781
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: bump chromium in DEPS to 132.0.6791.1
* 5804481: [UI] Migrate remaining clients of `MenuSourceType`
5804481
* chore: bump chromium in DEPS to 132.0.6793.1
* chore: bump chromium in DEPS to 132.0.6794.0
* chore: bump chromium in DEPS to 132.0.6797.0
* 5952404: Clean up //ui/base/resource from Lacros code.
5952404
* 5920842: Generate combined grd for PEPC strings and use them in the element
5920842
* 5943708: Enable DynamicSafeAreaInsets for eligible users only
5943708
* 5937004: Remove components/services/language_detection
5937004
* 5920322: [UI] Use mojo enum for `MenuSourceType` in ui/views/controls/
5920322
* chore: fixup patch indices
* chore: bump chromium in DEPS to 132.0.6799.0
* chore: bump chromium in DEPS to 132.0.6801.0
* chore: bump chromium in DEPS to 132.0.6803.0
* chore: bump chromium in DEPS to 132.0.6805.1
* chore: bump chromium in DEPS to 132.0.6807.0
* chore: bump chromium in DEPS to 132.0.6809.1
* chore: bump chromium in DEPS to 132.0.6811.1
* chore: bump chromium in DEPS to 132.0.6813.1
* chore: bump chromium in DEPS to 132.0.6815.1
* chore: bump chromium in DEPS to 132.0.6817.1
* 5947724: [ui] Add missing shortcut text for VKEY_COMMAND on linux
5947724
(cherry picked from commit 0fdf6c6e510752dcfd9d3062dff71aff55c5fdab)
* 5948024: [DNT] Fix NavigationController raw_ptr during WebContents destruction
5948024
(cherry picked from commit f6662c3b6dd5f40691644911a2d527ae48015ccb)
* 5945209: Roll libc++ from c8eec3629a9e to e2c39ff9388b (1 revision)
5945209
(cherry picked from commit 55b75a1456ccdb9a9771db741fed14a9706419b7)
* 5942398: Remove some chrome:: namespace from chrome/browser/win/*
Refs: 5942398
(cherry picked from commit d664ce2434e3995b628b3b252877df4efebc6825)
* chore: fixup patch indices
(cherry picked from commit 657cd6ee3470291123e8a8d0f6f189f2a3280c5d)
* 5963016: FSA: Use the profile path for base::DIR_HOME on ChromeOS
Refs: 5963016
(cherry picked from commit 69505baee6d037fe370ec10c0ffa03447a43ab34)
* chore: fixup patch indices
(cherry picked from commit c79c2c8734a82be32cd7ff6f9d70d3be5e08e50b)
* 5924816: [macOS][FSA] Block Access to Application Bundle Path
Refs: 5924816
(cherry picked from commit dbcc24fe26337d063a9623379a8e9c2b5a64ce65)
* 5962517: [media] Apply inside blink to renderer/platform/media
Refs: 5962517
(cherry picked from commit f396860717dc4692c9ee036b91a07d12f3114991)
* 5829616: MPArch based GuestViews basic implementation
Refs: 5829616
(cherry picked from commit b95772daa33fce58e0c09847c60511e8b53eacb2)
* 5953710: Expose a rust_static_library instead of raw rs file from rust_bindgen
Refs: 5953710
(cherry picked from commit 11edc865b578d1596d42a4abfb811360c960e51c)
* chore: fixup patch indices
(cherry picked from commit 7be81bdd02cff8894c4fff141d39408906164a8e)
* chore: disable ELF CREL on Linux Arm
5938657: Reapply "Enable ELF CREL, which reduces the size of ELF relocatable object files." | 5938657
(cherry picked from commit 48c5efd0b0ab8fdfafb1b8df2ef35150362df410)
* chore: bump chromium in DEPS to 132.0.6807.0
(cherry picked from commit f41da7b5a3b8da6af161ab37c7b6792de1c008d7)
* 5868889: Shared Storage: Support saved queries in selectURL
Refs: 5868889
(cherry picked from commit 4e389ef21ab0e860373b7aab0cc74beee020b2fe)
* Revert "5956408: [fastapi] Promote deprecation of FastApiTypedArray"
Refs: 5956408
(cherry picked from commit a4b8e46b34a01e72dbeeaa4fdbae1939402a4ca6)
* Revert "5962696: [mojo] Force blink headers to only be included in blink"
Refs: 5962696
(cherry picked from commit f0228c286fcb8166ff57cda4dd2b353b4c06b69a)
* chore: update patches
(cherry picked from commit 3a3c527a1de9ee4f6f3e8545a8e4ff7c6ac6fa0c)
* 5973073: [Extensions] Improve warnings parsing (host) permissions in MV3
Refs: 5973073
(cherry picked from commit c571e561e0b4ba06bd40d8ec4e9cfe59ede010c5)
* chore: update filenames.libcxx.gni
(cherry picked from commit 7677e9bfc6b18ac3556b20fd4f4888e9f2d37431)
* Apply suggestions from code review
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
(cherry picked from commit e8dd8215cff2f3f7216b31ef8edc8a3b24c56e2c)
* chore: update patches after rebase
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* Revert "docs: fix `win.getContentView(`) return type (#44464)"
This reverts commit b11c6cf9bf.
* fix: Use openURL:configuration:completionHandler instead of openUrl
Co-authored-by: alice <alice@makenotion.com>
* test: add a test
Co-authored-by: alice <alice@makenotion.com>
* fix: add dispatch_async to replace GetUIThreadTaskRunner
Co-authored-by: alice <alice@makenotion.com>
* refactor: remove unused import
Co-authored-by: alice <alice@makenotion.com>
* fix: update to use BindPostTaskToCurrentDefault
Co-authored-by: alice <alice@makenotion.com>
* test: add regression test for window focus
Co-authored-by: alice <alice@makenotion.com>
* refactor: update to explicit task runner
Co-authored-by: alice <alice@makenotion.com>
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: alice <alice@makenotion.com>
* perf: prefer NewFromUtf8Literal() over NewFromUtf8() for string literals
the string length is known at compile time and no need to call ToLocalChecked()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* perf: string length is known when calling NewFromUtf8(), so use it
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* perf: remove unnecessary calls to c_str()
these just force the code being called to have to recalculate the string length
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: move as_byte_span() to new shell/common/mac_util.h
this way it can be used by multiple mm files
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* fix: -Wunsafe-buffer-usage warnings in UNNotificationResponseToNSDictionary
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: use base::HexEncode() instead of rolling our own
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* fixup! chore: move as_byte_span() to new shell/common/mac_util.h
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* fixup! chore: move as_byte_span() to new shell/common/mac_util.h
fix: move mac_util to the right place in filenames.gni
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
fix: respect setAlwaysOnTop before showInactive on Linux under X11 (#44078)
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Beutner <31829097+cptpcrd@users.noreply.github.com>
* chore: bump chromium in DEPS to 131.0.6778.4
* chore: bump chromium to 131.0.6778.0 (main) (#44251)
* chore: bump chromium in DEPS to 131.0.6778.0
* 5803393: [UI] Add alias for mojo version of `MenuSourceType`
5803393
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
(cherry picked from commit ef84f13650)
* chore: bump chromium in DEPS to 132.0.6779.0
(cherry picked from commit 77f17523f2103a3f3521d063c4cc73b018745d42)
* chore: update patches
(cherry picked from commit fed98882323641f3212f0023c6d46a23ef20e835)
* 5904951: controlledframe: Disable File System Access for <controlledframe>
5904951
(cherry picked from commit 289a2fb86aa8d2c4f2431289214ce00fa52a67a7)
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* chore: bump chromium in DEPS to 131.0.6756.0
* chore: update disable_hidden.patch
no code changes; just handling upstream context shear
5887019
* chore: update feat_expose_raw_response_headers_from_urlloader.patch
Factor out URLLoader's URLRequest configuration into a helper
Xref: 5902254
* chore: update fix_disabling_background_throttling_in_compositor.patch
no manual changes; patch applied with fuzz 1
* chore: e patches all
* 5882129: Fix basic auth issues for sub frame and sub resources | 5882129
- Add `is_request_for_navigation` param to
ElectronBrowserClient::CreateLoginDelegate().
- Propagate the flag as another undocumented property
in the app.login Event's authenticationResponseDetails object
- Side cleanup: also in CreateLoginDelegate(), use upstream's name
for the `is_request_for_main_frame` param, renamed back in
3256171
* 5875189: [FSA] Check for DANGEROUS extension types when creating a new file. | 5875189
* chore: node ./script/gen-libc++-filenames.js
* chore: bump chromium in DEPS to 131.0.6758.0
* chore: bump chromium in DEPS to 131.0.6760.0
* chore: update patches
* [A11y] Remove Accessibility Object Model (AOM)
Refs 5896593
* chore: bump chromium in DEPS to 131.0.6762.0
* [heap] Remove deprecated V8 flag
Refs 5904046
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* refactor: const correctness
* refactor: extract-method AsarFileValidator::EnsureHashExists()
* refactor: replace use of deprecated crypto API
https://crbug.com/364687923
* refactor: use span API in AsarFileValidator::OnRead()
* refactor: replace use of deprecated crypto API
https://crbug.com/364687923
* fixup! refactor: use span API in AsarFileValidator::OnRead()
fix: electron-ia32-testing FTBFS
* chore: bump chromium in DEPS to 131.0.6750.0
* Clean up stale base::Feature "RestrictFileURLNavigation"
Xref: 5891262
* chore: update mas_avoid_private_macos_api_usage.patch
Comment out some new private macOS API use.
Xref: 5837702
Xref: https://electronhq.slack.com/archives/C5VT8SQ8K/p1727807285899389
* chore: e patches all
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
perf: use ArrayBuffer::Data() API
Replace our `GetBackingStore()->Data()` calls with this instead.
Explained by the V8 docs, ArrayBuffer.Data() is
> More efficient shortcut for GetBackingStore()->Data(). The
> returned pointer is valid as long as the ArrayBuffer is alive.
fix: -Wunsafe-buffer-usage warnings in ElectronComponentExtensionResourceManager::AddComponentResourceEntries()
just replace pointer-and-length args with a span
* chore: bump chromium in DEPS to 131.0.6738.0
* chore: bump chromium in DEPS to 131.0.6740.0
* 5889025: [LaCrOS] Remove LaCrOS screen capturer. | 5889025
* https://boringssl.googlesource.com/boringssl.git/+/40dd94116ba03678226443ba20c5887459c9bf16/crypto/fipsmodule/digest/digests.c.inc
* chore: update patches
* 5878695: Add IsolationInfo for embedders handling external protocols | 5878695
* 5854304: [UI] Remove alias of mojom | 5854304
* chore: bump chromium in DEPS to 131.0.6742.0
* chore: update patches
* chore: bump chromium in DEPS to 131.0.6744.0
* fixup! 5889025: [LaCrOS] Remove LaCrOS screen capturer. | 5889025
* chore: e patches all
* chore: update chore_provide_iswebcontentscreationoverridden_with_full_params.patch
Xref: 5894233
* [UI] Remove alias of mojom 'WindowShowState'
Xref: 5854304
* chore: gen-libc++-filenames.js
* chore: partially revert 5894233
see patch commit message for description
* Clean up stale base::Feature "kFileSystemAccessLocalUNCPathBlock"
This feature is always on by default and doesn't have active finch
experiments.
Xref: 5881253
* fix: asar integrity test recognizes SIGABRT as a crash
5882758
ValidateIntegrityOrDie() exits via LOG(FATAL)'s call to
base::ImmediateCrash(). There's been churn there upstream between
5332940 and 5882758 on whether to use SIGTRAP or SIGABRT. For now,
let's accept both until the churn is done.
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: alice <alice@makenotion.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* fix: do not build electron_plugin_info_host_impl.cc when plugins are disabled
it fails to build from source with this error:
../../content/public/browser/plugin_service.h:17:2: error: "Plugins should be enabled"
17 | #error "Plugins should be enabled"
* fix: FTBFS in printing_utils.cc when ENABLE_PDF is false
* fixup! fix: do not build electron_plugin_info_host_impl.cc when plugins are disabled
fix BUILD.gn linting
* feat: add error event for utility process
* chore: use public report api
* chore: fix lint
* doc: mark error event as experimental
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: -Wunsafe-buffer-usage warnings in GdkPixbufFromSkBitmap()
* refactor: don't change previous behavior for 0-height images
Is a 0x0 image even a thing? I'm not sure; but just in case, let's
treat it the same way the previous implementation did.
test: expect a `sender-pid` hint in Linux notifications.
This PR ensures that the `sender-pid` hint is set for new notifications.
It also updates the spec to confirm that DBus receives the hint and that
it has the correct value.
This fixes a spec failure when running libnotify >= 0.7.12 (2022-05-05).
Starting with that version, libnotify started injecting `sender-pid` if
not provided by the client. So our tests received a slightly different
DBus payload depending on what version of libnotify was installed,
causing our deep-equals tests to fail.
By always providing and testing the `sender-pid` hint, our behavior and
tests should be consistent across distros.
* chore: bump chromium in DEPS to 130.0.6723.4
* chore: bump chromium in DEPS to 131.0.6724.0
* chore: update patches
* chore: update libc++ filenames
* 5844369: controlledframe: Disable Web Bluetooth for <webview> & <controlledframe>
5844369
* (multiple CLs): Use an opaque type for FrameTreeNode IDs
5807683: Use an opaque type for FrameTreeNode IDs, part 1 | 5807683
5829746: Use an opaque type for FrameTreeNode IDs, part 2 | 5829746
5836903: Use an opaque type for FrameTreeNode IDs, part 7 | 5836903
5837249: Use an opaque type for FrameTreeNode IDs, part 8 | 5837249
5836564: Use an opaque type for FrameTreeNode IDs, part 12 | 5836564
5837180: Use an opaque type for FrameTreeNode IDs, part 15 | 5837180
* 5822889: [task] Make GetForegroundTaskRunner non-virtual
5822889
* 5833297: Remove unused inner WebContents attach params
5833297
* 5806403: Shift PowerMonitor to non static
5806403
* 5666874: [3/N] Remove old OnPowerChange in PowerObserver
5666874
* 5829085: [v8] Differentiate between UserVisible and BestEffort task runners
5829085
* 5791112: [webrtc] Use `c/b/permissions/system` for system permissions
5791112
* 5825636: [Extensions] Create WebContentsObservers with ExtensionsBrowserClient
5825636
* fixup! (multiple CLs): Use an opaque type for FrameTreeNode IDs
* fixup! 5791112: [webrtc] Use `c/b/permissions/system` for system permissions 5791112
* chore: bump chromium in DEPS to 131.0.6726.0
* chore: update patches
* chore: update libc++ filenames
* 5858119: Declutter: Allow opening to a specific feature
5858119
* fix: macOS SDK 15 error
Not sure exactly what changed in the upgrade to macOS SDK 15, but it triggered a new error:
```
electron/shell/browser/ui/message_box_mac.mm:84:7: error: multiple methods named 'highlight:' found with mismatched result, parameter type or attributes
```
The `highlight:` selector a few lines down was ambiguous because the object type of the `NSArray` was not specified. Specifying `NSButton` as the element type makes the selector unambiguous for type checking.
* 5854143: [File Download Access Prevention] Obfuscate download file for enterprise deep scan
5854143
* 5854811: Use kNotAllowedError instead of kSecurityError for Web MIDI
5854811
* chore: bump chromium in DEPS to 131.0.6728.0
* chore: update patches
* disable invalid test
* chore: bump chromium in DEPS to 131.0.6730.0
* chore: update patches
* update build tools target commit for new macOS SDK
* chore: update libc++ file names
* chore: bump chromium in DEPS to 131.0.6732.0
* chore: bump chromium in DEPS to 131.0.6734.0
* 5856527: [UI] Use mojo enum for `WindowShowState` in ui/
5856527
* chore: update build-tools sha to include macOD 15.0 SDK
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: alice <alice@makenotion.com>
