Cheng Zhao
0dc094fffc
Do not change logic on highlighing
2017-11-28 17:37:58 +09:00
Cheng Zhao
d1ebce0395
Remove unused methods
2017-11-28 17:31:13 +09:00
Cheng Zhao
590578c187
Cache the attributed string
2017-11-28 17:26:09 +09:00
Cheng Zhao
eab3342065
Fix the detection of ANSI code
2017-11-28 16:36:07 +09:00
Cheng Zhao
c9acccaddc
Fix memory leak in ANSCI parsing code
...
We do not have ARC enabled.
2017-11-28 16:36:07 +09:00
Cheng Zhao
4ded79801f
Remove unused code in NSColor+Hex.h
2017-11-28 16:10:24 +09:00
Cheng Zhao
08f30e4ca6
Add license for the vendored files
...
Checked the original files and they were compatible with MIT.
2017-11-28 15:38:42 +09:00
Cheng Zhao
edede7f33f
Fix cpplint warning
2017-11-28 15:36:45 +09:00
Sebastien Bramille
a4905b3c95
Lint
2017-11-28 15:34:13 +09:00
Sebastien Bramille
e8b0897ea1
Fix margin
2017-11-28 15:34:13 +09:00
Sebastien Bramille
71cfb7441c
Update header file
2017-11-28 15:34:13 +09:00
Sebastien Bramille
9f89bd8d8e
Add isHighlighted method
2017-11-28 15:34:13 +09:00
Sebastien Bramille
6a1cfafbd8
Clean
2017-11-28 15:34:13 +09:00
Sebastien Bramille
85f254316c
Add logic
2017-11-28 15:34:13 +09:00
Sebastien Bramille
d722d20974
Use NSString+ANSI on the Menu title
2017-11-28 15:34:13 +09:00
Cheng Zhao
b161a4f515
Merge pull request #11166 from sethlu/openrecent
...
feat: Recent documents menu item
2017-11-28 10:55:14 +09:00
Zhuo Lu
104d307a4a
Use base::scoped_nsobject
2017-11-27 17:26:23 +09:00
Zhuo Lu
8fa3e71ce4
Format code
2017-11-27 17:26:22 +09:00
Zhuo Lu
4934685f53
Declare with static
2017-11-27 17:26:22 +09:00
Zhuo Lu
0c4e425872
Do not autorelease global variables
2017-11-27 17:26:22 +09:00
Zhuo Lu
dcdc3621ac
Rename roles
2017-11-27 17:26:22 +09:00
Zhuo Lu
1ab4504e94
No need to make visible
2017-11-27 17:26:22 +09:00
Zhuo Lu
cf73fb737f
Small optimization
2017-11-27 17:26:22 +09:00
Zhuo Lu
5d44dbaf54
Redesign recent documents role API
...
- For more flexibility in designing the recent documents menu, now there can be one menu item (known issue: you may specify more but AppKit doens't display more than one) in the submenu list, rather than separating the labels with a tab.
- Also added is the role `clearrecent` that can be given to a menu item that can clear the recent documents.
2017-11-27 17:26:22 +09:00
Zhuo Lu
0b9cea334f
Specify "Clear Menu" through label option
...
Like a bit of a hack right now, conforming to the existing menu item definition
2017-11-27 17:26:22 +09:00
Zhuo Lu
8b720c120d
Hide "Open Recent" in xib
2017-11-27 17:26:22 +09:00
Zhuo Lu
4da2eb9366
Introduce openrecent role
...
- Does not yet accept any options except label--"Clear Menu" can't be modified through exposed node API
- If `openrecent` is present across multiple menu items, the last seen will be visible in the main menu due to that it is designed to behave like a singleton
2017-11-27 17:26:22 +09:00
Zhuo Lu
0ba2fa5cba
Use else if
2017-11-27 17:26:22 +09:00
Aleksei Kuzmin
fe9ae41f98
Use gtk_toggle_button_get_active()
2017-11-24 10:58:53 +09:00
Samuel Attard
797a58bee0
Result of RunMenuAt is now void, no need to ignore it
2017-11-24 10:58:17 +09:00
Tomas Rycl
a723e5a4c5
Fixed moved cert x509 function issue on Windows
2017-11-24 10:58:17 +09:00
Aleksei Kuzmin
338604239d
Cleanup MenuRunner API
...
https://codereview.chromium.org/2790773002
2017-11-24 10:58:17 +09:00
Aleksei Kuzmin
14eb2af876
Give CustomButton a focus painter.
...
https://chromium-review.googlesource.com/c/chromium/src/+/516824
2017-11-24 10:58:17 +09:00
Aleksei Kuzmin
e0d7b7d0fc
Clean up views::Background.
...
https://chromium-review.googlesource.com/c/chromium/src/+/520702
2017-11-24 10:58:17 +09:00
Aleksei Kuzmin
93b3d8cb49
Changed top/bottom & left/right border parameters on BoxLayout to take single gfx::Insets parameter.
...
https://chromium-review.googlesource.com/c/chromium/src/+/515902
2017-11-24 10:58:17 +09:00
Tony Ganch
513d4fd225
Remove usage of X11AtomCache
...
See https://codereview.chromium.org/2914103002/
2017-11-24 10:58:17 +09:00
Tony Ganch
d7e4e8d6cc
Rename GetPrefferedSize to CalculatePrefferedSize
...
See https://chromium-review.googlesource.com/c/chromium/src/+/516542
2017-11-24 10:58:17 +09:00
Aleksei Kuzmin
7f5fbb04e2
Migrate from ScopedComPtr::CreateInstance() to CoCreateInstance in chrome/...
...
https://codereview.chromium.org/2894483002
2017-11-24 10:58:17 +09:00
Aleksei Kuzmin
75b41102ef
Remove unused includes
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
1127452429
PlzNavigate: make NavigationResourceHandler a LayeredResourceHandler
...
https://codereview.chromium.org/2847443002
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
a72a08bccc
Convert iOS to use X509CertificateBytes.
...
https://codereview.chromium.org/2864133002
2017-11-24 10:58:16 +09:00
Cheng Zhao
3cc8330998
Merge branch 'master' into ahmedmohamedali-master
2017-11-20 11:04:47 +09:00
Cheng Zhao
7e0593950c
Code style fixes
2017-11-13 16:13:54 +09:00
Heilig Benedek
26daffea9c
use smart pointer for paint_canvas
2017-11-13 15:50:49 +09:00
Heilig Benedek
4b10445c2e
lint fix
2017-11-13 15:50:49 +09:00
Heilig Benedek
193beb57c9
fix datalist element popup position when menu is hidden
2017-11-13 15:50:49 +09:00
Heilig Benedek
f8b3009ebf
restructure code to use web_preferences if possible
2017-11-13 15:50:49 +09:00
Heilig Benedek
71b36ef54d
don't show the dummy window for the rest of the dialogs too on mac
2017-11-13 15:46:46 +09:00
Heilig Benedek
13b86598e8
don't show osr dummy window when dialog is shown on mac
2017-11-13 15:46:46 +09:00
Heilig Benedek
e39aacb30e
fix a bug that caused a crash when using an offscreen window with detached devtools, related to autofill popups
2017-11-13 15:46:46 +09:00