trop[bot]
474c4b43db
fix: potentially closed webContents in BrowserView ( #42811 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-10 11:18:17 -04:00
trop[bot]
26d5583c6b
fix: video and audio capture should be separate ( #42808 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-08 16:49:10 +02:00
trop[bot]
0a73b80127
feat: enable Windows Control Overlay on Linux ( #42681 )
...
* feat: enable Windows Control Overlay on Linux
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* docs: update documentation for Linux WCO
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: initial symbol painting
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* test: enable WCO tests for Linux
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: add missing Layer include
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: fix gn-check failure
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: enable BrowserWindow.setTitleBarOverlay on Linux
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* test: fix test for maximize event on Linux
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: geometry updating on BrowserWindow.setTitleBarOverlay
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: crash when invalid titleBarStyle set
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: clean up ordering and comments
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* Update docs/api/structures/base-window-options.md
Co-authored-by: Erick Zhao <erick@hotmail.ca>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* feat: enable customizing symbolColor
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* docs: correct symbolColor reference
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
* chore: remove Chrome-specific padding
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fixup .patches after rebase
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-07-03 18:56:40 -04:00
trop[bot]
57e859d0af
fix: use BlockedRequest
struct to handle webRequest
data ( #42750 )
...
* refactor: use BlockedRequest model to handle webRequest
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* refactor: finish de-templating
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: address some feedback from review
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-03 13:03:09 +02:00
trop[bot]
de6e6b60bc
fix: setTopBrowserView focus issue with reordering ( #42733 )
...
* fix: reorder top browser view instead of adding/removing
Co-authored-by: Alice Zhao <alice@makenotion.com>
* fix: update browserViews order
Co-authored-by: Alice Zhao <alice@makenotion.com>
* test: add a test for setTopBrowserView
Co-authored-by: Alice Zhao <alice@makenotion.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Alice Zhao <alice@makenotion.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-07-03 12:43:07 +02:00
trop[bot]
5c6daa2223
build: remove fs-extra devdep ( #42712 )
...
* build: remove fs-extra devdep
* build: remove fs-extra dependency from script/gen-filenames.ts
* build: remove fs-extra dependency from script/spec-runner.js
* build: remove fs-extra dependency from script/gn-asar.js
* build: remove fs-extra dependency from spec/api-autoupdater-darwin-spec.ts
* build: remove fs-extra dependency from spec/api-safe-storage-spec.ts
* build: remove fs-extra dependency from spec/lib/codesign-helpers.ts
* build: remove fs-extra dependency from spec/api-app-spec.ts
* build: remove fs-extra dependency from spec/esm-spec.ts
* build: remove fs-extra dependency from spec/lib/fs-helpers.ts
* build: remove fs-extra dependency from spec/lib/api-shell-spec.ts
* build: remove fs-extra dependency from spec/api-context-bridge-spec.ts
* build: remove fs-extra dependency from spec/asar-integrity-spec.ts
* build: remove fs-extra dependency from spec/node-spec.ts
* build: remove fs-extra devdiv
* fixup! build: remove fs-extra dependency from spec/api-context-bridge-spec.ts
* fix: use force: true when removing directories
* chore: reduce diffs to main
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* empty commit to re-trigger appveyor
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-07-01 18:08:09 +02:00
Keeley Hammond
ec64e675c3
build: migrate to GitHub Actions ( #42671 )
...
* build: migrate to GitHub Actions
* build: strip binaries w/ target arch
* chore: fix lint on GHA
* build: remove CircleCI from release builds
2024-07-01 06:32:49 -04:00
trop[bot]
79751340c6
fix: fetch-dependent interfaces in Web Workers ( #42595 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-06-20 16:32:58 -04:00
trop[bot]
50ea20168d
feat: expose system preferences to utility process ( #42599 )
...
* chore: expose system preferences to utility process
* chore: add tests, doc changes and module-list update
* relative link
* use @
* fix test
* chore: disable linux test
* kick
* noop on windows utility process
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: George Xu <33054982+georgexu99@users.noreply.github.com>
2024-06-20 16:12:16 -04:00
trop[bot]
d7858f2f91
fix: MessagePort closing unexpectedly with non-cloneable objects ( #42581 )
...
* fix: MessagePort closing unexpectedly with non-cloneable objects
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: handle serialization failure in parentPort
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-06-19 10:10:57 -04:00
trop[bot]
ff16e0e858
test: use longer timeout on contentTracing tests on WOA ( #42551 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-06-18 17:29:06 +02:00
rcombs
d8e4579e3c
feat: add cumulativeCPUUsage to AppMetrics and CPUUsage ( #41819 )
...
This allows apps to measure their CPU usage over any given period
without worrying about other calls affecting the output,
as they would with `percentCPUUsage`.
2024-06-11 09:38:03 -05:00
electron-roller[bot]
c3b4cd987c
chore: bump chromium to 127.0.6521.0 (main) ( #42118 )
...
* chore: bump chromium in DEPS to 126.0.6470.0
* 5492605: Migrate TODOs referencing old crbug IDs to the new issue tracker IDs | https://chromium-review.googlesource.com/c/chromium/src/+/5492605
* 5513277: Move subresource-filter-ruleset to GCS | https://chromium-review.googlesource.com/c/chromium/src/+/5513277
* 5512656: Remove CustomizeChromeSupportsChromeRefresh2023 | https://chromium-review.googlesource.com/c/chromium/src/+/5512656
* 5516009: Accept mouse events in inactive window for Top Chrome WebUIs | https://chromium-review.googlesource.com/c/chromium/src/+/5516009
* 5376861: Change references to RWHVB in RWHIER and RenderWidgetTargeter to RWHVI. | https://chromium-review.googlesource.com/c/chromium/src/+/5376861
* 5490530: Use partition_alloc PA_BUILDFLAG(...) outside PA. #cleanup | https://chromium-review.googlesource.com/c/chromium/src/+/5490530
* 5296870: network: Allow trusted loaders to learn the sent request cookies. | https://chromium-review.googlesource.com/c/chromium/src/+/5296870
* 5453438: Delegate delegated ink trails to RWHI from RWHIER. | https://chromium-review.googlesource.com/c/chromium/src/+/5453438
* chore: update patches
* chore: bump chromium in DEPS to 126.0.6472.0
* chore: bump chromium in DEPS to 126.0.6474.0
* chore: update patches
* chore: bump chromium in DEPS to 126.0.6476.0
* chore: bump chromium in DEPS to 126.0.6478.0
* chore: bump chromium in DEPS to 126.0.6478.3
* chore: bump chromium in DEPS to 126.0.6478.8
* update patches
* only disable enterprise_cloud_content_analysis
* 5403888: [api] support v8::Data in v8::TracedReference and v8::EmbedderGraph
https://chromium-review.googlesource.com/c/v8/v8/+/5403888
* chore: bump chromium in DEPS to 127.0.6484.0
* chore: bump chromium in DEPS to 127.0.6485.0
* 5539004: Use NOTREACHED_IN_MIGRATION() in remaining chrome/ | https://chromium-review.googlesource.com/c/chromium/src/+/5539004
* src: cast to v8::Value before using v8::EmbedderGraph::V8Node | https://github.com/nodejs/node/pull/52638/files
* chore: update patches
* chore: update v8 patches
* chore: bump chromium in DEPS to 127.0.6486.0
* chore: bump chromium in DEPS to 127.0.6488.0
* chore: bump chromium in DEPS to 127.0.6490.0
* chore: bump chromium in DEPS to 127.0.6492.0
* chore: update patches
For some reason, `feat_expose_raw_response_headers_from_urlloader.patch` got messed up in an earlier commit.
* chore: update patches
printing.patch was updated due to https://chromium-review.googlesource.com/c/chromium/src/+/5535938
* 5527572: Move Connectors prefs files to components/enterprise/connectors/
https://chromium-review.googlesource.com/c/chromium/src/+/5527572
* chore: bump chromium in DEPS to 127.0.6494.0
* chore: bump chromium in DEPS to 127.0.6495.0
* chore: bump chromium in DEPS to 127.0.6496.0
* 5465511: [api] Mark v8::ObjectTemplate::SetAccessor(..) for deprecation
https://chromium-review.googlesource.com/c/v8/v8/+/5465511
* chore: revert v8 deprecation
See patch message for more details.
https://chromium-review.googlesource.com/c/v8/v8/+/5526611
* chore: update patches
* 5538771: Remove srcdoc else-if block in CalculateOrigin()
https://chromium-review.googlesource.com/c/chromium/src/+/5538771
* 5522321: [devtools] Support saving base64 encoded files via host bindings
https://chromium-review.googlesource.com/c/chromium/src/+/5522321
* 5376861: Change references to RWHVB in RWHIER and RenderWidgetTargeter to RWHVI.
https://chromium-review.googlesource.com/c/chromium/src/+/5376861
* 5530163: [media] Use VideoFrame::Plane typed enum instead of nameless enum
https://chromium-review.googlesource.com/c/chromium/src/+/5530163
* 5463431: iwa: Only create IsolatedWebAppURLLoaderFactory for subresources in IWAs
https://chromium-review.googlesource.com/c/chromium/src/+/5463431
* fixup! 5465511: [api] Mark v8::ObjectTemplate::SetAccessor(..) for deprecation https://chromium-review.googlesource.com/c/v8/v8/+/5465511
* 5512176: Remove OnEnvironmentEstimationComplete()
https://chromium-review.googlesource.com/c/chromium/src/+/5512176
* 5528282: Move Web Speech API .mojom files to //media/mojo/mojom
https://chromium-review.googlesource.com/c/chromium/src/+/5528282
* 5513740: Reland "[Extensions] Restructure extensions::ProcessMap"
https://chromium-review.googlesource.com/c/chromium/src/+/5513740
* 5483406: [PEPC] Make PEPC permission subscription take into account device status
https://chromium-review.googlesource.com/c/chromium/src/+/5483406
* 5526034: [DoH] Remove kDnsOverHttps feature flag
https://chromium-review.googlesource.com/c/chromium/src/+/5526034
The title is a bit misleading. They removed handling for the feature flag and generally intend to remove it but haven't yet.
I only changed our code to address the flag that was removed. A quick search on GitHub for `DnsOverHttpsFallback` yielded a few results, but they were all C++ chromium code or patches, 0 app code or discussion results. Since I couldn't find any evidence of this flag being used in developer applications, I've chosen to exclude this change from the breaking changes docs.
* chore: revert v8 removal
https://chromium-review.googlesource.com/c/v8/v8/+/5497515
See patch message for more details.
* chore: cherry-pick Node.js patch for V8 API removal fix
Node.js PR: https://github.com/nodejs/node/pull/52996
V8 API Removal CL: https://chromium-review.googlesource.com/c/v8/v8/+/5539888
See the patch description for more details.
* 5492183: Extensions: CodeHealth: Give enums some class
https://chromium-review.googlesource.com/c/chromium/src/+/5492183
* fixup! 5528282: Move Web Speech API .mojom files to //media/mojo/mojom https://chromium-review.googlesource.com/c/chromium/src/+/5528282
* 5514687: Reland "Add a secret handshake to the base::Feature constructor"
https://chromium-review.googlesource.com/c/chromium/src/+/5514687
* fixup! 5530163: [media] Use VideoFrame::Plane typed enum instead of nameless enum https://chromium-review.googlesource.com/c/chromium/src/+/5530163
* 5466238: PDF Viewer: add metrics to record if PDF is opened with a11y
https://chromium-review.googlesource.com/c/chromium/src/+/5466238
* 5502081: Migrate OnDisplayRemoved to OnDisplaysRemoved
https://chromium-review.googlesource.com/c/chromium/src/+/5502081
* 5539888: [api] Remove several APIs deprecated in version 12.6
https://chromium-review.googlesource.com/c/v8/v8/+/5539888
This commit essentially only removes the `only_terminate_in_safe_scope` isolate creation parameter. This undoes some work that was originally done in #35766 .
* 5498236: Make browser_tests force full async initialization for OSCrypt Async
https://chromium-review.googlesource.com/c/chromium/src/+/5498236
* fixup! 5528282: Move Web Speech API .mojom files to //media/mojo/mojom https://chromium-review.googlesource.com/c/chromium/src/+/5528282
* 5545807: Migrate most remaining NOTREACHED()
https://chromium-review.googlesource.com/c/chromium/src/+/5545807
I took a systematic approach to modifying all of our uses of `NOTREACHED` that were causing errors:
* If there was a `return` or `break` (etc.) immediately after `NOTREACHED`, I removed the control flow instruction and left the `NOTREACHED` unmodified
* All other instances were migrated to `NOTREACHED_IN_MIGRATION`
We should revisit pretty much all usage of `NOTREACHED` as an upgrade follow-up item.
* fixup! 5526034: [DoH] Remove kDnsOverHttps feature flag https://chromium-review.googlesource.com/c/chromium/src/+/5526034
Turns out the feature flags were removed in the `.cc` file, but not the
`.h` feature list file. This means that the feature flags are pretty
much officially gone. (The leftover symbols in the header are likely an
oversight from what I can gather.)
We may potentially decide to put this in the breaking changes doc if we
decide this feature flag is important enough to highlight.
* chore: bump chromium in DEPS to 127.0.6498.3
* chore: bump chromium in DEPS to 127.0.6500.0
* chore: bump chromium in DEPS to 127.0.6502.0
* chore: bump chromium in DEPS to 127.0.6504.0
* chore: bump chromium in DEPS to 127.0.6505.0
* chore: bump chromium in DEPS to 127.0.6508.0
* build: use Sha256Sum in script/sysroots.json
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5506275
* chore: update chore_add_electron_deps_to_gitignores.patch
Xref: no manual changes; patch applied with fuzz 2
* chore: update feat_allow_code_cache_in_custom_schemes.patch
Xref: no manual changes; patch applied with fuzz 1
* chore: e patches all
* fixup! build: use Sha256Sum in script/sysroots.json
`sync` succeeds now
* chore: replace absl::optional with std::optional
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5253843
* chore: update CalculatePreferredSize() to new upstream semantics
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5459174
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5541220
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5514708
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5504212
Xref: https://chromium-review.googlesource.com/516542
* chore: replace absl::optional with std::optional
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5296147
* chore: add kPip to enumeration as a no-op
https://chromium-review.googlesource.com/c/chromium/src/+/5546257
* [Autofill] Remove RenderFrame::ElementBoundsInWindow()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5553982
* chore: fix feat_add_streaming-protocol_registry_to_multibuffer_data_source.patch
need new header to pick up definition of BLINK_PLATFORM_EXPORT macro
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5463143
* chore: bump chromium in DEPS to 127.0.6510.0
* chore: update patches
* chore: fix include path for native_web_keyboard_event.h
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5541976
* chore: add currently-unused should_include_device_status arg to GetPermissionStatusForCurrentDocument()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5545382
* chore: bump chromium in DEPS to 127.0.6512.0
* chore: update mas_avoid_private_macos_api_usage.patch.patch
No manual changes; patch applied with fuzz 1
* chore: update feat_add_streaming-protocol_registry_to_multibuffer_data_source.patch
No manual changes; patch applied with fuzz 1
* chore: update webview_fullscreen.patch
No manual changes; patch applied with fuzz 1
* chore=: remove cherry-pick-22db6918bac9.patch
already present upstream
* chore: remove nonexistent patchfiles from .patches
* chore: remove cherry-pick-3e037e195e50.patch
no longer needed; merged upstream
* Update namespace for files moved to //components/input
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5563251
* Require client for InitParams to always specify an ownership mode.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5532482
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5578714
* chore: e patches all
* fixup! Update namespace for files moved to //components/input
* chore: remove profile_keyed_service_factory, profile_selections from chromium_src
already being linked in via chrome browser for printing
* chore: bump chromium in DEPS to 127.0.6515.0
* chore: bump chromium in DEPS to 127.0.6516.0
* chore: update render_widget_host_view_base.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5547803
patch applied manually due to simple upstream shear
* chore: update feat_allow_code_cache_in_custom_schemes.patch
No manual changes; patch applied with fuzz 1
* chore: e patches all
* Pull RWHIER and RWT to //content/common/input.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5397681
* chore: bump chromium in DEPS to 127.0.6517.0
* chore: update patches
* fixup: Update namespace for files moved to //components/input
* Remove 0-arg (default) constructor for views::Widget::InitParams.
https://chromium-review.googlesource.com/c/chromium/src/+/5578714
* fixup: only disable enterprise_cloud_content_analysis
The original commit a5480accc2
, was due to this CL 5527572: Move Connectors prefs files to components/enterprise/connectors/ | https://chromium-review.googlesource.com/c/chromium/src/+/5527572
* chore: bump chromium in DEPS to 127.0.6519.0
* chore: update patches
* src: do not use deprecated V8 API
https://github.com/nodejs/node/pull/53084
* src: remove dependency on wrapper-descriptor-based cpp heap
https://github.com/nodejs/node/pull/53086
* 5344413: [DevTools] Add `getHostConfig` UI binding for sending status of `base::Features` to DevTools
https://chromium-review.googlesource.com/c/chromium/src/+/5344413
* 5585788: Extensions: ManifestHandler: Separate Registry like ExtensionRegistry
https://chromium-review.googlesource.com/c/chromium/src/+/5585788
* chore: update filenames.libcxx.gni
* 5506857: Reland "Migrate clang-format to gcs first class deps"
https://chromium-review.googlesource.com/c/chromium/src/+/5506857
* fixup: 5539888: [api] Remove several APIs deprecated in version 12.6
* fixup: 5506857: Reland Migrate clang-format to gcs first class deps
* chore: bump chromium in DEPS to 127.0.6521.0
* chore: update patches
* spec: update navigator.keyboard should lock the keyboard
* Block or allow all MIDI using the existing SysEx permission
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5154368
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5499157
* spec: update test/parallel/test-v8-stats
* views: remove CalculatePreferredSize()
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5504212
* chore: update patches after rebase
* 5560288: Re-enable ChromeOS XNNPack on Intel only
https://chromium-review.googlesource.com/c/chromium/src/+/5560288
* chore: add nan patches for v8 changes
Refs
5539888: [api] Remove several APIs deprecated in version 12.6 | https://chromium-review.googlesource.com/c/v8/v8/+/5539888
and
5539852: [heap][api] Remove deprecated v8::Isolate::IdleNotificationDeadline | https://chromium-review.googlesource.com/c/v8/v8/+/5539852
* 5573603: Modularize //chrome/browser/themes
https://chromium-review.googlesource.com/c/chromium/src/+/5573603
* 5539888: [api] Remove several APIs deprecated in version 12.6
https://chromium-review.googlesource.com/c/v8/v8/+/5539888
* chore: update patches
* test: fixup navigator.keyboard.lock on Windows
* chore: remove unneeded profile target
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
Co-authored-by: clavin <clavin@electronjs.org>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2024-06-07 17:18:35 -04:00
Shelley Vohr
54c315c9b0
refactor: improve cookie failure rejection messages ( #42362 )
2024-06-07 10:06:37 +02:00
Shelley Vohr
7f3dc7d4ce
fix: utilityProcess exit codes ( #42297 )
2024-06-07 10:06:00 +02:00
Alice Zhao
406f644d26
feat: duplicate navigation related APIs to contents.navigationHistory
( #41752 )
...
* refactor: move navigation related api to navigationHistory
* docs: add deprecation messages to old web content methods
* fix: add deprecation warnings to webcontents
* fix: add deprecation warnings and make existing naviagation apis internal
* Update docs/api/web-contents.md
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com>
* Update docs/api/web-contents.md
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com>
* Update docs/api/web-contents.md
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com>
* Update docs/api/web-contents.md
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com>
* docs: fix links
* docs: add breaking change to 31
* docs: move breaking change to 32
* chore: re-run pipeline
---------
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com>
2024-06-05 09:34:47 -07:00
Anny Yang
5fb117a7d7
fix: don't destroy BrowserView webContents when owning BrowserWindow hasn't been closed ( #42353 )
...
* fix: moves bv webContents close to closed event
* chore: adds unit tests
* chore: test that bv webContents are destroyed when parent bw closed
2024-06-05 09:58:38 +02:00
Shelley Vohr
39c984e23a
fix: WebUSB should not crash when using in-memory partitions ( #42347 )
2024-06-04 15:24:08 +02:00
Krzysztof Halwa
85df2a86dd
feat: Allow WebContentsView to accept webContents object. ( #42086 )
...
feat: Allow WebContentsView to accept webContents object
2024-05-30 12:45:35 -07:00
Jeremy Rose
19dc276878
feat: remove File.path ( #42053 )
2024-05-15 11:07:23 -07:00
Shelley Vohr
d0cb298f95
fix: webContents.navigationHistory
should be enumerable ( #42139 )
...
fix: webContents.navigationHistory should be enumerable
2024-05-14 16:47:47 -04:00
Samuel Attard
e19754d7fd
test: add tests for electron fuses ( #42129 )
...
* spec: add tests for electron fuses
* spec: fix tests for windows
* spec: handle weird crash codes on win32
* spec: disable fuse tests on arm64 windows
2024-05-13 10:48:26 -07:00
Shelley Vohr
c765d57265
fix: BrowserView autoresizing conversion error ( #42056 )
2024-05-13 10:27:01 +02:00
electron-roller[bot]
9b0409f7c9
chore: bump chromium to 126.0.6445.0 (main) ( #41868 )
...
* chore: bump chromium in DEPS to 125.0.6421.0
* chore: bump chromium in DEPS to 125.0.6422.0
* Add ENABLE_BASE_TRACING flags for compatibility with enable_base_tracing = false on Windows
https://chromium-review.googlesource.com/c/chromium/src/+/5434658
* chore: update patches
* fixup: Add ENABLE_BASE_TRACING flags for compatibility with enable_base_tracing = false on Windows
* chore: bump chromium in DEPS to 126.0.6423.0
* chore: update patches
* 5426599: Next generation control of unsafe-buffers-usage plugin
https://chromium-review.googlesource.com/c/chromium/src/+/5426599
* chore: bump chromium in DEPS to 126.0.6425.0
* chore: update patches
* Roll clang+rust llvmorg-19-init-7229-g315c88c5-2 : llvmorg-19-init-8091-gab037c4f-1 / ceab6128fa48a616bfd3e3adf4bc80133b8ee223-1 : ab71ee7a9214c2793108a41efb065aa77aeb7326-1
https://chromium-review.googlesource.com/c/chromium/src/+/5444328
Also see https://issues.chromium.org/issues/332931387
* 5445074: [Views AX] Move AXEventNotificationDetails to ui/accessibility/
https://chromium-review.googlesource.com/c/chromium/src/+/5445074
Also
5455993: [Views AX] Rename AXEventNotificationDetails to AXUpdatesAndEvents | https://chromium-review.googlesource.com/c/chromium/src/+/5455993
* Pass IsolationInfo to ContentBrowserClient::WillCreateURLLoaderFactory()
https://chromium-review.googlesource.com/c/chromium/src/+/5405301
* chore: bump chromium in DEPS to 126.0.6427.0
* chore: update patches
* chore: remove no longer needed patch
perfetto is now turned on so this patch is no longer needed.
* chore: bump chromium in DEPS to 126.0.6429.0
* chore: bump chromium in DEPS to 126.0.6431.0
* chore: bump chromium in DEPS to 126.0.6433.0
* 5466654: Do not create a console if logging to a handle
https://chromium-review.googlesource.com/c/chromium/src/+/5466654
* chore: fixup patch indices
* Address Linux NonClientFrameView Changes
- https://chromium-review.googlesource.com/c/chromium/src/+/5180720
- https://chromium-review.googlesource.com/c/chromium/src/+/5367794
* chore: bump chromium in DEPS to 126.0.6435.0
* chore: bump chromium in DEPS to 126.0.6437.0
* chore: update patches
* chore: bump chromium in DEPS to 126.0.6439.0
* chore: bump chromium in DEPS to 126.0.6441.0
* 5477689: components/crash/content/tools: Format with yapf | https://chromium-review.googlesource.com/c/chromium/src/+/5477689
* 5485006: Remove enable_print_content_analysis GN flag | https://chromium-review.googlesource.com/c/chromium/src/+/5485006
* chore: update chromium patches
* chore: bump chromium in DEPS to 126.0.6443.0
* 5465608: Convert DCHECKs near RenderWidgetHost, DelegatedFrameHost to CHECK | https://chromium-review.googlesource.com/c/chromium/src/+/5465608
* 5492605: Migrate TODOs referencing old crbug IDs to the new issue tracker IDs | https://chromium-review.googlesource.com/c/chromium/src/+/5492605
* chore: update patches
* chore: bump chromium in DEPS to 126.0.6445.0
* chore: update patches
* 5468588: Fullscreen: Encapsulate ExclusiveAccessBubble params in a struct | https://chromium-review.googlesource.com/c/chromium/src/+/5468588
* fixup! 5485006: Remove enable_print_content_analysis GN flag | https://chromium-review.googlesource.com/c/chromium/src/+/5485006
* 5461340: `size_t` in `mojo::DataPipe[Consumer|Producer]Handle`: /components. | https://chromium-review.googlesource.com/c/chromium/src/+/5461340
* 5480213: Add an EvictIds struct to FrameEvictorClient | https://chromium-review.googlesource.com/c/chromium/src/+/5480213
* 4341506: [api] Deprecate Isolate::IdleNotificationDeadline | https://chromium-review.googlesource.com/c/v8/v8/+/4341506
* 5300826: [v8-tasks] Add source location to v8::TaskRunner, step 4/4. | https://chromium-review.googlesource.com/c/v8/v8/+/5300826
* partially revert is_newly_created to allow for browser initiated about:blank loads
* add dep on app_launch_prefetch
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5420149
* install sysroots from electron not from chrome
We should add a new var upstream for `download_sysroots` so that we can skip downloading chromes at all.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5462469
* refactor: make UpdateFrameHints an override
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5473548
* fix ppapi
* refactor: update namespace for pwm switches
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5444617
* 5459367: WebSQL: Restrict WebSQL service creation to Android only | https://chromium-review.googlesource.com/c/chromium/src/+/5459367
* 5455853: Revert "[Clipboard] Don't add meta charset tag for async write() method on Mac." | https://chromium-review.googlesource.com/c/chromium/src/+/5455853
* fixup! refactor: update namespace for pwm switches
edd9e26
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5444617
* 5147611: [heap] Add checks for ensuring position info slow path is not used in heap snapshot | https://chromium-review.googlesource.com/c/v8/v8/+/5147611
* fixup! 5412666: [heap] Also avoid heap allocation for allocation tracked functions | https://chromium-review.googlesource.com/c/v8/v8/+/5412666
* chore: add websql removal to breaking-changes.md
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
2024-05-10 11:21:10 -04:00
Shelley Vohr
3bd807b03e
fix: View reordering on re-addition to same parent ( #42085 )
2024-05-10 10:16:33 +02:00
Shelley Vohr
6675f3ae65
fix: CHECK when adding view as its own child ( #42067 )
2024-05-09 09:47:47 -04:00
Charles Kerr
05631ec445
chore: disable tests that require nut.js ( #42006 )
...
* chore: disable tests that require nut.js
* fixup! chore: disable tests that require nut.js
2024-04-30 21:13:38 -04:00
Shelley Vohr
f5fb44eaf8
fix: requestFullscreen
from WebContentsView
( #41966 )
...
fix: requestFullscreen from WebContentsView
2024-04-29 19:09:29 -04:00
Michaela Laurencin
ef097b77ad
chore: fix notes stack updates ( #41600 )
...
* chore: fix removeSupercededStackUpdates for generating notes
* add early stop for less than
* Update script/release/notes/notes.js
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
* clean up comparison functionality
* add tests
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
2024-04-29 11:41:54 -04:00
Jeremy Rose
4e8c28fdf0
fix: data corruption in protocol.handle
( #41894 )
2024-04-22 13:40:01 -07:00
Jeremy Rose
ed9fec7da4
fix: nativeImage.createThumbnailFromPath
and shell.openExternal
in renderer ( #41875 )
...
* fix: nativeImage.createThumbnailFromPath in renderer
* also fix shell.openExternal
2024-04-19 09:43:01 -04:00
electron-roller[bot]
c670e38b4b
chore: bump chromium to 125.0.6412.0 (main) ( #41610 )
...
* chore: bump chromium in DEPS to 124.0.6361.0
* chore: bump chromium in DEPS to 124.0.6363.0
* chore: update patches
Manually apply printing.patch w/no code changes due to upstream shear.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5349263
* chore: bump chromium in DEPS to 124.0.6365.0
* chore: bump chromium in DEPS to 124.0.6367.0
* update patches
* 5371735: Rename SystemGeolocationSourceMac to SystemGeolocationSourceApple
https://chromium-review.googlesource.com/c/chromium/src/+/5371735
* missed a MAS bit
* chore: update windows toolchain
5350823: New toolchain for Windows 11 10.0.22621.2428 SDK | https://chromium-review.googlesource.com/c/chromium/src/+/5350823
* chore: bump chromium in DEPS to 125.0.6368.0
* fix patches
* chore: update patches
* 5232401: [PDF] Move generic utils from //chrome to //components/pdf (1/2)
https://chromium-review.googlesource.com/c/chromium/src/+/5232401
* revert https://chromium-review.googlesource.com/c/chromium/src/+/5380898
* chore: bump chromium in DEPS to 125.0.6370.0
* build: use updated windows toolchain
* fix patches
* chore: update patches
* more pdf_util to components
* 5372414: [Extensions] Remove DispatcherDelegate
https://chromium-review.googlesource.com/c/chromium/src/+/5372414
* fix accessibility_ui patch
* chore: bump chromium in DEPS to 125.0.6372.0
* chore: bump chromium in DEPS to 125.0.6374.0
* chore: bump chromium in DEPS to 125.0.6376.0
* chore: bump chromium in DEPS to 125.0.6378.0
* chore: bump chromium in DEPS to 125.0.6379.3
* chore: update patches (+ MAS patch changes)
* chore: update patches
* 5381159: Cleanup media::KeySystemSupportObserver
https://chromium-review.googlesource.com/c/chromium/src/+/5381159
* 5382233: Reland "Web `Speech to Text` with SODA backend"
https://chromium-review.googlesource.com/c/chromium/src/+/5382233
* chore: update `exclusive_access` patch
- 5367497: Add a metric for the website state when Fullscreen API is requested
- https://chromium-review.googlesource.com/c/chromium/src/+/5367497
* chore: add build dependency
5367497: Add a metric for the website state when Fullscreen API is requested
https://chromium-review.googlesource.com/c/chromium/src/+/5367497
* chore: bump chromium in DEPS to 125.0.6382.0
* chore: update libcxx filenames
* chore: update patches
* chore: bump chromium in DEPS to 125.0.6384.0
* chore: remove old patch
* 5394039: [Extensions] Change "blessed" -> "privileged" in extension feature files
https://chromium-review.googlesource.com/c/chromium/src/+/5394039
* fix: remove deprecated errno constants in node/libuv
* 5362194: Return expected from ProcessMetrics CPU methods
https://chromium-review.googlesource.com/c/chromium/src/+/5362194
* 5383927: Add new Pickle factory functions with explicit ownership
https://chromium-review.googlesource.com/c/chromium/src/+/5383927
* 5373340: Simplify app-region/Draggable Region implementation
https://chromium-review.googlesource.com/c/chromium/src/+/5373340
* 5386875: Cleanup printing preferences files
https://chromium-review.googlesource.com/c/chromium/src/+/5386875
* chore: update libc++ filenames
* fix: add enterprise buildflags dep
* chore: bump chromium in DEPS to 125.0.6386.0
* chore: add build dep
* chore: update patches
* chore: bump chromium in DEPS to 125.0.6388.0
* chore: bump chromium in DEPS to 125.0.6390.0
* chore: update patches
* 4918014: preloading: Add NewTabPagePageLoadMetricsObserver
https://chromium-review.googlesource.com/c/chromium/src/+/4918014
* 5401234: [PDF] Remove `PDFDocumentHelperClient::FindPdfChildFrame` API
https://chromium-review.googlesource.com/c/chromium/src/+/5401234
* 5116175: Relocate Windows XPS printing feature helper methods
https://chromium-review.googlesource.com/c/chromium/src/+/5116175
* fixup! 5373340: Simplify app-region/Draggable Region implementation https://chromium-review.googlesource.com/c/chromium/src/+/5373340
* fixup! chore: add build dep
* chore: remove dead code & dead patch
Was dealing with https://chromium-review.googlesource.com/c/chromium/src/+/5402805 when I realized this code is no longer possible to call. It seems like this code became dead in the previous roll (#41514 ).
The patch exposed a `DxdiagDx12VulkanRequested` method on Chromium's `GpuDataManagerImpl`, which we consumed only in our own `GPUInfoManager::NeedsCompleteGpuInfoCollection`. There are no other references to this method, so it and the patch can both be deleted. Yay!
* chore: bump chromium in DEPS to 125.0.6392.0
* chore: bump chromium in DEPS to 125.0.6393.0
* chore: update patches
* chore: bump chromium in DEPS to 125.0.6394.0
* chore: bump chromium in DEPS to 125.0.6396.0
* chore: bump chromium in DEPS to 125.0.6397.0
* chore: update printing.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5100842
No code changes, but had to apply patch manually due to upstream code shear
* chore: update add_maximized_parameter_to_linuxui_getwindowframeprovider.patch
No manual changes; patch applied with fuzz 1
* chore: update feat_allow_code_cache_in_custom_schemes.patch
No manual changes; patch applied with fuzz 2
* chore: silence "space before tab in indent" git rebase-apply warning
* chore: e patches all
* build: update all.gn to avoid FTBFS when disabling raw_ptr
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5371737
* Rename PdfService Mojo interface to PdfHost
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5411957
* chore: bump chromium in DEPS to 125.0.6398.0
* chore: update patches
* chore: bump chromium in DEPS to 125.0.6400.0
* chore: update patches
* [media] Remove unused `GetSupportedKeySystems` from MediaClient
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5420247
* chore: update JSInjection::New call to match upstream change
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5403967
[Extensions] Wire up the renderer for multiple user script worlds
* 5362362: Derive display ID from monitor adapter ID instead of szDevice.
https://chromium-review.googlesource.com/c/chromium/src/+/5362362
* 5116175: Relocate Windows XPS printing feature helper methods
https://chromium-review.googlesource.com/c/chromium/src/+/5116175
* chore: add v8-sandbox.h to electron-node
* chore: update patches
* chore: update patches
* fixup! 5394039: [Extensions] Change blessed -> privileged in extension feature files
* chore: bump chromium in DEPS to 125.0.6412.0
* chore: update patches
* chore: node script/gen-libc++-filenames.js
* [FPF] Create Fingerprinting Protection ruleset service.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5420158
* Add ExclusiveAccessPermissionManager
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5273787
* Preserve the PNG colorspace when decoding into a SkBitmap.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5421254
* chore: iwyu
* fix: abstract-socket compilation
* ci: bump container for node 20 support
* fixup! abstract-socket compilation
* fix: compiling nan specs
* chore: revert winreg version bump
accidental bump to 1.2.5 revealed failing app.setasdefaultprotocolclient
test suite. Should be revisited separately.
* ci: set node 20 for darwin x64 tests
* fix: broken patch export
* chore: cleanup mas_avoid_private_macos_api_usage.patch.patch
Removed code that was inadvertently put back after https://chromium-review.googlesource.com/c/chromium/src/+/5348565 removed it
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2024-04-15 18:10:32 -04:00
Mitchell Cohen
05fba85aa3
fix: do not activate app when showing a panel on Mac ( #41750 )
...
* fix: do not activate app when showing or focusing a panel on Mac
* restored panel activation test
2024-04-12 14:27:59 +02:00
Shelley Vohr
344aba0838
feat: implement File System API support ( #41419 )
2024-04-10 22:06:47 +02:00
Jeremy Rose
76f7bbb0a8
fix: move BrowserWindow's WebContentsView to be a child of rootview ( #41256 )
2024-04-08 10:30:23 -07:00
Calvin
3eb94b72ba
feat: Options parameter for Session.clearData
API ( #41355 )
...
* feat: Options parameter for `Session.clearData` API
* Consolidate & curate data type categories
* Update docs for better typing
* off-by-one typo
* refactor to use `std::shared_ptr` instead of `base::RefCounted`
* fix compile errors
* std::enable_shared_from_this didn't work 🤷
* Refine docs with defaults
2024-04-01 12:09:01 -04:00
Shelley Vohr
0bf53a3876
fix: Storage.{get|set|clear}Cookies
via CDP not working ( #41718 )
2024-03-28 16:09:27 -07:00
Shelley Vohr
62d4b21819
test: disable flaky <webview>.capturePage()
specs ( #41713 )
...
test: disable flaky <webview>.capturePage() specs
2024-03-28 22:37:14 +01:00
Jeremy Rose
c6102b9278
docs: add missing headers option to ClientRequest options ( #41723 )
2024-03-28 09:38:16 -07:00
daihere1993
72c2b9e862
fix: recognize 'undefined' header value in ClientRequest
( #41615 )
...
Co-authored-by: zowu <luke.wu@nokia-sbell.com>
2024-03-27 16:46:07 -07:00
Shelley Vohr
08241669bc
test: add tests for Storage Access API ( #41698 )
2024-03-27 19:52:24 +01:00
Alice Zhao
c82ec0c72b
test: remove hardcoded url ( #41706 )
2024-03-27 10:53:02 +01:00
Alice Zhao
c57ce31e84
test: fix flaky tests in webContents.navigationHistory
( #41705 )
...
test: fix flaky tests by replacing real urls with data urls
2024-03-27 13:49:11 +09:00
Shelley Vohr
7032c0d03c
test: add test and api_feature
definition for chrome.scripting.globalParams
( #41685 )
...
chore: add test and api_feature for chrome.scripting.globalParams
2024-03-26 12:33:47 +01:00
Shelley Vohr
707b9a58cc
fix: app.setLoginItemSettings
error getting swallowed by gin conversion ( #41647 )
...
* fix: errors getting swallowed by gin conversion
* fix: Windows build
* test: re-enable disabled test
2024-03-22 09:00:21 -04:00
Shelley Vohr
a32705fd30
test: add test for setJumpList
arguments ( #41650 )
...
test: add test for setJumpList arguments
2024-03-21 19:01:54 -04:00
Alice Zhao
00e3445f8a
feat: add navigationHistory.getEntryAtIndex(int index)
method ( #41577 )
2024-03-21 14:59:23 -07:00
John Kleinschmidt
1036d824fe
ci: use CircleCI hosted macOS arm64 runners for testing ( #41649 )
2024-03-21 14:07:18 -04:00
Shelley Vohr
040acaaf30
fix: support withFileTypes
in fs.{readdir|readdirSync}
( #41627 )
...
fix: support withFileTypes in fs.{readdir|readdirSync}
2024-03-21 10:22:40 -04:00
Shelley Vohr
b02918883f
fix: support recursive readdir in Asar files ( #41582 )
2024-03-19 11:10:14 +01:00