Samuel Attard
22ba8b6f01
fix: restore original BrowserWindow.show() behavior ( #42300 )
2024-05-28 23:31:11 -07:00
Erick Zhao
09fb892c6e
docs: ensure all links are on a single line ( #42235 )
2024-05-28 11:15:18 -07:00
Charles Kerr
bb4374ee2c
fix: potential null dereference in normalizeSpawnArguments() patch ( #42260 )
...
fix: potential null deref in normalizeSpawnArguments() patch
Use upstream's practice of using `env = options.env || process.env`.
Previously, we were unconditionally assigning CRASHDUMP_SIGNAL_FD
and CRASHPAD_HANDLER_PID to options.env.
2024-05-27 10:41:42 +02:00
Evo
6423968dc5
fix: fixed the type of WebviewTag.webpreferences ( #42275 )
...
fix: fixed the type of WebviewTag.webpreferences
2024-05-25 22:06:06 -07:00
BILL SHEN
3ffa35dc8d
fix: calculate a hash for the Tag property of ToastNotification. ( #42239 )
...
* fix: calculate a hash for the Tag property of ToastNotification.
* fix: calculate a hash for the Tag property of ToastNotification.
---------
Co-authored-by: bill.shen <shenyb32768@gmail.com>
2024-05-24 21:20:59 +02:00
Keeley Hammond
7ec813732a
chore: cherry-pick 3e037e195e50 from v8 ( #42253 )
2024-05-23 07:20:13 -07:00
dependabot[bot]
0285ff0c0f
build(deps): bump dsanders11/project-actions from 1.2.0 to 1.3.0 ( #42230 )
...
---
updated-dependencies:
- dependency-name: dsanders11/project-actions
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-23 11:14:23 +02:00
dependabot[bot]
f6bdbd6000
build(deps): bump github/codeql-action from 3.25.5 to 3.25.6 ( #42229 )
...
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-23 11:14:12 +02:00
Charles Kerr
752efddf89
refactor: prefer to inherit observer classes privately ( #41360 )
...
* refactor: use private inheritance in CookieChangeNotifier
* refactor: use private inheritance in WebViewGuestDelegate
* refactor: use private inheritance in UsbChooserController
* refactor: use private inheritance in DesktopCapturer
* refactor: use private inheritance in Browser
* refactor: use private inheritance in WebContentsZoomController
* refactor: use private inheritance in FrameSubscriber
* refactor: use private inheritance in AutofillAgent
* refactor: use private inheritance in HidChooserController
* refactor: use private inheritance in PepperHelper
* refactor: use private inheritance in AutofillPopup
* refactor: use private inheritance in SerialChooserController
* refactor: use private inheritance in MediaCaptureDevicesDispatcher
* refactor: use private inheritance in electron::api::View
* refactor: use private inheritance in AutofillDriverFactory
* refactor: use private inheritance in GPUInfoManager
* refactor: use private inheritance in SavePageHandler
* refactor: use private inheritance in GlobalShortcut
* refactor: use private inheritance in ElectronRenderFrameObserver
2024-05-21 14:21:31 -05:00
dependabot[bot]
23a5d8b64a
build(deps): bump mikefarah/yq from 4.43.1 to 4.44.1 ( #42228 )
...
---
updated-dependencies:
- dependency-name: mikefarah/yq
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-20 20:41:47 -07:00
Samuel Attard
2e778a98b9
fix: ensure showInactive actually shows ( #42226 )
2024-05-20 14:12:05 -07:00
Erick Zhao
b8381b7d93
docs: fix broken anchors ( #42213 )
2024-05-17 09:46:18 +02:00
Shelley Vohr
af9a59cc40
build: cancel in-progress runs on new commits ( #42193 )
2024-05-15 23:45:54 +02:00
Charles Kerr
c67744a127
refactor: use raw_ref in RootView ( #42114 )
...
* refactor: make RootView::window_ a const raw_ref
The Chromium C++ style guide says "prefer const raw_ref<T> whenever
the held pointer will never be null," so let's do that.
* refactor: make RootView::main_view_ a const raw_ref
> The Chromium C++ style guide says "prefer const raw_ref<T> whenever
> the held pointer will never be null," so let's do that.
* refactor: aggregate RootView::last_focused_view_tracker_
RootView already owns it, so aggregate it
2024-05-15 14:45:47 -04:00
David Sanders
0b62abf244
chore: use markdownlint-cli2 directly for linting Markdown ( #42192 )
2024-05-15 14:44:46 -04:00
Jeremy Rose
19dc276878
feat: remove File.path ( #42053 )
2024-05-15 11:07:23 -07:00
Shelley Vohr
a54afabe04
fix: win.center() on Windows ( #42195 )
...
fix: win.center() on Windows
2024-05-15 10:36:24 -07:00
Piotr Płaczek
125bd6aa2b
docs: troubleshooting advice for rbe auth 'token not valid' error ( #42027 )
2024-05-15 10:35:32 -07:00
Keeley Hammond
7f8fabbe7b
chore: remove focus ring patch ( #42183 )
2024-05-14 15:57:00 -07:00
Samuel Attard
435003566d
fix: restore non-panel focus behavior ( #42180 )
2024-05-14 15:52:08 -07:00
Keeley Hammond
d7099b0ad4
chore: cherry-pick b3c01ac1e60a from v8 ( #42172 )
...
* chore: cherry-pick b3c01ac1e60a from v8
* chore: update patches
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-05-14 18:02:24 -04:00
Fedor Indutny
f2af35182c
fix: fix cast in ElectronDesktopWindowTreeHostLinux ( #42179 )
...
Fix cast in ElectronDesktopWindowTreeHostLinux
The frame view of the widget is an `ClientFrameViewLinux` instance only
when both `frame` and `client_frame` booleans are set to `true`.
Otherwise it is an instance of a different class and thus casting to
`ClientFrameViewLinux` is incorrect and leads to crashes.
Fix : #41839
2024-05-14 14:26:39 -07:00
Shelley Vohr
d0cb298f95
fix: webContents.navigationHistory should be enumerable ( #42139 )
...
fix: webContents.navigationHistory should be enumerable
2024-05-14 16:47:47 -04:00
David Sanders
1ef5406c8c
chore: enable no autolink markdownlint rule ( #42127 )
2024-05-14 16:32:52 -04:00
dependabot[bot]
4e70213037
build(deps): bump dsanders11/github-app-commit-action from 1.1.0 to 1.4.0 ( #42161 )
...
build(deps): bump dsanders11/github-app-commit-action
Bumps [dsanders11/github-app-commit-action](https://github.com/dsanders11/github-app-commit-action ) from 1.1.0 to 1.4.0.
- [Release notes](https://github.com/dsanders11/github-app-commit-action/releases )
- [Changelog](https://github.com/dsanders11/github-app-commit-action/blob/main/.releaserc.json )
- [Commits](1dd0a2d22c...48d2ff8c1a
2024-05-14 10:53:15 -04:00
dependabot[bot]
45cc31fd2f
build(deps): bump github/codeql-action from 3.25.3 to 3.25.5 ( #42160 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.25.3 to 3.25.5.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](d39d31e687...b7cec75265
2024-05-14 10:52:54 -04:00
dependabot[bot]
03e259dc25
build(deps): bump ossf/scorecard-action from 2.3.1 to 2.3.3 ( #42159 )
...
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action ) from 2.3.1 to 2.3.3.
- [Release notes](https://github.com/ossf/scorecard-action/releases )
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md )
- [Commits](0864cf1902...dc50aa9510
2024-05-14 10:51:35 +02:00
dependabot[bot]
e4d89ba2b4
build(deps): bump amannn/action-semantic-pull-request from 5.4.0 to 5.5.2 ( #42158 )
...
build(deps): bump amannn/action-semantic-pull-request
Bumps [amannn/action-semantic-pull-request](https://github.com/amannn/action-semantic-pull-request ) from 5.4.0 to 5.5.2.
- [Release notes](https://github.com/amannn/action-semantic-pull-request/releases )
- [Changelog](https://github.com/amannn/action-semantic-pull-request/blob/main/CHANGELOG.md )
- [Commits](e9fabac35e...cfb60706e1
2024-05-14 10:50:36 +02:00
John Kleinschmidt
44ebc1b1c2
chore: update patches after #42126 was merged ( #42153 )
2024-05-13 15:46:59 -07:00
electron-appveyor-updater[bot]
4c27b0c282
build: update appveyor image to latest version ( #42135 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-05-13 16:58:15 -04:00
Samuel Attard
e19754d7fd
test: add tests for electron fuses ( #42129 )
...
* spec: add tests for electron fuses
* spec: fix tests for windows
* spec: handle weird crash codes on win32
* spec: disable fuse tests on arm64 windows
2024-05-13 10:48:26 -07:00
Keeley Hammond
c56e1dffb0
fix: partially revert invalidate focus ring ( #42126 )
2024-05-13 11:02:59 -05:00
electron-roller[bot]
653d0f009e
chore: bump node to v20.13.1 (main) ( #42088 )
...
* chore: bump node in DEPS to v20.13.0
* crypto: enable NODE_EXTRA_CA_CERTS with BoringSSL
https://github.com/nodejs/node/pull/52217
* test: skip test for dynamically linked OpenSSL
https://github.com/nodejs/node/pull/52542
* lib, url: add a `windows` option to path parsing
https://github.com/nodejs/node/pull/52509
* src: use dedicated routine to compile function for builtin CJS loader
https://github.com/nodejs/node/pull/52016
* test: mark test as flaky
https://github.com/nodejs/node/pull/52671
* build,tools: add test-ubsan ci
https://github.com/nodejs/node/pull/46297
* src: preload function for Environment
https://github.com/nodejs/node/pull/51539
* chore: fixup patch indices
* deps: update c-ares to 1.28.1
https://github.com/nodejs/node/pull/52285
* chore: handle updated filenames
- https://github.com/nodejs/node/pull/51999
- https://github.com/nodejs/node/pull/51927
* chore: bump node in DEPS to v20.13.1
* events: extract addAbortListener for safe internal use
https://github.com/nodejs/node/pull/52081
* module: print location of unsettled top-level await in entry points
https://github.com/nodejs/node/pull/51999
* fs: add stacktrace to fs/promises
https://github.com/nodejs/node/pull/49849
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-05-13 11:43:14 -04:00
Charles Kerr
10fd0ba655
refactor: use base::Value::Take*() ( #41169 )
...
* perf: avoid temporary strings in Converter<net::HttpRequestHeaders>::FromV8()
* perf: take strings instead of copying them in ToResponseHead()
* refactor: prefer base::Value::Take*() where appropriate
As per the base::Value docs: "prefer over `std::move(value.Get...())`
so clang-tidy can warn about potential use-after-move mistakes."
2024-05-13 15:58:52 +02:00
David Sanders
88f28a302f
docs: improve protocol.handle file examples ( #42111 )
...
* docs: improve protocol.handle file examples
* chore: fix lint
2024-05-13 11:49:18 +02:00
Richard Torres
8d4467bdc4
docs: fixing typo in dark mode fiddle and doc ( #42112 )
2024-05-13 10:50:55 +02:00
David Sanders
188196e78c
ci: auto label bug issues with version label ( #42044 )
2024-05-13 10:49:23 +02:00
Shelley Vohr
c765d57265
fix: BrowserView autoresizing conversion error ( #42056 )
2024-05-13 10:27:01 +02:00
Samuel Attard
3ea3b0e8e1
fix: ensure originalFs.promises.cp works ( #42132 )
2024-05-12 21:03:00 -07:00
Keeley Hammond
96dda274e9
chore: cherry-pick f320600cd1f4 from v8 ( #42120 )
2024-05-11 14:17:02 -07:00
electron-roller[bot]
9b0409f7c9
chore: bump chromium to 126.0.6445.0 (main) ( #41868 )
...
* chore: bump chromium in DEPS to 125.0.6421.0
* chore: bump chromium in DEPS to 125.0.6422.0
* Add ENABLE_BASE_TRACING flags for compatibility with enable_base_tracing = false on Windows
https://chromium-review.googlesource.com/c/chromium/src/+/5434658
* chore: update patches
* fixup: Add ENABLE_BASE_TRACING flags for compatibility with enable_base_tracing = false on Windows
* chore: bump chromium in DEPS to 126.0.6423.0
* chore: update patches
* 5426599: Next generation control of unsafe-buffers-usage plugin
https://chromium-review.googlesource.com/c/chromium/src/+/5426599
* chore: bump chromium in DEPS to 126.0.6425.0
* chore: update patches
* Roll clang+rust llvmorg-19-init-7229-g315c88c5-2 : llvmorg-19-init-8091-gab037c4f-1 / ceab6128fa48a616bfd3e3adf4bc80133b8ee223-1 : ab71ee7a9214c2793108a41efb065aa77aeb7326-1
https://chromium-review.googlesource.com/c/chromium/src/+/5444328
Also see https://issues.chromium.org/issues/332931387
* 5445074: [Views AX] Move AXEventNotificationDetails to ui/accessibility/
https://chromium-review.googlesource.com/c/chromium/src/+/5445074
Also
5455993: [Views AX] Rename AXEventNotificationDetails to AXUpdatesAndEvents | https://chromium-review.googlesource.com/c/chromium/src/+/5455993
* Pass IsolationInfo to ContentBrowserClient::WillCreateURLLoaderFactory()
https://chromium-review.googlesource.com/c/chromium/src/+/5405301
* chore: bump chromium in DEPS to 126.0.6427.0
* chore: update patches
* chore: remove no longer needed patch
perfetto is now turned on so this patch is no longer needed.
* chore: bump chromium in DEPS to 126.0.6429.0
* chore: bump chromium in DEPS to 126.0.6431.0
* chore: bump chromium in DEPS to 126.0.6433.0
* 5466654: Do not create a console if logging to a handle
https://chromium-review.googlesource.com/c/chromium/src/+/5466654
* chore: fixup patch indices
* Address Linux NonClientFrameView Changes
- https://chromium-review.googlesource.com/c/chromium/src/+/5180720
- https://chromium-review.googlesource.com/c/chromium/src/+/5367794
* chore: bump chromium in DEPS to 126.0.6435.0
* chore: bump chromium in DEPS to 126.0.6437.0
* chore: update patches
* chore: bump chromium in DEPS to 126.0.6439.0
* chore: bump chromium in DEPS to 126.0.6441.0
* 5477689: components/crash/content/tools: Format with yapf | https://chromium-review.googlesource.com/c/chromium/src/+/5477689
* 5485006: Remove enable_print_content_analysis GN flag | https://chromium-review.googlesource.com/c/chromium/src/+/5485006
* chore: update chromium patches
* chore: bump chromium in DEPS to 126.0.6443.0
* 5465608: Convert DCHECKs near RenderWidgetHost, DelegatedFrameHost to CHECK | https://chromium-review.googlesource.com/c/chromium/src/+/5465608
* 5492605: Migrate TODOs referencing old crbug IDs to the new issue tracker IDs | https://chromium-review.googlesource.com/c/chromium/src/+/5492605
* chore: update patches
* chore: bump chromium in DEPS to 126.0.6445.0
* chore: update patches
* 5468588: Fullscreen: Encapsulate ExclusiveAccessBubble params in a struct | https://chromium-review.googlesource.com/c/chromium/src/+/5468588
* fixup! 5485006: Remove enable_print_content_analysis GN flag | https://chromium-review.googlesource.com/c/chromium/src/+/5485006
* 5461340: `size_t` in `mojo::DataPipe[Consumer|Producer]Handle`: /components. | https://chromium-review.googlesource.com/c/chromium/src/+/5461340
* 5480213: Add an EvictIds struct to FrameEvictorClient | https://chromium-review.googlesource.com/c/chromium/src/+/5480213
* 4341506: [api] Deprecate Isolate::IdleNotificationDeadline | https://chromium-review.googlesource.com/c/v8/v8/+/4341506
* 5300826: [v8-tasks] Add source location to v8::TaskRunner, step 4/4. | https://chromium-review.googlesource.com/c/v8/v8/+/5300826
* partially revert is_newly_created to allow for browser initiated about:blank loads
* add dep on app_launch_prefetch
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5420149
* install sysroots from electron not from chrome
We should add a new var upstream for `download_sysroots` so that we can skip downloading chromes at all.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5462469
* refactor: make UpdateFrameHints an override
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5473548
* fix ppapi
* refactor: update namespace for pwm switches
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5444617
* 5459367: WebSQL: Restrict WebSQL service creation to Android only | https://chromium-review.googlesource.com/c/chromium/src/+/5459367
* 5455853: Revert "[Clipboard] Don't add meta charset tag for async write() method on Mac." | https://chromium-review.googlesource.com/c/chromium/src/+/5455853
* fixup! refactor: update namespace for pwm switches
edd9e26
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5444617
* 5147611: [heap] Add checks for ensuring position info slow path is not used in heap snapshot | https://chromium-review.googlesource.com/c/v8/v8/+/5147611
* fixup! 5412666: [heap] Also avoid heap allocation for allocation tracked functions | https://chromium-review.googlesource.com/c/v8/v8/+/5412666
* chore: add websql removal to breaking-changes.md
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
2024-05-10 11:21:10 -04:00
dependabot[bot]
0725f5c5cf
build(deps): bump mikefarah/yq from 4.40.7 to 4.43.1 ( #42074 )
...
Bumps [mikefarah/yq](https://github.com/mikefarah/yq ) from 4.40.7 to 4.43.1.
- [Release notes](https://github.com/mikefarah/yq/releases )
- [Changelog](https://github.com/mikefarah/yq/blob/master/release_notes.txt )
- [Commits](bb66c9c872...c35ec752e3
2024-05-10 11:33:15 +02:00
David Sanders
c00eb5d491
chore: update @electron/lint-roller to 2.1.0 ( #42078 )
2024-05-10 11:00:15 +02:00
Shelley Vohr
3bd807b03e
fix: View reordering on re-addition to same parent ( #42085 )
2024-05-10 10:16:33 +02:00
Charles Kerr
e2acdffe58
perf: avoid protocol registry redundant lookup ( #41991 )
...
* perf: avoid redundant map lookup in SimpleURLLoaderWrapper::GetURLLoaderFactoryForURL()
* perf: avoid redundant map lookup in InspectableWebContents::LoadNetworkResource()
* refactor: remove unused ProtocolRegistry::IsProtocolRegistered()
refactor: remove unused ProtocolRegistry::IsProtocolIntercepted()
* refactor: remove unused ProtocolRegistry::handlers()
* refactor: rename ProtocolRegistry::FindIntercepted()
refactor: rename ProtocolRegistry::FindRegistered()
similar semantics to base::Value::Find*()
* chore: follow Google C++ brace style
chore: use same variable names as in main
2024-05-09 09:53:09 -04:00
Shelley Vohr
865b0499bb
refactor: use //ui/shell_dialogs on Linux ( #42045 )
...
* refactor: use //ui/shell_dialogs on Linux
* fix: add proper filtering
* fix: add support for missing dialog features to //shell_dialogs
* fix: parent_window could be null
* chore: cleanup patch
* fix: use a OnceCallback in the sync implementation
* chore: remove stray debuglog
* Apply suggestions from code review
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: use settings struct
* fix: show hidden file property checking
* chore: changes from review
* fix: multi selection for dialogs
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-05-09 09:51:42 -04:00
Shelley Vohr
6675f3ae65
fix: CHECK when adding view as its own child ( #42067 )
2024-05-09 09:47:47 -04:00
Shelley Vohr
731bc7a334
fix: BrowserWindow.center() should center relative to screen ( #42048 )
2024-05-08 15:42:20 -07:00
dependabot[bot]
793276ac87
build(deps): bump slackapi/slack-github-action from 1.25.0 to 1.26.0 ( #42076 )
2024-05-08 13:36:33 +02:00
Peter Xu
0128a072d6
docs: make corrections for BrowserViews since it is deprecated ( #42030 )
2024-05-08 11:21:26 +02:00
